mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
4475d4efe3
Round 21 follow-up to #1400 (P0 write-action symmetry, merged `644d4517`). 5 features + help docs unified into one PR per WAWQAQ "全部合成一个 PR" directive. ## Scope - **P1** (`cf10c098`): `twitter search` `--from / --has / --exclude / --product` filters, mapping to X `from:` / `filter:` / `-filter:` / `f=` operators; legacy `--filter top|live` preserved (--product win on conflict) - **P2** (`a484a69a`): new `twitter bookmark-folders` + `bookmark-folder <id>`; X Premium GraphQL `bookmarkFoldersSlice` + `BookmarkFolderTimeline`; queryId 三层 fallback (placeholder.json → client-web bundle → pinned constants) - **P3** (`f209f914`): `--top-by-engagement N` to 7 tweet-shaped read commands (search/timeline/likes/bookmarks/list-tweets/tweets/thread); single helper in `utils.js`; formula `likes×1 + retweets×3 + replies×2 + bookmarks×5 + log10(views+1)×0.5`; **N=0 reference equality no-op** → existing 157 twitter tests 0 churn - **P4** (`89283fa0`): `TWITTER_BEARER_TOKEN` + composer image helpers extracted to `utils.js` (12 GraphQL adapter dedup); reply hardening; quote adds `--image` - **P5** (`a3d10a48`): sibling article-scope helper extracted to `shared.js` (9 write commands reuse, dedup with #1400 P0 invariant) - **docs** (`2a358d80`): help-doc precision (positional-omitted defaults + download/bookmarks/notifications/timeline/lists description thicken; concurrent #1401/#1403 wording preserved) 47 files / +2594/-470. Tests **96 → 216 (+120)**, manifest 798 → 801 (+3), typed-error-lint 190 → 189 (resolved 1 grandfathered sentinel). ## Iteration history (3 review fix commits on top of 6 author commits) - `7f93779b` — codex-mini1 lead fix1: 3 blocker bundle (P5 host invariant + P2 safe-id + sentinel removal + P1 fallback fail-fast) - `2a29ecc6` — codex-mini1 lead fix2: P3 help formula consistency (doc/help text matches actual `log10(views+1)×0.5`) - `df4dcd76` — codex-mini1 lead fix3 (F-P-1 aux catch): P2 `bookmark-folder --limit` upfront validation (`Number(kwargs.limit ?? 20)` + reject non-positive/non-integer + regression `0/negative/fractional/NaN` + `page.goto` zero-call assert) ## 4 progressive blockers caught (codex-mini1 lead 3 rounds + F-P-1 aux 1 round) 1. **P5 host invariant gap** (lead): article-scope helper preserved exact `/status/<id>` path but ignored link host → off-domain `https://evil.com/alice/status/<target>` would satisfy `__twHasLinkToTarget`. Fixed: `https` + X/Twitter host or subdomain + exact `/status/<id>` or `/i/status/<id>` path; query/hash allowed; off-domain/host-suffix/non-https/path-suffix/substring-id rejected; JSDOM positive + 5 negative anchors. 2. **P2 listing→detail round-trip + sentinel** (lead): `bookmark-folders` accepted opaque IDs but `bookmark-folder <id>` only accepted numeric → round-trip broken; new `author: 'unknown'` sentinel created fabricated author URL. Fixed: `[A-Za-z0-9_-]+` opaque safe-id (rejects `/`, `?`, `%`, spaces) + `resolveTwitterQueryId()` sanitization for queryId resolution; sentinel removed → empty author + canonical `/i/status/<id>` URL. 3. **P1 fallback silent tab miss** (lead): pushState fail → fallback typing into search box, `clickProductTabIfNeeded()` silent return on tab not found → user `--product photos` silently degraded to Top results. Fixed: throw `CommandExecutionError` when requested `--product` tab cannot be selected + invalid `--from` / `--limit` upfront pre-nav reject + double-direction tests. 4. **P2 limit silent normalize** (aux): `const limit = kwargs.limit || 20` → `--limit 0` silent → 20; negative/non-integer pre-IO unchecked. Fixed: `Number(kwargs.limit ?? 20)` + require positive integer before `page.goto` + regression covers `0/negative/fractional/NaN` + `page.goto` zero-call. ## Cultural sediment (Round 21 audit checklist 7 rules / 6 dimensions) This PR **immediately validated 4 of 7 rules** in review pipeline: - (b) silent-clamp class — P1 fallback silent tab miss (silent semantic-downgrade) + P2 `|| 20` silent normalize - (e) ID exact-not-substring — P5 host invariant (was only path-exact, not host-exact) - (f) grandfathered-not-exempt — P5 helper-refactor boundary lost host invariant + P2 new adapter inherited grandfathered `'unknown'` sentinel - (g) fallback-must-have-success-criterion — P1 fallback path missing post-condition assertion 7 rules / 6 dimensions: - (a) cross-grep sibling URL pattern — structural - (b) silent-clamp class — failure mode (input) - (c) broad querySelector → article-scoping — scope - (d) missing-validation early reject — boundary - (e) ID exact-not-substring — identity - (f) grandfathered-not-exempt (corollary: applies to new file + new helper-refactor boundary; not original-file line-edit) — time-axis - (g) fallback-must-have-success-criterion (sub-rule g': fallback unit test must include post-condition assertion, not just "doesn't throw") — failure mode (output) **Cross-PR validation 4-chain on meta-anchor "Structural exactness for identity matching"**: - #1391 URL layer (`isFacebookAuthRedirectPath`: top-level anchor + `\.php` + `(/|$)` segment edge) - #1392 URL parser layer (`parseGrokSessionId`: bare UUID exact / URL host-exact-or-subdomain + path-exact) - #1400 DOM layer (article-scoping: status-id `/\/status\/${id}(?:\/|$)/` regex / segment-array exact) - #1406 P5 helper-refactor boundary (full URL invariant in shared helper: host+path re-anchored after extraction) - Common invariant: boundary-lock structural shape; **fuzzy match is silent-failure 温床**; lesson lifecycle = surface-shift not add-and-forget. **Audit framework self-discipline**: each rule must have grep-able detection signal, otherwise rule degenerates to mantra. Framework is "7 rules + sub-instance pattern in new surface", not frozen 7 rules. **Round 17 race-mitigation 第 9 连续 race-free execution**: standard alternation cadence (#1400 A 组 → #1406 B 组), lead final + aux final + `@pr-monitor squash?` trigger, pr-monitor proactive ack + serial squash, lead silent on closeout. ## Validation gates (final head `df4dcd76`) Local: Twitter adapter tests `25 files / 216 tests`, focused P1/P2/P3/P5 tests `99/99`, `node --check` touched runtime, `npx tsc --noEmit`, `npm run build`, manifest 801 entries, typed-error-lint `189/189`, silent-column-drop `103/103`, doc-coverage `140/140`, docs:build clean, listing-id advisory `13` unchanged (wikipedia/trending residual non-Twitter), `git diff --check` clean. GitHub: build×3 (ubuntu/macos/windows) SUCCESS, unit-test shards SUCCESS, bun-test SUCCESS, adapter-test SUCCESS, audit SUCCESS, doc-coverage SUCCESS, docs-build SUCCESS, smoke-test skipped, PR `CLEAN/MERGEABLE`. Reviewers: - Lead: @codex-mini1 (3 fix rounds, all caught proactively + amend P3 help consistency) - Aux: @First-principles-1 (better-solution triangulation on P2 queryId 三层 fallback + P5 invariant + P3 N=0 reference no-op + caught P2 limit silent normalize) - Author: @opencli-user (5-feature scope + 7-rule sediment co-author + corollary contributor)
142 lines
7.0 KiB
JavaScript
142 lines
7.0 KiB
JavaScript
import * as fs from 'node:fs';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
import { describe, expect, it, vi } from 'vitest';
|
|
import { ArgumentError, CommandExecutionError } from '@jackwener/opencli/errors';
|
|
import { getRegistry } from '@jackwener/opencli/registry';
|
|
import { __test__ } from './reply.js';
|
|
import { __test__ as utilsTest } from './utils.js';
|
|
import { createPageMock } from '../test-utils.js';
|
|
|
|
describe('twitter reply command', () => {
|
|
it('uses the dedicated reply composer for text-only replies too', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
const page = createPageMock([
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
]);
|
|
const result = await cmd.func(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'text-only reply',
|
|
});
|
|
expect(page.goto).toHaveBeenCalledWith('https://x.com/compose/post?in_reply_to=2040254679301718161', { waitUntil: 'load', settleMs: 2500 });
|
|
expect(page.wait).toHaveBeenCalledWith({ selector: '[data-testid="tweetTextarea_0"]', timeout: 15 });
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'text-only reply',
|
|
},
|
|
]);
|
|
});
|
|
it('uploads a local image through the dedicated reply composer when --image is provided', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'opencli-twitter-reply-'));
|
|
const imagePath = path.join(tempDir, 'qr.png');
|
|
fs.writeFileSync(imagePath, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
|
|
const setFileInput = vi.fn().mockResolvedValue(undefined);
|
|
const page = createPageMock([
|
|
{ ok: true, previewCount: 1 },
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
], {
|
|
setFileInput,
|
|
});
|
|
const result = await cmd.func(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'reply with image',
|
|
image: imagePath,
|
|
});
|
|
expect(page.goto).toHaveBeenCalledWith('https://x.com/compose/post?in_reply_to=2040254679301718161', { waitUntil: 'load', settleMs: 2500 });
|
|
expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="tweetTextarea_0"]', timeout: 15 });
|
|
expect(page.wait).toHaveBeenNthCalledWith(2, { selector: 'input[type="file"][data-testid="fileInput"]', timeout: 20 });
|
|
expect(setFileInput).toHaveBeenCalledWith([imagePath], 'input[type="file"][data-testid="fileInput"]');
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'reply with image',
|
|
image: imagePath,
|
|
},
|
|
]);
|
|
});
|
|
it('downloads a remote image before uploading when --image-url is provided', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
const fetchMock = vi.fn().mockResolvedValue({
|
|
ok: true,
|
|
headers: {
|
|
get: vi.fn().mockReturnValue('image/png'),
|
|
},
|
|
arrayBuffer: vi.fn().mockResolvedValue(Uint8Array.from([0x89, 0x50, 0x4e, 0x47]).buffer),
|
|
});
|
|
vi.stubGlobal('fetch', fetchMock);
|
|
const setFileInput = vi.fn().mockResolvedValue(undefined);
|
|
const page = createPageMock([
|
|
{ ok: true, previewCount: 1 },
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
], {
|
|
setFileInput,
|
|
});
|
|
const result = await cmd.func(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'reply with remote image',
|
|
'image-url': 'https://example.com/qr',
|
|
});
|
|
expect(fetchMock).toHaveBeenCalledWith('https://example.com/qr');
|
|
expect(setFileInput).toHaveBeenCalledTimes(1);
|
|
const uploadedPath = setFileInput.mock.calls[0][0][0];
|
|
// Tmp dir is created by utils.downloadRemoteImage with the
|
|
// 'opencli-twitter-' prefix; final extension comes from Content-Type.
|
|
expect(uploadedPath).toMatch(/opencli-twitter-.*\/image\.png$/);
|
|
// Per-call tmp dir is removed in the adapter's finally block, so the
|
|
// downloaded file no longer exists once the command returns.
|
|
expect(fs.existsSync(uploadedPath)).toBe(false);
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'reply with remote image',
|
|
'image-url': 'https://example.com/qr',
|
|
},
|
|
]);
|
|
vi.unstubAllGlobals();
|
|
});
|
|
it('rejects using --image and --image-url together', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
const page = createPageMock([]);
|
|
await expect(cmd.func(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'nope',
|
|
image: '/tmp/a.png',
|
|
'image-url': 'https://example.com/a.png',
|
|
})).rejects.toThrow(CommandExecutionError);
|
|
});
|
|
it('rejects malformed tweet URLs before any browser interaction', () => {
|
|
// buildReplyComposerUrl runs parseTweetUrl synchronously; substring matches
|
|
// and off-domain hosts now throw ArgumentError instead of silently
|
|
// producing a wrong-host /compose/post URL.
|
|
expect(() => __test__.buildReplyComposerUrl('https://x.com/alice/home')).toThrow(ArgumentError);
|
|
expect(() => __test__.buildReplyComposerUrl('https://x.com.evil.com/alice/status/2040254679301718161')).toThrow(ArgumentError);
|
|
expect(() => __test__.buildReplyComposerUrl('not a url')).toThrow(ArgumentError);
|
|
});
|
|
it('builds the reply composer URL for both /<user>/status/<id> and /i/status/<id> shapes', () => {
|
|
expect(__test__.buildReplyComposerUrl('https://x.com/_kop6/status/2040254679301718161?s=20'))
|
|
.toBe('https://x.com/compose/post?in_reply_to=2040254679301718161');
|
|
expect(__test__.buildReplyComposerUrl('https://x.com/i/status/2040318731105313143'))
|
|
.toBe('https://x.com/compose/post?in_reply_to=2040318731105313143');
|
|
});
|
|
});
|
|
|
|
describe('twitter image helpers (utils.js)', () => {
|
|
it('rejects invalid image paths early', () => {
|
|
expect(() => utilsTest.resolveImagePath('/tmp/does-not-exist.png'))
|
|
.toThrow(ArgumentError);
|
|
});
|
|
it('prefers content-type when resolving remote image extensions', () => {
|
|
expect(utilsTest.resolveImageExtension('https://example.com/no-ext', 'image/webp')).toBe('.webp');
|
|
expect(utilsTest.resolveImageExtension('https://example.com/a.jpeg?x=1', null)).toBe('.jpeg');
|
|
});
|
|
});
|