mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
12d88e4b23
* refactor(runtime): unify command timeout into a single --timeout arg Drop the cli-level `timeoutSeconds` build-time ceiling field. A command now opts into runtime-enforced timeouts purely by declaring an arg named `timeout`; the user-facing `--timeout` value (its default or override) is the single authoritative knob, used both by the adapter polling loop and by the runtime ceiling (with a 30s padding for return + closeWindow + trace export). Behavior: - Browser commands without a `--timeout` arg fall back to OPENCLI_BROWSER_COMMAND_TIMEOUT (default 60s, unchanged). - Non-browser commands without a `--timeout` arg now run unbounded rather than against the previously implicit `timeoutSeconds` cap. Affected commands keep their old caps via newly added `--timeout` args. - LLM adapters (gemini/claude/deepseek/doubao/qwen/yuanbao ask) keep their current `--timeout` defaults; the runtime ceiling is now strictly more generous (userTimeout + 30s vs. the previous 180s cap), so `--timeout 600` actually buys 600s of polling rather than dying at 180s. Closes the design discussion that started from PR #1227, which proposed a per-site `OPENCLI_GEMINI_ASK_TIMEOUT` env var to work around the same underlying mismatch. * fix(timeout): wire --timeout arg into chatgpt/gemini image adapter polling codex-coder review on PR #1364 caught that the new --timeout arg I added to chatgpt/image and gemini/image only drove the runtime ceiling — the adapter still hardcoded `const timeout = 120`, so users passing --timeout 240/600 saw runtime allow 270s/630s but the adapter stop polling at 120s. That recreated the same single-knob mismatch this PR was meant to delete. Also add the browser-path runWithTimeout assertion codex-coder flagged as missing: a browser command with --timeout default=5 must call runWithTimeout with timeout: 35; a browser command without --timeout arg must fall back to DEFAULT_BROWSER_COMMAND_TIMEOUT. Image adapters now read kwargs.timeout and reject non-positive-integer values with ArgumentError (no silent fallback). chatgpt/image.test.js updated to pass an explicit timeout when calling .func directly (the test bypasses arg coercion). * fix(runtime): reject invalid timeout ceilings * fix(timeout): normalize timeout args to integer values * fix(timeout): preserve remaining command ceilings * fix(runtime): validate timeout before browser setup
44 lines
1.6 KiB
JavaScript
44 lines
1.6 KiB
JavaScript
import { cli, Strategy } from '@jackwener/opencli/registry';
|
|
export const watchCommand = cli({
|
|
site: 'antigravity',
|
|
name: 'watch',
|
|
access: 'read',
|
|
description: 'Stream new chat messages from Antigravity in real-time',
|
|
domain: 'localhost',
|
|
strategy: Strategy.UI,
|
|
browser: true,
|
|
args: [
|
|
{ name: 'timeout', type: 'int', required: false, default: 86400, help: 'Max seconds to keep watching (default: 86400 — 24h)' },
|
|
],
|
|
columns: [], // We use direct stdout streaming
|
|
func: async (page) => {
|
|
console.log('Watching Antigravity chat... (Press Ctrl+C to stop)');
|
|
let lastLength = 0;
|
|
// Loop until process gets killed
|
|
while (true) {
|
|
const text = await page.evaluate(`
|
|
async () => {
|
|
const container = document.getElementById('conversation');
|
|
return container ? container.innerText : '';
|
|
}
|
|
`);
|
|
const currentLength = text.length;
|
|
if (currentLength > lastLength) {
|
|
// Delta mode
|
|
const newSegment = text.substring(lastLength);
|
|
if (newSegment.trim().length > 0) {
|
|
process.stdout.write(newSegment);
|
|
}
|
|
lastLength = currentLength;
|
|
}
|
|
else if (currentLength < lastLength) {
|
|
// The conversation was cleared or updated significantly
|
|
lastLength = currentLength;
|
|
console.log('\\n--- Conversation Cleared/Changed ---\\n');
|
|
process.stdout.write(text);
|
|
}
|
|
await new Promise(resolve => setTimeout(resolve, 500));
|
|
}
|
|
},
|
|
});
|