Files
jackwener__opencli/clis/bilibili/dynamic.test.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

80 lines
1.9 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest';
const { mockApiGet } = vi.hoisted(() => ({
mockApiGet: vi.fn(),
}));
vi.mock('./utils.js', () => ({
apiGet: mockApiGet,
}));
import { getRegistry } from '@jackwener/opencli/registry';
import './dynamic.js';
describe('bilibili dynamic adapter', () => {
const command = getRegistry().get('bilibili/dynamic');
beforeEach(() => {
mockApiGet.mockReset();
});
it('maps desc text rows from the dynamic feed payload', async () => {
mockApiGet.mockResolvedValue({
data: {
items: [
{
id_str: '123',
modules: {
module_author: { name: 'Alice' },
module_dynamic: { desc: { text: 'hello world' } },
module_stat: { like: { count: 9 } },
},
},
],
},
});
const result = await command!.func!({} as any, { limit: 5 });
expect(mockApiGet).toHaveBeenCalledWith({}, '/x/polymer/web-dynamic/v1/feed/all', { params: {}, signed: false });
expect(result).toEqual([
{
id: '123',
author: 'Alice',
text: 'hello world',
likes: 9,
url: 'https://t.bilibili.com/123',
},
]);
});
it('falls back to archive title when desc text is absent', async () => {
mockApiGet.mockResolvedValue({
data: {
items: [
{
id_str: '456',
modules: {
module_author: { name: 'Bob' },
module_dynamic: { major: { archive: { title: 'Video title' } } },
module_stat: { like: { count: 3 } },
},
},
],
},
});
const result = await command!.func!({} as any, { limit: 5 });
expect(result).toEqual([
{
id: '456',
author: 'Bob',
text: 'Video title',
likes: 3,
url: 'https://t.bilibili.com/456',
},
]);
});
});