mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
80eef46b4e
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation Separates CLI adapters from the core runtime to prepare for independent adapter distribution via postinstall fetch. Key changes: - Move src/clis/ → clis/ (adapters at repo root) - Change tsconfig rootDir from "src" to "." so tsc compiles both - Create root-level shim files (registry.ts, errors.ts, etc.) so adapter relative imports (../../registry.js) resolve correctly - Update build-manifest.ts, main.ts paths for new dist/src/ structure - Expand ensureUserCliCompatShims() to cover all adapter import targets (types, utils, logger, launcher, browser/*, download/*, pipeline/*) - Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync - Update vitest.config.ts adapter test paths - Add package.json files field to exclude adapters from npm package Official adapter files are unconditionally overwritten on update; user-created files not in the manifest are preserved. * fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters - Add dist/clis/ and dist/cli-manifest.json to package.json files field so built-in adapters and manifest ship with the npm package - Replace execSync with execFileSync to prevent command injection - Add version check to skip redundant adapter fetches - Track tmpRoot explicitly for reliable cleanup * fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback 1. Manifest-based update strategy: - Read old manifest to identify previously-official files - Clean up files removed upstream (in old manifest but not new) - User-created files (never in any manifest) remain untouched 2. Only run fetch-adapters on global install (npm_config_global=true) or explicit OPENCLI_FETCH=1, preventing heavy side effects for local/dev installs 3. First-run fallback in discovery.ts: - ensureUserAdapters() checks for adapter-manifest.json - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js - Guarantees adapters are available even with --ignore-scripts * fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead * feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger * simplify: replace git clone with local copy from dist/clis/ Adapters already ship in the npm package (dist/clis/), so there's no need to clone from GitHub. Copy directly from the installed package: - Eliminates git, curl, tar dependencies - No network calls in postinstall - No timeout/offline issues - Version always matches the installed CLI - ~65 lines of clone/download code replaced by one cpSync loop
178 lines
6.5 KiB
TypeScript
178 lines
6.5 KiB
TypeScript
import * as fs from 'node:fs';
|
|
import * as os from 'node:os';
|
|
import * as path from 'node:path';
|
|
|
|
import { describe, expect, it, vi } from 'vitest';
|
|
|
|
import { getRegistry } from '../../registry.js';
|
|
import type { IPage } from '../../types.js';
|
|
import { __test__ } from './reply.js';
|
|
|
|
function createPageMock(evaluateResults: any[], overrides: Partial<IPage> = {}): IPage {
|
|
const evaluate = vi.fn();
|
|
for (const result of evaluateResults) {
|
|
evaluate.mockResolvedValueOnce(result);
|
|
}
|
|
|
|
return {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
evaluate,
|
|
snapshot: vi.fn().mockResolvedValue(undefined),
|
|
click: vi.fn().mockResolvedValue(undefined),
|
|
typeText: vi.fn().mockResolvedValue(undefined),
|
|
pressKey: vi.fn().mockResolvedValue(undefined),
|
|
scrollTo: vi.fn().mockResolvedValue(undefined),
|
|
getFormState: vi.fn().mockResolvedValue({ forms: [], orphanFields: [] }),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
tabs: vi.fn().mockResolvedValue([]),
|
|
selectTab: vi.fn().mockResolvedValue(undefined),
|
|
networkRequests: vi.fn().mockResolvedValue([]),
|
|
consoleMessages: vi.fn().mockResolvedValue([]),
|
|
scroll: vi.fn().mockResolvedValue(undefined),
|
|
autoScroll: vi.fn().mockResolvedValue(undefined),
|
|
installInterceptor: vi.fn().mockResolvedValue(undefined),
|
|
getInterceptedRequests: vi.fn().mockResolvedValue([]),
|
|
getCookies: vi.fn().mockResolvedValue([]),
|
|
screenshot: vi.fn().mockResolvedValue(''),
|
|
waitForCapture: vi.fn().mockResolvedValue(undefined),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe('twitter reply command', () => {
|
|
it('keeps the text-only reply flow working', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const page = createPageMock([
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
]);
|
|
|
|
const result = await cmd!.func!(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'text-only reply',
|
|
});
|
|
|
|
expect(page.goto).toHaveBeenCalledWith('https://x.com/_kop6/status/2040254679301718161?s=20');
|
|
expect(page.wait).toHaveBeenCalledWith({ selector: '[data-testid="primaryColumn"]' });
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'text-only reply',
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('uploads a local image through the dedicated reply composer when --image is provided', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'opencli-twitter-reply-'));
|
|
const imagePath = path.join(tempDir, 'qr.png');
|
|
fs.writeFileSync(imagePath, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
|
|
|
|
const setFileInput = vi.fn().mockResolvedValue(undefined);
|
|
const page = createPageMock([
|
|
{ ok: true, previewCount: 1 },
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
], {
|
|
setFileInput,
|
|
});
|
|
|
|
const result = await cmd!.func!(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'reply with image',
|
|
image: imagePath,
|
|
});
|
|
|
|
expect(page.goto).toHaveBeenCalledWith('https://x.com/compose/post?in_reply_to=2040254679301718161');
|
|
expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="tweetTextarea_0"]' });
|
|
expect(page.wait).toHaveBeenNthCalledWith(2, { selector: 'input[type="file"][data-testid="fileInput"]', timeout: 20 });
|
|
expect(setFileInput).toHaveBeenCalledWith([imagePath], 'input[type="file"][data-testid="fileInput"]');
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'reply with image',
|
|
image: imagePath,
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('downloads a remote image before uploading when --image-url is provided', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const fetchMock = vi.fn().mockResolvedValue({
|
|
ok: true,
|
|
headers: {
|
|
get: vi.fn().mockReturnValue('image/png'),
|
|
},
|
|
arrayBuffer: vi.fn().mockResolvedValue(Uint8Array.from([0x89, 0x50, 0x4e, 0x47]).buffer),
|
|
});
|
|
vi.stubGlobal('fetch', fetchMock);
|
|
|
|
const setFileInput = vi.fn().mockResolvedValue(undefined);
|
|
const page = createPageMock([
|
|
{ ok: true, previewCount: 1 },
|
|
{ ok: true, message: 'Reply posted successfully.' },
|
|
], {
|
|
setFileInput,
|
|
});
|
|
|
|
const result = await cmd!.func!(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'reply with remote image',
|
|
'image-url': 'https://example.com/qr',
|
|
});
|
|
|
|
expect(fetchMock).toHaveBeenCalledWith('https://example.com/qr');
|
|
expect(setFileInput).toHaveBeenCalledTimes(1);
|
|
const uploadedPath = setFileInput.mock.calls[0][0][0];
|
|
expect(uploadedPath).toMatch(/opencli-twitter-reply-.*\/image\.png$/);
|
|
expect(fs.existsSync(uploadedPath)).toBe(false);
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Reply posted successfully.',
|
|
text: 'reply with remote image',
|
|
'image-url': 'https://example.com/qr',
|
|
},
|
|
]);
|
|
|
|
vi.unstubAllGlobals();
|
|
});
|
|
|
|
it('rejects invalid image paths early', async () => {
|
|
await expect(() => __test__.resolveImagePath('/tmp/does-not-exist.png'))
|
|
.toThrow('Image file not found');
|
|
});
|
|
|
|
it('rejects using --image and --image-url together', async () => {
|
|
const cmd = getRegistry().get('twitter/reply');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const page = createPageMock([]);
|
|
|
|
await expect(cmd!.func!(page, {
|
|
url: 'https://x.com/_kop6/status/2040254679301718161?s=20',
|
|
text: 'nope',
|
|
image: '/tmp/a.png',
|
|
'image-url': 'https://example.com/a.png',
|
|
})).rejects.toThrow('Use either --image or --image-url, not both.');
|
|
});
|
|
|
|
it('extracts tweet ids from both user and i/status URLs', () => {
|
|
expect(__test__.extractTweetId('https://x.com/_kop6/status/2040254679301718161?s=20')).toBe('2040254679301718161');
|
|
expect(__test__.extractTweetId('https://x.com/i/status/2040318731105313143')).toBe('2040318731105313143');
|
|
expect(__test__.buildReplyComposerUrl('https://x.com/i/status/2040318731105313143'))
|
|
.toBe('https://x.com/compose/post?in_reply_to=2040318731105313143');
|
|
});
|
|
|
|
it('prefers content-type when resolving remote image extensions', () => {
|
|
expect(__test__.resolveImageExtension('https://example.com/no-ext', 'image/webp')).toBe('.webp');
|
|
expect(__test__.resolveImageExtension('https://example.com/a.jpeg?x=1', null)).toBe('.jpeg');
|
|
});
|
|
});
|