mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
80eef46b4e
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation Separates CLI adapters from the core runtime to prepare for independent adapter distribution via postinstall fetch. Key changes: - Move src/clis/ → clis/ (adapters at repo root) - Change tsconfig rootDir from "src" to "." so tsc compiles both - Create root-level shim files (registry.ts, errors.ts, etc.) so adapter relative imports (../../registry.js) resolve correctly - Update build-manifest.ts, main.ts paths for new dist/src/ structure - Expand ensureUserCliCompatShims() to cover all adapter import targets (types, utils, logger, launcher, browser/*, download/*, pipeline/*) - Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync - Update vitest.config.ts adapter test paths - Add package.json files field to exclude adapters from npm package Official adapter files are unconditionally overwritten on update; user-created files not in the manifest are preserved. * fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters - Add dist/clis/ and dist/cli-manifest.json to package.json files field so built-in adapters and manifest ship with the npm package - Replace execSync with execFileSync to prevent command injection - Add version check to skip redundant adapter fetches - Track tmpRoot explicitly for reliable cleanup * fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback 1. Manifest-based update strategy: - Read old manifest to identify previously-official files - Clean up files removed upstream (in old manifest but not new) - User-created files (never in any manifest) remain untouched 2. Only run fetch-adapters on global install (npm_config_global=true) or explicit OPENCLI_FETCH=1, preventing heavy side effects for local/dev installs 3. First-run fallback in discovery.ts: - ensureUserAdapters() checks for adapter-manifest.json - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js - Guarantees adapters are available even with --ignore-scripts * fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead * feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger * simplify: replace git clone with local copy from dist/clis/ Adapters already ship in the npm package (dist/clis/), so there's no need to clone from GitHub. Copy directly from the installed package: - Eliminates git, curl, tar dependencies - No network calls in postinstall - No timeout/offline issues - Version always matches the installed CLI - ~65 lines of clone/download code replaced by one cpSync loop
92 lines
3.1 KiB
TypeScript
92 lines
3.1 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
|
|
import { CommandExecutionError } from '../../errors.js';
|
|
import { getRegistry } from '../../registry.js';
|
|
import { __test__ } from './delete.js';
|
|
import './delete.js';
|
|
|
|
describe('twitter delete command', () => {
|
|
it('extracts tweet ids from both user and i/status URLs', () => {
|
|
expect(__test__.extractTweetId('https://x.com/alice/status/2040254679301718161?s=20')).toBe('2040254679301718161');
|
|
expect(__test__.extractTweetId('https://x.com/i/status/2040318731105313143')).toBe('2040318731105313143');
|
|
});
|
|
|
|
it('targets the matched tweet article instead of the first More button on the page', async () => {
|
|
const cmd = getRegistry().get('twitter/delete');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
evaluate: vi.fn().mockResolvedValue({ ok: true, message: 'Tweet successfully deleted.' }),
|
|
};
|
|
|
|
const result = await cmd!.func!(page as any, {
|
|
url: 'https://x.com/alice/status/2040254679301718161?s=20',
|
|
});
|
|
|
|
expect(page.goto).toHaveBeenCalledWith('https://x.com/alice/status/2040254679301718161?s=20');
|
|
expect(page.wait).toHaveBeenNthCalledWith(1, { selector: '[data-testid="primaryColumn"]' });
|
|
expect(page.wait).toHaveBeenNthCalledWith(2, 2);
|
|
|
|
const script = (page.evaluate as ReturnType<typeof vi.fn>).mock.calls[0][0] as string;
|
|
expect(script).toContain("document.querySelectorAll('article')");
|
|
expect(script).toContain("'/status/' + tweetId");
|
|
expect(script).toContain("targetArticle.querySelectorAll('button,[role=\"button\"]')");
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'success',
|
|
message: 'Tweet successfully deleted.',
|
|
},
|
|
]);
|
|
});
|
|
|
|
it('passes through matched-tweet lookup failures', async () => {
|
|
const cmd = getRegistry().get('twitter/delete');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const page = {
|
|
goto: vi.fn().mockResolvedValue(undefined),
|
|
wait: vi.fn().mockResolvedValue(undefined),
|
|
evaluate: vi.fn().mockResolvedValue({
|
|
ok: false,
|
|
message: 'Could not find the tweet card matching the requested URL.',
|
|
}),
|
|
};
|
|
|
|
const result = await cmd!.func!(page as any, {
|
|
url: 'https://x.com/alice/status/2040254679301718161',
|
|
});
|
|
|
|
expect(result).toEqual([
|
|
{
|
|
status: 'failed',
|
|
message: 'Could not find the tweet card matching the requested URL.',
|
|
},
|
|
]);
|
|
expect(page.wait).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('normalizes invalid tweet URLs into CommandExecutionError', async () => {
|
|
const cmd = getRegistry().get('twitter/delete');
|
|
expect(cmd?.func).toBeTypeOf('function');
|
|
|
|
const page = {
|
|
goto: vi.fn(),
|
|
wait: vi.fn(),
|
|
evaluate: vi.fn(),
|
|
};
|
|
|
|
await expect(
|
|
cmd!.func!(page as any, {
|
|
url: 'https://x.com/alice/home',
|
|
}),
|
|
).rejects.toThrow(CommandExecutionError);
|
|
|
|
expect(page.goto).not.toHaveBeenCalled();
|
|
expect(page.wait).not.toHaveBeenCalled();
|
|
expect(page.evaluate).not.toHaveBeenCalled();
|
|
});
|
|
});
|