Files
jackwener__opencli/clis/notebooklm/source-get.test.ts
jakevin 80eef46b4e refactor: monorepo adapter separation (clis/ at root) (#782)
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation

Separates CLI adapters from the core runtime to prepare for independent
adapter distribution via postinstall fetch.

Key changes:
- Move src/clis/ → clis/ (adapters at repo root)
- Change tsconfig rootDir from "src" to "." so tsc compiles both
- Create root-level shim files (registry.ts, errors.ts, etc.) so adapter
  relative imports (../../registry.js) resolve correctly
- Update build-manifest.ts, main.ts paths for new dist/src/ structure
- Expand ensureUserCliCompatShims() to cover all adapter import targets
  (types, utils, logger, launcher, browser/*, download/*, pipeline/*)
- Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync
- Update vitest.config.ts adapter test paths
- Add package.json files field to exclude adapters from npm package

Official adapter files are unconditionally overwritten on update;
user-created files not in the manifest are preserved.

* fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters

- Add dist/clis/ and dist/cli-manifest.json to package.json files field
  so built-in adapters and manifest ship with the npm package
- Replace execSync with execFileSync to prevent command injection
- Add version check to skip redundant adapter fetches
- Track tmpRoot explicitly for reliable cleanup

* fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback

1. Manifest-based update strategy:
   - Read old manifest to identify previously-official files
   - Clean up files removed upstream (in old manifest but not new)
   - User-created files (never in any manifest) remain untouched

2. Only run fetch-adapters on global install (npm_config_global=true)
   or explicit OPENCLI_FETCH=1, preventing heavy side effects for
   local/dev installs

3. First-run fallback in discovery.ts:
   - ensureUserAdapters() checks for adapter-manifest.json
   - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js
   - Guarantees adapters are available even with --ignore-scripts

* fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead

* feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger

* simplify: replace git clone with local copy from dist/clis/

Adapters already ship in the npm package (dist/clis/), so there's no
need to clone from GitHub. Copy directly from the installed package:

- Eliminates git, curl, tar dependencies
- No network calls in postinstall
- No timeout/offline issues
- Version always matches the installed CLI
- ~65 lines of clone/download code replaced by one cpSync loop
2026-04-05 01:46:36 +08:00

101 lines
3.0 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest';
const {
mockListNotebooklmSourcesViaRpc,
mockListNotebooklmSourcesFromPage,
mockGetNotebooklmPageState,
mockRequireNotebooklmSession,
} = vi.hoisted(() => ({
mockListNotebooklmSourcesViaRpc: vi.fn(),
mockListNotebooklmSourcesFromPage: vi.fn(),
mockGetNotebooklmPageState: vi.fn(),
mockRequireNotebooklmSession: vi.fn(),
}));
vi.mock('./utils.js', async () => {
const actual = await vi.importActual<typeof import('./utils.js')>('./utils.js');
return {
...actual,
getNotebooklmPageState: mockGetNotebooklmPageState,
listNotebooklmSourcesViaRpc: mockListNotebooklmSourcesViaRpc,
listNotebooklmSourcesFromPage: mockListNotebooklmSourcesFromPage,
requireNotebooklmSession: mockRequireNotebooklmSession,
};
});
import { getRegistry } from '../../registry.js';
import './source-get.js';
describe('notebooklm source-get', () => {
const command = getRegistry().get('notebooklm/source-get');
beforeEach(() => {
mockListNotebooklmSourcesViaRpc.mockReset();
mockListNotebooklmSourcesFromPage.mockReset();
mockGetNotebooklmPageState.mockReset();
mockRequireNotebooklmSession.mockReset();
mockRequireNotebooklmSession.mockResolvedValue(undefined);
mockGetNotebooklmPageState.mockResolvedValue({
url: 'https://notebooklm.google.com/notebook/nb-demo',
title: 'Browser Automation',
hostname: 'notebooklm.google.com',
kind: 'notebook',
notebookId: 'nb-demo',
loginRequired: false,
notebookCount: 1,
});
});
it('returns a source by exact id from rpc results', async () => {
mockListNotebooklmSourcesViaRpc.mockResolvedValue([
{
id: 'src-1',
notebook_id: 'nb-demo',
title: 'Release Notes',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'rpc',
type: 'web',
},
]);
const result = await command!.func!({} as any, { source: 'src-1' });
expect(result).toEqual([
{
id: 'src-1',
notebook_id: 'nb-demo',
title: 'Release Notes',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'rpc',
type: 'web',
},
]);
expect(mockListNotebooklmSourcesFromPage).not.toHaveBeenCalled();
});
it('falls back to page results and matches by title when rpc is empty', async () => {
mockListNotebooklmSourcesViaRpc.mockResolvedValue([]);
mockListNotebooklmSourcesFromPage.mockResolvedValue([
{
id: 'Meeting Notes',
notebook_id: 'nb-demo',
title: 'Meeting Notes',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'current-page',
},
]);
const result = await command!.func!({} as any, { source: 'meeting notes' });
expect(result).toEqual([
{
id: 'Meeting Notes',
notebook_id: 'nb-demo',
title: 'Meeting Notes',
url: 'https://notebooklm.google.com/notebook/nb-demo',
source: 'current-page',
},
]);
});
});