mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
80eef46b4e
* refactor: move adapters from src/clis/ to root clis/ for monorepo separation Separates CLI adapters from the core runtime to prepare for independent adapter distribution via postinstall fetch. Key changes: - Move src/clis/ → clis/ (adapters at repo root) - Change tsconfig rootDir from "src" to "." so tsc compiles both - Create root-level shim files (registry.ts, errors.ts, etc.) so adapter relative imports (../../registry.js) resolve correctly - Update build-manifest.ts, main.ts paths for new dist/src/ structure - Expand ensureUserCliCompatShims() to cover all adapter import targets (types, utils, logger, launcher, browser/*, download/*, pipeline/*) - Add scripts/fetch-adapters.js postinstall for ~/.opencli/clis/ sync - Update vitest.config.ts adapter test paths - Add package.json files field to exclude adapters from npm package Official adapter files are unconditionally overwritten on update; user-created files not in the manifest are preserved. * fix: add dist/clis/ and cli-manifest.json to npm files, harden fetch-adapters - Add dist/clis/ and dist/cli-manifest.json to package.json files field so built-in adapters and manifest ship with the npm package - Replace execSync with execFileSync to prevent command injection - Add version check to skip redundant adapter fetches - Track tmpRoot explicitly for reliable cleanup * fix: address review blockers — manifest-based updates, global-only fetch, first-run fallback 1. Manifest-based update strategy: - Read old manifest to identify previously-official files - Clean up files removed upstream (in old manifest but not new) - User-created files (never in any manifest) remain untouched 2. Only run fetch-adapters on global install (npm_config_global=true) or explicit OPENCLI_FETCH=1, preventing heavy side effects for local/dev installs 3. First-run fallback in discovery.ts: - ensureUserAdapters() checks for adapter-manifest.json - If missing and ~/.opencli/clis/ is empty, spawns fetch-adapters.js - Guarantees adapters are available even with --ignore-scripts * fix: remove OPENCLI_FETCH env var, use internal _OPENCLI_FIRST_RUN instead * feat: also support OPENCLI_FETCH=1 for explicit adapter fetch trigger * simplify: replace git clone with local copy from dist/clis/ Adapters already ship in the npm package (dist/clis/), so there's no need to clone from GitHub. Copy directly from the installed package: - Eliminates git, curl, tar dependencies - No network calls in postinstall - No timeout/offline issues - Version always matches the installed CLI - ~65 lines of clone/download code replaced by one cpSync loop
118 lines
4.2 KiB
TypeScript
118 lines
4.2 KiB
TypeScript
import { describe, expect, it, vi } from 'vitest';
|
|
import type { IPage } from '../../types.js';
|
|
import {
|
|
extractJsonLd,
|
|
forceEnglishUrl,
|
|
formatDuration,
|
|
getCurrentImdbId,
|
|
isChallengePage,
|
|
normalizeImdbTitleType,
|
|
normalizeImdbId,
|
|
waitForImdbPath,
|
|
waitForImdbReviewsReady,
|
|
waitForImdbSearchReady,
|
|
} from './utils.js';
|
|
|
|
describe('normalizeImdbId', () => {
|
|
it('passes through bare ids', () => {
|
|
expect(normalizeImdbId('tt1375666', 'tt')).toBe('tt1375666');
|
|
expect(normalizeImdbId('nm0634240', 'nm')).toBe('nm0634240');
|
|
});
|
|
|
|
it('extracts ids from supported urls', () => {
|
|
expect(normalizeImdbId('https://www.imdb.com/title/tt1375666/', 'tt')).toBe('tt1375666');
|
|
expect(normalizeImdbId('https://m.imdb.com/title/tt1375666/', 'tt')).toBe('tt1375666');
|
|
expect(normalizeImdbId('https://www.imdb.com/de/title/tt1375666/?ref_=nv_sr_srsg_0', 'tt')).toBe('tt1375666');
|
|
expect(normalizeImdbId('https://www.imdb.com/name/nm0634240/', 'nm')).toBe('nm0634240');
|
|
});
|
|
|
|
it('throws on invalid or mismatched ids', () => {
|
|
expect(() => normalizeImdbId('invalid', 'tt')).toThrow('Invalid IMDb ID');
|
|
expect(() => normalizeImdbId('tt1', 'tt')).toThrow('Invalid IMDb ID');
|
|
expect(() => normalizeImdbId('nm0634240', 'tt')).toThrow('Invalid IMDb ID');
|
|
});
|
|
});
|
|
|
|
describe('formatDuration', () => {
|
|
it('converts ISO-8601 durations to a short human format', () => {
|
|
expect(formatDuration('PT2H28M')).toBe('2h 28m');
|
|
expect(formatDuration('PT1H')).toBe('1h');
|
|
expect(formatDuration('PT45M')).toBe('45m');
|
|
expect(formatDuration('PT2H')).toBe('2h');
|
|
});
|
|
|
|
it('returns an empty string for invalid input', () => {
|
|
expect(formatDuration('')).toBe('');
|
|
expect(formatDuration('invalid')).toBe('');
|
|
});
|
|
});
|
|
|
|
describe('forceEnglishUrl', () => {
|
|
it('adds the English language parameter', () => {
|
|
expect(forceEnglishUrl('https://www.imdb.com/title/tt1375666/')).toContain('language=en-US');
|
|
});
|
|
|
|
it('preserves existing query parameters', () => {
|
|
const result = forceEnglishUrl('https://www.imdb.com/title/tt1375666/?ref_=nv');
|
|
expect(result).toContain('language=en-US');
|
|
expect(result).toContain('ref_=nv');
|
|
});
|
|
});
|
|
|
|
describe('normalizeImdbTitleType', () => {
|
|
it('maps internal imdb ids to readable labels', () => {
|
|
expect(normalizeImdbTitleType({ id: 'movie', text: '' })).toBe('Movie');
|
|
expect(normalizeImdbTitleType({ id: 'tvSeries', text: '' })).toBe('TV Series');
|
|
expect(normalizeImdbTitleType('short')).toBe('Short');
|
|
});
|
|
|
|
it('preserves explicit text labels', () => {
|
|
expect(normalizeImdbTitleType({ id: 'movie', text: 'Feature Film' })).toBe('Feature Film');
|
|
});
|
|
});
|
|
|
|
describe('extractJsonLd', () => {
|
|
it('returns the evaluated JSON-LD payload', async () => {
|
|
const page = {
|
|
evaluate: vi.fn().mockResolvedValue({ '@type': 'Movie', name: 'Inception' }),
|
|
} as unknown as IPage;
|
|
|
|
await expect(extractJsonLd(page, 'Movie')).resolves.toEqual({ '@type': 'Movie', name: 'Inception' });
|
|
expect(page.evaluate).toHaveBeenCalledTimes(1);
|
|
expect(page.evaluate).toHaveBeenCalledWith(expect.stringContaining('"Movie"'));
|
|
});
|
|
});
|
|
|
|
describe('isChallengePage', () => {
|
|
it('returns true when the page evaluation matches a challenge', async () => {
|
|
const page = {
|
|
evaluate: vi.fn().mockResolvedValue(true),
|
|
} as unknown as IPage;
|
|
|
|
await expect(isChallengePage(page)).resolves.toBe(true);
|
|
expect(page.evaluate).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
describe('imdb browser helpers', () => {
|
|
it('reads the current imdb id from page metadata', async () => {
|
|
const page = {
|
|
evaluate: vi.fn().mockResolvedValue('nm0634240'),
|
|
} as unknown as IPage;
|
|
|
|
await expect(getCurrentImdbId(page, 'nm')).resolves.toBe('nm0634240');
|
|
expect(page.evaluate).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('wait helpers resolve mocked readiness booleans', async () => {
|
|
const page = {
|
|
evaluate: vi.fn().mockResolvedValue(true),
|
|
} as unknown as IPage;
|
|
|
|
await expect(waitForImdbPath(page, '^/find/?$')).resolves.toBe(true);
|
|
await expect(waitForImdbSearchReady(page)).resolves.toBe(true);
|
|
await expect(waitForImdbReviewsReady(page)).resolves.toBe(true);
|
|
expect(page.evaluate).toHaveBeenCalledTimes(3);
|
|
});
|
|
});
|