Files
jackwener__opencli/clis/twitter/download.ts
jakevin 4fe9a73ebc refactor: migrate adapter imports to package exports (#795)
* refactor: migrate adapter imports to package exports

Replace all relative imports (../../src/registry.js, ../../browser/cdp.js, etc.)
with package exports (@jackwener/opencli/registry, @jackwener/opencli/errors, etc.)
across all 484 adapter files.

This decouples adapter import resolution from directory structure:
- User CLIs in ~/.opencli/clis/ resolve via node_modules symlink
- Internal adapters resolve via Node.js self-referencing
- No more shim files needed for import resolution

Changes:
- package.json: add sub-path exports for all public modules
- clis/**: replace relative imports with @jackwener/opencli/...
- discovery.ts: simplify ensureUserCliCompatShims to symlink-only
- registry-api.ts: export CommandArgs type
- Remove root-level shim directories (browser/, download/, pipeline/)
- Remove shim entries from tsconfig.json include and package.json files

* test: add regression tests for package exports

Prevents regressions like #788/#791 by:
1. Scanning all adapter files for forbidden relative imports
   (../../src/, ../../browser/, etc.) — fails if any remain
2. Verifying every package.json export maps to an existing source file

18 new test cases.

* fix: use junction on Windows + broaden test patterns

- discovery.ts: use 'junction' symlink type on Windows (no admin required)
- package-exports.test.ts: generalize forbidden patterns to catch any
  depth of ../ traversal (not just ../../ and ../../../)

* fix: update stale vi.mock/importActual paths in adapter tests

Test files still used old relative paths for vi.mock() and
vi.importActual() calls. Updated 5 test files to use package exports.
Also broadened regression test patterns to catch mock/importActual paths.

* fix: use rm instead of unlink for symlink cleanup, add warn on failure

Addresses review feedback from Astro-Han:
- rm() handles both symlinks and stale directories (unlink fails on dirs)
- Log a warning when symlink creation fails instead of silent catch

* docs: update import examples to use package exports

Update all documentation, contributing guides, and skills to use
@jackwener/opencli/registry instead of ../../src/registry.js.

Without this, users following the docs would write adapters with
broken imports since the old shim files are no longer created.
2026-04-05 16:02:17 +08:00

119 lines
3.7 KiB
TypeScript

/**
* Twitter/X download — download images and videos from tweets.
*
* Usage:
* opencli twitter download elonmusk --limit 10 --output ./twitter
* opencli twitter download --tweet-url https://x.com/xxx/status/123 --output ./twitter
*/
import { cli, Strategy } from '@jackwener/opencli/registry';
import { formatCookieHeader } from '@jackwener/opencli/download';
import { downloadMedia } from '@jackwener/opencli/download/media-download';
cli({
site: 'twitter',
name: 'download',
description: '下载 Twitter/X 媒体(图片和视频)',
domain: 'x.com',
strategy: Strategy.COOKIE,
args: [
{ name: 'username', positional: true, help: 'Twitter username (downloads from media tab)' },
{ name: 'tweet-url', help: 'Single tweet URL to download' },
{ name: 'limit', type: 'int', default: 10, help: 'Number of tweets to scan' },
{ name: 'output', default: './twitter-downloads', help: 'Output directory' },
],
columns: ['index', 'type', 'status', 'size'],
func: async (page, kwargs) => {
const username = kwargs.username;
const tweetUrl = kwargs['tweet-url'];
const limit = kwargs.limit;
const output = kwargs.output;
if (!username && !tweetUrl) {
return [{
index: 0,
type: '-',
status: 'failed',
size: 'Must provide a username or --tweet-url',
}];
}
// Navigate to the appropriate page
if (tweetUrl) {
await page.goto(tweetUrl);
} else {
await page.goto(`https://x.com/${username}/media`);
}
await page.wait(3);
// Scroll to load more content
if (!tweetUrl) {
await page.autoScroll({ times: Math.ceil(limit / 5) });
}
// Extract media URLs
const data = await page.evaluate(`
(() => {
const media = [];
// Find images (high quality)
document.querySelectorAll('img[src*="pbs.twimg.com/media"]').forEach(img => {
let src = img.src || '';
// Get large version
src = src.replace(/&name=\\w+$/, '&name=large');
src = src.replace(/\\?format=/, '?format=');
if (!src.includes('&name=')) {
src = src + '&name=large';
}
media.push({ type: 'image', url: src });
});
// Find videos
document.querySelectorAll('video').forEach(video => {
const src = video.src || '';
if (src) {
media.push({ type: 'video', url: src, poster: video.poster || '' });
}
});
// Find video tweets (for yt-dlp)
document.querySelectorAll('[data-testid="videoPlayer"]').forEach(player => {
const tweetLink = player.closest('article')?.querySelector('a[href*="/status/"]');
const href = tweetLink?.getAttribute('href') || '';
if (href) {
const tweetUrl = 'https://x.com' + href;
media.push({ type: 'video-tweet', url: tweetUrl });
}
});
return media;
})()
`);
if (!data || data.length === 0) {
return [{ index: 0, type: '-', status: 'failed', size: 'No media found' }];
}
// Extract cookies
const browserCookies = await page.getCookies({ domain: 'x.com' });
// Deduplicate media
const seen = new Set<string>();
const uniqueMedia = data.filter((m: any) => {
if (seen.has(m.url)) return false;
seen.add(m.url);
return true;
}).slice(0, limit);
const subdir = tweetUrl ? 'tweets' : (username || 'media');
return downloadMedia(uniqueMedia, {
output,
subdir,
cookies: formatCookieHeader(browserCookies),
browserCookies,
filenamePrefix: username || 'tweet',
ytdlpExtraArgs: ['--merge-output-format', 'mp4'],
});
},
});