mirror of
https://github.com/jackwener/OpenCLI.git
synced 2026-09-14 18:25:42 +08:00
ffb61c51ea
* fix: address code audit findings (C1-C4, I1, I4, I6) Security: - C1: Fix page.evaluate injection in browser type/select commands and 6 adapter files by using JSON.stringify for user input interpolation - C2: Close WebSocket on CDP connect timeout to prevent resource leak - C3: Reject CDP connect promise on Page.enable failure instead of silently swallowing the error Reliability: - C4: Guard against corrupted adapter-manifest.json hashes to prevent false-positive override deletion - I1: Throw on pre-navigation failure instead of warn-and-continue - I4: Use Map<string, Promise<void>> for lazy module loading to prevent concurrent double-imports of the same adapter Performance: - I6: Replace O(n) registry alias cleanup with O(k) direct deletion * fix: address self-review findings on PR #981 - C1: add quotes around CSS selector attribute values in browser type/select to match other commands (get text/value/attributes) - C2: clear this._ws in timeout handler to prevent race with open event - C4: refine corruption guard — treat null/undefined hashes as empty, only skip sync for truly invalid types (string, number, array)