mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-14 18:01:20 +08:00
Miguel Ángel
6aaab32ccb
* refactor: make @hyperframes/lint depend only on parsers, not core Relocates the leaf utilities lint pulled from core — URL/asset-path helpers, font aliases, and the slideshow manifest parser — into the standalone @hyperframes/parsers base, and drops @hyperframes/core from lint's dependencies. Core keeps back-compat re-export stubs at the old paths, so producer/studio/cli are unchanged. Why: lint was the lightweight validator from #1749, but depending on core transitively pulled studio-server (hono) and bpm-detective — irrelevant to linting. Now installing @hyperframes/lint pulls only parsers + postcss, and the core<->lint dependency cycle is gone. - parsers main entry stays browser-safe (pure utils only); the node:path asset helpers live behind the new @hyperframes/parsers/asset-paths subpath - slideshow parser exposed via @hyperframes/parsers/slideshow * feat(lint): add browser entry; harden CSS url() regex (ReDoS) @hyperframes/lint/browser — a fully client-side rule engine (lintHyperframeHtml, lintMediaUrls, shouldBlockRender) with zero node: builtins, so browser-only editors can validate compositions with no Node.js and no server round-trip. Closes the browser-validation ask on #1749. - shouldBlockRender extracted from the fs-bound project.ts into its own pure module so the browser entry stays node-free - pure composition primitives (data types, font aliases, URL helper) exposed via a new recast-free @hyperframes/parsers/composition subpath, so the browser bundle tree-shakes out the GSAP/recast machinery (verified: esbuild platform=browser bundles with 0 node builtins) - lint built with a platform:browser tsup pass — compile-time guarantee the browser entry never pulls a node builtin - harden CSS_URL_RE against polynomial ReDoS (CodeQL js/polynomial-redos); behavior-preserving, verified against existing tests + an old/new parity check - parsers/lint marked sideEffects:false
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
rewriteAssetPath,
|
|
rewriteCssAssetUrls,
|
|
rewriteInlineStyleAssetUrls,
|
|
} from "./rewriteSubCompPaths.js";
|
|
|
|
describe("rewriteAssetPath", () => {
|
|
it("rewrites `../` against the sub-composition dir", () => {
|
|
expect(rewriteAssetPath("compositions/scene.html", "../icon.svg")).toBe("icon.svg");
|
|
});
|
|
|
|
it("leaves plain relative paths untouched", () => {
|
|
expect(rewriteAssetPath("compositions/scene.html", "assets/logo.png")).toBe("assets/logo.png");
|
|
});
|
|
|
|
it("leaves absolute URLs and data URIs untouched", () => {
|
|
expect(rewriteAssetPath("compositions/scene.html", "https://x/y")).toBe("https://x/y");
|
|
expect(rewriteAssetPath("compositions/scene.html", "data:image/png;base64,AA")).toBe(
|
|
"data:image/png;base64,AA",
|
|
);
|
|
expect(rewriteAssetPath("compositions/scene.html", "#hash")).toBe("#hash");
|
|
});
|
|
|
|
// Regression guard for a Windows-only bug: the rewriter used to import
|
|
// `path` (native) and emit `:\fonts\brand.woff2` — native `join` used
|
|
// backslashes, and `resolve("/", x).slice(1)` chopped the `D` off a
|
|
// `D:\…` absolute path. URLs must be POSIX regardless of host OS.
|
|
it("never emits backslashes on any platform", () => {
|
|
const out = rewriteAssetPath("compositions/nested/scene.html", "../../fonts/brand.woff2");
|
|
expect(out).toBe("fonts/brand.woff2");
|
|
expect(out).not.toMatch(/\\/);
|
|
expect(out).not.toMatch(/^:/);
|
|
});
|
|
|
|
it("CSS url(...) rewrites also stay POSIX under nesting", () => {
|
|
const css = `@font-face { src: url("../../fonts/brand.woff2") format("woff2"); }`;
|
|
const out = rewriteCssAssetUrls(css, "compositions/nested/scene.html");
|
|
expect(out).toContain(`url("fonts/brand.woff2")`);
|
|
expect(out).not.toMatch(/\\/);
|
|
expect(out).not.toMatch(/:\\/);
|
|
});
|
|
|
|
it("rewrites CSS urls inside inline style attributes", () => {
|
|
const elements = [{ style: `background-image: url("../cover.png")` }];
|
|
|
|
rewriteInlineStyleAssetUrls(
|
|
elements,
|
|
"compositions/scene.html",
|
|
(el) => el.style,
|
|
(el, value) => {
|
|
el.style = value;
|
|
},
|
|
);
|
|
|
|
expect(elements[0]?.style).toBe(`background-image: url("cover.png")`);
|
|
});
|
|
});
|