mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-14 18:01:20 +08:00
969474e843
## What PR 3/17 of the catalog system rollout. Introduces the registry resolver/installer abstraction. No UX change — `init --template` still works identically. Stacks on #253. **New module: `packages/cli/src/registry/`** - `remote.ts` — fetches manifests (`registry.json`, `registry-item.json`) and item files from a GitHub-hosted registry. 24h cache on manifests; item files stream straight to `destDir` - `resolver.ts` — `listRegistryItems`, `loadAllItems` (parallel fetch for picker UX), `resolveItem` (single-item fetch with `Available:` error) - `installer.ts` — `assertSafeTarget` (runtime path-traversal guard) + `installItem` (parallel file download with up-front validation; all-or-nothing semantics) - `index.ts` — barrel **Registry content:** - `registry/registry.json` — top-level manifest in PR 1's `RegistryManifest` shape. 8 examples - `registry/examples/<id>/registry-item.json` — per-item manifest for each existing example, generated from legacy `templates.json` + HTML data-attribute probing - `registry/examples/templates.json` — **deleted**, replaced by the above **Compat layer:** - `packages/cli/src/templates/{remote,generators}.ts` — thin shims that delegate to `../registry/`, keeping `init.ts`'s existing imports stable. `init.ts` doesn't move to the new API until PR 5 where it's part of a larger UX pass **Tooling:** - `scripts/generate-registry-items.ts` — idempotent one-off generator for this PR, kept in-repo for future example additions (`--only <name>` flag) Design doc: [Hyperframes Catalog System](https://www.notion.so/heygen/Hyperframes-Catalog-System-Design-Plan-341449792c69813f899dcd53b4c0383a). Tracker entry in local `hyperframes-catalog-plan.md`. ## Why Every future PR (`hyperframes add`, seed blocks, seed components, custom registries) otherwise has to keep piling onto the ad-hoc fetch + `cpSync` pattern in the old `fetchRemoteTemplate`. The new module is the single place that understands the registry wire format and file layout. **This is also where PR 1's schema comes alive.** ## How ### Scope-trimmed from the plan - **No transitive dependency resolution yet.** Examples have no deps today. `resolveItem` doesn't walk `registryDependencies`; PR 5 adds that when blocks/components need it. - **No ajv schema validation yet.** TS types + runtime path-traversal guard are the only safety nets. Full JSON-Schema validation lands when the registry starts accepting third-party content (PR 14 / custom registries). - **init.ts refactor deferred to PR 5.** Compat shims keep this PR small and reviewable. PR 5 rewrites init alongside adding the `add` command. ### Safety - `assertSafeTarget` rejects absolute paths, `..` segments, Windows drive letters, and any target that `path.resolve` shows to escape `destDir`. Mirrors the PR 1 schema `pattern`/`not.anyOf` on `target`, but runs at install-time so a registry that bypasses schema validation still can't write outside the project - Up-front validation in `installItem` means a malformed item fails **before** any file is written. Atomic-ish semantics: all files land or none do ### Caching - 24h manifest cache lives at `~/.hyperframes/cache/` per existing convention, but now keyed by `<baseUrl>__<kind>__<name>.json` so PR 14 custom registries can coexist ## Test plan - [x] `bun run test` in `packages/cli`: **70 passed** (was 57 on #253, +13). Same 4 pre-existing failures (SRT/VTT whisper normalizer + `lintProject` clean-project test) — identical to main. No regressions - [x] **Resolver unit tests (8):** filter by type, parallel load with fail-safe, resolve-by-name with `Available:` error message, unreachable-registry handling - [x] **Installer unit tests (5):** accepts simple relative paths, rejects `..` segments, rejects Unix absolute paths, rejects Windows drive letters, permits `.` and dotfile-like names - [x] **Smoke test**: `hyperframes init /tmp/x --template blank` (bundled code path, unchanged) works end-to-end - [x] `bunx oxfmt --check` + `bunx oxlint`: clean - [x] Pre-commit typecheck (core + studio): clean. CLI typecheck has 2 pre-existing errors (`render.ts`, `studioServer.ts` — unrelated `"mov"` format issue on main) - [ ] **Smoke test remote fetch (`--template warm-grain`)** — verifiable only post-merge; registry paths live on `main` after this PR lands ## Breaking / migration **No end-user-visible UX change.** `init --template <name>` still works the same way. Internally, `templates.json` is gone and the CLI now reads `registry.json` + `registry-item.json` per example. Installed CLIs on old versions (`hyperframes@0.1.0`–`0.3.0`) already broke at PR 2 merge (see #253 rollout note). The next CLI release after this lands (`0.3.1`+) is the full fix. ## Commits 1. `generate-registry-items.ts` + generated manifests + deleted `templates.json` 2. Resolver + installer + compat shims 3. Unit tests (All squashed into one commit on this branch; see `git log feat/registry-resolver ^refactor/registry-examples-dir`.) ## Stacks on #253 — base branch. When #253 merges, this rebases onto `main`. ## Next in stack PR 4 — `feat(cli)!: rename --template to --example`. Single clean cut, no alias. Tiny PR (~150 lines) that mostly updates `init.ts`'s argument schema, help text, and docs. Depends on this PR so the new flag name can be applied against the refactored code path. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
183 lines
5.9 KiB
TypeScript
183 lines
5.9 KiB
TypeScript
#!/usr/bin/env tsx
|
|
/**
|
|
* Generate registry-item.json manifests for every example in registry/examples/,
|
|
* plus the top-level registry/registry.json manifest.
|
|
*
|
|
* Reads the legacy registry/examples/templates.json (label + hint) and probes
|
|
* each example's index.html for dimensions / duration data attributes.
|
|
* Placeholder `__VIDEO_DURATION__` falls back to 10 (the init-time default).
|
|
*
|
|
* Idempotent — safe to re-run, but will overwrite any hand-edits. Intended as
|
|
* one-shot scaffolding for PR 3.
|
|
*
|
|
* Usage:
|
|
* bun run scripts/generate-registry-items.ts
|
|
* bun run scripts/generate-registry-items.ts --only warm-grain
|
|
*/
|
|
|
|
import { readFileSync, writeFileSync, readdirSync, statSync } from "node:fs";
|
|
import { join, relative, resolve, dirname } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import {
|
|
ITEM_TYPE_DIRS,
|
|
type FileTarget,
|
|
type FileType,
|
|
type RegistryItem,
|
|
type RegistryManifest,
|
|
} from "@hyperframes/core";
|
|
|
|
const scriptDir = dirname(fileURLToPath(import.meta.url));
|
|
const repoRoot = resolve(scriptDir, "..");
|
|
const examplesDir = resolve(repoRoot, "registry", ITEM_TYPE_DIRS["hyperframes:example"]);
|
|
const registryManifestPath = resolve(repoRoot, "registry/registry.json");
|
|
const legacyManifestPath = resolve(examplesDir, "templates.json");
|
|
|
|
const DEFAULT_DURATION_SECONDS = 10;
|
|
const PLACEHOLDER_DURATION = "__VIDEO_DURATION__";
|
|
|
|
interface LegacyTemplateEntry {
|
|
id: string;
|
|
label: string;
|
|
hint: string;
|
|
bundled: boolean;
|
|
}
|
|
|
|
interface LegacyManifest {
|
|
templates: LegacyTemplateEntry[];
|
|
}
|
|
|
|
function readLegacyManifest(): LegacyTemplateEntry[] {
|
|
const raw = readFileSync(legacyManifestPath, "utf-8");
|
|
const parsed = JSON.parse(raw) as LegacyManifest;
|
|
return parsed.templates;
|
|
}
|
|
|
|
function extractAttr(html: string, attr: string): string | undefined {
|
|
const match = new RegExp(`data-${attr}="([^"]*)"`).exec(html);
|
|
return match?.[1];
|
|
}
|
|
|
|
interface CanvasMeta {
|
|
width: number;
|
|
height: number;
|
|
duration: number;
|
|
}
|
|
|
|
function probeCanvas(exampleDir: string): CanvasMeta {
|
|
const html = readFileSync(join(exampleDir, "index.html"), "utf-8");
|
|
const width = Number(extractAttr(html, "width") ?? 1920);
|
|
const height = Number(extractAttr(html, "height") ?? 1080);
|
|
const rawDuration = extractAttr(html, "duration");
|
|
const duration =
|
|
rawDuration === undefined || rawDuration === PLACEHOLDER_DURATION
|
|
? DEFAULT_DURATION_SECONDS
|
|
: Number(rawDuration);
|
|
return { width, height, duration };
|
|
}
|
|
|
|
function fileTypeFor(path: string): FileType {
|
|
if (path.endsWith(".html")) return "hyperframes:composition";
|
|
return "hyperframes:asset";
|
|
}
|
|
|
|
/** Walk the example dir and collect every tracked file (HTML + assets). */
|
|
function collectFiles(exampleDir: string): FileTarget[] {
|
|
const files: FileTarget[] = [];
|
|
const walk = (dir: string): void => {
|
|
for (const entry of readdirSync(dir, { withFileTypes: true })) {
|
|
const full = join(dir, entry.name);
|
|
if (entry.isDirectory()) {
|
|
walk(full);
|
|
} else if (entry.isFile()) {
|
|
// Skip the registry-item.json itself if it already exists from a
|
|
// prior run; we're regenerating it.
|
|
if (entry.name === "registry-item.json") continue;
|
|
const rel = relative(exampleDir, full);
|
|
files.push({ path: rel, target: rel, type: fileTypeFor(rel) });
|
|
}
|
|
}
|
|
};
|
|
walk(exampleDir);
|
|
files.sort((a, b) => a.path.localeCompare(b.path));
|
|
return files;
|
|
}
|
|
|
|
function buildItem(entry: LegacyTemplateEntry): RegistryItem {
|
|
// The `blank` template is bundled inside the CLI package; don't generate a
|
|
// manifest in registry/examples/ for it.
|
|
const exampleDir = join(examplesDir, entry.id);
|
|
const canvas = probeCanvas(exampleDir);
|
|
const files = collectFiles(exampleDir);
|
|
|
|
return {
|
|
$schema: "https://hyperframes.heygen.com/schema/registry-item.json",
|
|
name: entry.id,
|
|
type: "hyperframes:example",
|
|
title: entry.label,
|
|
description: entry.hint,
|
|
dimensions: { width: canvas.width, height: canvas.height },
|
|
duration: canvas.duration,
|
|
files,
|
|
};
|
|
}
|
|
|
|
function writeItem(item: RegistryItem): void {
|
|
if (item.type !== "hyperframes:example") return;
|
|
const out = join(examplesDir, item.name, "registry-item.json");
|
|
writeFileSync(out, JSON.stringify(item, null, 2) + "\n", "utf-8");
|
|
console.log(`wrote ${relative(repoRoot, out)}`);
|
|
}
|
|
|
|
function writeRegistryManifest(items: RegistryItem[]): void {
|
|
const manifest: RegistryManifest = {
|
|
$schema: "https://hyperframes.heygen.com/schema/registry.json",
|
|
name: "hyperframes",
|
|
homepage: "https://hyperframes.heygen.com",
|
|
items: items.map((item) => ({ name: item.name, type: item.type })),
|
|
};
|
|
writeFileSync(registryManifestPath, JSON.stringify(manifest, null, 2) + "\n", "utf-8");
|
|
console.log(`wrote ${relative(repoRoot, registryManifestPath)}`);
|
|
}
|
|
|
|
function main(): void {
|
|
const args = process.argv.slice(2);
|
|
const onlyIdx = args.indexOf("--only");
|
|
const only = onlyIdx >= 0 ? args[onlyIdx + 1] : undefined;
|
|
|
|
const legacy = readLegacyManifest();
|
|
// Skip bundled templates (e.g. `blank`) — they live inside the CLI package,
|
|
// not under registry/examples/.
|
|
const onDisk = legacy.filter((t) => !t.bundled);
|
|
const filtered = only ? onDisk.filter((t) => t.id === only) : onDisk;
|
|
|
|
if (filtered.length === 0) {
|
|
console.error(
|
|
only
|
|
? `No example matches --only ${only}. Available: ${onDisk.map((t) => t.id).join(", ")}`
|
|
: "No examples found in registry/examples/templates.json",
|
|
);
|
|
process.exit(1);
|
|
}
|
|
|
|
const items: RegistryItem[] = [];
|
|
for (const entry of filtered) {
|
|
const exampleDir = join(examplesDir, entry.id);
|
|
try {
|
|
statSync(exampleDir);
|
|
} catch {
|
|
console.warn(`skip ${entry.id}: directory not found at ${relative(repoRoot, exampleDir)}`);
|
|
continue;
|
|
}
|
|
const item = buildItem(entry);
|
|
writeItem(item);
|
|
items.push(item);
|
|
}
|
|
|
|
// Only rewrite the top-level manifest on a full-run (not --only).
|
|
if (!only) {
|
|
writeRegistryManifest(items);
|
|
}
|
|
}
|
|
|
|
main();
|