mirror of
https://github.com/Fission-AI/OpenSpec.git
synced 2026-09-14 20:16:53 +08:00
6d84924c18
* fix(cli): use dynamic import for @inquirer/prompts in config command The config command (added in #382) reintroduced the pre-commit hook hang issue that was fixed in #380. The static import of @inquirer/prompts at module load time causes stdin event listeners to be registered even when running non-interactive commands, preventing clean process exit when stdin is piped (as pre-commit does). Convert the static import to a dynamic import that only loads inquirer when the `config reset` command is actually used interactively. Fixes #367 * chore: add ESLint with no-restricted-imports rule for @inquirer Add ESLint configuration that prevents static imports of @inquirer/* modules. This prevents future regressions of the pre-commit hook hang issue fixed in this PR. The rule shows a helpful error message pointing to issue #367 for context. init.ts is exempted since it's already dynamically imported from the CLI. * ci: add ESLint step to lint job Run `pnpm lint` in CI to enforce the no-restricted-imports rule that prevents static @inquirer imports.
226 lines
5.2 KiB
YAML
226 lines
5.2 KiB
YAML
name: CI
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
push:
|
|
branches: [main]
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: ci-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
test_pr:
|
|
name: Test
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
if: github.event_name == 'pull_request'
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Setup pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 9
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build project
|
|
run: pnpm run build
|
|
|
|
- name: Run tests
|
|
run: pnpm test
|
|
|
|
- name: Upload test coverage
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: coverage-report-pr
|
|
path: coverage/
|
|
retention-days: 7
|
|
|
|
test_matrix:
|
|
name: Test (${{ matrix.label }})
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 15
|
|
if: github.event_name != 'pull_request'
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- os: ubuntu-latest
|
|
shell: bash
|
|
label: linux-bash
|
|
- os: macos-latest
|
|
shell: bash
|
|
label: macos-bash
|
|
- os: windows-latest
|
|
shell: pwsh
|
|
label: windows-pwsh
|
|
|
|
defaults:
|
|
run:
|
|
shell: ${{ matrix.shell }}
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Setup pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 9
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Print environment diagnostics
|
|
run: |
|
|
node -p "JSON.stringify({ platform: process.platform, arch: process.arch, shell: process.env.SHELL || process.env.ComSpec || '' })"
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build project
|
|
run: pnpm run build
|
|
|
|
- name: Run tests
|
|
run: pnpm test
|
|
|
|
- name: Upload test coverage
|
|
if: matrix.os == 'ubuntu-latest'
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: coverage-report-main
|
|
path: coverage/
|
|
retention-days: 7
|
|
|
|
lint:
|
|
name: Lint & Type Check
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Setup pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 9
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Build project
|
|
run: pnpm run build
|
|
|
|
- name: Type check
|
|
run: pnpm exec tsc --noEmit
|
|
|
|
- name: Lint
|
|
run: pnpm lint
|
|
|
|
- name: Check for build artifacts
|
|
run: |
|
|
if [ ! -d "dist" ]; then
|
|
echo "Error: dist directory not found after build"
|
|
exit 1
|
|
fi
|
|
if [ ! -f "dist/cli/index.js" ]; then
|
|
echo "Error: CLI entry point not found"
|
|
exit 1
|
|
fi
|
|
|
|
validate-changesets:
|
|
name: Validate Changesets
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request'
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Setup pnpm
|
|
uses: pnpm/action-setup@v4
|
|
with:
|
|
version: 9
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: '20'
|
|
cache: 'pnpm'
|
|
|
|
- name: Install dependencies
|
|
run: pnpm install --frozen-lockfile
|
|
|
|
- name: Validate changesets
|
|
run: |
|
|
if command -v changeset &> /dev/null; then
|
|
pnpm exec changeset status --since=origin/main
|
|
else
|
|
echo "Changesets not configured, skipping validation"
|
|
fi
|
|
|
|
required-checks-pr:
|
|
name: All checks passed
|
|
runs-on: ubuntu-latest
|
|
needs: [test_pr, lint]
|
|
if: always() && github.event_name == 'pull_request'
|
|
steps:
|
|
- name: Verify all checks passed
|
|
run: |
|
|
if [[ "${{ needs.test_pr.result }}" != "success" ]]; then
|
|
echo "Test job failed"
|
|
exit 1
|
|
fi
|
|
if [[ "${{ needs.lint.result }}" != "success" ]]; then
|
|
echo "Lint job failed"
|
|
exit 1
|
|
fi
|
|
echo "All required checks passed!"
|
|
|
|
required-checks-main:
|
|
name: All checks passed
|
|
runs-on: ubuntu-latest
|
|
needs: [test_matrix, lint]
|
|
if: always() && github.event_name != 'pull_request'
|
|
steps:
|
|
- name: Verify all checks passed
|
|
run: |
|
|
if [[ "${{ needs.test_matrix.result }}" != "success" ]]; then
|
|
echo "Matrix test job failed"
|
|
exit 1
|
|
fi
|
|
if [[ "${{ needs.lint.result }}" != "success" ]]; then
|
|
echo "Lint job failed"
|
|
exit 1
|
|
fi
|
|
echo "All required checks passed!"
|