2 Commits

Author	SHA1	Message	Date
Tabish Bidiwale	d73705736f	feat: make apply instructions schema-aware (#444) ... * feat: make apply instructions schema-aware The `generateApplyInstructions` function was hardcoded to check for `spec-driven` artifacts. This change makes it read artifact definitions from the schema's new `apply` block, enabling support for different workflows like TDD. Changes: - Add `ApplyPhaseSchema` Zod schema with `requires`, `tracks`, and `instruction` fields to types.ts - Update `SchemaYamlSchema` to include optional `apply` field - Add `apply` block to spec-driven and tdd schemas - Refactor `generateApplyInstructions` to: - Load schema via `resolveSchema()` - Read `apply.requires` for required artifacts - Check artifact existence dynamically (supports glob patterns) - Use `apply.tracks` for progress tracking (or skip if null) - Use `apply.instruction` for custom guidance - Build `contextFiles` from all existing artifacts in schema - Handle fallback when schema has no `apply` block (require all artifacts) - Add 8 new tests for schema-aware apply behavior * fix: improve apply instructions robustness and consistency - Fix artifactOutputExists to properly handle glob patterns cross-platform by using path.sep and verifying actual file matches - Remove redundant if/else in contextFiles loop - Distinguish between missing tracks file vs empty tracks file - Use consistent { error: } key in ApplyPhaseSchema validation - Rename fallback test to accurately describe what it tests * test: add fallback behavior tests for schemas without apply block Add two tests that verify the fallback logic when a schema lacks an apply block: - Blocks when not all artifacts exist (requires ALL artifacts) - Ready state with default instruction when all artifacts exist Uses XDG_DATA_HOME to create temporary user schemas for testing.	2026-01-05 22:45:27 -08:00
Tabish Bidiwale	cac54042ce	feat: add Agent Skills for experimental artifact workflow (#424) ... * feat: add Agent Skills for experimental artifact workflow Implements Task #3 from the experimental release plan: - Create skill templates for openspec-new-change and openspec-continue-change - Add artifact-experimental-setup CLI command - Generate Agent Skills in .claude/skills/ directory - Support cross-editor compatibility (Claude Code, Cursor, Windsurf) Skills follow the Agent Skills specification and provide: - Natural language invocation by AI assistants - Step-by-step artifact creation workflow - Dependency-driven change management * fix: update GitHub issues URL to correct repository Replace placeholder `https://github.com/your-org/openspec/issues` with correct URL `https://github.com/Fission-AI/OpenSpec/issues` in: - docs/experimental-release-plan.md - src/commands/artifact-workflow.ts Verified against package.json repository.url field. * feat: add openspec-apply-change skill for task implementation Add the apply skill to guide agents through implementing tasks from an OpenSpec change: - Add `openspec instructions apply` CLI command that parses tasks.md and returns context files, progress tracking, and dynamic instructions - Add `getApplyChangeSkillTemplate()` to skill-templates.ts with full workflow guidance for implementing tasks - Update artifact-experimental-setup to generate all three skills: openspec-new-change, openspec-continue-change, openspec-apply-change The apply skill supports the fluid "actions on a change" model: - Can be invoked anytime (if tasks.md exists) - Handles blocked/ready/all_done states - Guides agents to pause on issues and suggest artifact updates - Tracks progress via task checkboxes * docs: mark apply skill implementation steps as complete * feat: add Capabilities section to proposal template Enrich the proposal template to explicitly capture capability discovery: - Add "Capabilities" section with "New Capabilities" and "Modified Capabilities" subsections to proposal template - Update proposal instruction in schema.yaml to guide agents on researching existing specs and listing capabilities - Update skill instructions with detailed guidance for the Capabilities section This creates a clear contract between proposal and specs phases - each capability listed in the proposal will need a corresponding spec file. * feat: remove redundant `openspec next` command The `next` command was redundant with `status` - both show which artifacts are ready to create. The status command provides more context (done/ready/blocked) and is the single source of truth for artifact state. Changes: - Remove nextCommand function and CLI registration from artifact-workflow.ts - Update skill templates to use status instead of next - Update docs and specs to reflect removal - Add REMOVED Requirements section to cli-artifact-workflow spec - Remove 7 tests for the next command Migration: Use `openspec status --change <id> --json` and filter artifacts with `status: "ready"` to find artifacts that can be created next. * docs: clarify kebab-case naming in proposal template Update HTML comments in the Capabilities section to explicitly instruct using kebab-case identifiers with examples (user-auth, data-export, api-rate-limiting). * feat: add change proposals for per-change schema metadata Add two related change proposals for enabling schema selection in the experimental artifact workflow: 1. add-per-change-schema-metadata: Store schema choice in .openspec.yaml per change, enabling auto-detection in workflow commands. Includes Zod schema design and delta specs for cli-artifact-workflow. 2. add-agent-schema-selection: Follow-up to update agent skills to support dynamic schema selection (depends on metadata change). Also includes: - Example .openspec.yaml in add-frontmatter-to-openspec-artifact-files - Clarify "Modified Capabilities" guidance in proposal template * remove test change * feat: fix design.md as optional, update docs, add schema-aware apply proposal Changes: - Fix generateApplyInstructions to treat design.md as optional (not required) - Update experimental-release-plan.md CLI output to match implementation - Add openspec-apply-change skill to docs (was missing) - Fix test flow numbering after adding apply skill verification step - Add change proposal for making apply instructions schema-aware The schema-aware proposal introduces an `implementation` block in schema.yaml to define when a change becomes implementable and how to track progress.	2026-01-05 16:42:17 -08:00