Files
Trevin Chow 89cff2103f fix(review): resolve PR #881 Codex feedback on the apply / agent-mode contract
Address 7 P2 review threads, several of them fallout from this branch's
apply-model changes:

- mode:agent is now described as report-only (skips Stage 5c apply), not
  "serialization only" — a runner could otherwise apply during mode:agent and
  the caller would re-apply the same findings.
- Deprecated mode:autofix removed from the conflict-stop list so it no longer
  contradicts the deprecated-mode "ignore and proceed" path.
- Agent-mode output: the markdown Actionable Findings summary is default-mode
  only; mode:agent carries actionable findings solely in the JSON field and
  emits nothing after the object.
- Agent-mode JSON: require one raw (unfenced) JSON object so naive JSON.parse
  callers don't choke on a leading code fence.
- pr-remote scope: resolve a real PR_BASE_REF (fetch baseRefName + rev-parse)
  and pass it to reviewers/validators so the data-migration persona's
  git diff <base> -- db/schema.rb schema-drift check works on remote PRs.
- ce-optimize: inline a local mechanical-apply bar instead of referencing
  ce-work's review-findings-followup.md (skills must be self-contained).
- lfg review-followup: make the post-fix push upstream-aware so a fresh branch
  with no upstream doesn't break the autonomous pipeline.

Contract test updated for the report-only reframe. bun test: contract 29/0;
full suite at the 47 pre-existing failures, zero new.
2026-06-02 19:53:16 -07:00
..