Commit Graph

554 Commits

Author SHA1 Message Date
Trevin Chow 8069c020b4 fix(ce-sessions): guard tool-input slicing against dict-shaped values
summarize_claude_tool sliced inp.get("query", "") and inp.get("prompt", "")
unconditionally. When MCP or specialized tools put a dict in those fields,
dict[:80] raises TypeError: unhashable type: 'slice' and the per-session
extraction silently fails. Same exposure existed in handle_cursor's
tool_use path.

Add a _safe_slice helper and reroute every potentially-non-string field
through it, then add regression tests for dict-shaped query, command,
prompt, pattern, fall-through to a later string field, and the cursor path.

Fixes #805
2026-05-08 13:50:56 -07:00
Trevin Chow dd25db036c fix(ce-sessions): move orchestration to skill, reshape historian to synthesis-only
The ce-session-historian agent deadlocked when dispatched as a subagent in
Claude Code because its first action was Skill(ce-session-inventory), and
subagents cannot invoke the Skill tool (anthropics/claude-code#38719). The
spinner hung at "Initializing…" indefinitely; after timeout the orchestrator
received a spurious "user doesn't want to proceed" rejection.

The fix removes every code path that has a subagent calling Skill:

- Move 4 extraction scripts into plugins/compound-engineering/skills/ce-sessions/scripts/
  (single home; ce-session-inventory and ce-session-extract skills deleted)
- Rewrite ce-sessions/SKILL.md as the full orchestrator: discovery, branch +
  keyword filtering, scan-window selection, top-5 deep-dive cap, mktemp
  scratch dir, per-session extraction with new --output PATH flag (extraction
  bytes write directly to scratch, never round-trip through main-context tool
  results), dispatch of synthesis-only historian
- Reshape ce-session-historian.agent.md to synthesis-only: receives file
  paths in dispatch prompt, reads via native file-read tool, returns prose
  findings. No Skill calls, no Bash discovery, no orchestration logic
- Update ce-compound Phase 1 to delegate to ce-sessions via the platform's
  skill-invocation primitive (semantic-prose form per plan-handoff.md line 57
  convention, not literal Skill(...) syntax). Specifies dispatch ordering so
  the parallel research subagents and ce-sessions still run concurrently —
  wall-clock parallelism preserved
- Add --output PATH to extract-skeleton.py and extract-errors.py: when set,
  scripts write to file and emit only a one-line JSON status to stdout.
  Stdout-mode behavior preserved when omitted (additive API change)
- Add regression test (tests/skills/ce-session-historian-no-skill-tool.test.ts)
  asserting the agent body never instructs Skill(ce-session-inventory),
  Skill(ce-session-extract), or any literal Skill(...) tool-call expression
- Register ce-session-inventory and ce-session-extract in legacy-cleanup
  lookups (STALE_SKILL_DIRS, LEGACY_ONLY_SKILL_DESCRIPTIONS, and
  EXTRA_LEGACY_ARTIFACTS_BY_PLUGIN) so existing flat-installs sweep on upgrade
- Fix broken See Also links in docs/skills/ce-sessions.md

The bug is structurally gone: no subagent in the post-refactor flow ever
invokes the Skill tool. Plan with full design rationale, alternatives
considered (including issue #794's Options 1 and 2), and implementation
units lives at docs/plans/2026-05-08-001-fix-ce-sessions-orchestration-refactor-plan.md.

All 1337 bun tests pass; bun run release:validate passes (37 skills,
49 agents). Closes #794.
2026-05-08 09:33:48 -07:00
Trevin Chow 0e49506bf0 refactor(agent-descriptions): trim top 7 by ~25% (#803) 2026-05-08 09:31:03 -07:00
Trevin Chow 04031a5a54 refactor(skill-descriptions): trim top 7 by ~55% (#802) 2026-05-08 09:26:49 -07:00
Trevin Chow a01d2a64b2 refactor(ce-agent-native-architecture): slim SKILL.md by 80% (#801) 2026-05-08 09:19:40 -07:00
Trevin Chow 6fc57c501f fix(ce-debug): right-size triage and tighten hypothesis discipline (#796) 2026-05-08 08:09:47 -07:00
github-actions[bot] 0bb53dfad0 chore: release main (#789)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-07 08:11:18 -07:00
Trevin Chow 9ec351a13f refactor(ce-commit-push-pr): trim prescription and fold steps (#791) 2026-05-07 02:39:58 -07:00
Trevin Chow 168fad4ac2 fix(ce-ideate): bound scope and add topic-surface decomposition (#787)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-07 02:21:08 -07:00
Kieran Klaassen d316971b20 feat(lfg): allow model invocation, add CI autofix loop after PR (#788) 2026-05-07 00:06:10 -05:00
github-actions[bot] 52e8f868b9 chore: release main (#781)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-05 17:21:01 -07:00
Trevin Chow 8349e750b8 fix(doc-review): cut review noise on plans, scope personas to doc shape (#780)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 15:52:36 -07:00
github-actions[bot] 18076e0204 chore: release main (#771)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-05 13:22:55 -07:00
David A. Lee 3e03365d54 feat(ce-work-beta): adaptive effort selection for Codex delegation batches (#759) 2026-05-05 12:02:43 -07:00
David A. Lee 5139ff13e9 fix(ce-work-beta): replace semicolon pre-resolution with single-command form (#758)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-05 12:01:22 -07:00
Pavlos Vinieratos be2efd7d76 fix(ce-plan): render Implementation Units as headings, not bulleted list items (#766) 2026-05-05 11:59:48 -07:00
Trevin Chow c7fc674326 fix(review): escape literal pipes in finding table cells (#779)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 11:46:13 -07:00
Trevin Chow 1f3c6466e4 fix(ce-doc-review): block diagram deletion as a fix recommendation (#775)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-05 01:02:44 -07:00
Trevin Chow a1698b7a0e docs(skills): add user-facing skill docs at docs/skills/ (#773) 2026-05-04 17:39:48 -07:00
David A. Lee 7ff3472cab fix(ce-work-beta): update Codex sandbox flags to current CLI syntax (#770) 2026-05-04 17:01:59 -07:00
Trevin Chow 4cc1ee6fe2 fix(ce-worktree): resolve script path against skill dir, not user CWD (#772)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-04 15:55:19 -07:00
Trevin Chow 542786320b fix(ce-doc-review): tighten finding resolution routing (#769) 2026-05-04 14:10:46 -07:00
github-actions[bot] 62170315ba chore: release main (#767)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-04 11:55:42 -05:00
Kieran Klaassen dde9256362 feat(riffrec-feedback-analysis): add Riffrec feedback skill with three-path routing (#747)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-04 11:12:56 -05:00
github-actions[bot] 06a7cee0ad chore: release main (#753)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-03 19:58:28 -07:00
hnshah e8567566b7 fix(ce-code-review): keep finding numbers stable (#754) 2026-05-03 18:59:03 -07:00
Trevin Chow a84cb759d0 fix(ce-commit-push-pr): use body-file for PR descriptions (#757) 2026-05-03 18:58:17 -07:00
hnshah caf5e1251c fix(ce-polish-beta): support Bash 3.2 project detection (#755) 2026-05-03 00:36:25 -07:00
David Gerő 9539bf045d fix(ce-compound, ce-sessions): remove bash parameter expansion from ! backtick (#752)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-02 10:44:09 -07:00
Trevin Chow 74624f8e7f refactor(ce-simplify-code): scope tests by ripple risk, not full suite (#749) 2026-05-01 16:18:12 -07:00
Trevin Chow 607c52ab7d refactor(code-review): move resolve-base.sh to scripts/ directory (#744)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-01 13:34:56 -07:00
github-actions[bot] d685f07948 chore: release main (#740)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-01 10:39:23 -07:00
Trevin Chow 520a9ebea0 fix(code-review): grant Write to JSON-pipeline reviewer agents (#741)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-01 10:24:40 -07:00
Trevin Chow 887db6b2ad fix(ce-setup): detect codex global skills (#739) 2026-05-01 09:22:48 -07:00
github-actions[bot] e12afb1e43 chore: release main (#728)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-05-01 07:23:44 -07:00
Trevin Chow ae408721cd chore(code-review): remove cli-readiness reviewer agents (#734) 2026-05-01 01:21:44 -07:00
Trevin Chow 2d20757412 feat(ce-simplify-code): add skill for simplifying recent code changes (#735) 2026-05-01 01:14:27 -07:00
Dan Dombrowski 3873b9e9de fix(ce-commit-push-pr): URL-encode parens in badge model-slug examples (#725) 2026-04-30 23:00:29 -07:00
Trevin Chow 5e04534137 fix(ce-compound,ce-sessions): handle non-git CWD in pre-resolved git branch (#731)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 22:59:15 -07:00
Trevin Chow 265cb4280f feat(ce-strategy): move strategy doc to root and add frontmatter (#732)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 22:07:12 -07:00
imwm cb8f9b3483 feat(ce-strategy,ce-product-pulse): add PM skills for upstream anchor and outcome pulse (#614) 2026-04-30 17:49:35 -07:00
David Gerő 8f804669b1 fix(ce-sessions): 722 ce-compound and ce-sessions permission error (#723)
Co-authored-by: davidpgero <davidpgero@kor-group.com>
2026-04-30 16:32:22 -07:00
Trevin Chow 15c1cde7b3 fix(ce-plan): close synthesis drift in rich-context invocations (#729) 2026-04-30 16:30:07 -07:00
Trevin Chow d217660b3d fix(review): default to harness-native code review, escalate on risk (#721)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-30 16:08:31 -07:00
github-actions[bot] e5b397c9d1 chore: release main (#719)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-28 21:53:53 -07:00
Trevin Chow 09fa18bcc1 fix(ce-code-review): comment-gate previous-comments persona to skip empty PRs (#720)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-28 21:53:03 -07:00
Trevin Chow 5ac1a063a9 fix(ce-code-review): mandate walkthrough.md load on walk-through entry (#718) 2026-04-28 20:39:20 -07:00
github-actions[bot] 3803e8ab3d chore: release main (#717)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-28 13:11:22 -07:00
Trevin Chow d69a772bb8 fix(review): queue reviewers when subagent slots fill (#716) 2026-04-28 13:01:10 -07:00
github-actions[bot] 48e83d9340 chore: release main (#703)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-28 12:44:22 -07:00