Commit Graph

461 Commits

Author SHA1 Message Date
Trevin Chow e14b2360ac fix(ce-code-review): run mode guard before skip-condition probe in PR mode
mode:report-only and mode:headless should short-circuit before any gh
call — they don't need PR state to emit their "cannot switch shared
checkout" messages. Previously the skip probe (gh pr view) ran first,
causing environments without gh auth to abort early instead of hitting
the documented mode behavior. Reordered: mode guard first, then skip
probe.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 21:03:51 -07:00
Trevin Chow 9015e124b0 fix(ce-code-review): address PR feedback — demotion corroboration, Option C scope, artifact dependency
- Demotion rule (step 6c) now requires ALL contributing reviewers to
  be testing/maintainability; a finding corroborated by any other
  persona (security, correctness, etc.) is kept in primary findings
  regardless of severity or advisory status

- Stage 5b Option C scope corrected in both the mode table and step 1:
  File-tickets path validates all pending findings regardless of
  recommended action (not just Apply/Defer), since every finding is
  externalized as a ticket

- Stage 5b validator input makes why_it_matters optional — included
  when the artifact file exists, omitted when the write failed; a
  missing artifact no longer causes a validator failure or finding drop

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:53:04 -07:00
Trevin Chow 54b6832992 fix(ce-code-review): correct model reference date to April 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:33:52 -07:00
Trevin Chow b1e434734c fix(ce-code-review): correct OpenAI model references to gpt-5.4 family
gpt-4.1-mini is stale. Current OpenAI lineup is gpt-5.4 / gpt-5.4-mini
/ gpt-5.4-nano. Update mid-tier reference to gpt-5.4-mini and the
lightweight pre-check reference to gpt-5.4-nano.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:33:43 -07:00
Trevin Chow 41a6ba3359 fix(ce-code-review): update Codex mid-tier model reference to gpt-4.1-mini
gpt-4o is stale as of April 2025; gpt-4.1-mini is the current Sonnet
equivalent — same quality, 83% cheaper, ~2x faster.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:32:07 -07:00
Trevin Chow 142c8e559e refactor(ce-code-review): tier reviewer models by stakes
Correctness, security, and adversarial reviewers inherit the session
model (no override) -- these run the highest-stakes analysis and
should use whatever capability the user configured, typically Opus.

All other persona and CE sub-agents are explicitly pinned to mid-tier
(sonnet) since their work is more mechanical: test coverage, style,
standards compliance, learnings search, agent-native checks.

Orchestrator also inherits session model (unchanged behavior, now
explicit in the rationale).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:29:16 -07:00
Trevin Chow 4908f00a44 refactor(ce-code-review): replace PR skip heuristics with lightweight model judgment
- Remove draft-PR skip: reviewing in-progress work is valuable, not a
  reason to stop
- Remove already-reviewed skip: we don't post PR comments so there is
  no reliable signal to detect prior runs
- Replace chore(deps)/chore:release regex with a Haiku (Claude) /
  GPT-4.1-mini (Codex) sub-agent that judges trivial PRs by reading
  title, body, and file list -- LLM judgment beats pattern matching for
  lock-file bumps, release commits, and other auto-generated changes
- Update contract tests to match: verify draft is not skipped, verify
  lightweight model dispatch, remove regex literal assertions

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:26:55 -07:00
Trevin Chow 125fa727d6 fix(ce-code-review): address PR feedback — author-gated skip check and Stage 5b LFG handoff
- Restrict already-reviewed skip rule to comments authored by the
  current authenticated user (gh api user -q .login), preventing
  false skips from third-party or human comments with ## Code Review
  headings

- Split walk-through Stage 5b table row: per-finding phase stays No
  (user is the validator), LFG-the-rest handoff now runs Stage 5b on
  the remaining action set before bulk-preview dispatch — same gate as
  top-level LFG (option B)

- Update walkthrough.md LFG-the-rest routing to insert the Stage 5b
  validator gate before bulk-preview dispatch

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-21 20:12:57 -07:00
Trevin Chow f68907a6df fix(ce-code-review): reorder Stage 5 so promotion and demotion run before the confidence gate
Three review-feedback fixes:

1. Move the confidence gate to after dedup, cross-reviewer promotion, and
   mode-aware demotion. Previously the gate ran at step 2 and silently dropped
   anchor-50 findings before promotion (50 -> 75) or demotion (advisory ->
   soft buckets) could touch them, making both rules unreachable for matching
   anchor-50 inputs and contradicting the persona rubric.

2. Demotion text now uses title only ("file:line -- title") instead of
   "file:line -- title: why_it_matters". The compact return omits
   why_it_matters and report-only mode skips artifact files entirely, so the
   field was unavailable in the modes the rule applies to.

3. Update the compact-return JSON example from "confidence": 0.92 to
   "confidence": 100. The float was inconsistent with the schema's integer
   enum and would have been dropped by the Stage 5 validator if a persona
   followed the example literally.

Tests updated for the reordered step numbering and new demotion wording.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 19:07:52 -07:00
Trevin Chow 63f7e4fe30 refactor(ce-code-review): adopt anchored confidence, validation gate, and mode-aware precision
Port the anchored-rubric pattern from ce-doc-review and add three
code-review-specific precision controls inspired by Anthropic's official
code-review plugin.

Changes:
- Replace continuous confidence (0.0-1.0) with integer enum [0,25,50,75,100]
  and behavioral anchors. Threshold: anchor 75 (P0 escape at anchor 50).
- Replace +0.10 cross-reviewer boost with one-anchor promotion
  (50 -> 75, 75 -> 100). Sort by anchor descending.
- Add Stage 5b validation pass: independent validator subagent per surviving
  finding before externalization. Mode-conditional (headless/autofix and
  interactive LFG/File-tickets routing). 15-finding budget cap. No metadata
  field on findings; rejected drops, accepted flows through.
- Add PR-mode skip-condition pre-check (closed/draft/trivial/already-reviewed).
  Single gh pr view probe. Standalone branch and base: modes unaffected.
- Add mode-aware demotion in Stage 5: testing/maintainability P2/P3 advisory
  findings route to testing_gaps/residual_risks in interactive/report-only,
  suppress in headless/autofix.
- Add lint-ignore suppression to false-positive catalog.
- Update 18 persona files from float bands to anchored language, preserving
  per-persona calibration signals.
- Update review-output-template.md to render anchors as integers.
- Contract tests cover all the above plus per-persona anchored-language
  assertions.

Plan: docs/plans/2026-04-21-002-refactor-ce-code-review-precision-and-validation-plan.md
Solutions doc extended: docs/solutions/skill-design/confidence-anchored-scoring-2026-04-21.md

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 18:36:19 -07:00
Trevin Chow accbd2adcf refactor(todos): remove internal file-based todo system (#635)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 18:16:13 -07:00
Trevin Chow 19bbb60e90 refactor(skills): remove ce-onboarding skill (#639)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 18:15:36 -07:00
Trevin Chow 701ae10c2d feat(ce-code-review): add Swift/iOS stack-specific reviewer persona (#638)
Co-authored-by: Joshua Martens <joshua@every.to>
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-21 17:30:04 -07:00
Trevin Chow 271b1a4458 refactor(skills): remove 5 unused skills and clean references (#634) 2026-04-21 18:52:29 -05:00
Trevin Chow ff0eee391e refactor(ce-brainstorm): make doc review opt-in in Phase 4 handoff (#633) 2026-04-21 16:28:20 -07:00
Trevin Chow 44ce9dd127 feat(ce-plan): add U-IDs and origin trace to plan template (#632) 2026-04-21 16:07:28 -07:00
Trevin Chow 21666f0b67 refactor(ce-worktree): trim to creation-only and fix latent bugs (#631) 2026-04-21 15:15:09 -07:00
Trevin Chow 6caf330363 refactor(ce-doc-review): anchor-based confidence scoring (#622)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-21 14:54:03 -07:00
Trevin Chow bd77d5550a feat(ce-brainstorm): product-tier with end-to-end ID traceability (#629) 2026-04-21 14:07:20 -07:00
Trevin Chow 05ea109bdb fix(ce-learnings-researcher): drop unreadable schema path reference (#630) 2026-04-21 14:00:27 -07:00
Trevin Chow 4c57508c1a refactor(agents): flatten agents directory (#621) 2026-04-21 02:35:21 -07:00
Trevin Chow d359cc7e2f fix(question-tool): stop silent skips when tool looks unavailable (#620) 2026-04-21 01:27:52 -07:00
Trevin Chow cd4af86e5e refactor(session-history): move extraction scripts behind skills (#619) 2026-04-21 00:12:11 -07:00
Trevin Chow e0f2a4f9d7 feat(ce-proof): broaden triggers and surface markdown viewing (#618)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-20 21:11:07 -07:00
Trevin Chow 153bea8669 fix(ce-resolve-pr-feedback): stop dropping unresolved and actionable feedback (#617) 2026-04-20 20:44:16 -07:00
Trevin Chow 3ed4a4fa0f feat(codex): native plugin install manifests + agents-only converter (#616) 2026-04-20 19:44:25 -07:00
Trevin Chow c2d60b47be refactor(install): prefer native plugin install across targets (#609)
Co-authored-by: John Cavanaugh <cavanaug@users.noreply.github.com>
2026-04-20 18:47:07 -07:00
Trevin Chow 9497a00d90 fix(ce-plan): inline handoff menu so post-plan options are never skipped (#615) 2026-04-20 14:44:23 -07:00
Trevin Chow d8436b9a3c fix(ce-compound): quote YAML array items starting with reserved indicators (#613)
Co-authored-by: Nathan Vale <hi@nathanvale.com>
2026-04-20 14:01:11 -07:00
GruntworkAI e1524287f7 fix(ce-gemini-imagegen): bump Pillow floor to 10.3.0 to clear 4 CVEs (#608) 2026-04-20 12:11:28 -07:00
Trevin Chow 2dd0a6e6c7 feat(ce-resolve-pr-feedback): tighten clustering to cross-round only (#611) 2026-04-20 01:12:06 -07:00
Trevin Chow b35de99788 feat(ce-resolve-pr-feedback): drop bot noise, centralize test runs (#610) 2026-04-20 00:33:03 -07:00
Trevin Chow c1f68d4d55 feat(doc-review, learnings-researcher): tiers, chain grouping, rewrite (#601)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-19 20:25:47 -07:00
Trevin Chow 409b07fbc7 fix(ce-pr-description): cap description size and add pre-apply preview (#605) 2026-04-19 17:36:38 -07:00
Trevin Chow 2aee4d4203 fix(ce-release-notes): backtick-wrap <skill-name> token in description (#603) 2026-04-19 00:38:15 -07:00
Trevin Chow b575e49c29 fix(ce-work): reject plan re-scoping into human-time phases (#600) 2026-04-18 17:33:59 -07:00
Trevin Chow 5c0ec9137a refactor(cli)!: rename all skills and agents to consistent ce- prefix (#503)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-18 15:44:22 -07:00
Trevin Chow 49249d7317 fix(ce-plan): run ambiguity gate before the non-software catch-all (#598)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 15:31:38 -07:00
Trevin Chow d8e87c1790 fix(ce-plan): close exit gates and honor user-named resources (#597)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-18 15:19:04 -07:00
Trevin Chow 27cbaf8161 feat(ce-review): add per-finding judgment loop to Interactive mode (#590)
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-18 13:09:03 -07:00
github-actions[bot] dfcaddf345 chore: release main (#592)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-18 02:44:29 -07:00
Trevin Chow 1afd63cc76 fix(git-commit-push-pr): apply PR description after delegate hand-off (#594) 2026-04-18 02:42:00 -07:00
Trevin Chow cc78551e7c fix(ce-pr-description): mark return block as hand-off (#593) 2026-04-18 01:55:09 -07:00
Trevin Chow 821c69c567 fix(ce-compound-refresh): restore ce:compound hand-off (#591) 2026-04-18 01:47:05 -07:00
github-actions[bot] 7924f5ccc9 chore: release main (#586)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-17 11:42:41 -07:00
Trevin Chow 12aaad31eb feat(ce-ideate): mode-aware v2 ideation (#588)
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-17 11:40:54 -07:00
Trevin Chow 59dbaef376 feat(ce-release-notes): add skill for browsing plugin release history (#589)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-17 02:00:37 -07:00
Trevin Chow e7cf0ae957 feat(proof, ce-brainstorm, ce-plan, ce-ideate): HITL review-loop mode (#580)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-16 23:14:33 -07:00
github-actions[bot] d8af513a0a chore: release main (#584)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2026-04-16 22:59:10 -07:00
Trevin Chow c89f18a115 fix(ce-pr-description): hand off PR body via temp file (#581)
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-04-16 22:47:49 -07:00