mirror of
https://github.com/dotnet/skills.git
synced 2026-09-20 09:49:54 +08:00
Abhitej John
78054c1161
* Make Vally the sole LLM eval engine, retiring skill-validator evaluate Collapses the parallel skill-validator + Vally eval pipeline into a single Vally-only path while preserving every capability skill-validator provided: PR gate, PR comment, dotnet/skills-data historical push, and the dashboard. The skill-validator `check` linter is retained (skill-check.yml) pending microsoft/vally #463. - evaluation.yml: delete build-validator and the skill-validator `evaluate` job; single `evaluate:` job now uses vally-evaluation.yml. Forward the COPILOT_PAT_0..9 pool onto it (from #911) so the reusable workflow's token gate is satisfied. Rewire comment-on-pr / report-status / publish-* / deploy-dashboard onto `evaluate` and vally-results-* artifacts. - vally-evaluation.yml: pin @microsoft/vally-cli@0.9.0; keep the #911 prepare guard; write the generated per-plugin experiment to $GITHUB_WORKSPACE so relative eval globs resolve. - adapt.mjs: reconcile #887's runCompareWithRetry + conclusive/unmatched hardening with the consolidation helpers (nonActivation, compareByStim, roleToDashboard, etc.). Add consolidate.mjs and gen-experiment.mjs. - build-replay-sessions.ps1: read Vally executor-session-logs/events.jsonl instead of skill-validator session output. - Rename all tests/*/*/eval.vally.yaml to eval.yaml (Vally format is now the only eval format); author Vally evals for the four skills that lacked one. - CONTRIBUTING.md + InvestigatingResults: point contributors at the Vally harness; drop non-public links. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix setup-local-sdk eval for Vally schema The hand-authored setup-local-sdk eval used skill-validator grader/environment schema that Vally rejects at validation (no stimuli executed): - file-contains/file-not-contains graders require 'value:' not 'substring:' (output-contains correctly keeps 'substring:'). - environment.files entries require 'src:'/'dest:' (copy a fixture) rather than inline 'path:'/'content:'. Moved the global.json body into fixtures/global.json. Verified with 'vally lint --eval-spec' (0 errors) across all 97 eval.yaml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix markdownlint violations in migration docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address PR review feedback on eval migration - Consolidate run-vally-evals.sh into a single neutral entrypoint eng/run-skill-evals.sh (deletes the thin wrapper; adapt.mjs stays in eng/vally-adapter/ since CI invokes it directly) - Rename reusable workflow vally-evaluation.yml -> evaluation-run.yml and update all references/self-trigger regexes - Rename local output dir vally-results -> eval-results - Bake prerequisite preflight (Node 20+, GITHUB_TOKEN/gh) into the runner - Simplify CONTRIBUTING "Running tests locally" prerequisites - Scrub harness name from consumer-facing surfaces Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reinstate overfitting detection under the Vally harness Overfitting detection previously ran inside skill-validator's `evaluate` command, which the Vally migration replaced, so it silently stopped running. Reinstate it as a standalone step wired into the Vally pipeline: - Add `skill-validator overfitting` command that discovers skills, parses each eval.yaml, runs the existing OverfittingJudge, and emits [{plugin, skill, overfittingResult}] JSON (per-skill failures non-fatal, bounded parallelism). - Add a Vally-format parser bridge (ParseEvalConfigFlexible) so the judge handles the current stimuli/graders eval.yaml format; the legacy scenarios-only parser rejected all 98 evals, so the judge never ran. - adapt.mjs: merge overfitting results onto each verdict via --overfitting <file> (keyed by plugin/skill); output is byte-identical when the flag is absent. - evaluation-run.yml: build skill-validator (shared cache with check), run the judge per leg reading GITHUB_TOKEN, and pass --overfitting to adapt.mjs so the dashboard/skills-data consume it unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Reconcile #919 Vally eval configs into the sole eval.yaml convention PR #919 landed on main adding fresh Vally specs for three coverage-gap skills (setup-local-sdk, convert-blazor-server-to-webapp, dotnet-webapi) under the interim eval.vally.yaml filename. This branch collapses to a single Vally spec named eval.yaml, so the merge left each skill with both my migrated eval.yaml and #919's newer eval.vally.yaml (a git-clean but semantic duplicate the pipeline would not discover). Adopt #919's reviewed Vally content as the canonical eval.yaml for all three skills and drop the redundant eval.vally.yaml files, preserving the 'sole eval.yaml, zero eval.vally.yaml' invariant. Content is byte-identical to #919's blobs (b14121c6/47d43823/18a9362f), which already passed vally-evaluate on main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
82 lines
3.5 KiB
YAML
82 lines
3.5 KiB
YAML
name: template-validation
|
|
description: Evaluates the dotnet-template-engine/template-validation skill
|
|
type: capability
|
|
config:
|
|
timeout: 3m
|
|
stimuli:
|
|
- name: Validate template with multiple errors
|
|
prompt: Check this template.json for any issues. It's at .template.config/template.json
|
|
environment:
|
|
files:
|
|
- src: ./fixtures/validate-template-with-multiple-errors/.template.config/template.json
|
|
dest: .template.config/template.json
|
|
graders:
|
|
- type: exit-success
|
|
- type: output-contains
|
|
config:
|
|
substring: identity
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)shortName.*(list|conflict|reserved|CLI)
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)(net7\.0|default.*not in|not.*valid.*choice)
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)((enableLogging|yes).*(bool|boolean).*(invalid|not\s+valid|must\s+be|expected)|(enableLogging|yes).*(invalid|not\s+valid|must\s+be|expected).*(bool|boolean))
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)((maxRetries|abc).*(int|integer).*(invalid|not\s+valid|must\s+be|expected)|(maxRetries|abc).*(invalid|not\s+valid|must\s+be|expected).*(int|integer))
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)computed.*(missing|no).*value
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)generated.*(missing|no).*generator
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)(actionId|post.?action).*(missing|required|no)
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)(not ready|\d+\s*error)
|
|
- type: output-matches
|
|
config:
|
|
pattern: \|.*\|
|
|
- type: prompt
|
|
rubric:
|
|
- The agent identified the missing 'identity' field (required)
|
|
- The agent flagged 'list' as a shortName that conflicts with a dotnet new subcommand
|
|
- The agent found that defaultValue 'net7.0' is not in the choices (net8.0, net9.0)
|
|
- The agent reported that 'yes' is not a valid boolean defaultValue for enableLogging
|
|
- The agent reported that 'abc' is not a valid integer defaultValue for maxRetries
|
|
- The agent found the computed symbol missing its 'value' expression
|
|
- The agent found the generated symbol missing its 'generator' field
|
|
- The agent found the post-action missing its 'actionId'
|
|
constraints:
|
|
expect_tools:
|
|
- skill
|
|
- name: Validate correct template and suggest improvements
|
|
prompt: Review the template at .template.config/template.json and tell me if it's ready to publish to NuGet.
|
|
environment:
|
|
files:
|
|
- src: ./fixtures/validate-correct-template-and-suggest-improvements/.template.config/template.json
|
|
dest: .template.config/template.json
|
|
graders:
|
|
- type: exit-success
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)(no errors?\b|0 errors?\b|template (is|looks) (valid|good)|ready to publish|no issues? (found|identified)?)
|
|
- type: output-matches
|
|
config:
|
|
pattern: (?i)\b(identity|shortName|name)\b
|
|
- type: prompt
|
|
rubric:
|
|
- The agent confirmed the template has no errors
|
|
- The agent verified all required fields (identity, name, shortName) are present
|
|
- The agent checked that shortName doesn't conflict with CLI commands
|
|
- The agent noted the template is well-formed and ready to publish
|
|
- The agent may suggest optional improvements (defaultName, description) without flagging errors
|
|
constraints:
|
|
expect_tools:
|
|
- skill
|