mirror of
https://github.com/dotnet/skills.git
synced 2026-09-20 09:49:54 +08:00
Jan Krivanek
1b99afac59
* Fix dotnet-msbuild skill eval regressions and coverage gaps (#896) Addresses the cross-family evaluation findings in #896. P0: - eval-performance: add diagnostic-first framing + explicit stop-conditions and gate prescriptive fixes on measurement, to stop over-application regressions. - msbuild-antipatterns: rewrite description with an action-verb lead and concrete trigger phrases to fix low invocation (FIX-DISCOVERY). P1: - Add cross-family eval.vally.yaml for extension-points, item-management, property-patterns, and target-authoring (previously excluded from the matrix). - check-bin-obj-clash: trim 465 -> 315 lines, removing the redundant text-log fallback steps, duplicate example workflow, and verbose tips (TRIM-COST). P2: - build-parallelism: add an opinionated 'start here' critical-path checklist. - binlog-generation: add one-build-one-binlog rule and a verify step. Keeps the plugin under the 15,000-char rendered skill-menu budget (14,981 -> 14,873). * Address PR review: portable grep whitespace + per-project eval count; shell-labeled binlog verify commands (#896) - check-bin-obj-clash: use [[:space:]] instead of non-portable \s in ERE; replace 'grep -c' note with an accurate per-project uniq -c count. - binlog-generation: label verify commands by shell and add the Windows cmd (dir /b) equivalent instead of mislabeling ls as cmd. * Address PR review round 2: full PowerShell -m command; match quoted project path in per-project eval count (#896) - build-parallelism: spell out 'dotnet build -m -bl:{{}}' for PowerShell so the -m flag isn't dropped. - check-bin-obj-clash: match the full quoted project path (not just filename) so same-named projects in different dirs stay distinct and paths with spaces work.