mirror of
https://github.com/dotnet/skills.git
synced 2026-09-20 09:49:54 +08:00
Jan Krivanek
14ee3c90f9
* Shard plugin evaluation via executionShard tag in eval.yaml MCP-heavy plugins like dotnet-msbuild reliably exhaust the GitHub-hosted runner host after ~87 min of cumulative MCP traffic (Copilot CLI plus dotnet dnx Microsoft.AITools.BinlogMcp child processes), which has produced no dashboard data for dotnet-msbuild scheduled runs since 2026-05-20. Cutting per-runner concurrency alone was insufficient: at the default 18-way concurrency the runner OOMs in 17-30 min; at 3-way it survives longer but still hits a host-level termination at ~87 min. Two mitigations, both required: 1. Sharding (this change). The discover step reads an optional top-level 'executionShard:' string from each tests/<plugin>/<skill>/eval.yaml and groups skills by tag, emitting one matrix entry per shard so each shard runs on a fresh runner. Untagged skills fall into a 'default' bucket. Plugins where all skills resolve to a single bucket emit one entry (unchanged behavior). The validator already calls IgnoreUnmatchedProperties so no Models.cs change is needed. Shard names follow '<plugin>--shard-<tag>' so the existing 'skill-validator-results-<plugin>--*' artifact glob keeps working. 2. Per-MCP-plugin concurrency caps (already in place). When plugin.json declares mcpServers, parallelism is forced to 1x3x1 with --judge-timeout 600 to avoid acute OOM within a shard. Also adds a workflow_dispatch 'plugin' input for targeted re-runs of a single plugin, and tags 10 dotnet-msbuild eval.yamls (heavy/medium); the remaining 8 fall into 'default'. Empirically the three shards complete in parallel in ~30-40 min each, well inside the 180-min job timeout, and successfully upload dashboard data. * Address PR review: lenient shard regex and validate dispatch plugin input - executionShard regex now tolerates optional leading whitespace, so an accidentally indented key still groups correctly instead of silently falling back to the default bucket. - workflow_dispatch 'plugin' input is now validated against ^[a-zA-Z0-9._-]+$ before any Join-Path/Test-Path use, preventing path-traversal style values (e.g. '../foo') from being injected into filesystem paths.
21 lines
1.0 KiB
YAML
21 lines
1.0 KiB
YAML
executionShard: medium
|
|
scenarios:
|
|
- name: "Diagnose bin/obj output path clashes"
|
|
prompt: "Build this solution and diagnose any build failures related to output path conflicts."
|
|
setup:
|
|
copy_test_files: true
|
|
assertions:
|
|
- type: "output_contains"
|
|
value: "AppendTargetFrameworkToOutputPath"
|
|
- type: "output_contains"
|
|
value: "OutputPath"
|
|
- type: "output_contains"
|
|
value: "IntermediateOutputPath"
|
|
rubric:
|
|
- "Identified MultiTargetLib has AppendTargetFrameworkToOutputPath=false causing net8.0 and net9.0 to write to the same output directory"
|
|
- "Identified LibraryA and LibraryB share ../SharedOutput/ as OutputPath causing build artifacts to overwrite each other"
|
|
- "Identified LibraryA and LibraryB share ../SharedObj/ as IntermediateOutputPath causing project.assets.json conflicts"
|
|
- "Suggested giving each project unique output and intermediate output paths"
|
|
- "Referenced BaseIntermediateOutputPath vs IntermediateOutputPath concepts"
|
|
timeout: 160
|