mirror of
https://github.com/dotnet/skills.git
synced 2026-09-20 09:49:54 +08:00
948a9a52ef
* Add exp-mock-usage-analysis skill and evaluation New experimental skill that detects unused, redundant, or unnecessary mocks in .NET test suites. Covers Moq, NSubstitute, FakeItEasy, and manual test doubles. - SKILL.md with 6-step workflow: gather code, classify mocks, detect anti-patterns, incorporate runtime data, generate recommendations, report findings - eval.yaml with 10 scenarios: trivial type mocking, unused setups, redundant configs, stable utility mocks, well-placed mocks (no false positives), NSubstitute support, FakeItEasy support, setup sprawl, and 2 non-activation boundary tests - Fixture files for each scenario with production + test code - CODEOWNERS entry for @dotnet/dotnet-testing * Remove no-headroom scenarios, increase NSubstitute timeout Remove 4 scenarios where baseline already scores 5.0/5 (model handles these well without skill guidance): - Detect mocking of DTOs, records, and enums - Recognize well-placed mocks without inventing false positives - Decline when asked about non-mock test anti-patterns - Decline mock framework migration request Increase NSubstitute scenario timeout from 120s to 180s to avoid baseline timeouts impacting scoring. Remaining 6 scenarios all show positive skill impact (3→5, 3→4, etc). * Document areas the model handles well without the skill Add a subsection under 'When Not to Use' listing mock-related tasks where the base model already scores 5.0/5 without skill guidance: - Mocking trivial types (DTOs, records, enums) - Recognizing well-placed mocks (no false positives) * Fix md * Improve
46 lines
1.2 KiB
C#
46 lines
1.2 KiB
C#
namespace Scheduling;
|
|
|
|
public interface ICalendarService
|
|
{
|
|
IReadOnlyList<TimeSlot> GetAvailableSlots(DateTime date);
|
|
bool BookSlot(string slotId, string attendeeEmail);
|
|
}
|
|
|
|
public interface IEmailService
|
|
{
|
|
void SendConfirmation(string to, string subject, string body);
|
|
}
|
|
|
|
public record TimeSlot(string Id, DateTime Start, DateTime End, bool IsAvailable);
|
|
|
|
public class AppointmentScheduler
|
|
{
|
|
private readonly ICalendarService _calendar;
|
|
private readonly IEmailService _email;
|
|
|
|
public AppointmentScheduler(ICalendarService calendar, IEmailService email)
|
|
{
|
|
_calendar = calendar;
|
|
_email = email;
|
|
}
|
|
|
|
public bool ScheduleAppointment(DateTime date, string attendeeEmail)
|
|
{
|
|
var slots = _calendar.GetAvailableSlots(date);
|
|
var firstAvailable = slots.FirstOrDefault(s => s.IsAvailable);
|
|
if (firstAvailable is null)
|
|
return false;
|
|
|
|
var booked = _calendar.BookSlot(firstAvailable.Id, attendeeEmail);
|
|
if (booked)
|
|
{
|
|
_email.SendConfirmation(
|
|
attendeeEmail,
|
|
"Appointment Confirmed",
|
|
$"Your appointment on {firstAvailable.Start:g} is confirmed.");
|
|
}
|
|
|
|
return booked;
|
|
}
|
|
}
|