Files
Amaury Levé 948a9a52ef Add exp-mock-usage-analysis skill and evaluation (#483)
* Add exp-mock-usage-analysis skill and evaluation

New experimental skill that detects unused, redundant, or unnecessary
mocks in .NET test suites. Covers Moq, NSubstitute, FakeItEasy, and
manual test doubles.

- SKILL.md with 6-step workflow: gather code, classify mocks, detect
  anti-patterns, incorporate runtime data, generate recommendations,
  report findings
- eval.yaml with 10 scenarios: trivial type mocking, unused setups,
  redundant configs, stable utility mocks, well-placed mocks (no false
  positives), NSubstitute support, FakeItEasy support, setup sprawl,
  and 2 non-activation boundary tests
- Fixture files for each scenario with production + test code
- CODEOWNERS entry for @dotnet/dotnet-testing

* Remove no-headroom scenarios, increase NSubstitute timeout

Remove 4 scenarios where baseline already scores 5.0/5 (model handles
these well without skill guidance):
- Detect mocking of DTOs, records, and enums
- Recognize well-placed mocks without inventing false positives
- Decline when asked about non-mock test anti-patterns
- Decline mock framework migration request

Increase NSubstitute scenario timeout from 120s to 180s to avoid
baseline timeouts impacting scoring.

Remaining 6 scenarios all show positive skill impact (3→5, 3→4, etc).

* Document areas the model handles well without the skill

Add a subsection under 'When Not to Use' listing mock-related tasks
where the base model already scores 5.0/5 without skill guidance:
- Mocking trivial types (DTOs, records, enums)
- Recognizing well-placed mocks (no false positives)

* Fix md

* Improve
2026-04-02 10:03:17 +00:00

50 lines
1.6 KiB
C#

namespace Shipping;
public interface IShippingProvider
{
decimal CalculateRate(string origin, string destination, decimal weightKg);
string CreateShipment(string orderId, string origin, string destination);
TrackingInfo GetTracking(string shipmentId);
}
public interface IAddressValidator
{
bool IsValid(string address);
string Normalize(string address);
}
public record TrackingInfo(string ShipmentId, string Status, DateTime? EstimatedDelivery);
public record ShippingRequest(string OrderId, string Origin, string Destination, decimal WeightKg);
public class ShippingService
{
private readonly IShippingProvider _provider;
private readonly IAddressValidator _validator;
public ShippingService(IShippingProvider provider, IAddressValidator validator)
{
_provider = provider;
_validator = validator;
}
public decimal GetQuote(ShippingRequest request)
{
if (!_validator.IsValid(request.Origin) || !_validator.IsValid(request.Destination))
throw new ArgumentException("Invalid address");
var normalizedOrigin = _validator.Normalize(request.Origin);
var normalizedDest = _validator.Normalize(request.Destination);
return _provider.CalculateRate(normalizedOrigin, normalizedDest, request.WeightKg);
}
public string Ship(ShippingRequest request)
{
if (!_validator.IsValid(request.Destination))
throw new ArgumentException("Invalid destination");
return _provider.CreateShipment(request.OrderId, request.Origin, request.Destination);
}
}