mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
Claude
ce3084700c
The release-PR workflow's pre-commit hook ran the full test suite and
failed because @tanstack/virtual-core 3.13.18 has a latent bug — its
scrollToIndex schedules a nested rAF that calls
`this.targetWindow.requestAnimationFrame(verify)` with no null-check.
The virtualizer's cleanup nulls `targetWindow` on React unmount, so the
queued rAF fires post-unmount and throws. All 1170 tests passed, but
vitest exited non-zero from the unhandled error.
Wrap rAF on both globalThis and window (separate bindings in
vitest+jsdom; tanstack uses `targetWindow.rAF` which resolves to
`window.rAF`) so callbacks hitting this specific error are swallowed.
Also fix the lint-fix lefthook command — `[ -n "{staged_files}" ]`
broke on multi-file expansion ("[: <path>: unexpected operator")
because lefthook interpolates files as space-separated words, not a
quoted string. Use `set --` to put them in positional args.
65 lines
2.4 KiB
YAML
65 lines
2.4 KiB
YAML
output:
|
|
- meta
|
|
- summary
|
|
- success
|
|
- failure
|
|
- execution
|
|
- execution_out
|
|
- execution_info
|
|
- skips
|
|
|
|
pre-commit:
|
|
parallel: true
|
|
commands:
|
|
check-binaries:
|
|
tags: binaries
|
|
run: bash scripts/hooks/check-binaries.sh
|
|
sync-lockfile:
|
|
tags: lockfile
|
|
glob: "{packages,examples,showcase/scripts}/**/package.json"
|
|
run: pnpm i --lockfile-only
|
|
stage_fixed: true
|
|
lint-fix:
|
|
tags: lint
|
|
# Scope oxlint and oxfmt to just the files staged for commit — running
|
|
# `--fix .` / `--write .` across the whole monorepo on every commit is
|
|
# both slow and blurs the hook's purpose (touch files that aren't part
|
|
# of this change). Guard against empty `{staged_files}` expansion: when
|
|
# a commit touches only non-matching files (markdown, YAML), lefthook
|
|
# still invokes this hook with an empty expansion, and oxlint/oxfmt
|
|
# would default to operating on the current directory, defeating the
|
|
# scoping entirely. stage_fixed re-stages whatever the hooks modify.
|
|
glob: "*.{js,jsx,ts,tsx,mjs,cjs,json,jsonc,json5,md,css,yml,yaml,html,vue,py}"
|
|
# Mirror the ignorePatterns in .oxlintrc.json / .oxfmtrc.json at the
|
|
# hook layer. Without this, a docs-only commit expands {staged_files}
|
|
# to a single docs/** path; oxlint silently processes 0 files, then
|
|
# oxfmt exits 2 with "Expected at least one target file" and blocks
|
|
# the commit.
|
|
exclude:
|
|
- "docs/**"
|
|
# Use `set --` so the staged files become positional args; this is the
|
|
# only shell-portable way to test "are there any" without breaking on
|
|
# multi-file expansion. The old `[ -n "{staged_files}" ]` form failed
|
|
# with `sh: 1: [: <path>: unexpected operator` because lefthook
|
|
# interpolates the file list as space-separated words, not a single
|
|
# quoted string, so [ saw 3+ args and tried to parse a binary op.
|
|
run: |
|
|
set -- {staged_files}
|
|
if [ "$#" -gt 0 ]; then
|
|
pnpm exec oxlint --fix "$@" &&
|
|
pnpm exec oxfmt --write "$@" ;
|
|
ruff format "$@" 2>/dev/null || true
|
|
fi
|
|
stage_fixed: true
|
|
test-and-check-packages:
|
|
tags: test-packages
|
|
env:
|
|
NX_TUI: "false"
|
|
run: pnpm run test && pnpm run check:packages
|
|
|
|
commit-msg:
|
|
commands:
|
|
commitlint:
|
|
tags: commitlint
|
|
run: pnpm commitlint --edit {1}
|