mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
lukasmoschitz
5195118345
## Why `showcase/scripts/validate-parity.ts` keys spec and QA filenames to the demo id. Seven integrations still carried the pre-rename `byoc-*` names for the hashbrown / json-render demos, so the validator emitted spurious `demo 'declarative-hashbrown' has no qa/declarative-hashbrown.md` style warnings. **454 → 446 warnings, still 21/21 pass.** ## What changed **QA docs (14 files, all 7 integrations)** — renamed `qa/byoc-*.md` → `qa/declarative-*.md` and reconciled against the `langgraph-python` north star. Test Steps and Expected Results are now identical per demo across every integration; genuinely per-integration facts (agent mount path, env var, prompt module, preserved regression guards) live in an `Integration notes` section. Every fact was verified against source — pill labels, `data-testid`s, header text, package pins, API route → `AGENT_URL` mappings — rather than carried over from the old doc. **E2E specs (10 files, 5 integrations) — deleted, not renamed.** Those integrations already ship `declarative-hashbrown.spec.ts` / `declarative-json-render.spec.ts` byte-identical to the north star (md5 `57eee13d…` / `638e2ac4…`). The `byoc-*` copies point at `/demos/byoc-*` routes that no longer exist and assert little beyond "page loads", so renaming them would have clobbered the good specs. Spec counts stay above demo count in all five packages, so no under-coverage warning appears. Python backend modules keep their `byoc_` prefix (`byoc_hashbrown_agent.py`, `byoc_json_render_agent.py`) — the north star uses those names too and integration `manifest.yaml` files reference them under `highlight:`. `claude-sdk-python` is deliberately untouched (handled in OSS-578 / #6235). ## Found along the way, NOT fixed here 1. **`declarative-json-render` is broken in both crewai packages.** The demo page (a north-star copy) mounts `runtimeUrl="/api/copilotkit-declarative-json-render"`, but those packages only ship `src/app/api/copilotkit-byoc-json-render/route.ts`, and `next.config.ts` has no covering rewrite — the runtime URL 404s. The rename was only half applied: page renamed, API route not. Documented as a known break in the affected QA docs; fixing it is a runtime change, so it wants its own PR. 2. **`langgraph-python/qa/declarative-json-render.md` still has the stale title** `# QA: BYOC json-render — LangGraph (Python)`. Left alone so as not to collide with #6235. Minor, also left as-is: `crewai-*/src/app/demos/byoc-hashbrown/page.tsx` are one-line alias re-exports of the declarative page, and the `crewai-*` / `llamaindex` manifests still list `byoc-hashbrown` / `byoc-json-render` under `features:` (a separate id namespace the validator does not read). ## Verification ``` cd showcase/scripts && npx tsx validate-parity.ts # 21 package(s) checked, 21 pass, 0 fail, 446 warning(s) ``` Diff of validator output before/after shows exactly the 8 target warnings removed and nothing new. `showcase/scripts` suite: 78 files / 2539 tests pass. No dangling references to the deleted paths anywhere in `showcase/` or `.github/`.