mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
edf10769ac
Comprehensive CI/CD security hardening pass over all 33 workflows. Action pinning - Every `uses:` is now pinned to a 40-char commit SHA with a `# vX.Y.Z` comment alongside (167 occurrences resolved). Tag-style refs like `@v4` are mutable and have been used in past supply-chain attacks (e.g. tj-actions/changed-files in March 2025) to repoint widely-used actions to malicious commits. - Removed redundant `version: "10.13.1"` hardcodes from `pnpm/action-setup` call sites so the action inherits from package.json `packageManager` (one source of truth). Automated maintenance - Added `.github/dependabot.yml` for the `github-actions` ecosystem so SHA pins stay current. Without this, pins go stale fast and new upstream advisories never reach us. Minor/patch bumps are grouped; major bumps stay separate so they get a real review. Static analysis - Added `.github/zizmor.yml` configuration and `.github/workflows/security_zizmor.yml` (blocking on PR, runs on push to main, weekly schedule for advisory drift). zizmor catches the well-known classes of Actions footguns: template injection from untrusted input, dangerous triggers, unpinned uses, excessive token scopes, secret exfil patterns. - All 28 high-severity and 54 medium-severity findings from the baseline scan are remediated. Each suppression in zizmor.yml carries a per-finding justification comment so future maintainers can audit the trust assumption. Workflow hardening (from zizmor + manual audit) - Added `persist-credentials: false` to every `actions/checkout` except the 7 workflows that legitimately push back to the repo via the workflow token (release tagging, auto-formatting, docs-sync, registry updates). Each retained credential persistence carries a `persist-credentials required: ...` comment explaining the call site. - Routed every attacker-controllable expansion (`github.head_ref`, `github.event.pull_request.head.repo.full_name`, `inputs.*`, step outputs) through `env:` and referenced as quoted shell variables. Eliminates 17 template-injection vectors in fork-PR-reachable workflows. - Added per-job `permissions:` blocks across 14 workflows; demoted broad workflow-level `id-token: write` to the specific Depot-runner jobs that need it; narrowed `pull-requests: write` / `actions: write` to the jobs that actually call those APIs. Audit-driven fixes - `publish-release.yml` build job: dropped `token:` and added `persist-credentials: false`. The subsequent `Upload workspace` step was packing `.git/config` (with the persisted GITHUB_TOKEN) into a 1-day-retention artifact downloadable by anyone with `actions:read`. - `auto_merge_showcases.yml`: team-membership check now authorizes on the PR AUTHOR (`pull_request.user.login`), never `context.actor` — the actor is whoever triggered the latest event, so a team member synchronizing or reopening an outsider's PR would otherwise green-light auto-merge of code they didn't author. - `static_quality.yml`: pinned ruff to a specific version so a compromised release can't land on the next PR run with the persisted-credentials write token in the format job. - `showcase_capture-previews.yml`: switched the args-string construction to a bash array so a slug or demo value containing whitespace or shell metacharacters stays a single argument rather than being re-tokenized by the shell.
105 lines
3.4 KiB
YAML
105 lines
3.4 KiB
YAML
name: static / check binaries
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
check-config-files:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
|
with:
|
|
persist-credentials: false
|
|
|
|
- name: Check build config allowlist
|
|
run: bash .github/scripts/check-config-allowlist.sh
|
|
|
|
check-binaries:
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
|
with:
|
|
fetch-depth: 0
|
|
persist-credentials: false
|
|
|
|
- name: Check for binary and build artifacts
|
|
env:
|
|
BASE_REF: ${{ github.event.pull_request.base.ref }}
|
|
run: |
|
|
VIOLATIONS=0
|
|
|
|
# Get list of added/modified files in the PR
|
|
CHANGED_FILES=$(git diff --name-only "origin/${BASE_REF}...HEAD")
|
|
|
|
if [ -z "$CHANGED_FILES" ]; then
|
|
echo "No changed files detected."
|
|
exit 0
|
|
fi
|
|
|
|
# Check for binary file extensions
|
|
BINARY_FILES=$(echo "$CHANGED_FILES" | grep -iE '\.(exe|dll|so|dylib|o|obj|a|lib|wasm)$' || true)
|
|
if [ -n "$BINARY_FILES" ]; then
|
|
echo "::error::Binary files detected in PR:"
|
|
echo "$BINARY_FILES"
|
|
VIOLATIONS=1
|
|
fi
|
|
|
|
# Check for build directories
|
|
BUILD_FILES=$(echo "$CHANGED_FILES" | grep -E '/build/' || true)
|
|
if [ -n "$BUILD_FILES" ]; then
|
|
echo "::error::Files in build directories detected in PR:"
|
|
echo "$BUILD_FILES"
|
|
VIOLATIONS=1
|
|
fi
|
|
|
|
# Check for dSYM directories
|
|
DSYM_FILES=$(echo "$CHANGED_FILES" | grep -E '\.dSYM/' || true)
|
|
if [ -n "$DSYM_FILES" ]; then
|
|
echo "::error::dSYM debug symbol directories detected in PR:"
|
|
echo "$DSYM_FILES"
|
|
VIOLATIONS=1
|
|
fi
|
|
|
|
# Check for large files (>1MB) among changed files
|
|
# Exclude known large files: lockfiles, assets, docs media, bundled actions
|
|
LARGE_FILES=""
|
|
while IFS= read -r file; do
|
|
if [ -f "$file" ]; then
|
|
case "$file" in
|
|
pnpm-lock.yaml|*/pnpm-lock.yaml|*/package-lock.json|*/poetry.lock) continue ;;
|
|
assets/*|docs/public/*|examples/*/preview.gif|examples/*/assets/*) continue ;;
|
|
.github/actions/*/dist/*) continue ;;
|
|
showcase/shell/src/data/*|showcase/shell-docs/src/data/*|showcase/shell-dojo/src/data/demo-content.json) continue ;;
|
|
esac
|
|
SIZE=$(wc -c < "$file" | tr -d ' ')
|
|
if [ "$SIZE" -gt 1048576 ]; then
|
|
LARGE_FILES="${LARGE_FILES}${file} ($(( SIZE / 1024 )) KB)\n"
|
|
fi
|
|
fi
|
|
done <<< "$CHANGED_FILES"
|
|
|
|
if [ -n "$LARGE_FILES" ]; then
|
|
echo "::error::Files over 1 MB detected in PR:"
|
|
echo -e "$LARGE_FILES"
|
|
VIOLATIONS=1
|
|
fi
|
|
|
|
if [ "$VIOLATIONS" -eq 1 ]; then
|
|
echo ""
|
|
echo "This PR contains binary artifacts, build outputs, or oversized files."
|
|
echo "Please remove them and update your .gitignore if needed."
|
|
exit 1
|
|
fi
|
|
|
|
echo "No binary artifacts or oversized files detected."
|