Files
copilotkit__copilotkit/examples/slack/app/managed.test.ts
Ben Taylor 8a8e52d9e9 fix(runtime): non-optional listener.channels and honest lifecycle docs (OSS-646) (#6207)
Closes OSS-646. Split out of OSS-641 as the unambiguous half. This PR
does **not** change when activation happens — whether the long-running
wrappers should auto-connect stays open on OSS-641.

## Why

`createCopilotRuntimeHandler` builds the `ChannelManager` but opens no
connection; activation is lazy, triggered by the first
`channels.ready()`. That is deliberate (`fbf35ac59`, OSS-473) —
Cloudflare/Next isolates freeze and recycle per request, so cold starts
would mint conflicting listeners. Two things were left inconsistent with
it:

1. `endpoints/node.ts` still documented the pre-`fbf35ac59` world — "the
same `ChannelsControl` surface the underlying fetch handler **activates
at creation time**" — and labelled the one required call as `//
Optional:`. That's the TSDoc developers and coding agents see in-editor,
and it contradicted every channel-package README. Same failure class as
OSS-634.
2. `68349bc1f` gave the fetch handler a branded overload so
`handler.channels.ready()` type-checks without `?.`, but the node
wrapper never got it — so every call site, including our own example and
all nine showcase docs pages, was written defensively.

### A live consequence, found en route

`examples/slack/app/managed.ts` never called `ready()`. It built the
runtime, mounted the listener, logged `[channel] started managed Channel
"…"`, and only ever called `stop()` — so since activation went lazy it
has connected nothing while reporting success. It was written against
exactly the creation-time model the TSDoc described. Fixed here, with a
regression assertion.

## What changed

- **Types** — `createCopilotNodeListener` gets the branded overload pair
mirroring `createCopilotRuntimeHandler`: a runtime with at least one
declared Channel yields non-optional `.channels`; `activateChannels:
false` and channel-less runtimes keep the optional shape. Adds
`NodeCopilotListenerWithChannels`; both listener types are now exported
from `@copilotkit/runtime/v2/node`.
- **Docs** — node/express/hono TSDoc corrected: creation opens no
connection, `ready()` is what activates, and it is required on a
long-running host. Same stale claim fixed in the three example comments
and `examples/slack/README.md` that repeated it.
- **Call sites** — `?.` dropped from `examples/slack`, `examples/teams`,
both READMEs, and the nine `showcase/shell-docs` channel pages.

## Deliberate scope choices, called out

- **Express/Hono keep an optional `.channels`.** Only their TSDoc is
corrected here. Their own type docs name Node as the lifecycle-owning
surface and attach `.channels` best-effort, so the branded overload is
Node-only for now; `endpoints-channels.test.ts` still uses `!` for those
two. Say the word if the overload should extend to them.
- **The non-optional shape requires a literal `channels` tuple**
(`readonly [Channel, ...Channel[]]`). A runtime built from a
dynamically-assembled `Channel[]` is unbranded and still needs `?.`. Now
stated in the node TSDoc.
- **`examples/slack/app/managed.ts` now exits nonzero if activation
fails**, where before it stayed up serving HTTP with nothing connected.
Intentional — fail loud, and it matches `index.ts`. Note that `ready()`
resolves for `setup_required`, so a declared-but-unprovisioned channel
still logs as started.
- **Signal handlers are registered before awaiting activation** in
`managed.ts`, so a Ctrl-C inside the 30s activation window still tears
the Channel down instead of hitting Node's default handler.

## Verification

- **Type contract, red → green:** the new `KeyIsRequired<typeof
listener, "channels">` assertion in `handler-channels-types.test.ts`
failed to compile before the overload (`error TS2344: Type 'false' does
not satisfy the constraint 'true'`) and passes after.
- **Example bug, red → green:** stashing only `managed.ts` fails the new
guard with `expected "vi.fn()" to be called once, but got 0 times`.
- **Strict-null proof:** `slack-example` and `teams-example` both `tsc
--noEmit` clean under `strict: true` with the `?.` removed. This matters
because the runtime package compiles with `strict: false`, so its own
type test can only probe the optionality modifier structurally.
- Runtime channel suites 54/54; slack example 63/63.
- **Coverage limit:** the `managed.ts` guard is mocked — it proves the
example *calls* `ready()` with a bound, not that a Channel connects.
Nothing in CI exercises a real gateway connect for these examples.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
2026-07-28 14:11:53 -05:00

134 lines
5.0 KiB
TypeScript

import { afterEach, describe, expect, it, vi } from "vitest";
const fakes = vi.hoisted(() => {
const stop = vi.fn(async () => {
throw new Error("stop failed");
});
const ready = vi.fn(async () => {});
// The Node listener is a callable object carrying `.channels` (the activation
// + shutdown surface), mirroring the real `createCopilotNodeListener` return.
const listener = Object.assign(vi.fn(), { channels: { ready, stop } });
return {
ready,
stop,
listener,
closeBrowser: vi.fn(async () => {}),
createCopilotNodeListener: vi.fn(() => listener),
// Captures the options `new CopilotRuntime(...)` was constructed with so
// the test can assert the runtime carries `channels`.
runtimeOptions: undefined as unknown,
CopilotRuntime: vi.fn(function CopilotRuntime(options: unknown) {
fakes.runtimeOptions = options;
}),
CopilotKitIntelligence: vi.fn(function CopilotKitIntelligence() {}),
createServer: vi.fn(() => ({
listen: (_port: number, cb?: () => void) => {
cb?.();
return { close: vi.fn() };
},
})),
bot: {
onMention: vi.fn(),
onModalSubmit: vi.fn(),
onThreadStarted: vi.fn(),
},
};
});
vi.mock("node:http", () => ({ createServer: fakes.createServer }));
vi.mock("@copilotkit/channels", () => ({
createChannel: vi.fn(() => fakes.bot),
}));
vi.mock("@copilotkit/channels/slack", () => ({
defaultSlackTools: [],
defaultSlackContext: [],
SanitizingHttpAgent: function SanitizingHttpAgent() {},
}));
vi.mock("@copilotkit/runtime/v2", () => ({
CopilotRuntime: fakes.CopilotRuntime,
CopilotKitIntelligence: fakes.CopilotKitIntelligence,
}));
vi.mock("@copilotkit/runtime/v2/node", () => ({
createCopilotNodeListener: fakes.createCopilotNodeListener,
}));
vi.mock("./tools/index.js", () => ({ appTools: [] }));
vi.mock("./context/app-context.js", () => ({ appContext: [] }));
vi.mock("./commands/index.js", () => ({ appCommands: [] }));
vi.mock("./sender-context.js", () => ({ senderContext: vi.fn() }));
vi.mock("./modals/file-issue.js", () => ({
fileIssueSubmit: vi.fn(),
FILE_ISSUE_CALLBACK: "file-issue",
}));
vi.mock("./render/browser.js", () => ({ closeBrowser: fakes.closeBrowser }));
const envKeys = [
"AGENT_URL",
"COPILOTKIT_INTELLIGENCE_URL",
"COPILOTKIT_INTELLIGENCE_WS_URL",
"COPILOTKIT_API_KEY",
] as const;
describe("managed channel entrypoint", () => {
const previousEnv = new Map<string, string | undefined>();
afterEach(() => {
vi.restoreAllMocks();
for (const key of envKeys) {
const value = previousEnv.get(key);
if (value === undefined) delete process.env[key];
else process.env[key] = value;
}
previousEnv.clear();
});
it("mounts the normal handler over a channels-carrying runtime and stops channels on shutdown", async () => {
for (const key of envKeys) previousEnv.set(key, process.env[key]);
process.env.AGENT_URL = "http://agent.test/run";
// Overrides the managed-platform defaults to point at a local stack. Both
// are set together, and deliberately at a different host+port: the realtime
// plane is deployed separately, so there is no derive from apiUrl.
process.env.COPILOTKIT_INTELLIGENCE_URL = "http://localhost:4201";
process.env.COPILOTKIT_INTELLIGENCE_WS_URL = "ws://localhost:4401";
process.env.COPILOTKIT_API_KEY = "cpk-test";
let sigterm: (() => void) | undefined;
vi.spyOn(process, "on").mockImplementation(((event, listener) => {
if (event === "SIGTERM") sigterm = listener as () => void;
return process;
}) as typeof process.on);
const exit = vi
.spyOn(process, "exit")
.mockImplementation((() => undefined as never) as typeof process.exit);
vi.spyOn(console, "log").mockImplementation(() => {});
vi.spyOn(console, "error").mockImplementation(() => {});
await import("./managed.js");
await vi.waitFor(() => expect(sigterm).toBeTypeOf("function"));
// The listener is created from the NORMAL runtime handler — no realtime
// gateway launcher is involved.
expect(fakes.createCopilotNodeListener).toHaveBeenCalledWith(
expect.objectContaining({ basePath: "/api/copilotkit" }),
);
// The runtime carries the Channel in `channels`.
expect(fakes.CopilotRuntime).toHaveBeenCalledOnce();
expect(fakes.runtimeOptions).toEqual(
expect.objectContaining({ channels: [fakes.bot] }),
);
// Activation is what connects the Channel to the Realtime Gateway, and
// mounting the listener does not do it. Regression guard: this example
// shipped without the call and so connected nothing (OSS-646).
expect(fakes.ready).toHaveBeenCalledOnce();
expect(fakes.ready).toHaveBeenCalledWith({ timeoutMs: 30_000 });
// Shutdown stops the managed Channel via listener.channels.stop().
sigterm!();
await vi.waitFor(() => expect(exit).toHaveBeenCalled());
expect(fakes.stop).toHaveBeenCalledOnce();
expect(fakes.closeBrowser).toHaveBeenCalledOnce();
// stop() threw, so shutdown exits nonzero.
expect(exit).toHaveBeenCalledWith(1);
});
});