mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
59eb245a1c
The specs and QA markdowns had drifted from the demos they describe.
This commit brings every test contract into line with the actual demo
source — eliminating false-greens, false-fails, and stale assertions.
False-fail spec assertions (would fail every run):
- `agentic-chat.spec.ts` — rewrote from the old `change_background` /
`weather-card` / `useAgentContext` flow that no longer exists. New
spec exercises the vanilla `<CopilotChat>` + three suggestion pills
contract the simplified demo actually exposes.
- `gen-ui-tool-based.spec.ts` — asserted on UI text ("Use the sidebar
to generate charts", "Chart Generator") that doesn't exist; switched
to suggestion-pill assertions and scoped the SVG check to inside the
assistant-message bubble (was matching CopilotChat's send-button
SVG).
- `agent-config.spec.ts` — asserted heading "Agent Config Object" but
the demo has "Agent Config".
- `multimodal.spec.ts` — asserted a non-existent "Multimodal
attachments" heading; switched to the `multimodal-demo-root` testid.
- `chat-slots.spec.ts` — asserted `[data-testid="custom-assistant-
message"]` and the bare text "slot" — neither exists. The actual
signal is `data-slot-label="MessageView.AssistantMessage"` from the
SlotMarker wrapper.
- `reasoning-default.spec.ts` — asserted `[data-testid="copilot-
reasoning-message"]` and `[data-message-role="reasoning"]`; neither
is emitted by `CopilotChatReasoningMessage`. Switched to the text-
based "Thinking…/Thought for…" header label.
False-green spec assertions (passed for the wrong reason):
- `shared-state-read.spec.ts` — was a complete false-green: asserted
on "Sales Pipeline", "Total Pipeline", "Active Deals" but the demo
has been a Recipe Editor for some time. Rewrote against the
recipe-card / ingredients-container / instructions-container testids.
- 11 specs (agent-config, beautiful-chat, frontend-tools-async,
gen-ui-tool-based, gen-ui-agent, gen-ui-interrupt, hitl-in-chat,
hitl-in-app, multimodal, readonly-state-agent-context, voice) used
`[data-role="assistant"]` to gate "agent responded" — but the v2
react-core bundle never emits that attribute (it ships
`data-testid="copilot-assistant-message"`). Mechanical sweep to the
correct testid.
- Deleted `shared-state-write.spec.ts` (route consolidated into
`shared-state-read-write` earlier on this branch — spec targeted a
removed demo) and `renderer-selector.spec.ts` (asserted on a radio-
pill UI that no longer exists; the four "Declarative UI" variants
are now separate manifest demos).
QA drift:
- `qa/gen-ui-tool-based.md` documented a "Haiku Generator" demo with
haiku-card / japanese-line / english-line / haiku-image testids — a
demo that doesn't exist anywhere on this branch. Rewrote to match
the chart-rendering demo's actual testids and pill prompts.
- `qa/chat-slots.md` referenced "Custom Slot" pill / "Welcome to the
Slots demo" heading / "This welcome card is rendered via the
welcomeScreen slot." body text — all of which the slot-wrappers
refactor on this branch removed. Updated to match the
`custom-welcome-message` sub-slot that's actually rendered. Also
fixed max-w-4xl → max-w-5xl to match the page.
- `qa/shared-state-read.md` said default instruction is "Preheat oven
to 350 F" but the source has "Preheat oven to 350°F (175°C)".
- `qa/agentic-chat.md` rewrote to match the simplified vanilla-chat
demo (the previous QA documented `change_background` / `WeatherCard`
flows that no longer exist).
- `qa/reasoning-default.md` cited `kind: "testing"` in feature-
registry.json for the `reasoning-default` entry; the registry entry
has no `kind` field. Rewrote without the false cross-file claim.
- Deleted 4 orphan QA files for demos that don't exist:
`agentic-chat-reasoning.md`, `hitl.md`, `hitl-in-chat-booking.md`,
`shared-state-write.md`.
- Renamed `qa/reasoning-default-render.md` → `qa/reasoning-default.md`
to match the manifest cell name.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
77 lines
2.6 KiB
TypeScript
77 lines
2.6 KiB
TypeScript
import { test, expect } from "@playwright/test";
|
|
|
|
/**
|
|
* E2E spec for the Declarative UI: json-render demo. Structurally
|
|
* mirrors `gen-ui-tool-based.spec.ts` so the dashboard's BYOC rows
|
|
* exercise the same surfaces (json-render-root + metric-card + chart).
|
|
*/
|
|
test.describe("Declarative UI: json-render", () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.goto("/demos/declarative-json-render");
|
|
});
|
|
|
|
test("page loads with chat composer and suggestion pills", async ({
|
|
page,
|
|
}) => {
|
|
// Chat composer
|
|
await expect(
|
|
page.locator('textarea, [placeholder*="message"]').first(),
|
|
).toBeVisible({ timeout: 10000 });
|
|
|
|
// Suggestion pills driven by useConfigureSuggestions. The
|
|
// CopilotChat welcome screen renders titles as buttons/links.
|
|
await expect(page.getByText("Sales dashboard")).toBeVisible({
|
|
timeout: 10000,
|
|
});
|
|
await expect(page.getByText("Revenue by category")).toBeVisible();
|
|
await expect(page.getByText("Expense trend")).toBeVisible();
|
|
});
|
|
|
|
test("sales dashboard request renders a json-render tree", async ({
|
|
page,
|
|
}) => {
|
|
const input = page.locator('textarea, [placeholder*="message"]').first();
|
|
await input.fill(
|
|
"Show me the sales dashboard with metrics and a revenue chart",
|
|
);
|
|
await input.press("Enter");
|
|
|
|
// The JsonRenderAssistantMessage slot wraps renders in this testid.
|
|
await expect(
|
|
page.locator('[data-testid="json-render-root"]').first(),
|
|
).toBeVisible({ timeout: 60000 });
|
|
|
|
// A MetricCard should appear in the rendered tree.
|
|
await expect(
|
|
page.locator('[data-testid="metric-card"]').first(),
|
|
).toBeVisible({ timeout: 60000 });
|
|
|
|
// ...plus at least one chart (either shape).
|
|
await expect(
|
|
page
|
|
.locator('[data-testid="bar-chart"], [data-testid="pie-chart"]')
|
|
.first(),
|
|
).toBeVisible({ timeout: 60000 });
|
|
});
|
|
|
|
test("revenue-by-category request renders a pie chart", async ({ page }) => {
|
|
const input = page.locator('textarea, [placeholder*="message"]').first();
|
|
await input.fill("Break down revenue by category as a pie chart");
|
|
await input.press("Enter");
|
|
|
|
await expect(page.locator('[data-testid="pie-chart"]').first()).toBeVisible(
|
|
{ timeout: 60000 },
|
|
);
|
|
});
|
|
|
|
test("expense-trend request renders a bar chart", async ({ page }) => {
|
|
const input = page.locator('textarea, [placeholder*="message"]').first();
|
|
await input.fill("Show me monthly expenses as a bar chart");
|
|
await input.press("Enter");
|
|
|
|
await expect(page.locator('[data-testid="bar-chart"]').first()).toBeVisible(
|
|
{ timeout: 60000 },
|
|
);
|
|
});
|
|
});
|