mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
Mark Fogle
c9dd12473b
Adds oxlint RuleTester cases for the lint rule introduced in #5025, per review feedback: valid two-arg forms don't false-positive (including a single-arg `.record()` on a non-`z` object), the single-arg form fires with correct autofix output (plain and chained `.optional()`), and a spread argument reports without a fix. Since the guarded bug is type-level, this rule is the real regression guard, so it warrants direct coverage. oxlint's RuleTester requires Node >= 22; the cases are gated to skip on older runtimes so the Node 20 CI job stays green (the rule itself is exercised on every Node via the oxlint job). Extends the react-ui vitest include to pick up co-located oxlint-rules tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
53 lines
2.1 KiB
JavaScript
53 lines
2.1 KiB
JavaScript
import { describe, it } from "vitest";
|
|
import { RuleTester } from "oxlint/plugins-dev";
|
|
import rule from "./no-single-arg-zod-record.mjs";
|
|
|
|
// oxlint's RuleTester relies on V8 APIs that only exist on Node >= 22, and
|
|
// throws at parse time on older runtimes. The CI unit matrix includes Node 20,
|
|
// so gate the RuleTester cases to supported runtimes. The lint rule itself is
|
|
// exercised on every Node version through `oxlint` in the lint job — this file
|
|
// only adds RuleTester-based unit coverage where the tester can run.
|
|
const ruleTesterSupported = Number(process.versions.node.split(".")[0]) >= 22;
|
|
|
|
if (ruleTesterSupported) {
|
|
RuleTester.describe = describe;
|
|
RuleTester.it = it;
|
|
|
|
const ruleTester = new RuleTester();
|
|
|
|
ruleTester.run("no-single-arg-zod-record", rule, {
|
|
valid: [
|
|
// Two-argument form is the correct, Zod 4-compatible shape.
|
|
"const s = z.record(z.string(), z.unknown());",
|
|
"const s = z.record(z.string(), z.number()).optional();",
|
|
// A single-argument `.record()` on something that isn't the `z` alias
|
|
// must not be flagged — this rule is scoped to Zod schemas.
|
|
"const m = cache.record(entry);",
|
|
],
|
|
invalid: [
|
|
// Single-argument form: fires and autofixes by inserting the key schema.
|
|
{
|
|
code: "const s = z.record(z.unknown());",
|
|
output: "const s = z.record(z.string(), z.unknown());",
|
|
errors: [{ messageId: "singleArgRecord" }],
|
|
},
|
|
// Chained `.optional()` still fixes the inner z.record call.
|
|
{
|
|
code: "const s = z.record(z.unknown()).optional();",
|
|
output: "const s = z.record(z.string(), z.unknown()).optional();",
|
|
errors: [{ messageId: "singleArgRecord" }],
|
|
},
|
|
// A spread argument cannot be safely rewritten — report without a fix.
|
|
{
|
|
code: "const s = z.record(...valueTypes);",
|
|
output: null,
|
|
errors: [{ messageId: "singleArgRecord" }],
|
|
},
|
|
],
|
|
});
|
|
} else {
|
|
describe("no-single-arg-zod-record", () => {
|
|
it.skip("oxlint RuleTester requires Node >= 22; skipped on this runtime", () => {});
|
|
});
|
|
}
|