mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
Jordan Ritter
f2a199b78c
serviceInstanceUpdate returns a Boolean scalar — the spec requires we confirm that boolean is true AND re-query serviceInstance to confirm BOTH source.image advanced to the new digest AND updatedAt strictly advanced past the pre-mutation value. Image-equality alone is insufficient: a no-op re-pin to the current value would otherwise appear green. Implementation: - PromoteCommand::SERVICE_INSTANCE_RECHECK_QUERY: minimal query adding updatedAt (kept separate from snapshot's SERVICE_INSTANCE_QUERY to avoid disturbing snapshot behavior). - PromoteCommand.pin_and_verify: pre-query updatedAt, run serviceInstanceUpdate, assert boolean true, run serviceInstanceRedeploy, then re-query up to RETRY_COUNT=3 times with RETRY_DELAY_SEC=10s apart. Each retry must observe BOTH gates green (image match AND updatedAt > pre_update_ts). Otherwise raises PromoteCommand::MutationError. - execute_promotion now calls pin_and_verify (instead of RestoreCommand.pin_and_redeploy) so promote inherits the verification. MutationError is caught and converted to exit 1. 5 new P5 tests: boolean=false refusal, happy-path success, image-advanced-but-ts-stale refusal, all-retries-stale refusal, and late-third-retry success.
100 lines
4.2 KiB
Ruby
100 lines
4.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "spec_helper"
|
|
|
|
class PromoteP5Test < Minitest::Test
|
|
class FakeGQL
|
|
def initialize(plan); @plan = plan; @calls = []; end
|
|
attr_reader :calls
|
|
|
|
def query(q, vars = {})
|
|
@calls << [q, vars]
|
|
step = @plan.shift
|
|
raise "fake exhausted at call ##{@calls.size}: #{q[0,40]}" unless step
|
|
raise step[:raise] if step[:raise]
|
|
step[:data] # inner data hash, matching GraphQL#query's return shape
|
|
end
|
|
end
|
|
|
|
# Helper: a "pre-update snapshot" GQL response with a given updatedAt.
|
|
def pre(ts) = { data: { "serviceInstance" => { "id" => "i", "source" => { "image" => "ghcr.io/copilotkit/x@sha256:OLD" }, "updatedAt" => ts } } }
|
|
|
|
# Helper: a "post-update re-query" response.
|
|
def post(image:, ts:) = { data: { "serviceInstance" => { "id" => "i", "source" => { "image" => image }, "updatedAt" => ts } } }
|
|
|
|
def test_refuses_when_update_returns_false
|
|
# Order: pre-update snapshot, then update (false) — refuse before redeploy.
|
|
gql = FakeGQL.new([
|
|
pre("2026-05-27T00:00:00Z"),
|
|
{ data: { "serviceInstanceUpdate" => false } },
|
|
])
|
|
assert_raises(Railway::PromoteCommand::MutationError) do
|
|
Railway::PromoteCommand.pin_and_verify(gql,
|
|
service_id: "s", env_id: "e", image: "ghcr.io/copilotkit/x@sha256:NEW",
|
|
sleeper: ->(_n) {})
|
|
end
|
|
end
|
|
|
|
def test_verifies_image_AND_updatedAt_advanced_after_update
|
|
gql = FakeGQL.new([
|
|
pre("2026-05-27T00:00:00Z"),
|
|
{ data: { "serviceInstanceUpdate" => true } },
|
|
{ data: { "serviceInstanceRedeploy" => true } },
|
|
post(image: "ghcr.io/copilotkit/x@sha256:NEW", ts: "2026-05-28T01:00:00Z"),
|
|
])
|
|
Railway::PromoteCommand.pin_and_verify(gql,
|
|
service_id: "s", env_id: "e", image: "ghcr.io/copilotkit/x@sha256:NEW",
|
|
sleeper: ->(_n) {})
|
|
assert_equal 4, gql.calls.size
|
|
end
|
|
|
|
def test_refuses_when_image_advanced_but_updatedAt_did_NOT_advance
|
|
# P5 guard for the no-op re-pin / cache-shaped race: image-equality
|
|
# alone is insufficient. updatedAt MUST strictly advance past
|
|
# pre_update_ts; if not, three retries then refuse.
|
|
pre_ts = "2026-05-27T00:00:00Z"
|
|
stale_ts_post = post(image: "ghcr.io/copilotkit/x@sha256:NEW", ts: pre_ts)
|
|
gql = FakeGQL.new([
|
|
pre(pre_ts),
|
|
{ data: { "serviceInstanceUpdate" => true } },
|
|
{ data: { "serviceInstanceRedeploy" => true } },
|
|
stale_ts_post, stale_ts_post, stale_ts_post,
|
|
])
|
|
assert_raises(Railway::PromoteCommand::MutationError) do
|
|
Railway::PromoteCommand.pin_and_verify(gql,
|
|
service_id: "s", env_id: "e", image: "ghcr.io/copilotkit/x@sha256:NEW",
|
|
sleeper: ->(_n) {})
|
|
end
|
|
end
|
|
|
|
def test_retries_then_refuses_on_stale_image
|
|
# Three re-queries all report stale image.
|
|
stale = post(image: "ghcr.io/copilotkit/x@sha256:OLD", ts: "2026-05-27T00:00:00Z")
|
|
gql = FakeGQL.new([
|
|
pre("2026-05-27T00:00:00Z"),
|
|
{ data: { "serviceInstanceUpdate" => true } },
|
|
{ data: { "serviceInstanceRedeploy" => true } },
|
|
stale, stale, stale,
|
|
])
|
|
assert_raises(Railway::PromoteCommand::MutationError) do
|
|
Railway::PromoteCommand.pin_and_verify(gql,
|
|
service_id: "s", env_id: "e", image: "ghcr.io/copilotkit/x@sha256:NEW",
|
|
sleeper: ->(_n) {})
|
|
end
|
|
end
|
|
|
|
def test_accepts_when_third_requery_shows_advance
|
|
new_ok = post(image: "ghcr.io/copilotkit/x@sha256:NEW", ts: "2026-05-28T02:00:00Z")
|
|
stale = post(image: "ghcr.io/copilotkit/x@sha256:OLD", ts: "2026-05-27T00:00:00Z")
|
|
gql = FakeGQL.new([
|
|
pre("2026-05-27T00:00:00Z"),
|
|
{ data: { "serviceInstanceUpdate" => true } },
|
|
{ data: { "serviceInstanceRedeploy" => true } },
|
|
stale, stale, new_ok,
|
|
])
|
|
Railway::PromoteCommand.pin_and_verify(gql,
|
|
service_id: "s", env_id: "e", image: "ghcr.io/copilotkit/x@sha256:NEW",
|
|
sleeper: ->(_n) {})
|
|
end
|
|
end
|