mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
Tyler Slaton
ef1ca9808c
Result of 10 parallel QA agents auditing all 30 active demos against
langgraph-python (north-star). Each agent ported drift back to LP-verbatim
across three axes:
1. Agent layer
- tool_rendering_common.py: rebuilt to LP's surface — get_weather,
search_flights(origin, destination), get_stock_price, roll_d20,
roll_dice. Removed the ADK-only query_data.
- tool_rendering_*_agent.py (4 variants): ported LP's travel/concierge
prompt; reasoning-chain variant got LP's chain-two-tools prompt.
- beautiful_chat_agent.py: ported LP's per-tool system prompt; added
manage_sales_todos / get_sales_todos / generate_a2ui; dropped the
redundant schedule_meeting (frontend HITL handles it).
- open_gen_ui_agents.py: ported LP's full SYSTEM_PROMPT for both
variants, including the Websandbox.connection.remote.* contract
for the advanced sandbox demo (was `window.sandbox.*`, which the
LP frontend's Websandbox bridge silently no-ops).
- byoc_agents.py: fused LP's hashbrown + json-render prompts so the
single ADK byoc_agent emits both wire shapes. Aliases exported for
a future per-route split.
- declarative_gen_ui_agent.py: ported LP's a2ui_dynamic SYSTEM_PROMPT.
- a2ui_fixed_agent.py: picked up LP's #4734 regression guard
("exactly ONCE", "do NOT call again").
- agent_config_agent.py: rewrote to read useAgentContext (was
state["config"]); reconciled schema to LP's 3-field camelCase
{tone, expertise, responseLength} with LP's value enums.
- subagents_agent.py: dropped the "running" placeholder; returns
plain str so the LP-verbatim frontend's `result?.trim()` works.
- hitl_in_app_agent.py / hitl_in_chat_book_call_agent.py: prompts +
tool-result shape ({approved, reason}) aligned to LP.
- AGUIToolset() added wherever it was missing on the bespoke agents
(multimodal, mcp_apps, a2ui_fixed) so frontend-registered tools
reach the model.
2. Dedicated runtime routes
- copilotkit-multimodal/route.ts (new) — mirrors LP shape with
ADK's HttpAgent + AGENT_URL pattern.
- copilotkit-agent-config/route.ts (new) — same pattern.
- copilotkit-mcp-apps/route.ts — refreshed.
3. Frontend ports (ADK frontend brought to LP-verbatim where it had
drifted from the parity blitz state)
- tool-rendering family (4 demos): full re-port — WeatherCard,
FlightListCard, StockCard, D20Card, ReasoningBlock, CatchallRenderer,
suggestions, and the page wiring with all useRenderTool /
useDefaultRenderTool / reasoningMessage registrations.
- a2ui-fixed-schema, mcp-apps, multimodal: full frontend re-ports
with their _components/ Tailwind primitives.
- frontend-tools, frontend-tools-async, agent-config: ported LP's
component structure (separate Background, NotesCard with query_notes,
config-context-relay).
- shared-state-read, shared-state-read-write, readonly-state-agent-context:
ported LP's demo-layout + _components + suggestions. recipe-card.tsx
pulled directly from LP (one QA agent had adapted to Unicode glyphs
thinking ADK lacked lucide-react — it doesn't, after the parity blitz).
- shared-state-streaming, subagents, hitl-in-app: ported LP's
DocumentView / supervisor-activity / TicketsPanel structure.
hitl-in-app/page.tsx pulled directly from LP to keep the hyphenated
agent slug aligned with the renamed registry key.
- auth, hitl-in-chat: ported LP's SignInCard-first auth UX and the
time-picker Tailwind port.
- prebuilt-popup: pulled LP's main-content + suggestions split.
4. Test fixtures
- 30 tests/e2e/<slug>.spec.ts ported from LP, several overwriting
stale stubs (shared-state-streaming, subagents, auth, hitl-in-chat,
shared-state-read, agent-config).
- 30 qa/<slug>.md ported from LP with ADK env-var and registry
references substituted (GOOGLE_API_KEY, AGENT_URL, registry.py).
- QA3's byoc-hashbrown / byoc-json-render specs renamed to
declarative-hashbrown / declarative-json-render with internal
URL references substituted (the orchestrator pass had already
renamed the demo dirs + manifest entries).
Frontend changes from QA agents were filtered: kept where they ported
LP-verbatim into ADK, replaced with direct LP pulls where the agent
had made ADK-specific adaptations (one Unicode-glyph case, one
stale-registry-slug case).
Not touched per blitz rules: shared_chat.py, registry.py, manifest.yaml,
src/app/api/copilotkit/route.ts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4.9 KiB
4.9 KiB
QA: In-App Human in the Loop — Google ADK
Prerequisites
- Demo is deployed and accessible at
/demos/hitl-in-appon the dashboard host - Agent backend is healthy (
/api/health);GOOGLE_API_KEYis set (orGOOGLE_GEMINI_BASE_URLpoints at the aimock proxy) - Note: Unlike the in-chat HITL demo, the approval UI here is an app-level modal portal'd to
document.bodyand is NOT a child of the chat transcript.
Test Steps
1. Basic Functionality
- Navigate to
/demos/hitl-in-app; verify the page renders within 3s with the "Support Inbox" panel filling the viewport and theCopilotPopupopen by default in the bottom-right corner - Verify the left header shows the eyebrow "Support Inbox", heading "Open tickets", and the instruction text mentioning "approval dialog here in the app — outside the chat"
- Verify exactly 3 ticket cards render with test ids
ticket-12345,ticket-12346,ticket-12347, each showing the customer name (Jordan Rivera / Priya Shah / Morgan Lee), subject line, and status pill ("Open" green, "Escalating" amber) - Verify ticket #12345 displays "Disputed amount: $50.00"
- Verify the
CopilotPopupchat input placeholder is visible (popup opens by default) and no approval dialog is rendered on initial load - Send "Hello" and verify the agent responds within 10s
2. Feature-Specific Checks
Suggestions
- Verify all 3 suggestion pills are visible with verbatim titles:
- "Approve refund for #12345"
- "Downgrade plan for #12346"
- "Escalate ticket #12347"
Approval Flow — Approve Path (useFrontendTool async handler)
- Click the "Approve refund for #12345" suggestion (or type the equivalent prompt)
- Within 15s verify an approval modal appears with
data-testid="approval-dialog-overlay"(fullscreen fixed backdrop withbackdrop-blur-sm) anddata-testid="approval-dialog"(centered card withrole="dialog"andaria-modal="true") - Verify the modal is rendered at the document root (portaled via
createPortal(content, document.body)) — confirm in DevTools thatapproval-dialog-overlayis a direct descendant of<body>, NOT nested inside theCopilotPopupcontainer - Verify the modal shows the eyebrow "Action requires your approval", a heading containing the action summary (with concrete numbers such as "$50" and "#12345"), and optional context block below
- Verify the textarea
data-testid="approval-dialog-reason"is present with placeholder "Add a short note the assistant will see…" - Type a short note (e.g. "Verified duplicate charge") into the reason textarea
- Click the
data-testid="approval-dialog-approve"button (labeled "Approve") - Verify the modal closes immediately and does NOT re-open
- Verify the agent resumes within 10s and replies in the chat with a one/two-sentence confirmation acknowledging the action is being processed (should reference the refund / #12345)
Approval Flow — Reject Path
- In a fresh conversation, click "Downgrade plan for #12346"
- Verify the approval modal re-opens (same testids as above) with a heading referencing Priya Shah / #12346 / Starter plan
- Type a rejection reason (e.g. "Customer must confirm in writing first")
- Click
data-testid="approval-dialog-reject"(labeled "Reject") - Verify the modal closes immediately
- Verify the agent's reply acknowledges the rejection in one or two sentences, reflects the rejection reason back, and does NOT claim the downgrade was performed
Empty-Reason Path
- Trigger the approval flow a third time via "Escalate ticket #12347"
- Leave the reason textarea empty and click Approve
- Verify the modal closes and the agent still proceeds with the action (reason is optional — omitted when empty)
Modal Is Outside the Chat (Contract Check)
- While the modal is open, verify the chat transcript inside the popup is still scrollable / visible and does NOT contain an inline copy of the approval UI
- Confirm that closing the modal via Approve/Reject is the only resolution path — there is no inline "approve" button rendered inside a chat bubble
3. Error Handling
- Send an empty message; verify it is a no-op (no user bubble, no assistant response)
- Trigger the approval flow and dismiss via Approve without touching the reason field — verify no console errors and the promise resolves
- Verify no uncaught console errors during any approve / reject cycle above
Expected Results
- Chat loads within 3 seconds; initial agent response within 10 seconds
- Approval modal appears within 15 seconds of the triggering prompt
- Modal is portaled to
<body>(NOT nested in the chat) and closes on Approve/Reject - Approve path: agent acknowledges and proceeds; Reject path: agent acknowledges and stops, reflecting the reason when provided
- No UI layout breaks, no uncaught console errors, no stuck-open modal