mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
ef1ca9808c
Result of 10 parallel QA agents auditing all 30 active demos against
langgraph-python (north-star). Each agent ported drift back to LP-verbatim
across three axes:
1. Agent layer
- tool_rendering_common.py: rebuilt to LP's surface — get_weather,
search_flights(origin, destination), get_stock_price, roll_d20,
roll_dice. Removed the ADK-only query_data.
- tool_rendering_*_agent.py (4 variants): ported LP's travel/concierge
prompt; reasoning-chain variant got LP's chain-two-tools prompt.
- beautiful_chat_agent.py: ported LP's per-tool system prompt; added
manage_sales_todos / get_sales_todos / generate_a2ui; dropped the
redundant schedule_meeting (frontend HITL handles it).
- open_gen_ui_agents.py: ported LP's full SYSTEM_PROMPT for both
variants, including the Websandbox.connection.remote.* contract
for the advanced sandbox demo (was `window.sandbox.*`, which the
LP frontend's Websandbox bridge silently no-ops).
- byoc_agents.py: fused LP's hashbrown + json-render prompts so the
single ADK byoc_agent emits both wire shapes. Aliases exported for
a future per-route split.
- declarative_gen_ui_agent.py: ported LP's a2ui_dynamic SYSTEM_PROMPT.
- a2ui_fixed_agent.py: picked up LP's #4734 regression guard
("exactly ONCE", "do NOT call again").
- agent_config_agent.py: rewrote to read useAgentContext (was
state["config"]); reconciled schema to LP's 3-field camelCase
{tone, expertise, responseLength} with LP's value enums.
- subagents_agent.py: dropped the "running" placeholder; returns
plain str so the LP-verbatim frontend's `result?.trim()` works.
- hitl_in_app_agent.py / hitl_in_chat_book_call_agent.py: prompts +
tool-result shape ({approved, reason}) aligned to LP.
- AGUIToolset() added wherever it was missing on the bespoke agents
(multimodal, mcp_apps, a2ui_fixed) so frontend-registered tools
reach the model.
2. Dedicated runtime routes
- copilotkit-multimodal/route.ts (new) — mirrors LP shape with
ADK's HttpAgent + AGENT_URL pattern.
- copilotkit-agent-config/route.ts (new) — same pattern.
- copilotkit-mcp-apps/route.ts — refreshed.
3. Frontend ports (ADK frontend brought to LP-verbatim where it had
drifted from the parity blitz state)
- tool-rendering family (4 demos): full re-port — WeatherCard,
FlightListCard, StockCard, D20Card, ReasoningBlock, CatchallRenderer,
suggestions, and the page wiring with all useRenderTool /
useDefaultRenderTool / reasoningMessage registrations.
- a2ui-fixed-schema, mcp-apps, multimodal: full frontend re-ports
with their _components/ Tailwind primitives.
- frontend-tools, frontend-tools-async, agent-config: ported LP's
component structure (separate Background, NotesCard with query_notes,
config-context-relay).
- shared-state-read, shared-state-read-write, readonly-state-agent-context:
ported LP's demo-layout + _components + suggestions. recipe-card.tsx
pulled directly from LP (one QA agent had adapted to Unicode glyphs
thinking ADK lacked lucide-react — it doesn't, after the parity blitz).
- shared-state-streaming, subagents, hitl-in-app: ported LP's
DocumentView / supervisor-activity / TicketsPanel structure.
hitl-in-app/page.tsx pulled directly from LP to keep the hyphenated
agent slug aligned with the renamed registry key.
- auth, hitl-in-chat: ported LP's SignInCard-first auth UX and the
time-picker Tailwind port.
- prebuilt-popup: pulled LP's main-content + suggestions split.
4. Test fixtures
- 30 tests/e2e/<slug>.spec.ts ported from LP, several overwriting
stale stubs (shared-state-streaming, subagents, auth, hitl-in-chat,
shared-state-read, agent-config).
- 30 qa/<slug>.md ported from LP with ADK env-var and registry
references substituted (GOOGLE_API_KEY, AGENT_URL, registry.py).
- QA3's byoc-hashbrown / byoc-json-render specs renamed to
declarative-hashbrown / declarative-json-render with internal
URL references substituted (the orchestrator pass had already
renamed the demo dirs + manifest entries).
Frontend changes from QA agents were filtered: kept where they ported
LP-verbatim into ADK, replaced with direct LP pulls where the agent
had made ADK-specific adaptations (one Unicode-glyph case, one
stale-registry-slug case).
Not touched per blitz rules: shared_chat.py, registry.py, manifest.yaml,
src/app/api/copilotkit/route.ts.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
79 lines
2.9 KiB
TypeScript
79 lines
2.9 KiB
TypeScript
import { test, expect } from "@playwright/test";
|
|
|
|
// Shared State (Read + Write) — Preferences + Scratch Pad demo. The page
|
|
// publishes `agent.state.preferences` via setState, and the agent writes
|
|
// back via its `set_notes` tool. All three pills must hit
|
|
// shared-state-specific fixtures rather than falling through to the bare
|
|
// "hi" / "plan" catch-alls in feature-parity.json.
|
|
test.describe("Shared State (Read + Write)", () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await page.goto("/demos/shared-state-read-write");
|
|
});
|
|
|
|
test("preferences panel and agent scratch pad both mount", async ({
|
|
page,
|
|
}) => {
|
|
await expect(page.getByText("Your preferences")).toBeVisible({
|
|
timeout: 15000,
|
|
});
|
|
await expect(page.getByText("Agent Scratch pad")).toBeVisible({
|
|
timeout: 15000,
|
|
});
|
|
});
|
|
|
|
test("starter suggestions render", async ({ page }) => {
|
|
for (const title of ["Greet me", "Remember something", "Plan a weekend"]) {
|
|
await expect(page.getByRole("button", { name: title })).toBeVisible({
|
|
timeout: 15000,
|
|
});
|
|
}
|
|
});
|
|
|
|
// Regression for the wrong-fixture-fallthrough bug:
|
|
// The Greet me pill ("Say hi and introduce yourself.") was matching
|
|
// feature-parity.json's bare `userMessage: "hi"` fixture and replying
|
|
// with the generic showcase-assistant blurb ("Hi there! I'm your
|
|
// showcase assistant. I can help with weather, charts, meetings…").
|
|
// Likewise, Plan a weekend ("Suggest a weekend plan based on my
|
|
// interests.") was matching the bare `userMessage: "plan"` fixture and
|
|
// replying with a generic 5-step content-marketing plan. Fix: add
|
|
// d5-all.json fixtures with longer substring matchers that win first.
|
|
test("Greet me pill returns a shared-state-aware greeting, not the generic showcase blurb", async ({
|
|
page,
|
|
}) => {
|
|
test.setTimeout(120_000);
|
|
|
|
await page.getByRole("button", { name: /^Greet me$/i }).click();
|
|
|
|
const assistantMessage = page
|
|
.locator('[data-testid="copilot-assistant-message"]')
|
|
.last();
|
|
await expect(assistantMessage).toContainText(/shared-state co-pilot/i, {
|
|
timeout: 60_000,
|
|
});
|
|
// Negative assertion: the wrong-fixture response is gone.
|
|
await expect(assistantMessage).not.toContainText(
|
|
/showcase assistant\. I can help with weather, charts/i,
|
|
);
|
|
});
|
|
|
|
test("Plan a weekend pill returns an interests-aware plan, not the generic content-marketing plan", async ({
|
|
page,
|
|
}) => {
|
|
test.setTimeout(120_000);
|
|
|
|
await page.getByRole("button", { name: /^Plan a weekend$/i }).click();
|
|
|
|
const assistantMessage = page
|
|
.locator('[data-testid="copilot-assistant-message"]')
|
|
.last();
|
|
await expect(assistantMessage).toContainText(/interests panel/i, {
|
|
timeout: 60_000,
|
|
});
|
|
// Negative assertion: the wrong-fixture response is gone.
|
|
await expect(assistantMessage).not.toContainText(
|
|
/Research the topic.*Outline key points/is,
|
|
);
|
|
});
|
|
});
|