mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
3f5eba4999
Nine correctness fixes to bin/railway PromoteCommand, each red-green tested. - P2 in-flight race-check now compares deployed digest against the digest captured in @promote_refs (P1-resolved), not svc["digest"] which is nil for tag-form staging — the check was dead code. Also: parse JSON-string Deployment.meta; sort fetch_latest_staging_deployments by createdAt desc. - @promote_refs is RESET (not memoized) at the top of check_p1_ghcr_digests, so a reused command instance cannot carry stale A-era refs into a B-era promote. execute_promotion hard-guards against a nil @promote_refs. - execute_promotion pre-validates that every prod-matched service has a digest-shaped @promote_refs entry BEFORE pinning anything, eliminating the partial-promotion-on-missing-ref hazard. - execute_promotion rescue broadens to MutationError + GraphQL::Error + StandardError so a transient mid-loop failure still surfaces the PARTIAL-PROMOTION recovery report; dedup the duplicate warn line and note that source.image may already be partially advanced on Railway. - check_p1_ghcr_digests emits REFUSE: P1 ... "no image" for an imageless staging service (instead of a silent skip that surfaced later as a misleading "internal error"). - check_p1_ghcr_digests per-service rescue broadens to StandardError so a non-GHCR error (e.g. ArgumentError, network) does not bypass the rescue and crash the loop, discarding earlier services' findings. - pin_and_verify raises ArgumentError immediately if called with a tag-form image (instead of 30s of futile retries + misleading error). - pin_and_verify timestamp gate is non-vacuous: a non-nil observed updatedAt is ALWAYS required, even when pre_update_ts is nil (which previously collapsed the gate to digest-equality alone). - run_staging_probe rescues Errno::ENOENT / StandardError around the IO.popen launch so a missing npx produces a clean ok:false summary instead of a raw stack trace bubbling out of P3. Spec hygiene: drop the unused FakeGQL class in test_promote_execute.rb (it referenced an uninitialized @after_image); give the unresolvable-tag fixture a placeholder digest so it never builds a malformed "...@" ref; test_promote_p2.rb tests now capture both streams and assert against the combined output, matching the convention used elsewhere in the suite.
107 lines
4.7 KiB
Ruby
107 lines
4.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require_relative "spec_helper"
|
|
|
|
class PromoteP2Test < Minitest::Test
|
|
class FakeGQL
|
|
def initialize(deployments_by_svc)
|
|
@deployments_by_svc = deployments_by_svc
|
|
@calls = []
|
|
end
|
|
|
|
attr_reader :calls
|
|
|
|
def query(q, vars = {})
|
|
@calls << [q, vars]
|
|
if q.include?("query Deployments")
|
|
edges = (@deployments_by_svc[vars[:serviceId]] || []).map { |n| { "node" => n } }
|
|
return { "deployments" => { "edges" => edges } }
|
|
end
|
|
raise "unexpected query: #{q[0,40]}"
|
|
end
|
|
end
|
|
|
|
def cmd_with(staging:, deployments:)
|
|
c = Railway::PromoteCommand.new(["--non-interactive", "--yes"])
|
|
c.instance_variable_set(:@staging_snapshot, staging)
|
|
c.instance_variable_set(:@prod_snapshot, { "services" => [] })
|
|
c.instance_variable_set(:@gql, FakeGQL.new(deployments))
|
|
c.instance_variable_set(:@ghcr, Object.new.tap do |o|
|
|
def o.manifest_exists(_); :exists; end
|
|
def o.resolve_digest(ref); ref.include?("@sha256:") ? ref.split("@", 2).last : "sha256:fake"; end
|
|
def o.parse_image_ref(ref); Railway::GHCR.allocate.parse_image_ref(ref); end
|
|
end)
|
|
# Stub P3 probe so the test does not shell out to verify-deploy.ts.
|
|
c.define_singleton_method(:run_staging_probe) { |services:| { ok: true, summary: "" } }
|
|
c
|
|
end
|
|
|
|
def test_refuses_when_latest_deployment_not_success
|
|
staging = { "services" => [{
|
|
"name" => "x", "service_id" => "svc-1",
|
|
"image" => "ghcr.io/copilotkit/x@sha256:abc", "digest" => "sha256:abc",
|
|
"env_keys" => [],
|
|
}] }
|
|
deps = { "svc-1" => [
|
|
{ "id" => "d2", "status" => "FAILED", "meta" => { "image" => "ghcr.io/copilotkit/x@sha256:abc" }, "createdAt" => "2026-05-28T01:00:00Z" },
|
|
{ "id" => "d1", "status" => "SUCCESS", "meta" => { "image" => "ghcr.io/copilotkit/x@sha256:abc" }, "createdAt" => "2026-05-28T00:00:00Z" },
|
|
] }
|
|
out, err = capture_io { @rc = cmd_with(staging: staging, deployments: deps).run_with_preflight_only }
|
|
combined = out + err
|
|
assert_equal 1, @rc
|
|
assert_match(/REFUSE: P2.*x.*latest staging deployment.*FAILED/i, combined)
|
|
end
|
|
|
|
def test_refuses_when_latest_success_image_does_not_match
|
|
# In-flight race: newer build with a different digest is the latest.
|
|
staging = { "services" => [{
|
|
"name" => "x", "service_id" => "svc-1",
|
|
"image" => "ghcr.io/copilotkit/x@sha256:OLD", "digest" => "sha256:OLD",
|
|
"env_keys" => [],
|
|
}] }
|
|
deps = { "svc-1" => [
|
|
{ "id" => "d2", "status" => "SUCCESS", "meta" => { "image" => "ghcr.io/copilotkit/x@sha256:NEW" }, "createdAt" => "2026-05-28T01:00:00Z" },
|
|
] }
|
|
out, err = capture_io { @rc = cmd_with(staging: staging, deployments: deps).run_with_preflight_only }
|
|
combined = out + err
|
|
assert_equal 1, @rc
|
|
assert_match(/REFUSE: P2.*in-flight.*sha256:NEW.*sha256:OLD/i, combined)
|
|
end
|
|
|
|
def test_does_not_crash_when_deployment_meta_is_a_string
|
|
# Railway's Deployment.meta is a JSON scalar that can come back as a
|
|
# String (not a Hash). After FIX-2 we PARSE it first; a non-JSON
|
|
# string falls back to a WARN, but MUST NOT crash and MUST NOT
|
|
# produce a P2 REFUSE.
|
|
staging = { "services" => [{
|
|
"name" => "x", "service_id" => "svc-1",
|
|
"image" => "ghcr.io/copilotkit/x@sha256:abc", "digest" => "sha256:abc",
|
|
"env_keys" => [],
|
|
}] }
|
|
deps = { "svc-1" => [
|
|
{ "id" => "d1", "status" => "SUCCESS",
|
|
"meta" => "raw-string-not-a-hash",
|
|
"createdAt" => "2026-05-28T01:00:00Z" },
|
|
] }
|
|
out, err = capture_io { cmd_with(staging: staging, deployments: deps).run_with_preflight_only }
|
|
combined = out + err
|
|
# MUST NOT crash. P2 race-check is best-effort; SUCCESS is the real gate.
|
|
refute_match(/REFUSE: P2/, combined)
|
|
refute_match(/NoMethodError/, combined)
|
|
end
|
|
|
|
def test_passes_p2_when_latest_is_success_and_image_matches
|
|
staging = { "services" => [{
|
|
"name" => "x", "service_id" => "svc-1",
|
|
"image" => "ghcr.io/copilotkit/x@sha256:abc", "digest" => "sha256:abc",
|
|
"env_keys" => [],
|
|
}] }
|
|
deps = { "svc-1" => [
|
|
{ "id" => "d1", "status" => "SUCCESS", "meta" => { "image" => "ghcr.io/copilotkit/x@sha256:abc" }, "createdAt" => "2026-05-28T01:00:00Z" },
|
|
] }
|
|
out, err = capture_io { cmd_with(staging: staging, deployments: deps).run_with_preflight_only }
|
|
combined = out + err
|
|
refute_match(/REFUSE: P2/, combined)
|
|
end
|
|
end
|