Files
Alem Tuzlak 9845dadebb fix(aimock): re-key HITL confirmations on toolCallId so back-to-back flows work
Bug: in a single chat session, running both HITL booking flows
back-to-back (Alice 1:1 → then Sales call without refresh) used to
skip the time-picker on the second flow and jump straight to
"Booked ..." text.

Cause: confirmation fixtures were matched on `hasToolResult: true`,
which fires whenever the conversation has ANY tool message in
history. After the first flow finished, the second user message
short-circuited to a confirmation match before the second flow's
toolCall fixture (gated on `hasToolResult: false`) had a chance to
fire. The picker never rendered.

Fix: re-key the two confirmation fixtures on `toolCallId` (the
specific tool_call_id of the matching `book_call` invocation), which
only fires when the LAST conversation message is a tool result with
that id — exactly the moment we want the confirmation. Drop the
`hasToolResult: false` constraint on the toolCall fixtures so they
match a fresh user request regardless of prior tool history.

Add a back-to-back regression test to all 17 hitl-in-chat specs:
walk Alice flow to completion, then sales flow without refresh,
assert two `time-picker-card` elements rendered. If the multi-flow
regression returns, the second card never appears and the test
fails at `toHaveCount(2)`.
2026-05-01 12:42:53 +02:00

153 lines
6.1 KiB
TypeScript

import { test, expect } from "@playwright/test";
test.describe("HITL in chat — booking flow", () => {
test.beforeEach(async ({ page }) => {
await page.goto("/demos/hitl-in-chat");
});
test("page loads with chat input", async ({ page }) => {
await expect(page.getByPlaceholder("Type a message")).toBeVisible();
});
// Regression: the broad `userMessage: "Alice"` fixture in
// showcase/aimock/feature-parity.json was intercepting this suggestion and
// returning a generic "Nice to meet you, Alice! ... Tokyo" greeting, so the
// book_call HITL flow never fired. The fixture pair added in the same PR
// as this test (full-sentence userMessage match, ordered before the broad
// Alice match) routes the suggestion to a `book_call` toolCall, which is
// what makes the time-picker card render.
test("'Schedule a 1:1 with Alice' suggestion renders the time-picker", async ({
page,
}) => {
const input = page.getByPlaceholder("Type a message");
await input.fill("Schedule a 1:1 with Alice next week to review Q2 goals.");
await input.press("Enter");
const card = page.locator('[data-testid="time-picker-card"]');
await expect(card).toBeVisible({ timeout: 60000 });
// The Tokyo greeting starts with "Nice to meet you, Alice" — if any
// assistant message contains that, the broad Alice fixture won and the
// fix has regressed.
await expect(page.getByText(/Nice to meet you, Alice/i)).toHaveCount(0);
// The card should advertise the booking and the attendee parsed by the
// fixture's toolCall arguments.
await expect(card.getByText(/With Alice/i)).toBeVisible();
// At least one selectable time slot is present.
const slots = page.locator('[data-testid="time-picker-slot"]');
expect(await slots.count()).toBeGreaterThan(0);
});
test("picking a time slot resolves the HITL with a confirmation", async ({
page,
}) => {
const input = page.getByPlaceholder("Type a message");
await input.fill("Schedule a 1:1 with Alice next week to review Q2 goals.");
await input.press("Enter");
const slot = page.locator('[data-testid="time-picker-slot"]').first();
await expect(slot).toBeVisible({ timeout: 60000 });
await slot.click();
// The picked-state card replaces the slot grid.
await expect(
page.locator('[data-testid="time-picker-picked"]'),
).toBeVisible({ timeout: 10000 });
// Agent's follow-up confirmation arrives next.
await expect(
page
.locator('[data-role="assistant"]')
.filter({ hasText: /Booked.*Alice/i })
.first(),
).toBeVisible({ timeout: 30000 });
});
// The other suggestion in the demo. Same HITL flow, different
// attendee/topic. Pinned here so a missing/regressed aimock fixture for
// this suggestion (or a wiring regression in this integration's
// useHumanInTheLoop binding) fails CI loudly instead of silently falling
// through to "the agent rambled at me with no toolCall."
test("'Book a call with sales' suggestion runs the HITL flow end-to-end", async ({
page,
}) => {
const input = page.getByPlaceholder("Type a message");
await input.fill(
"Please book an intro call with the sales team to discuss pricing.",
);
await input.press("Enter");
const card = page.locator('[data-testid="time-picker-card"]');
await expect(card).toBeVisible({ timeout: 60000 });
await expect(card.getByText(/Sales team/i)).toBeVisible();
const slot = page.locator('[data-testid="time-picker-slot"]').first();
await slot.click();
await expect(
page.locator('[data-testid="time-picker-picked"]'),
).toBeVisible({ timeout: 10000 });
await expect(
page
.locator('[data-role="assistant"]')
.filter({ hasText: /Booked.*sales team/i })
.first(),
).toBeVisible({ timeout: 30000 });
});
// Regression: the second booking flow in a single chat session used to
// skip the picker entirely and jump straight to "Booked ..." text. Cause
// was the aimock confirmation fixture being keyed on `hasToolResult: true`
// — once the first flow finished, the conversation had a tool message in
// history, so on the second user message the confirmation fixture matched
// before the toolCall fixture (which required `hasToolResult: false`) had
// a chance to fire. Fix re-keyed confirmation fixtures on `toolCallId`
// (matches only when the LAST message is a tool result with that id) and
// dropped the `hasToolResult: false` constraint on the toolCall fixtures.
// This test explicitly walks both flows in one page session — if the
// multi-flow regression returns, the second time-picker never renders and
// this test fails at step 2.
test("both suggestions render the picker when run back-to-back without refresh", async ({
page,
}) => {
const input = page.getByPlaceholder("Type a message");
const card = page.locator('[data-testid="time-picker-card"]');
// Flow 1: Alice
await input.fill("Schedule a 1:1 with Alice next week to review Q2 goals.");
await input.press("Enter");
await expect(card.first()).toBeVisible({ timeout: 60000 });
await page.locator('[data-testid="time-picker-slot"]').first().click();
await expect(
page
.locator('[data-role="assistant"]')
.filter({ hasText: /Booked.*Alice/i })
.first(),
).toBeVisible({ timeout: 30000 });
// Flow 2: sales — same page, no refresh.
await input.fill(
"Please book an intro call with the sales team to discuss pricing.",
);
await input.press("Enter");
// A SECOND picker card must appear. If the regression returns, no new
// card renders and the agent jumps straight to confirmation text.
await expect(card).toHaveCount(2, { timeout: 60000 });
await expect(card.last().getByText(/Sales team/i)).toBeVisible();
// Pick a slot in the new card and verify the sales-specific
// confirmation arrives.
await page.locator('[data-testid="time-picker-slot"]').last().click();
await expect(
page
.locator('[data-role="assistant"]')
.filter({ hasText: /Booked.*sales team/i })
.first(),
).toBeVisible({ timeout: 30000 });
});
});