Files
copilotkit__copilotkit/showcase/bin/spec/test_promote_execute.rb
Jordan Ritter 3f5eba4999 fix(showcase): harden promote P2 race-check, resolve-once map, and pin verification
Nine correctness fixes to bin/railway PromoteCommand, each red-green tested.

- P2 in-flight race-check now compares deployed digest against the digest
  captured in @promote_refs (P1-resolved), not svc["digest"] which is nil
  for tag-form staging — the check was dead code. Also: parse JSON-string
  Deployment.meta; sort fetch_latest_staging_deployments by createdAt desc.
- @promote_refs is RESET (not memoized) at the top of check_p1_ghcr_digests,
  so a reused command instance cannot carry stale A-era refs into a B-era
  promote. execute_promotion hard-guards against a nil @promote_refs.
- execute_promotion pre-validates that every prod-matched service has a
  digest-shaped @promote_refs entry BEFORE pinning anything, eliminating
  the partial-promotion-on-missing-ref hazard.
- execute_promotion rescue broadens to MutationError + GraphQL::Error +
  StandardError so a transient mid-loop failure still surfaces the
  PARTIAL-PROMOTION recovery report; dedup the duplicate warn line and
  note that source.image may already be partially advanced on Railway.
- check_p1_ghcr_digests emits REFUSE: P1 ... "no image" for an imageless
  staging service (instead of a silent skip that surfaced later as a
  misleading "internal error").
- check_p1_ghcr_digests per-service rescue broadens to StandardError so a
  non-GHCR error (e.g. ArgumentError, network) does not bypass the rescue
  and crash the loop, discarding earlier services' findings.
- pin_and_verify raises ArgumentError immediately if called with a
  tag-form image (instead of 30s of futile retries + misleading error).
- pin_and_verify timestamp gate is non-vacuous: a non-nil observed
  updatedAt is ALWAYS required, even when pre_update_ts is nil
  (which previously collapsed the gate to digest-equality alone).
- run_staging_probe rescues Errno::ENOENT / StandardError around the
  IO.popen launch so a missing npx produces a clean ok:false summary
  instead of a raw stack trace bubbling out of P3.

Spec hygiene: drop the unused FakeGQL class in test_promote_execute.rb
(it referenced an uninitialized @after_image); give the unresolvable-tag
fixture a placeholder digest so it never builds a malformed "...@" ref;
test_promote_p2.rb tests now capture both streams and assert against the
combined output, matching the convention used elsewhere in the suite.
2026-05-29 11:45:14 -07:00

180 lines
8.2 KiB
Ruby

# frozen_string_literal: true
require_relative "spec_helper"
# execute_promotion must resolve any staging tag (e.g. ":latest") to its
# concrete GHCR digest and pin THAT to prod — never a mutable tag. This is
# the core invariant of the showcase deploy model (P6 enforces shape).
class PromoteExecuteTest < Minitest::Test
# A FakeGQL that returns the most-recently-pinned image on recheck,
# so pin_and_verify sees the advance. Records all calls for assertions.
class RecordingGQL
def initialize(pre_ts: "2026-05-28T00:00:00Z")
@calls = []
@pinned_image = nil
@pre_ts = pre_ts
end
attr_reader :calls
def query(q, vars = {})
@calls << [q, vars]
if q.include?("serviceInstanceUpdate")
@pinned_image = vars[:image]
{ "serviceInstanceUpdate" => true }
elsif q.include?("serviceInstanceRedeploy")
{ "serviceInstanceRedeploy" => true }
elsif q.include?("ServiceInstanceRecheck")
if @pinned_image.nil?
# Pre-update snapshot.
{
"serviceInstance" => {
"id" => "i",
"source" => { "image" => "ghcr.io/copilotkit/x@sha256:OLD" },
"updatedAt" => @pre_ts,
},
}
else
{
"serviceInstance" => {
"id" => "i",
"source" => { "image" => @pinned_image },
"updatedAt" => "2026-05-29T00:00:01Z",
},
}
end
else
{}
end
end
# Find the `image:` arg passed to the serviceInstanceUpdate mutation.
def pinned_image
row = @calls.find { |q, _| q.include?("serviceInstanceUpdate") }
row && row[1][:image]
end
end
# FakeGHCR that maps tag-form refs to a digest, and reports :exists for
# the corresponding digest-pinned ref so P1 passes.
class FakeGHCR
# `resolve_map` is { "ghcr.io/org/name:tag" => "sha256:abc..." } or nil for unresolvable.
# `exists_set` is the set of digest-pinned refs that report :exists.
def initialize(resolve_map: {}, exists_set: nil)
@resolve_map = resolve_map
@exists_set = exists_set
end
def resolve_digest(ref)
# Pass-through for already-pinned refs.
return ref.split("@", 2).last if ref.include?("@sha256:")
@resolve_map[ref]
end
def manifest_exists(ref)
return :missing if @exists_set && !@exists_set.include?(ref)
:exists
end
# Delegate to the real GHCR parser — pure function, no I/O.
def parse_image_ref(ref)
Railway::GHCR.allocate.parse_image_ref(ref)
end
end
# Build a command with staging-tag service, snapshot the prod target, and
# inject fakes. Returns [cmd, gql].
def build_cmd(staging_image:, resolve_map:, exists_set: nil)
# --confirm-divergence: bypass the (test-irrelevant) WARN that prod is
# missing the EXPECTED_DOMAINS set; we are testing pin behavior.
cmd = Railway::PromoteCommand.new(["--non-interactive", "--yes", "--confirm-divergence"])
cmd.parser.parse!(cmd.argv)
cmd.instance_variable_set(:@staging_snapshot, {
"services" => [{
"name" => "x", "service_id" => "svc-staging",
"image" => staging_image,
"env_keys" => [],
"start_command" => "node server.js", "healthcheck_path" => "/health",
"region" => "us-west", "replicas" => 1, "restart_policy" => "ON_FAILURE",
}],
})
cmd.instance_variable_set(:@prod_snapshot, {
"services" => [{
"name" => "x", "service_id" => "svc-prod",
"image" => "ghcr.io/copilotkit/x@sha256:OLD",
"env_keys" => [],
"start_command" => "node server.js", "healthcheck_path" => "/health",
"region" => "us-west", "replicas" => 1, "restart_policy" => "ON_FAILURE",
}],
})
gql = RecordingGQL.new
cmd.instance_variable_set(:@gql, gql)
cmd.instance_variable_set(:@ghcr, FakeGHCR.new(resolve_map: resolve_map, exists_set: exists_set))
# Skip P2 deployments query — make fetch_latest_staging_deployments return
# a SUCCESS deployment whose digest matches whatever we will resolve.
# Fall back to a placeholder digest so the fixture is never a malformed
# "...@" — the unresolvable-tag test path will REFUSE at P1 before P2
# consults this stub, so the placeholder value is benign.
resolved_digest = resolve_map.values.first ||
(staging_image.include?("@") ? staging_image.split("@", 2).last : "sha256:placeholder")
cmd.define_singleton_method(:fetch_latest_staging_deployments) do |_svc_id|
[{ "id" => "d", "status" => "SUCCESS", "meta" => { "image" => "ghcr.io/copilotkit/x@#{resolved_digest}" } }]
end
cmd.define_singleton_method(:run_staging_probe) { |services:| { ok: true, summary: "" } }
[cmd, gql]
end
# Silence pin_and_verify's 10s-per-retry waits. RETRY_DELAY_SEC is a
# constant on PromoteCommand; remap to 0 around the test body and restore.
def with_fast_sleeper
original = Railway::PromoteCommand.const_get(:RETRY_DELAY_SEC)
Railway::PromoteCommand.send(:remove_const, :RETRY_DELAY_SEC)
Railway::PromoteCommand.const_set(:RETRY_DELAY_SEC, 0)
yield
ensure
Railway::PromoteCommand.send(:remove_const, :RETRY_DELAY_SEC)
Railway::PromoteCommand.const_set(:RETRY_DELAY_SEC, original)
end
def test_resolves_staging_tag_to_digest_and_pins_digest_to_prod
# (a) staging image is `:latest`; resolve_map maps it to a digest.
cmd, gql = build_cmd(
staging_image: "ghcr.io/copilotkit/x:latest",
resolve_map: { "ghcr.io/copilotkit/x:latest" => "sha256:abc123" },
)
out, _ = with_fast_sleeper { capture_io { @rc = cmd.run_with_preflight_only } }
assert_equal 0, @rc, "promote should succeed when staging tag resolves cleanly; got out=#{out}"
pinned = gql.pinned_image
assert_equal "ghcr.io/copilotkit/x@sha256:abc123", pinned,
"must pin the DIGEST-form ref, not the :latest tag; pinned=#{pinned.inspect}"
refute_includes pinned.to_s, ":latest", "must not pin a mutable tag"
assert_match(/promoted x -> ghcr\.io\/copilotkit\/x@sha256:abc123/, out)
end
def test_refuses_when_staging_tag_cannot_be_resolved_to_digest
# (b) staging :latest that GHCR cannot resolve (resolve_digest returns nil)
# → REFUSE; serviceInstanceUpdate is NEVER called.
cmd, gql = build_cmd(
staging_image: "ghcr.io/copilotkit/x:latest",
resolve_map: {}, # unresolvable
)
out, _ = with_fast_sleeper { capture_io { @rc = cmd.run_with_preflight_only } }
assert_equal 1, @rc, "must refuse when staging tag is unresolvable"
assert_match(/cannot resolve .*:latest.* GHCR digest/i, out)
refuses_update = gql.calls.any? { |q, _| q.include?("serviceInstanceUpdate") }
refute refuses_update, "must NOT call serviceInstanceUpdate when refusing on unresolvable tag"
end
def test_already_digest_pinned_staging_image_is_used_as_is
# (c) Unit test of the resolved-prod-image helper. A staging service
# whose image is already digest-pinned must be passed through unchanged
# (no GHCR tag lookup needed, no rewrite). (This shape is irregular for
# showcase staging — P6 would normally REFUSE staging != :tag — but the
# helper itself must be safe and idempotent.)
cmd = Railway::PromoteCommand.new([])
cmd.instance_variable_set(:@ghcr, FakeGHCR.new(resolve_map: {}))
svc = { "name" => "x", "image" => "ghcr.io/copilotkit/x@sha256:def456" }
assert_equal "ghcr.io/copilotkit/x@sha256:def456",
cmd.send(:resolved_prod_image, svc)
end
end