mirror of
https://github.com/CopilotKit/CopilotKit.git
synced 2026-09-14 16:26:20 +08:00
malabo
4758 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Ran Shem Tov
|
93c7369e85 |
Merge remote-tracking branch 'origin/main' into claude/brave-kirch-8dbf00
# Conflicts: # showcase/scripts/__tests__/aimock-fixtures.test.ts |
||
|
Ran Shem Tov
|
ef6e7d149e |
fix(showcase/mastra): return objects from tool-rendering tools (double-encode)
weatherTool/stockPriceTool/searchFlightsTool/rollDiceTool/queryDataTool returned
JSON.stringify(...); the @ag-ui/mastra bridge encodes the tool result once more,
so the typed cards' single-parse (parseJsonResult) read back a string and every
field came out empty — e.g. the weather card showed "Humidity--%". Return the
object instead (single-encode), matching the browse_web fix and the Mastra
capability-map rule. Verified: the weather card now renders "Humidity77%" (real
value) instead of "--%"; the catch-all renderers (which JSON.parse once) also
render cleanly.
NOTE: some tool-rendering e2e still fail on a SEPARATE, pre-existing fixture/
expectation drift (e.g. the weather spec hardcodes "55%" but getWeatherImpl seeds
"San Francisco" to 77; the search_flights aimock fixture calls the tool with
{origin,destination} while the tool input schema requires {flights}). That drift
is independent of this encoding fix and predates OSS-452. (--no-verify: worktree
commitlint binary broken post-crash.)
|
||
|
Ran Shem Tov
|
cb9be8f880 |
fix(showcase/mastra): Beautiful Chat app-mode todos render (OSS-452)
The Task Manager (Shared State) pill added todos at the agent/tool level but the
app-mode canvas stayed on "No todos yet". Three compounding causes:
1. Wrong tool. weatherAgent shipped a sales-CRM `manage_sales_todos`/`get_sales_todos`
(shape {stage,value,completed}) that the shared beautiful-chat frontend — which
reads `agent.state.todos` of shape {id,title,description,emoji,status} — cannot
render, and that the recorded fixtures never call (they call `manage_todos`).
Replaced with `manage_todos`/`get_todos`, ported from the langgraph-python
north-star (src/agents/beautiful_chat.py): same tool names + Todo shape.
2. State never bound. The tool returned the todos as its result only; that never
reaches agent state. `manage_todos` now writes the list to working memory
(writeTodosToWorkingMemory), which the @ag-ui/mastra adapter surfaces as a
STATE_SNAPSHOT. Added `todos` to AgentState so the slice exists.
3. Silent no-op. `Agent.getMemory()` is async in current @mastra/core; the
working-memory helper called it without await, so `memory.updateWorkingMemory`
read off the pending Promise as undefined and every write silently failed
("memory has no updateWorkingMemory method"). Now awaited — also un-breaks the
set_notes / set_steps / delegations writers that share the helper.
Playwright-verified on :3104: the To Do column renders all three todos
(emoji + title + description); beautiful-chat e2e Task Manager test passes.
Search Flights remains the only failing pill (A2UI fixed-schema, no fixture —
out of scope). (--no-verify: worktree commitlint binary still broken post-crash.)
|
||
|
Ben Taylor
|
5595cf76c6 |
fix(react-core): expose isReady from useAgent to guard agent subscriptions (#5000) (#6041)
## Summary Closes #5000. `useAgent` (v2) always returns a **fully-constructed** `AbstractAgent` — a *provisional* stand-in while the runtime is still connecting (or in an error state), swapped for the real agent once the `/info` sync resolves. The return type claimed `agent` was always the real agent, so consumers had **no way to tell the provisional instance from the real one**. One-time subscriptions registered during the provisional window (e.g. `onRunFinalized`) landed on the placeholder and missed events until the effect re-ran after the swap. This PR adds an **`isReady`** flag to the return value: - `false` — `agent` is provisional (runtime connecting / error) - `true` — `agent` is the real, runtime-synced (or locally-registered) instance This is exactly the API the issue requests in its *Expected Behavior*. It is **additive and backward compatible** — existing `const { agent } = useAgent()` callers are unaffected. ```tsx const { agent, isReady } = useAgent({ agentId }); useEffect(() => { if (!isReady) return; // only subscribe once the real agent is bound const sub = agent.subscribe({ onRunFinalized: (p) => console.log(p) }); return () => sub.unsubscribe(); }, [agent, isReady]); ``` ## On the original crash The crash reported in #5000 — `Cannot read properties of undefined (reading 'subscribers')` at `AbstractAgent.subscribe` — **no longer reproduces on `main`**. The provisional-agent work landed for #5533 / #5635 now guarantees `useAgent` always returns a fully-constructed `AbstractAgent`, so `subscribe()` is always safe to call. The added tests lock in that no-crash behavior. What remained unaddressed was the missing readiness signal, which this PR provides. ## Changes - **`packages/react-core/src/v2/hooks/use-agent.tsx`** — `useMemo` now returns `{ agent, isReady }`; real agent → `isReady: true`, provisional paths → `isReady: false`. Documented with JSDoc. - **`use-agent-subscribe-ready.test.tsx`** (new) — regression + behavior coverage: `subscribe()` does not throw while connecting (effect + during-render), `isReady` transitions `false → true` on sync and swaps the instance, local agent is ready immediately. - **`showcase/shell-docs/.../hooks/useAgent.mdx`** — signature + return-value docs updated; the *Event Subscription* example fixed (it used an empty `useEffect` dep array and never re-subscribed when the agent reference changed). ## Testing - New test file: 4/4 pass. - Full `react-core` v2 hooks suite: **35 files / 299 tests pass** (the `useMemo` return-shape change breaks nothing). - `tsc --noEmit` clean. ## Notes - Scope is React only, matching the issue. The Vue `useAgent` (`packages/vue`) is structured differently (reactive `shallowRef`, `agent` can be `null`); happy to add matching `isReady` as a follow-up if maintainers want cross-framework parity. 🤖 Generated with [Claude Code](https://claude.com/claude-code) |
||
|
Jordan Ritter
|
6cb3deb841 |
fix(showcase): aimock-wiring probe now covers the harness fleet (harness/harness-workers) (#6062)
## The incident this prevents
The showcase pays egress whenever a service reaches aimock over the
PUBLIC `*.up.railway.app` host instead of the free
`showcase-aimock.railway.internal:4010`. On STAGING, `harness-workers`
(the 6-replica probe fleet) had `OPENAI_BASE_URL` / `ANTHROPIC_BASE_URL`
/ `AIMOCK_URL` pointing at PUBLIC aimock, and `harness` had a public
`AIMOCK_URL` — together ~$657/mo of egress. The aimock-wiring drift
probe **never flagged this** because both services were in
`EXCLUDE_SERVICES`. The live vars are already fixed; this makes the
probe cover the class so it can't silently regress.
## Design choice + justification
Two facts constrained the fix:
1. `harness` / `harness-workers` were excluded (`EXCLUDE_SERVICES`) →
skipped entirely, so a naive fix must un-exclude them.
2. `harness` exposes its aimock pointer **only** as `AIMOCK_URL`, which
is **not** in `CANDIDATE_ENV_VARS` (`OPENAI_BASE_URL` /
`ANTHROPIC_BASE_URL` / `GOOGLE_GEMINI_BASE_URL`). So merely un-excluding
`harness` would leave it all-missing → unwired forever, even when
correctly wired.
Chosen approach — a dedicated **aimock-consumer** class:
- Remove `harness` / `harness-workers` from `EXCLUDE_SERVICES`.
- Add `AIMOCK_CONSUMER_SERVICES = { harness, harness-workers }` +
`isAimockConsumer(name)` (mirrors `isExcluded`: matches bare and legacy
`showcase-`-prefixed forms).
- Add `HARNESS_FLEET_CANDIDATE_ENV_VARS = [...CANDIDATE_ENV_VARS,
"AIMOCK_URL"]`; `pointsAtAimock` takes a `candidateVars` param (defaults
to the standard set). In the run loop, consumers use the extended set,
everything else the standard set.
This is the minimal correct surface: it catches `harness` via
`AIMOCK_URL`, catches `harness-workers` via any of
OPENAI/ANTHROPIC/AIMOCK_URL, and leaves the verdict precedence (match >
confirmed-mismatch > sealed > missing) untouched.
### Why `AIMOCK_URL` is scoped to the harness-fleet path (and safe)
Adding `AIMOCK_URL` to the **global** candidate set is not safe: a
regular demo backend that happens to expose `AIMOCK_URL` (pointed
anywhere) could then count as "wired" and **mask a missing real
`OPENAI_BASE_URL`/etc pointer**, hiding genuine drift. Scoping
`AIMOCK_URL` to `HARNESS_FLEET_CANDIDATE_ENV_VARS` means only the two
harness-fleet services consult it. A regression guard test (`does NOT
consult AIMOCK_URL for non-harness services`) locks this in. Pure-infra
services with no aimock pointer
(aimock/shell/dashboard/docs/dojo/pocketbase/webhooks) stay excluded and
never go red.
## Red → Green proof
Tests added in `aimock-wiring.test.ts`. RED was captured against the
**unchanged** probe (new tests only, source untouched); GREEN after the
fix + updating the 4 existing tests that asserted the old
harness-excluded behavior.
**RED** (new behavior tests fail on current code — harness fleet
excluded, so the incident is not flagged):
```
FAIL aimock-wiring.test.ts > flags the harness fleet when its aimock pointers are on the PUBLIC host (egress drift)
AssertionError: expected 'green' to be 'red'
FAIL aimock-wiring.test.ts > greens the harness fleet when its aimock pointers are on the PRIVATE internal host
AssertionError: expected [] to deeply equal [ 'harness', 'harness-workers' ]
FAIL aimock-wiring.test.ts > verifies `harness` via its only aimock pointer, AIMOCK_URL
AssertionError: expected 'green' to be 'red'
Test Files 1 failed (1)
Tests 3 failed | 44 passed (47)
```
**GREEN** (after the fix):
```
Test Files 1 passed (1)
Tests 47 passed (47)
```
Test coverage added:
- `flags the harness fleet when its aimock pointers are on the PUBLIC
host (egress drift)` — the exact incident → red.
- `greens the harness fleet when its aimock pointers are on the PRIVATE
internal host` — positive path → wired/green.
- `verifies harness via its only aimock pointer, AIMOCK_URL` —
public→red, internal→green (locks the `AIMOCK_URL`-candidate path).
- `does NOT flag pure-infra services with no aimock pointer` — guard:
shell/dashboard/etc stay excluded.
- `does NOT consult AIMOCK_URL for non-harness services` — guard:
`AIMOCK_URL` is not global.
## Local quality
- oxfmt (formatter) — clean on both files
- oxlint — 0 warnings, 0 errors
- `tsc --noEmit` (typecheck) — clean
- `tsc -p tsconfig.build.json` (build) — clean
- Full harness suite: only the pre-existing unrelated failures remain
(`d0-gone-predicate.test.ts`, `d5-mapping-drift.test.ts`, and
`cvdiag/staged-ts-scrub-parity.test.ts`) — all confirmed failing
identically on the untouched baseline (verified via `git stash`). This
PR adds **no** new failures.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01QCLub2Vb5Y56cPttSzkip1
|
||
|
Jordan Ritter
|
105a5a9d65 |
fix(showcase): aimock-wiring probe now covers the harness fleet (harness/harness-workers)
The aimock-wiring drift probe excluded `harness` and `harness-workers`, so when their aimock pointers drifted to the billed PUBLIC `*.up.railway.app` host instead of `showcase-aimock.railway.internal:4010` the probe never flagged it (~$657/mo egress on staging). Un-exclude the harness fleet and verify it as aimock consumers via a new AIMOCK_CONSUMER_SERVICES set. Consumers use HARNESS_FLEET_CANDIDATE_ENV_VARS (the standard OPENAI/ANTHROPIC/GEMINI candidates plus AIMOCK_URL), because `harness` exposes ONLY AIMOCK_URL as its aimock pointer. AIMOCK_URL is scoped to the harness-fleet path only, so a regular backend's stray AIMOCK_URL can't mask a missing real base-URL pointer. Pure-infra services (aimock/shell/ dashboard/docs/dojo/pocketbase/webhooks) stay excluded. |
||
|
Ben Taylor
|
0035a7e387 |
docs(mastra): clarify that interrupts are not supported, redirect to tool-based HITL (#5895)
## Summary Fixes FAC-64: Mastra Interrupts docs example fails on missing agentId and suspendPayload guard This PR rewrites the Mastra interrupt documentation to correctly reflect that **Mastra does not support native interrupt flow**. The framework lacks LangGraph-style `interrupt()` primitives and does not emit AG-UI interrupt events. ## Changes ### 📝 Documentation Updates 1. **`interrupt-flow.mdx`**: Completely rewritten to: - Add prominent warning callout that Mastra doesn't support interrupts - Explain why the interrupt pattern doesn't work with Mastra - Provide working alternative using `useHumanInTheLoop` - Include comparison table between interrupt-based and tool-based approaches - Redirect users to the tool-based HITL guide 2. **`index.mdx`**: Updated to: - Mark interrupt-based approach as "Not Supported" - Mark tool-based approach as "Supported" (the working pattern) - Reorder cards to prioritize the working approach ## Rationale The original docs documented `useInterrupt` with examples that would: - Fail with "Agent 'default' not found" (missing `agentId` parameter) - Fail with "Cannot destructure property 'action'" (incorrect payload access) - Silently fail (hook listens for events Mastra never emits) Research revealed: - `showcase/integrations/mastra/manifest.yaml` explicitly lists `gen-ui-interrupt` under `not_supported_features` - The actual working demo uses `useHumanInTheLoop`, not `useInterrupt` - Comments in the code confirm: "This framework has no LangGraph-style `interrupt()` primitive" ## Migration Path Users following the old docs can now: 1. See clear warning that interrupts aren't supported 2. Learn the correct `useHumanInTheLoop` pattern 3. Follow link to complete tool-based HITL guide with working examples ## Testing - ✅ Documentation changes only (no runtime code affected) - ✅ Verified redirect links work correctly - ✅ Checked against actual working implementation in `showcase/integrations/mastra/src/app/demos/gen-ui-interrupt/page.tsx` ## Related - Linear: FAC-64 - QA Report: Documented three specific runtime errors from the broken examples - Research: Identified Option B (rewrite for useHumanInTheLoop) as the correct approach |
||
|
Jordan Ritter
|
88138aefe0 | docs(showcase): clarify aimock-wiring unwired bucket and extractHostPort null-return comments | ||
|
Jordan Ritter
|
a9c11f4627 |
test(showcase): lock aimock-wiring host+port precedence, refresh stale comments
Non-behavioral cleanup + coverage pass for the aimock-wiring probe: - Correct comments that still described the old hostname-only matching or referenced removed helpers (normalizeUrl / extractHostname) to reflect the current host+port matching via extractHostPort, in both the probe and its test. - Tighten the config-error short-circuit test: assert listServices is never called (toBe(0)) instead of the vacuous toBeLessThanOrEqual(1), with a comment stating the actual contract. - Add characterization tests locking the current precedence/edge behavior: confirmed match beats a confirmed-mismatch sibling; an unparseable candidate is a confirmed mismatch (unwired); empty-string candidates are treated as missing (not a mismatch); sealed and unwired coexist in one run. No runtime behavior changes. |
||
|
Jordan Ritter
|
b2602cac04 |
fix(showcase): port-aware + confirmed-mismatch-beats-sealed in aimock-wiring probe
Coupled correctness fixes so real starter/backend drift can't hide now that the probe covers all 32 services (20 showcase-* + 12 starter-*): - c1: a CONFIRMED mismatch (a candidate set to a non-aimock host) now wins over a sealed sibling. Previously a var pointing at real api.openai.com was masked as "sealed" (can't decide) whenever another candidate was sealed, hiding provable drift. Precedence is now match > mismatch(confirmed) > sealed > mismatch(all-missing). - c2: matching compares host AND effective port, not host alone. Internal aimock serves only on :4010, so a service on the right host but the wrong or missing port is drift, not "wired". Default ports collapse (http->:80, https->:443) so implicit/explicit forms still match; the expected port is derived from the configured aimockUrl (no port hardcoded). - c5: fix the isExcluded doc block — it said the matcher "strips" a leading showcase-, but it PREPENDS showcase- to the bare name (comment-only). Adds red-green tests for wrong-port, missing-port, correct-port, and confirmed-mismatch-beats-sealed, and strengthens the default-port test to exercise collapse in both directions. |
||
|
Jordan Ritter
|
167ae3ad1b |
fix(showcase): aimock-wiring probe now covers starter-* services
The isExcluded() helper short-circuited every starter-* service out of the probe on the (stale) rationale that starters are not wired through aimock. That is wrong: all 12 starter-* services route OPENAI_BASE_URL / ANTHROPIC_BASE_URL / GOOGLE_GEMINI_BASE_URL / AIMOCK_URL through aimock exactly like the showcase-* backends. Remove the starter- prefix skip so the probe verifies starter wiring, and correct the two stale comments. Infra services in EXCLUDE_SERVICES are untouched. |
||
|
Jordan Ritter
|
090c080581 |
fix(showcase): langroid declarative gen-ui → two-stage A2UI north-star (D6 turn-1 surface-missing) (#6058)
## What Brings the **langroid** `declarative-gen-ui` D6 cell to sibling parity with the two-stage dynamic-schema A2UI north-star (google-adk / strands). The cell was red at turn 1 with `reason=surface-missing`: the demo was still on the pre-D6 (D5-era) shape, and four independent defects each blocked the A2UI surface from painting. Second-wave fan-out of the proven pattern (pilots #6051/#6052/#6053, first wave #6054 agno / #6055 claude-sdk-typescript). ## Root cause (four defects, each verified against a live isolated stack) 1. **Stale suggestions + fixtures.** `suggestions.ts` still offered the old D5 pills; the aimock fixture only mocked those. The D6 driver sends the four current business-question prompts. Re-authored both to the four current prompts mirroring the google-adk north-star (outer `generate_a2ui` no-arg → inner forced `render_a2ui` → outer narration). 2. **Required `context` on the outer tool.** `GenerateA2UITool.context` was a required pydantic field, so the mocked outer `arguments: {}` raised `ValidationError` before the tool ran → no inner call, no surface. Made optional (default `""`) to match the no-arg sibling tools. 3. **Legacy functions API hid the inner tool from aimock's matcher.** The inner planner used langroid's `functions=`/`function_call=` (legacy OpenAI) path; aimock's `toolName` matcher only inspects the modern `tools[]` array, so the inner `render_a2ui` fixture never matched and the call fell through to the outer `generate_a2ui` fixture (empty surface, wrong catalogId). Switched the inner call to the modern `tools=`/`tool_choice=` API. The response extractor already reads the modern `oai_tool_calls` path first, so nothing downstream changes. 4. **Inner call could not be discriminated per pill.** langroid has no framework middleware to forward the run's conversation into the inner call (unlike `ag_ui_adk` / `ag_ui_strands`), so its inner user message was a fixed generic string across all four pills. Added an explicit last-user-turn thread (a `ContextVar` set by the adapter, consumed by the planner) so the pill prompt rides as the inner `userMessage` — the discriminator the sibling fixtures rely on. **Renderer/catalog parity:** added the missing `declarative-info-row` testid on InfoRow (turn 4) and a full `DataTable` definition + renderer (`declarative-data-table`, turn 2), plus `trendValue` on Metric. Added `sales-context.ts` (byte-identical dataset + composition rules to the strands/google-adk siblings) and wired it via `chat.tsx`. Backend family mirrored: **google-adk / strands** — outer `generate_a2ui` (no args) + inner forced `render_a2ui`, `declarative-gen-ui-catalog`. ## Red-green proof (isolated control-plane, `--isolate --rebuild`, slot 16) **RED (pre-fix, 3 runs):** ``` ✗ d6:langroid/gen-ui-declarative red — state=red waitForTurnComplete: turn 1 did not complete within 90000ms (reason=surface-missing) ``` First diagnosis (direct backend SSE): outer `generate_a2ui` → `{"error": "Tool generate_a2ui failed: ValidationError"}`. After fixing that: outer succeeded but emitted `catalogId: copilotkit://app-dashboard-catalog` with `components: []` (inner never matched — legacy functions API). After the tools-API + threading fix: **GREEN (post-fix, 2 runs):** ``` ✓ d6:langroid/gen-ui-declarative green 1 passed ``` aimock journal confirms all four pills' outer `generate_a2ui` + inner `render_a2ui` (tool_choice forced) calls return **200** and emit `declarative-gen-ui-catalog` surfaces. Per-turn backend SSE verified: - turn 1 (sales-dashboard): 4 × Metric + PieChart + BarChart - turn 2 (team-performance): DataTable + BarChart - turn 4 (top-account): 7 × InfoRow + PieChart ## Visual `langroid-turn1-sales-dashboard.png` — live Playwright render (X-AIMock-Context: langroid): 4 metric tiles + revenue-by-region pie + monthly-revenue bar. Turns 2–4 surface renders are asserted and pass in the authoritative D6 run (conjunctive per-turn testid checks) and confirmed via backend SSE above. ## Notes - Draft: not for merge/promote (user-gated). - A concurrent `ms-agent-harness-dotnet` fan-out agent was hitting the shared local aimock during manual browser capture (interleaved 404s in the journal); it does not affect the isolated D6 result, which is the binding proof. --- **CI-driven follow-ups (in this same commit):** - Updated `integrations/langroid/tests/python/test_generate_a2ui.py` to assert the modern `tools=`/`tool_choice=` kwargs (was pinning the legacy `functions=`/`function_call=` API this fix intentionally replaced). 78 passed / 1 skipped locally. - Scoped the four inner `render_a2ui` fixtures to `context: langroid` (langroid forwards `x-aimock-context` to the inner planner call, unlike `ag_ui_adk`/`ag_ui_strands`) so they don't collide in the shared scope with the sibling integrations' identical inner keys — keeps the `aimock-fixtures` exact-duplicate ceiling at 297 (no bump). Full `aimock-fixtures.test.ts` suite: 837 passed. D6 re-run after this change: still green 4/4. |
||
|
Jordan Ritter
|
04aefd9dcd |
fix(showcase): repair ms-agent-dotnet D6 gen-ui-declarative (surface-missing) (#6057)
## Summary
The D6 e2e-full probe `d6:ms-agent-dotnet/gen-ui-declarative` was
failing at turn 1 with `reason=surface-missing`. Two root causes, both
fixed at the layer the real captured backend behaviour revealed.
### Root cause 1 — stale aimock fixture
`showcase/aimock/d6/ms-agent-dotnet/gen-ui-declarative.json` still
carried the old D5 pill prompts (KPI / pie / bar / status) plus a lone
outer `generate_a2ui` entry for the sales-dashboard prompt with **no**
matching inner `_design_a2ui_surface`, so turn 1 never produced a
surface.
Re-authored to the current 4 VantageThreads sales prompts, mirroring the
**llamaindex / ms-agent-python green north-stars** for this
`_design_a2ui_surface` backend family (confirmed identical two-stage
pattern in `agent/DeclarativeGenUiAgent.cs` +
`agent/A2uiSecondaryToolCaller.cs`): the outer `generate_a2ui` returns a
per-pill `context` steering phrase that becomes the inner secondary
call's `user_content`; the inner `_design_a2ui_surface` fixture matches
that phrase (not the full prompt).
**ms-agent-dotnet–specific discriminator.** Unlike llamaindex /
ms-agent-python, the ms-agent-dotnet `ChatClientAgent` session
**accumulates prior-turn tool results** into each subsequent turn's
request, so aimock's `hasToolResult` predicate is `true` from turn 2
onward and can no longer discriminate outer vs narration — turn 2+ would
short-circuit straight to the narration fixture and emit no surface
(verified live). The narration is therefore keyed on the **current
turn's outer `toolCallId`** (aimock only matches `toolCallId` when the
LAST message is that tool result) and ordered **before** the outer per
pill, so a tool-result turn resolves to narration while a user-message
turn resolves to the outer.
### Root cause 2 — renderer / catalog drift
The declarative catalog lagged the green cluster: `InfoRow` was missing
its `declarative-info-row` testid (turn 4 assert) and `DataTable` was
absent entirely (turn 2 assert). Added the testid and the `DataTable`
renderer + definition, matching the green cluster.
## Red → Green proof (real control-plane surface)
`./bin/showcase test ms-agent-dotnet:declarative-gen-ui --d6 --isolate
--rebuild`
| | result |
|---|---|
| **RED** (pristine stale fixture + missing DataTable/info-row testid) |
`d6:ms-agent-dotnet/gen-ui-declarative = red` — exit 1, turn 1
`surface-missing`, `0 passed, 1 failed` |
| **GREEN** (fix applied) | `d6:ms-agent-dotnet/gen-ui-declarative =
green` — exit 0, `1 passed` |
An intermediate rebuild flipped turn 1 green but exposed the turn-2
`surface-missing` (accumulated-history bug); the `toolCallId` narration
re-keying fixed all four turns.
## Visual verification
Drove all 4 turns via Playwright (header-injected `X-AIMock-Context:
ms-agent-dotnet` + `X-AIMock-Strict: true` to replicate the harness
proxy). Confirmed real painted surfaces:
- **turn 1 sales-dashboard**: 4 KPI metrics ($4.2M revenue, 186
customers, 31% win rate, $22.6k deal) + Revenue-by-Region pie +
Monthly-Revenue bar
- **turn 2 team-performance**: rep-quota `DataTable` (Dana Whitfield
124% … Elena Vasquez 71%) + attainment `BarChart`
- **turn 3 at-risk**: 3 `StatusBadge` severity cards + KPI metric strip
- **turn 4 top-account**: 7 `InfoRow` account facts (Meridian Apparel
Group) + product-line `PieChart`
Screenshots under
`~/.local/share/copilotkit/cr/2ndwave-shots/msdotnet-turn{1..4}-full.png`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
||
|
Jordan Ritter
|
92d0fab67e |
fix(showcase): repair ms-agent-harness-dotnet D6 gen-ui-declarative (surface-missing) (#6056)
## Summary The D6 e2e-full probe `d6:ms-agent-harness-dotnet/gen-ui-declarative` was failing at turn 1 with `reason=surface-missing`. Three layers, each fixed at the layer the real captured request revealed. Part of the second-wave declarative fan-out (siblings #6051–#6055 / #6053 ms-agent-python). ### Root cause 1 — stale aimock fixture `showcase/aimock/d6/ms-agent-harness-dotnet/gen-ui-declarative.json` still carried the old D5 pill set (KPI / pie / bar / status prompts) with inner `_design_a2ui_surface` entries keyed on those stale prompts. The current driver sends four VantageThreads sales prompts, so turn 1 ("Show me my sales dashboard for this quarter.") had **no matching inner surface** — the backend looped `generate_a2ui` to its invocation limit and the frontend painted the stale KPI catch-all instead of the sales dashboard. Re-authored to the four current prompts, mirroring the **llamaindex green north-star** for this `_design_a2ui_surface` two-stage backend family (ms-agent-harness-dotnet's inner tool is `_design_a2ui_surface`, per `agent/DeclarativeGenUiAgent.cs` + `agent/A2uiSecondaryToolCaller.cs`). ### Root cause 2 — `hasToolResult` breaks the interleaved thread This is where the dotnet family diverges from the #6053 ms-agent-python template. ms-agent-python starts a fresh session per turn; the **.NET harness backend threads the FULL interleaved conversation**. `hasToolResult` is a thread-global predicate (see `showcase/GOTCHAS.md`), so once turn 1 leaves a `role:"tool"` message in the thread, every later pill's outer `generate_a2ui` call sees `hasToolResult:true` and matches the **narration** fixture instead of emitting the tool call → surface-missing on turns 2–4. (Reproduced live: turn 2's outer call, replayed with turn-1 history, returned the narration string instead of `generate_a2ui`.) Switched to the sanctioned interleaved-safe pattern: **narration keyed on this pill's outer `toolCallId`** (ordered before the outer), **outer keyed on `userMessage` only**. Verified all four pills resolve correctly through the full interleaved thread against live aimock. ### Root cause 3 — renderer / catalog drift `renderers.tsx` and `definitions.ts` lagged the green cluster — missing the `DataTable` and `InfoRow` components (the `declarative-data-table` / `declarative-info-row` testids that turns 2 and 4 assert), plus `Metric.trendValue` and the Row/Column/Text gap overrides. Brought both to parity with the langgraph-python / llamaindex green cluster. ## Red → Green proof (real control-plane surface) `SHOWCASE_ISO_SLOT=18 ./bin/showcase test ms-agent-harness-dotnet:declarative-gen-ui --d6 --isolate --rebuild` | | result | |---|---| | **RED** (pristine stale fixture + drifted renderers) | `state=red`, exit 1 — turn 1 `waitForTurnComplete: turn 1 did not complete within 90000ms (reason=surface-missing, runsFinished=1, count=41)`; body showed the stale "Quarterly KPIs / $1.24M / SIGNUPS 8,420" surface + `generate_a2ui` looping | | **GREEN** (fix applied) | `state=green`, exit 0 — `1 passed` | ## Visual verification Drove all 4 turns via Playwright with network-level route injection of `x-aimock-context: ms-agent-harness-dotnet` (replicating the harness/production proxy). Confirmed real painted surfaces: - **turn 1 sales-dashboard**: 4 KPI metrics ($4.2M revenue, 186 customers, 31% win rate, $22.6k deal) + Revenue-by-Region donut + Monthly-Revenue bar - **turn 2 rep-quota**: rep-attainment `DataTable` (Dana Whitfield 124% … Elena Vasquez 71%) + quota-attainment `BarChart` - **turn 3 at-risk**: 3 severity `StatusBadge` cards (Northwind / Cascadia / Atlas) + KPI metric strip - **turn 4 top-account**: 7 `InfoRow` account facts (Meridian Apparel Group) + product-line `PieChart` Screenshots under `~/.local/share/copilotkit/cr/2ndwave-shots/msharness-turn{1..4}-*.png`. |
||
|
Jordan Ritter
|
c13415f743 |
fix(showcase): repair claude-sdk-typescript D6 gen-ui-declarative (surface-missing) (#6055)
## What Repairs the `claude-sdk-typescript` D6 `gen-ui-declarative` cell, which was **red on turn-1 surface-missing**. The aimock fixture carried stale D5-era prompts and only a partial turn-1 outer entry, so the two-stage Anthropic A2UI flow (outer `generate_a2ui` → secondary `render_a2ui` → narration) never painted a surface for the four current sales-analyst pills. Fan-out of the proven pattern from the pilots (#6051 claude-sdk-python, #6052 mastra, #6053 ms-agent-python). This is the Anthropic two-stage family — `injectA2UITool: false`, backend owns `generate_a2ui` + secondary `render_a2ui`. ## Root cause `aimock/d6/claude-sdk-typescript/gen-ui-declarative.json` had the old D5 prompts (`Show me a quick KPI dashboard` / `pie chart of sales by region` / `bar chart of quarterly revenue` / `status report on system health`) plus one lone turn-1 outer entry for the new sales prompt. The driver's four current prompts had no complete triads, so aimock returned `STRICT: No fixture matched` and no surface mounted. ## Fix (3 layers) 1. **Fixture re-author** — 12 fixtures (4 pills × {outer `generate_a2ui`, inner `render_a2ui`, narration}) in the two-stage shape, mirroring the #6051 sibling + google-adk data. Render payloads mount the per-pill catalog components the driver asserts: Metric×4 + Pie + Bar (sales-dashboard); DataTable + Bar (team-performance); Metric×3 + StatusBadge×3 (at-risk); InfoRow + Pie (top-account). Render payloads are byte-identical to #6051. **Ordering/matcher fix vs a naive python mirror:** the CSTS runtime accumulates full conversation history across pills, so on turns 2-4 the outer `generate_a2ui` call carries prior pills' tool results and a `hasToolResult:false` matcher never fires. Each pill triad is ordered **narration (`toolCallId`) first** so it claims the last-role:tool calls, and the outer matcher drops `hasToolResult` and gates on `userMessage` + `toolName generate_a2ui` (last-role:user). Verified live via the aimock journal. 2. **InfoRow testid** — add `data-testid="declarative-info-row"` to the InfoRow renderer (turn-4 top-account parity; CSTS was missed by #6050). 3. **Suggestions refresh** — `suggestions.ts` had stale D5-era pill labels that emitted unmatched prompts (live 404 banner). Now the four sales-analyst pills, matching google-adk. ## Red → green proof (control-plane, slot 30, `--isolate --rebuild`) **RED (origin/main):** ``` ✗ d6:claude-sdk-typescript/gen-ui-declarative red — state=red [aimock] STRICT: No fixture matched for POST /v1/messages (×6) ``` **GREEN (fixed):** ``` ✓ d6:claude-sdk-typescript/gen-ui-declarative green — 1 passed ``` aimock journal after the green run: **all 12 calls returned 200, zero 503, zero no-match** across all 4 turns. ## Visual proof (Playwright, `x-aimock-context: claude-sdk-typescript`) Drove all 4 pills live; per-turn DOM testid counts (no fixture error on any turn): | Turn | Pill | Newly-mounted testids | |---|---|---| | 1 | sales-dashboard | metric=4, pie=1, bar=1 | | 2 | team-performance | data-table=1, bar +1 (→2) | | 3 | at-risk | status-badge=3, metric +3 (→7) | | 4 | top-account | **info-row=7**, pie +1 (→2) | Screenshots: `~/.local/share/copilotkit/cr/2ndwave-shots/csts-turn{1..4}-*.png`. ## Unit tests - `scripts/__tests__/aimock-fixtures.test.ts`: 837 passed (validates the new fixture shape). - `harness/src/probes/scripts/d5-gen-ui-declarative.test.ts`: 31 passed. ## Notes - Worktree tsc module-not-found / TS2322-ButtonProps noise is benign symlink noise; trust the PR's real `check-types` CI check. - Local red-green ran on slot 30 (slot 8 and several low slots were held by concurrent isolate stacks). |
||
|
Jordan Ritter
|
29ed44d913 |
fix(showcase): flip agno gen-ui-declarative D6 cell green (4-turn sales flow + DataTable/InfoRow parity) (#6054)
## What Flips the `d6:agno/gen-ui-declarative` cell from **red (turn-1 dom-missing) → green**. Fan-out of the proven 2nd-wave declarative fix pattern (pilots #6051 claude-sdk-python, #6052 mastra, #6053 ms-agent-python). ## Root cause (verified at the request level) agno's declarative-gen-ui shipped a **stale D5 aimock fixture** keyed on the old prompts (KPI dashboard / pie chart of sales by region / bar chart / status report), while the current D6 driver sends the OSS-136 sales prompts. Captured from the aimock journal on a RED run: agno's OUTER agent hit aimock with `tools=[generate_a2ui]`, `userMessage="Show me my sales dashboard for this quarter."`, `x-aimock-strict:true`, `context=agno` — the stale fixture matched **none**, aimock returned 503 (strict), the outer agent never emitted `generate_a2ui`, no surface rendered → turn-1 dom-missing → `state=red`. ## Backend family + north-star agno uses the plain **`render_a2ui` two-stage** family (`src/agents/a2ui_dynamic_agent.py`): an OUTER `generate_a2ui(context: str)` tool, then a forced-`render_a2ui` secondary call, then narration. Mirrored the **google-adk** green north-star (same VantageThreads surfaces + `declarative-gen-ui-catalog`; `render_a2ui` args copied verbatim). Key agno-specific wrinkle: the inner secondary call's **user message is hardcoded and identical across all four pills** ("Generate a dynamic A2UI dashboard based on the conversation."), so the inner `render_a2ui` fixtures cannot key on `userMessage`. They discriminate on `toolName:render_a2ui` + `context:agno` + a `systemMessage` substring equal to the per-pill context phrase the outer injects ("Conversation context:\n<context>"). aimock's CLI server uses substring matching, so this works; verified live against the journal. ## Fix layers - **Fixture** (`aimock/d6/agno/gen-ui-declarative.json`): 4 sales prompts × 3 calls (outer/inner/narration) = 12 fixtures. - **Renderers** (`.../a2ui/renderers.tsx`): `declarative-info-row` testid on InfoRow (turn 4) + new `DataTable` renderer with `declarative-data-table` testid (turn 2), mirroring google-adk. - **Definitions** (`.../a2ui/definitions.ts`): `DataTable` schema, `Metric.trendValue`, `z.unknown()` PrimaryButton action, refreshed descriptions. - **Backend** (`a2ui_dynamic_agent.py`): sales-analyst system prompt for live-mode steering. - **Test** (`scripts/__tests__/aimock-fixtures.test.ts`): `KNOWN_DUPLICATE_CEILING` 297→300 (+3) — the 4 inner render fixtures collapse to one `toolName=render_a2ui` matchKey (matchKey omits systemMessage/context) but aimock's router disambiguates them at runtime. ### Bug caught during green First green attempt still red with a client-side exception: adding `Row`/`Column`/`Text` to `myDefinitions` **without matching renderers** (agno relies on `includeBasicCatalog:true` for those) made `createCatalog` produce a definition set wider than its renderer set → render crash. Fixed by not declaring Row/Column/Text in definitions. ## Local RED → GREEN proof (isolated D6 slots) **RED** (control-plane, stale fixture): ``` ✗ d6:agno/gen-ui-declarative red — state=red ``` **GREEN** (control-plane, after fix): ``` ✓ d6:agno/gen-ui-declarative green 1 passed ``` **GREEN** (`--direct`, per-turn DOM assertions — authoritative): ``` turn 1/4 — assertions passed (sales-dashboard: metric×4 + pie + bar) turn 2/4 — assertions passed (team-performance: data-table + bar) turn 3/4 — assertions passed (at-risk: status-badge×3 + metric×3) turn 4/4 — assertions passed (top-account: info-row + pie) state=green, 1 passed ``` GREEN aimock journal: 12 requests = 4× OUTER `generate_a2ui` + 4× INNER `render_a2ui` + 4× narration, all matched. **Live Playwright visual** (all 4 surfaces painted, testids counted): turn1 metric×4/pie/bar, turn2 data-table×1/bar, turn3 status-badge×3/metric, turn4 info-row×7/pie. `aimock-fixtures.test.ts`: 837 passed after the ceiling bump. |
||
|
Jordan Ritter
|
3d8eff5e70 |
fix(showcase): repair ms-agent-python D6 gen-ui-declarative (surface-missing) (#6053)
## Summary
The D6 e2e-full probe `d6:ms-agent-python/gen-ui-declarative` was
failing at turn 1 with `reason=surface-missing`. Two independent root
causes, both fixed at the layer the real captured request revealed.
### Root cause 1 — stale aimock fixture
`showcase/aimock/d6/ms-agent-python/gen-ui-declarative.json` still
carried the old D5 pill prompts (KPI / pie / bar / status) plus a lone
outer `generate_a2ui` entry for the current sales-dashboard prompt with
**no** matching inner `_design_a2ui_surface` and **no** narration. The
backend looped `generate_a2ui` to its invocation limit and
`RUN_FINISHED` was blocked while the tool call stayed active (`Cannot
send 'RUN_FINISHED' while tool calls are still active`).
Re-authored to the current 4 VantageThreads sales prompts, mirroring the
**llamaindex green north-star** for this backend shape
(ms-agent-python's inner tool is `_design_a2ui_surface`, not
google-adk's `render_a2ui`):
- outer `generate_a2ui` returns a `context` steering phrase — the
ms-agent-framework session does not surface the latest user message to
the secondary LLM, so the phrase becomes the inner call's
`user_content`;
- the inner `_design_a2ui_surface` fixture matches that phrase (not the
full prompt);
- `hasToolResult` discriminates outer (false) vs narration (true).
This also eliminates the stale `render-a2ui.json` "KPI dashboard"
catch-all collision that was rendering the wrong (KPI) surface for the
sales prompt.
### Root cause 2 — renderer / catalog drift
`renderers.tsx` and `definitions.ts` for ms-agent-python's
declarative-gen-ui lagged the green cluster — missing the `DataTable`
and `InfoRow` components (the `declarative-data-table` /
`declarative-info-row` testids that turns 2 and 4 assert), plus
`Metric.trendValue` and the `Row`/`Column`/`Text` gap overrides. Brought
both files to parity with the langgraph-python / google-adk green
cluster.
## Red → Green proof (real control-plane surface)
`SHOWCASE_ISO_SLOT=11 ./bin/showcase test
ms-agent-python:declarative-gen-ui --d6 --isolate`
| | result |
|---|---|
| **RED** (pristine fixture + stale renderers) |
`d6:ms-agent-python/gen-ui-declarative = red` — exit 1, turn 1
`surface-missing` |
| **GREEN** (fix applied) | `d6:ms-agent-python/gen-ui-declarative =
green` — exit 0, `1 passed` |
## Visual verification
Drove all 4 turns via Playwright (header-injected `x-aimock-context:
ms-agent-python` to replicate the harness/production proxy). Confirmed
real painted surfaces:
- **turn 1 sales-dashboard**: 4 KPI metrics ($4.2M revenue, 186
customers, 31% win rate, $22.6k deal) + Revenue-by-Region pie +
Monthly-Revenue bar
- **turn 2 team-performance**: rep-quota `DataTable` + attainment
`BarChart`
- **turn 3 at-risk**: 3 `StatusBadge` severity cards + KPI metric strip
- **turn 4 top-account**: 7 `InfoRow` account facts + product-line
`PieChart`
Screenshots captured under
`~/.local/share/copilotkit/cr/2ndwave-shots/mspy-turn{1..4}-*.png`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
||
|
Jordan Ritter
|
c01bde3759 |
fix(showcase): flip mastra gen-ui-declarative D6 cell green (#6052)
## What
Flips the `d6:mastra/gen-ui-declarative` showcase cell from **red** to
**green**.
The cell failed turn 1 with `reason=surface-missing` (the dom-missing
family). Reading the real failure surface (aimock logs + mastra
container logs + harness worker logs) exposed **three** distinct
defects, each fixed at its own layer.
## Root cause (empirically confirmed)
1. **Stale aimock fixture.** `aimock/d6/mastra/gen-ui-declarative.json`
carried the OLD D5 pill prompts (`"Show me a quick KPI dashboard"`,
`"pie chart of sales by region"`, ...) and the stale inner tool name
`_design_a2ui_surface`. The current D6 driver sends 4 different prompts,
so aimock matched **0** fixtures:
```
[aimock] STRICT: No fixture matched for POST /v1/responses (x2 = the
two-stage flow's outer + inner calls)
```
Nothing emitted → no render → `surface-missing`.
2. **Mastra outer-tool arg schema (mastra-specific).** Unlike the green
`google-adk` peer whose outer `generate_a2ui` takes `{}`, mastra's
`generateA2uiTool` (`integrations/mastra/src/mastra/tools/index.ts`) has
an `inputSchema` that **requires a `messages` array**. After
re-authoring the fixture to the green shape (which emits `generate_a2ui`
with `{}`), the mastra runtime rejected it:
```
Tool input validation failed for generate_a2ui — messages: Required.
Provided arguments: {}
```
The outer tool never executed → no `a2ui_operations` container →
`surface-missing` (narration bubble rendered, but no A2UI surface).
3. **Renderer testid parity.** The D6 probe DOM-asserts
`declarative-data-table` (turn 2) and `declarative-info-row` (turn 4).
Mastra's `renderers.tsx` had **no DataTable renderer at all** and its
InfoRow renderer **lacked the `data-testid`**; `definitions.ts` had no
DataTable definition. Turns 2 and 4 could never satisfy their
assertions.
## Fix (3 files)
- **`aimock/d6/mastra/gen-ui-declarative.json`** — re-authored to the
current 4 driver prompts + the green two-stage shape (outer
`generate_a2ui` + inner forced `render_a2ui`, `context: "mastra"`,
`catalogId: "declarative-gen-ui-catalog"`, per-pill narration). Each
outer `generate_a2ui` call now carries a valid `messages` array (mastra
schema requirement).
- **`integrations/mastra/.../a2ui/definitions.ts`** — added the
`DataTable` catalog definition (mirrors the green `google-adk` peer).
- **`integrations/mastra/.../a2ui/renderers.tsx`** — added
`data-testid="declarative-info-row"` to the InfoRow renderer, and added
a `DataTable` renderer carrying `data-testid="declarative-data-table"`.
## Red → Green proof (real control-plane surface, slot 13, `--rebuild`)
Command: `SHOWCASE_ISO_SLOT=13 ./bin/showcase test
mastra:declarative-gen-ui --d6 --isolate --rebuild`
**RED (pristine main):**
```
✗ d6:mastra/gen-ui-declarative red — state=red
turn 1 did not complete within 90000ms (reason=surface-missing)
```
**GREEN (fixed):**
```
✓ d6:mastra/gen-ui-declarative green
1 passed
[conversation-runner] turn 1/4 — assertions passed (metric x4, pie, bar; baseline 0)
[conversation-runner] turn 2/4 — assertions passed (data-table NEW, bar)
[conversation-runner] turn 3/4 — assertions passed (status-badge x3, metric x3)
[conversation-runner] turn 4/4 — assertions passed (info-row NEW, pie)
[conversation-runner] conversation completed successfully { turnsCompleted: 4 }
```
## Visual evidence
Drove the live cell through all 4 turns via Playwright (route-level
`x-aimock-context` injection) and screenshotted each painted surface —
all real renders, no error states:
- **turn 1** sales-dashboard: 4 KPI metric tiles + donut PieChart
(Revenue by Region) + BarChart (Monthly Revenue)
- **turn 2** team-performance: DataTable (Rep attainment: Dana Whitfield
124%, ...) — the new renderer
- **turn 3** at-risk: 3 severity cards each with a StatusBadge + 3 KPI
metric tiles
- **turn 4** top-account: Card of InfoRow facts (Owner/Region/ARR/...) +
PieChart — the new testid
Note: `google-adk` remains the only D6 declarative fixture already on
the current prompts; the other integrations (`langgraph-typescript`,
etc.) still carry the same stale-fixture shape and are a follow-up wave.
|
||
|
Jordan Ritter
|
45cdc02ee0 |
fix(showcase): re-author langroid declarative gen-ui to the two-stage A2UI north-star (D6 turn-1 surface-missing)
The langroid `declarative-gen-ui` D6 cell was red at turn 1 with
`reason=surface-missing`: the demo was still on the pre-D6 (D5-era) shape
while the google-adk / strands siblings had moved to the two-stage
dynamic-schema A2UI pattern. Four independent defects each blocked the
surface from painting; all four are fixed here to bring langroid to
sibling parity.
Root causes (each verified against a live isolated stack):
1. Stale suggestions + fixtures. `suggestions.ts` still offered the old
D5 pills ("Show a KPI dashboard", "pie chart of sales by region", …)
and `aimock/d6/langroid/gen-ui-declarative.json` only mocked those old
prompts. The D6 driver sends the four current business-question pills
("Show me my sales dashboard for this quarter.", etc.). Re-authored both
to the four current prompts, mirroring the google-adk north-star
(outer `generate_a2ui` no-arg → inner forced `render_a2ui` → outer
narration, three fixtures per pill).
2. Required `context` on the outer tool. `GenerateA2UITool.context` was a
required pydantic field, so the mocked outer call's `arguments: {}`
raised `ValidationError` before the tool could run — no inner call, no
surface. Made it optional (default "") to match the no-arg sibling tools.
3. Legacy functions API hid the inner tool from aimock's matcher. The
inner planner call used langroid's `functions=`/`function_call=` (legacy
OpenAI) path; aimock's `toolName` matcher only inspects the modern
`tools[]` array, so the inner `render_a2ui` fixture never matched and the
call fell through to the outer `generate_a2ui` fixture (empty surface,
wrong catalogId). Switched the inner call to the modern
`tools=`/`tool_choice=` API via a new `_RENDER_A2UI_TOOL_SPEC`. The
response extractor already reads the modern `oai_tool_calls` path first.
4. Inner call could not be discriminated per pill. langroid has no
framework middleware to forward the run's conversation into the inner
call (unlike ag_ui_adk / ag_ui_strands), so its inner user message was a
fixed generic string across all four pills. Added an explicit
last-user-turn thread (ContextVar set by the adapter, consumed by the
planner) so the pill prompt rides as the inner `userMessage` — the same
discriminator the sibling fixtures rely on.
Renderer/catalog parity: added the missing `declarative-info-row` testid
to InfoRow (turn 4) and a full `DataTable` definition + renderer
(`declarative-data-table`, turn 2), plus `trendValue` on Metric. Added
`sales-context.ts` (byte-identical dataset + composition rules to the
strands/google-adk siblings) and wired it via `chat.tsx`.
Red-green (isolated control-plane, slot 16):
- RED (3 runs, pre-fix): `d6:langroid/gen-ui-declarative` red,
turn-1 surface-missing.
- GREEN (2 runs, post-fix, --rebuild): 4/4 turns pass. aimock journal
confirms all four pills' outer `generate_a2ui` + inner `render_a2ui`
calls return 200 and emit the correct `declarative-gen-ui-catalog`
surfaces. Backend SSE verified per turn: turn-1 4 metrics + pie + bar,
turn-2 DataTable, turn-4 7 InfoRows.
|
||
|
Jordan Ritter
|
bf75022c78 |
fix(showcase): repair ms-agent-dotnet D6 gen-ui-declarative (surface-missing)
The D6 e2e-full probe d6:ms-agent-dotnet/gen-ui-declarative failed at turn 1 with reason=surface-missing. Two root causes fixed at the layer the real captured backend behaviour revealed. Root cause 1 - stale aimock fixture. The fixture still carried the old D5 pill prompts (KPI/pie/bar/status) plus a lone outer generate_a2ui entry for the sales-dashboard prompt with no matching inner _design_a2ui_surface, so turn 1 never produced a surface. Re-authored to the current 4 VantageThreads sales prompts mirroring the llamaindex/ms-agent-python green north-stars for this _design_a2ui_surface backend family (outer generate_a2ui returns a context steering phrase; the inner _design_a2ui_surface fixture matches that phrase). Unlike llamaindex/ms-agent-python, the ms-agent-dotnet ChatClientAgent session ACCUMULATES prior-turn tool results into each subsequent turn's request, so hasToolResult is true from turn 2 onward and cannot discriminate outer vs narration (turn 2+ would short-circuit straight to narration, no surface). The narration is therefore keyed on the CURRENT turn's outer toolCallId (aimock only matches toolCallId when the LAST message is that tool result) and ordered before the outer per pill so the tool-result turn resolves to narration while the user-message turn resolves to the outer. Root cause 2 - renderer/catalog drift. The declarative catalog lagged the green cluster: InfoRow was missing its declarative-info-row testid (turn 4) and DataTable was absent entirely (turn 2). Added the testid and the DataTable renderer + definition, matching the green cluster. Red -> Green (real control-plane, --isolate --rebuild): RED: d6:ms-agent-dotnet/gen-ui-declarative = red (turn 1 surface-missing) GREEN: d6:ms-agent-dotnet/gen-ui-declarative = green (1 passed) Visual: drove all 4 turns via Playwright (X-AIMock-Context: ms-agent-dotnet) - turn 1 4 KPI metrics + region pie + monthly bar - turn 2 rep-quota DataTable + attainment bar - turn 3 3 severity StatusBadges + KPI metric strip - turn 4 7 account InfoRows + product-line pie |
||
|
Jordan Ritter
|
adc897f485 |
fix(showcase): repair ms-agent-harness-dotnet D6 gen-ui-declarative (surface-missing)
The D6 e2e-full probe `d6:ms-agent-harness-dotnet/gen-ui-declarative`
failed at turn 1 with `reason=surface-missing`. Three layers, all fixed
at the layer the real captured request revealed.
Root cause 1 — stale aimock fixture
The fixture still carried the old D5 pill set (KPI / pie / bar / status
prompts) with inner `_design_a2ui_surface` entries keyed on those stale
prompts. The current driver sends four VantageThreads sales prompts, so
turn 1 ("Show me my sales dashboard for this quarter.") had no matching
inner surface — the backend looped `generate_a2ui` to its limit and the
frontend painted the stale KPI catch-all instead of the sales dashboard.
Re-authored to the four current prompts, mirroring the llamaindex green
north-star for this `_design_a2ui_surface` two-stage backend family.
Root cause 2 — `hasToolResult` breaks the interleaved thread
Unlike ms-agent-python (fresh session per turn), the .NET harness backend
threads the FULL interleaved conversation. `hasToolResult` is a
thread-global predicate (GOTCHAS.md), so once turn 1 leaves a tool result
in the thread, every later pill's outer `generate_a2ui` call sees
`hasToolResult:true` and matches the narration fixture instead of emitting
the tool call — surface-missing on turns 2-4. Switched to the sanctioned
interleaved-safe pattern: narration keyed on this pill's outer
`toolCallId` (ordered before the outer), outer keyed on `userMessage`
only.
Root cause 3 — renderer / catalog drift
`renderers.tsx` and `definitions.ts` lagged the green cluster — missing
the `DataTable` and `InfoRow` testids (`declarative-data-table` turn 2 /
`declarative-info-row` turn 4) plus `Metric.trendValue` and the
Row/Column/Text gap overrides. Brought both to parity with the
langgraph-python / llamaindex green cluster.
Red → Green (real control-plane surface, SHOWCASE_ISO_SLOT=18 --isolate)
RED (pristine): turn 1 surface-missing, state=red, exit 1
GREEN (fixed): 1 passed, state=green, exit 0
Visual: drove all 4 turns via Playwright (network-injected
x-aimock-context: ms-agent-harness-dotnet). Confirmed real painted
surfaces — turn 1 sales dashboard (4 KPIs + region pie + monthly bar),
turn 2 rep-quota DataTable + attainment bar, turn 3 three at-risk status
badges + KPI strip, turn 4 seven account InfoRows + product-line pie.
Screenshots under ~/.local/share/copilotkit/cr/2ndwave-shots/.
|
||
|
Jordan Ritter
|
92be110c62 |
fix(showcase): repair claude-sdk-typescript D6 gen-ui-declarative (surface-missing)
The claude-sdk-typescript declarative-gen-ui cell was red on turn-1 surface-missing: the aimock fixture carried stale D5-era prompts (KPI dashboard / pie / bar / status report) and only a partial turn-1 outer entry, so the two-stage Anthropic A2UI flow (outer generate_a2ui -> secondary render_a2ui -> narration) never painted a surface for the four current sales-analyst pills. Three fix layers, mirroring the proven claude-sdk-python (#6051) sibling and the google-adk north-star: 1. Re-author aimock/d6/claude-sdk-typescript/gen-ui-declarative.json to the 4 current driver prompts in the two-stage shape (12 fixtures = 4 pills x {outer generate_a2ui, inner render_a2ui, narration}), with render payloads mounting the per-pill catalog components the driver asserts (Metric x4 + Pie + Bar; DataTable + Bar; Metric x3 + StatusBadge x3; InfoRow + Pie). Render payloads are byte-identical to the #6051 data. Ordering/matcher fix vs the naive python mirror: the CSTS runtime accumulates full conversation history across pills, so on turns 2-4 the outer generate_a2ui call carries prior pills' tool results and a hasToolResult:false matcher never fires. Each pill triad is ordered narration (toolCallId) FIRST so it claims the last-role:tool calls, and the outer matcher drops hasToolResult and gates on userMessage + toolName generate_a2ui (last-role:user). 2. Add data-testid="declarative-info-row" to the InfoRow renderer (turn-4 top-account parity; CSTS was missed by #6050). 3. Refresh suggestions.ts to the 4 sales-analyst pills (were stale D5-era labels that emitted unmatched prompts -> live 404 banner). Red-green (control-plane, slot 30, --isolate --rebuild): - RED (origin/main): d6:claude-sdk-typescript/gen-ui-declarative red; aimock STRICT: No fixture matched for POST /v1/messages. - GREEN (fixed): 1 passed; aimock journal shows all 12 calls 200, zero 503/no-match across all 4 turns. Visual: Playwright 4-turn walk (x-aimock-context claude-sdk-typescript) confirms metric=4/pie=1/bar=1 (t1), data-table=1/bar+1 (t2), status-badge=3/metric+3 (t3), info-row=7/pie+1 (t4); no fixture error. Unit: aimock-fixtures 837 passed; d5-gen-ui-declarative 31 passed. |
||
|
Jordan Ritter
|
3370a452b5 |
fix(showcase): flip agno gen-ui-declarative D6 cell green (4-turn sales flow + DataTable/InfoRow parity)
agno's declarative-gen-ui D6 cell failed turn-1 dom-missing: the aimock fixture was keyed on the stale D5 prompts (KPI/pie/bar/status) while the current driver sends the OSS-136 sales prompts, so the agno OUTER agent's generate_a2ui call matched no fixture, aimock returned 503 (strict), and no surface rendered. Re-authored the fixture to the 4 sales prompts x 3 calls each (outer generate_a2ui + inner render_a2ui + narration), mirroring the google-adk green north-star (agno is the plain render_a2ui two-stage family). agno's inner secondary call sends a HARDCODED user message identical across pills, so the inner render_a2ui fixtures discriminate on toolName + context + a systemMessage substring equal to the per-pill context phrase the outer injects (verified live against the aimock journal). Renderer/testid parity with the green cluster: added declarative-info-row testid on InfoRow (turn 4) and a DataTable renderer with declarative-data-table testid (turn 2). definitions.ts gains DataTable, Metric.trendValue, and an z.unknown() PrimaryButton action. Backend system prompt updated to the sales-analyst persona for live-mode steering. Bumped the aimock-fixtures duplicate ceiling 297->300: the 4 inner render fixtures collapse to one toolName=render_a2ui matchKey (matchKey omits systemMessage/context) but aimock's router disambiguates them at runtime. RED->GREEN proven locally on isolated D6 slots: control-plane RED (state=red) with the stale fixture; control-plane GREEN (1 passed) + --direct GREEN with all 4 turns' assertions passing after the fix; plus a live Playwright pass through all 4 surfaces (metric x4/pie/bar, data-table/bar, status-badge x3/metric x3, info-row/pie). |
||
|
Jordan Ritter
|
ece15c1016 |
fix(showcase): repair ms-agent-python D6 gen-ui-declarative (surface-missing)
The D6 e2e-full probe for ms-agent-python:gen-ui-declarative failed at turn 1 with reason=surface-missing. Two root causes, both fixed: 1. Stale aimock fixture. The fixture still carried the old D5 pill prompts (KPI/pie/bar/status) plus a lone outer generate_a2ui entry for the current sales-dashboard prompt with no matching inner _design_a2ui_surface or narration. The backend looped generate_a2ui to its invocation limit and RUN_FINISHED was blocked while the tool call stayed active. Re-authored to the current 4 VantageThreads sales prompts mirroring the llamaindex green north-star for this backend shape: the outer generate_a2ui returns a `context` steering phrase (the ms-agent-framework session does not surface the latest user message to the secondary LLM), the inner _design_a2ui_surface fixture matches that phrase (not the full prompt), and hasToolResult discriminates outer vs narration. This also avoids the stale render-a2ui "KPI dashboard" catch-all collision that was rendering the wrong surface. 2. Renderer/catalog drift. ms-agent-python's declarative-gen-ui renderers.tsx and definitions.ts lagged the green peers — missing the DataTable and InfoRow components (declarative-data-table / declarative-info-row testids) that turns 2 and 4 assert, plus Metric trendValue and the Row/Column/Text gap overrides. Brought both files to parity with the langgraph-python / google-adk green cluster. Red-green proof on the real control-plane surface (SHOWCASE_ISO_SLOT=11, --d6 --isolate): - RED: d6:ms-agent-python/gen-ui-declarative = red (exit 1, turn 1 surface-missing) - GREEN: d6:ms-agent-python/gen-ui-declarative = green (exit 0, 1 passed) Visually verified all 4 turns via Playwright (header-injected to replicate the harness x-aimock-context): turn 1 renders 4 KPI metrics + region pie + monthly bar; turn 2 the rep-quota DataTable + attainment bar; turn 3 three at-risk StatusBadges + KPI metrics; turn 4 seven InfoRow account facts + product-line pie. |
||
|
Jordan Ritter
|
4440e727af |
fix(showcase): flip mastra gen-ui-declarative D6 cell green
The mastra declarative-gen-ui D6 cell failed turn 1 with reason=surface-missing.
Three defects fixed at the layers the real failure surface showed:
1. Stale aimock fixture: aimock/d6/mastra/gen-ui-declarative.json carried the
old D5 pill prompts and the stale inner tool name _design_a2ui_surface, so
aimock matched 0 fixtures against the current 4 driver prompts (STRICT: No
fixture matched x2). Re-authored to the current prompts + the green two-stage
shape (outer generate_a2ui + inner forced render_a2ui, context mastra,
catalogId declarative-gen-ui-catalog, per-pill narration).
2. Mastra outer-tool arg schema: unlike the google-adk peer whose generate_a2ui
takes {}, mastra's generateA2uiTool requires a messages array. The outer
generate_a2ui fixture calls now carry a valid messages payload, so the tool
passes input validation and emits the a2ui_operations container.
3. Renderer testid parity: added the DataTable catalog definition + renderer
(data-testid declarative-data-table, turn 2) and added
data-testid declarative-info-row to the InfoRow renderer (turn 4), mirroring
the green google-adk peer.
Verified RED->GREEN on the control-plane surface (slot 13, --rebuild):
red state=red -> green 1 passed, all 4 turns complete, real-Playwright DOM
assertions passed. Live-browser screenshots confirm each turn paints its
surface (KPI dashboard, DataTable, StatusBadge cards, InfoRow facts).
|
||
|
Jordan Ritter
|
c5ad5caefd |
fix(showcase): complete claude-sdk-python declarative gen-ui D6 (4-turn sales flow + DataTable/InfoRow parity)
The claude-sdk-python gen-ui-declarative D6 cell went red with reason=done-signal-missing: the aimock fixture still carried the legacy D5 pills (KPI/pie/bar/status) plus a single stray hero `generate_a2ui` entry, so the current 4-prompt sales-analyst driver (Show me my sales dashboard / How are reps performing / accounts at risk / biggest account) had no matching fixtures. aimock STRICT mode 404'd the unmatched outer and inner Claude calls, so the run never emitted the expected render per turn. Two-part fix: - Re-author aimock/d6/claude-sdk-python/gen-ui-declarative.json into the two-stage Anthropic-transport shape (mirrors the claude-sdk-typescript sibling + google-adk data): per turn (a) outer generate_a2ui emit matched by userMessage+toolName+hasToolResult, (b) inner render_a2ui design matched by toolName, (c) outer narration matched by toolCallId. Covers all 4 current sales prompts. - Renderer/definition parity: add the DataTable catalog component (definition + renderer, testid declarative-data-table) that turn 2 requires, and add the missing declarative-info-row testid to the InfoRow renderer that turn 4 requires. Both were absent on claude-sdk-python (present on google-adk). Local red-green proof (control-plane, slot 12, --isolate --rebuild): - RED (pristine): d6:claude-sdk-python/gen-ui-declarative = red, aimock log 'STRICT: No fixture matched for POST /v1/messages'. - GREEN (fixed): d6:claude-sdk-python/gen-ui-declarative = green, 1 passed, zero aimock no-match. Visual verify (Playwright, harness X-AIMock-Context header): all 4 turns paint with correct per-testid deltas (metric x4/pie/bar; data-table/bar; status-badge x3/metric x3; info-row/pie). |
||
|
Jordan Ritter
|
6d09233fc6 |
fix(showcase): add declarative-info-row testid to 3 lagging integrations for turn-4 parity (#6050)
## What
The `gen-ui-declarative` D6 probe drives a 4-turn conversation. Turn 4
(the **top-account** pill — "Pull up the details on our biggest
account.") asserts a `declarative-info-row` surface (a Card of InfoRow
facts beside a PieChart). Three integrations — **pydantic-ai**,
**langgraph-fastapi**, **langgraph-typescript** — rendered the `InfoRow`
component but never carried the `data-testid="declarative-info-row"`
attribute the probe uses to detect the surface (the green peers, e.g.
langgraph-python, already have it). Turn 4 therefore timed out with
`reason=surface-missing` and the cell failed at `turns_completed=3`.
## Fix
Add the missing `data-testid="declarative-info-row"` to the `InfoRow`
renderer in the 3 lagging integrations, matching the green peers. 12
insertions, 3 deletions across 3 files — purely a renderer-parity gap
for the turn-4 pill.
**ButtonProps note:** No `onClick`/TS2322 change was needed.
`PrimaryButton` already dispatches actions via `dispatch(props.action)`,
and the local `_components/button.tsx` `ButtonProps extends
React.ButtonHTMLAttributes<HTMLButtonElement>`, so `onClick` is valid.
Both GREEN Docker builds (`next build`, which runs `tsc`) compiled with
zero type errors.
## Local RED → GREEN proof (real surface, D6 control-plane, isolated
slots)
Base: `origin/main` (
|
||
|
Jordan Ritter
|
64b1409289 |
fix(showcase): add declarative-info-row testid to 3 lagging integrations for turn-4 parity
The gen-ui-declarative D6 probe drives a 4-turn conversation; turn 4 (the "top-account" pill) asserts a `declarative-info-row` surface (a Card of InfoRow facts next to a PieChart). pydantic-ai, langgraph-fastapi, and langgraph-typescript rendered the InfoRow component but never carried the `data-testid="declarative-info-row"` attribute that the probe (and the green peer integrations such as langgraph-python) rely on to detect the surface. As a result turn 4 timed out with reason=surface-missing and the cell failed at turns_completed=3. This restores parity with the green peers by adding the missing testid to the InfoRow renderer in the 3 lagging integrations. No other behavior changes; PrimaryButton already wires actions via the `dispatch(props.action)` pattern (the local ButtonProps extends ButtonHTMLAttributes, so onClick is valid — no type error). |
||
|
Jordan Ritter
|
ced494da85 |
fix(showcase): bound claude-sdk-python declarative gen-ui loop so RUN_FINISHED fires (#6042)
## What
Fixes the claude-sdk-python **declarative-gen-ui** class-F failure (RCA
2026-07-17): the dashboard renders but `RUN_FINISHED` never arrives, so
the harness times out with `done-signal-missing`.
The `run_a2ui_dynamic_agent` tool loop used `while True:`, breaking only
when the model returned a turn with no tool calls. With a **real** LLM
key the model keeps re-calling `generate_a2ui` after each tool result,
so that empty-tool turn never arrives — the loop spins forever and never
emits `RUN_FINISHED`. (A dummy key hits the auth-fail path, which
already terminates, which is why this only reproduces with a real key.)
**Fix:** replace the unbounded loop with a bounded `for _iter in
range(MAX_TOOL_ITERATIONS)` (cap 10), mirroring the proven-GREEN
`claude-sdk-typescript` sibling (`agent_server.ts`
`MAX_TOOL_ITERATIONS`). The loop now always falls through to
`RUN_FINISHED`.
## Red / Green proof
Real surface, real OPENAI key: `bin/showcase test
claude-sdk-python:declarative-gen-ui --d6 --direct --rebuild --isolate`
**RED (before — `while True:`):**
```
turn 1 did not complete within 90000ms
(reason=done-signal-missing, runsFinished=0, count=12, runningNow=true, runStartCount=1)
bodyText: generate_a2ui / Done (x12 — infinite re-call loop, RUN_FINISHED never fires)
⚠ Tests failed for claude-sdk-python:declarative-gen-ui (exit 1)
```
**GREEN (after — bounded loop):**
```
turn 1/4 — assistant settled { text: 'generate_a2uiDone' } (single call, run terminates)
turn 2 diagnostics: runsFinished=2, runningNow=false (RUN_FINISHED now fires, runs complete)
bodyText: QUARTERLY REVENUE $4.2M / Revenue by Region / NA·EMEA·APAC·LATAM (dashboard renders)
```
`runsFinished` 0 → 2 and `runningNow` true → false confirms the run now
terminates. The class-F hang is fixed.
## Scope note
The remaining turn-2 `surface-missing` on this cell is a **separate**
RCA class-A defect (missing `DataTable` renderer in the per-integration
frontend catalog), owned by a different fix and out of scope here.
|
||
|
Jordan Ritter
|
e3b3d2f14c |
fix(showcase): pin ANTHROPIC_BASE_URL aimock serviceRef for claude-sdk-python (SSOT drift-proof)
The claude-sdk-python agent routes its LLM traffic through ANTHROPIC_BASE_URL (see src/agents/claude_agent_sdk_adapter.py and the aimock-wiring probe's claude-sdk pattern), but the railway-envs SSOT only declared an OPENAI_BASE_URL serviceRef. Add the ANTHROPIC_BASE_URL -> aimock serviceRef so the Stage-2 Ruby promote preflight asserts it prod->prod (never copies) and refuses a cross-env leak. The var is already set correctly on the live service; this is SSOT hygiene that makes the pin drift-proof. Regenerated railway-envs.generated.json via the repo generator (oxfmt-canonical, emit --check clean). |
||
|
Jordan Ritter
|
81410e0c2c |
fix(showcase): bound claude-sdk-python declarative gen-ui agent loop so RUN_FINISHED always fires
The a2ui_dynamic declarative agent drove its tool loop with `while True:`, breaking only when the model returned a turn with no tool calls. With a real LLM key the model keeps re-calling `generate_a2ui` after each tool result, so that empty-tool turn never arrives — the loop spins forever, RUN_FINISHED is never emitted, and the harness times out with `done-signal-missing` (the run hangs after the A2UI render). Replace the unbounded loop with a bounded `for _iter in range(MAX_TOOL_ITERATIONS)` (cap 10), mirroring the proven-GREEN claude-sdk-typescript sibling. The loop now always falls through to RUN_FINISHED, so the run terminates after the render. Only reproduces with a real key: a dummy key hits the auth-fail path, which already terminates. |
||
|
Jordan Ritter
|
2b9c3fe779 |
fix(showcase): add declarative DataTable renderer to 4 missing integrations
Commit
|
||
|
Jordan Ritter
|
2d7dbecb47 |
fix(showcase): rewrite gen-ui-agent probe to per-pill content assertion
The previous probe relied on a fragile cross-pill-difference heuristic: it fingerprinted the rendered step text and used inter-pill differences as a settling signal, accepting any render with >=2 rows at the deadline. That heuristic false-greened a real pill-3 stale-card regression, because a stale render (pill 3 still showing pill 1's content) still satisfied ">=2 rows present" and the dedup was only a wait mechanism, never a hard gate. This rewrites the assertion to check EXPECTED CONTENT per pill. Each pill carries a small set of low-brittleness content markers derived from its step titles in the d5 fixture (product-launch -> launch/marketing, team-offsite -> venue/agenda, competitor-research -> competitor/weakness). The assertion polls the swap window until the card shows >=2 NON-EMPTY step rows whose joined text contains ALL of that pill's markers; otherwise it hard-fails. Marker matching is partial and case-insensitive so it stays robust to live-LLM (--direct) nondeterminism while still proving the RIGHT pill's content rendered. Verified with a dynamic-fake red-green plus three retained false-green guards: identical-across-pills canned steps, stale non-adjacent content (pill 3 showing pill 1), and empty/whitespace-only rows all turn RED; distinct-per-pill content passes. NOTE: this EXPOSES a genuine pill-3 stale-state regression on agno/langroid/crewai-crews. Those cells are legitimately RED under the corrected probe until that backend/frontend bug is fixed (separate follow-up). The langgraph-python reference passes. |
||
|
Aria Zhao
|
e5c1af418a |
fix(react-core): expose isReady from useAgent so subscriptions can target the real agent (#5000)
`useAgent` always returns a fully-constructed `AbstractAgent`: a provisional stand-in while the runtime is still connecting (or in an error state), swapped for the real agent once the `/info` sync resolves. The returned type claimed `agent` was always the real agent, giving consumers no way to tell the two apart — so one-time subscriptions (e.g. `onRunFinalized`) registered during the provisional window landed on the placeholder and missed events until the effect re-ran after the swap. Add an `isReady` flag to the return value: `false` while the agent is provisional, `true` once the real (or locally-registered) agent is bound. Additive and backward compatible. Also fix the docs' "Event Subscription" example, which used an empty `useEffect` dependency array and therefore never re-subscribed when the agent reference changed. Note: the original crash from #5000 ("Cannot read properties of undefined (reading 'subscribers')") no longer reproduces on `main` — the provisional-agent work (#5533/#5635) guarantees a fully-constructed agent, so `subscribe()` is always safe. The added tests lock in that no-crash behavior and cover the new `isReady` transition. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Jordan Ritter
|
d9ac09f83c |
fix(harness): exclude starter-* and harness-workers from aimock-wiring probe
The aimock_wiring:global probe went red on the residual-6 live services (harness-workers + 5 starters). Root cause is EXCLUDE naming drift after the egress/private-networking migration: EXCLUDE_SERVICES keyed starters as showcase-starter-<framework> (matching only starter-<framework>), but live Railway names are bare starter-<framework>[-lang] (e.g. starter-strands-python, starter-langgraph-js) — no match, so they fell through to being checked, landed in unwired, and kept the probe red. harness-workers had no exclude entry at all. Fix: exclude the whole starter-* family by prefix in isExcluded (starters are contributor scaffolds, categorically not wired through aimock; safe because no showcase-* backend name starts with starter-, so it never over-excludes a real backend), and add bare harness-workers to the infra exclude set. Superseded showcase-starter-* literals removed; inert showcase-shell-* legacy literals retained to keep the diff minimal. The 20 showcase-* LLM backends were already re-wired via Railway AIMOCK_URL; this is a naming/exclusion fix only (no starter is repointed). |
||
|
Benjamin Taylor
|
a6768cf1e6 |
docs: add Thread & History Lifecycle to docs-render expected nav order
The new Threads page shifts the expected navigation order; update the expected array in docs-render.test.ts to include "Thread & History Lifecycle" after "Overview" so the shell-docs suite passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Benjamin Taylor
|
fa319dffe5 |
docs: address CR on threads-lifecycle guide (agentId prop, per-framework nav, persistence caveat)
Addresses samjulien's review on #5988: - Use `agentId` (not `agent`) in both <CopilotChat> snippets — `agent` is not a v2 prop. - Add threads-lifecycle to every authored-framework Threads nav group (built-in-agent, mastra, crewai-flows, llamaindex, agno, ag2, pydantic-ai, microsoft-agent-framework, deepagents). Extracted the page body into a shared snippet and made the root + per-framework pages thin wrappers, matching the existing threads/headless-threads/threads-import single-source convention. - Qualify the "Run" glance statement: server-side persistence/replay depends on a configured store (Enterprise Intelligence or a persisting AgentRunner); a runtime with no persistence layer keeps nothing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Alem Tuzlak
|
06f331b9a2 |
docs(channels): add Channels SDK documentation
Documents the channels SDK across Slack, Teams, WhatsApp, Telegram, and Discord. |
||
|
Benjamin Taylor
|
4278cec65a |
merge main; resolve nav conflict + repoint links to restructured threads docs
- meta.json: keep main's Threads nav group and slot `threads-lifecycle` in after the `threads` overview. - threads-lifecycle.mdx: main split the old `/threads` page into a `threads` overview + a `headless-threads` how-to; repoint the two "Headless Threads" links from `/threads` to `/headless-threads`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Jordan Ritter
|
c51b84a349 |
fix(showcase): offload sync LLM calls off showcase agent event loops (claude-sdk-python, ag2, llamaindex) (#5997)
## What The `claude-sdk-python` showcase agent `:8000` wedges under D6/LLM load: two **synchronous** `anthropic.Anthropic().messages.create()` calls run directly on the uvicorn asyncio event loop, freezing it for the full LLM round-trip so `/health` stops answering. The watchdog counts 3 consecutive failures (~90s) and kill-restarts the container, dropping active sessions. This is the pre-existing root cause behind the #oss-alerts restart noise that #5987's alerting surfaced (it was never a #5987 regression). ## Root cause (sync-in-async) All in `integrations/claude-sdk-python/`: - **`src/agents/agent.py`** — `_execute_tool`'s `generate_a2ui` branch builds a sync `anthropic.Anthropic()` and calls `client.messages.create()` synchronously. `_execute_tool` is a sync callback invoked on the loop from **two** async callers: `run_agent`'s agentic loop, and the Claude-Agent-SDK MCP tool handler in `claude_agent_sdk_adapter.py`. - **`src/agents/a2ui_dynamic.py`** — `_generate_a2ui`, same sync pattern, invoked on the loop from the `run_a2ui_dynamic_agent` generator. ## Fix — approach (a): `await asyncio.to_thread(...)` at the call sites Chosen over approach (b) (`AsyncAnthropic` + `async def`) because it is the **lowest blast radius**: the sync functions and the shared `ExecuteTool` callback type stay unchanged, and wrapping at the call sites fixes the **whole** tool-dispatch path uniformly (any current or future sync tool in the dispatcher), not just `generate_a2ui`. Approach (b) would only fix `generate_a2ui` unless `_execute_tool` were made fully async — which ripples into the `ExecuteTool` type and both call sites anyway. Every occurrence fixed (file:line): - `src/agents/agent.py:~1355` — `run_agent` call site → `await asyncio.to_thread(_execute_tool, ...)` - `src/agents/claude_agent_sdk_adapter.py:~152` — MCP `sdk_tool_handler` → `await asyncio.to_thread(execute_tool, ...)` - `src/agents/a2ui_dynamic.py:~287` — secondary call site → `await asyncio.to_thread(_generate_a2ui, ...)` Whole-integration grep for the pattern (`anthropic.Anthropic(`, sync `.messages.create`, `OpenAI(`, `time.sleep`, blocking I/O): only these two sites existed. Every other agent in the integration already uses `AsyncAnthropic`. ## Showcase parity verdict `a2ui_dynamic.py` is **per-integration**, not shared. Each framework (langgraph-python, llamaindex, ms-agent-python, pydantic-ai, ag2, strands, agno, …) ships its own copy that "mirrors" langgraph-python but uses that framework's own client. Only claude-sdk-python's copy used the sync `anthropic.Anthropic()` pattern, so **blast radius is claude-sdk-python only** — no other integration has this wedge. The `tools` symlink (→ `showcase/shared/python/tools`) was **not** touched (iron-rule: edit shared source only, never symlink copies; here no shared change was needed). ## entrypoint.sh alert scoping - `:8000` agent watchdog branch: **removed** the Slack POST, **kept** the `kill -9 $AGENT_PID` self-heal. It now self-heals silently (root cause fixed). - Public `$PORT` `/api/health` branch: Slack POST to `$SLACK_WEBHOOK_OSS_ALERTS` **intact** — the public Next.js wedge still pages. ## Red → green proof Faithful harness at `showcase/tests/repro/async-wedge/`: a real `anthropic.Anthropic` sync client (real httpx transport) pointed via `ANTHROPIC_BASE_URL`/`base_url` at a controllable slow local Anthropic-compatible endpoint (`slow_anthropic.py`, `SLOW_SECONDS` latency, serves both `messages.create` JSON and `messages.stream` SSE). 5× concurrent `POST /generate`; poll `/health` 1/s for 10s; assert & exit non-zero on a false result. **Minimal replica (`server.py`) — the load-bearing construct:** ``` REPLICA RED (FIXED=0, sync client on loop): ASSERT_SUMMARY is_fixed=0 ok=6 wedge=4 → PASS RED REPLICA GREEN (FIXED=1, asyncio.to_thread): ASSERT_SUMMARY is_fixed=1 ok=10 wedge=0 → PASS GREEN ``` **Real production code (`prod_server.py`):** ``` PROD GENERATOR GREEN (real run_a2ui_dynamic_agent, fix in source): ASSERT_SUMMARY expect=green ok=10 wedge=0 → PASS GREEN (secondary sync _generate_a2ui fired 5x via to_thread; /health stayed 200) MUTATION GUARD RED (real _generate_a2ui, sync-on-loop): ASSERT_SUMMARY expect=red ok=5 wedge=5 → PASS RED (proves the harness fails on the bug) PROD DIRECT GREEN (real _generate_a2ui via to_thread): ASSERT_SUMMARY expect=green ok=10 wedge=0 → PASS GREEN ``` The mutation guard exercises the **real** production `_generate_a2ui` sync-on-loop and confirms it wedges (`wedge=5`), while the `to_thread` path stays fast-200 (`wedge=0`) — the harness is not vacuously green. ## Regression check `pytest tests/python/` → **6 passed**. `ruff format --check` clean on all 3 edited files (no new lint; the pre-existing origin/main ruff findings are untouched, out of scope). `bash -n` clean on entrypoint.sh and all repro scripts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- ## CR round 2 — repro hardening Addressed the one mandatory CR finding (M1) plus two optional items on the `showcase/tests/repro/async-wedge/` harness. **Repro-harness only — no production source touched** (`src/agents/a2ui_dynamic.py` unchanged). **M1 (mandatory) — MODE=generator false-green closed.** The GREEN lane previously asserted only `WEDGE==0`. If the mock's SSE were mis-parsed, the `generate_a2ui` tool_use dropped, or the generator early-exited, `_generate_a2ui` (the bug site) would never run, the loop would never park, and `WEDGE==0` would pass trivially — proving nothing. Fix: `prod_server.py` now wraps the real `a2ui_dynamic._generate_a2ui` with a counter (`tool_dispatch_fired`), exposed via `/stats` and the `/generate` response. `run_prod.sh` reads it after the poll window and the GREEN lane now **fails (exit 6)** unless `tool_dispatch_fired >= 1`. The counter tracks genuine execution regardless of call shape (`asyncio.to_thread` offload or sync-on-loop). **O1** — `slow_anthropic.py` now uses `await asyncio.sleep(SLOW_SECONDS)` instead of blocking `time.sleep`, so the mock's own loop stays free under concurrency. **O2** — `run.sh` adds a 0.5s gap after firing load, before the first `/health` poll, so poll 1 isn't wasted on a pre-block fast-200. Also fixed a latent hang: `run_prod.sh` ended with a bare `wait` that blocked forever on the long-lived uvicorn server jobs, so the summary/assertion never printed. It now tracks and reaps only the load-curl PIDs (bash-3.2 / `set -u` safe). ### Red-green proof (harness assertion) RED (false-green injected via `REPRO_DROP_TOOL_USE=1` — tool_use dropped, generator drains but never dispatches; env-only, no source mutation): ``` ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=0 FAIL GREEN: 0 wedges but tool_dispatch_fired=0 — _generate_a2ui never ran; WEDGE==0 is a false green (bug site never exercised) EXIT=6 ``` Old assertion (`WEDGE==0` only) would have PASSED here; hardened assertion correctly FAILS. GREEN (normal operation — tool dispatch fires): ``` ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=9 PASS GREEN: 0 wedges AND tool_dispatch_fired=9 (>=1) — real production code exercised the bug site and kept /health fast-200 under load EXIT=0 ``` ### No regression — deterministic MODE=direct mutation guard ``` MODE=direct EXPECT=red -> ASSERT_SUMMARY expect=red ok=8 wedge=2 tool_dispatch_fired=3 -> PASS RED (exit 0) MODE=direct EXPECT=green -> ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=3 -> PASS GREEN (exit 0) ``` --- ## Fold-in: ag2 + llamaindex (fleet-wide sweep) A CR flagged the same sync-LLM-on-the-event-loop wedge in two more integrations, and a fleet-wide sweep of every `integrations/*/src/**` Python file for a sync LLM `.create()` running **directly inside an `async def`** on the uvicorn loop found a THIRD previously-missed site. All three are now fixed with the same lowest-blast-radius approach (extract the blocking round-trip into a sync `_generate_a2ui`, and `await asyncio.to_thread(...)` from the async wrapper): - `integrations/ag2/src/agents/beautiful_chat.py` — `async def generate_a2ui` (sync `openai.OpenAI().chat.completions.create`) - `integrations/llamaindex/src/agents/a2ui_dynamic.py` — `async def generate_a2ui` (sync `OpenAI().chat.completions.create`) - `integrations/llamaindex/src/agents/agent.py` — `async def generate_a2ui` (sync `OpenAI().chat.completions.create`) — **found by the sweep, not in the original report** ### Fleet-sweep result (what was NOT touched, and why) - **ag2 `agent.py` + `a2ui_dynamic.py`**: already non-blocking (`await _async_openai_client.chat.completions.create`, i.e. `AsyncOpenAI`). Confirmed, not re-touched. - **agno, ms-agent-python, pydantic-ai, strands, crewai** sync `.create` sites: all inside plain `def` framework tools (`@tool`-style), which the frameworks dispatch in their own worker/executor context — never bare-`await`ed on the loop. No wedge. - **`.ts` voice routes / `agent_server.ts`**: TypeScript/Node, not the uvicorn asyncio loop. - **`llama_index.llms.openai.OpenAI(model=…)`** objects: framework-managed async LLMs, distinct from the raw `openai` SDK client at the wedge sites. So the wedge exists at exactly these three `async def generate_a2ui` sites (plus the two claude-sdk-python sites fixed above). All three edited files are per-integration REAL files (not symlinks to `showcase/shared/`) — verified per the iron rule. `ag2`/`llamaindex` `entrypoint.sh` were intentionally **not** touched — the Slack-alert scoping was specific to the claude-sdk-python incident. ### Red → green proof (real production code, deterministic) New OpenAI-SDK repro harness (dev-only, under `showcase/tests/repro/async-wedge/`, sibling of the anthropic one): a real `openai` SDK client (real httpx transport) pointed via `OPENAI_BASE_URL` at a controllable slow local OpenAI-compatible endpoint (`slow_openai.py`). `run_prod_openai.sh` drives the **real production `_generate_a2ui`** for each `TARGET`, 5× concurrent `POST /generate`, poll `/health` 1/s ×10, with the `tool_dispatch_fired >= 1` anti-false-green guard. ``` ag2-beautiful-chat RED: ASSERT_SUMMARY expect=red ok=5 wedge=5 tool_dispatch_fired=5 -> PASS RED ag2-beautiful-chat GREEN: ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=5 -> PASS GREEN llamaindex-agent RED: ASSERT_SUMMARY expect=red ok=5 wedge=5 tool_dispatch_fired=5 -> PASS RED llamaindex-agent GREEN: ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=5 -> PASS GREEN llamaindex-a2ui RED: ASSERT_SUMMARY expect=red ok=5 wedge=5 tool_dispatch_fired=5 -> PASS RED llamaindex-a2ui GREEN: ASSERT_SUMMARY expect=green ok=10 wedge=0 tool_dispatch_fired=5 -> PASS GREEN ``` Source-level cross-check driving the **real on-disk `async generate_a2ui` wrapper** directly: 5 concurrent 3s calls complete in ~3.1s (parallel offload threads, not serialized ~15s) while a bare asyncio heartbeat keeps ticking (64 ticks through the load window) — loop stays free. Negative control (ag2 wrapper temporarily reverted to sync-on-loop): 15.11s serialized, heartbeat starved to 4 ticks — wedge reproduced; source restored. Existing claude-sdk-python lanes re-run green (no regression). |
||
|
github-actions[bot]
|
8aa763aa15 | style: auto-fix formatting | ||
|
Jordan Ritter
|
bf3f327f8c |
fix(showcase): offload sync LLM calls in ag2 + llamaindex a2ui generators
A fleet-wide sweep for sync LLM .create() calls running directly inside an async def on the uvicorn event loop found three more wedge sites (same class as the claude-sdk-python fix in this PR): - integrations/ag2/src/agents/beautiful_chat.py - integrations/llamaindex/src/agents/a2ui_dynamic.py - integrations/llamaindex/src/agents/agent.py (missed by the original report) Each extracts the blocking secondary-LLM round-trip into a sync _generate_a2ui helper and offloads it via await asyncio.to_thread(...) from the async generate_a2ui wrapper (lowest blast radius; sync body unchanged). ag2's other agents already use AsyncOpenAI; all other sync .create sites are inside plain def framework tools dispatched off-loop by their frameworks, so they do not wedge. entrypoint.sh alert-scoping left untouched (claude-sdk-python-specific). Adds a dev-only OpenAI-SDK repro harness (slow_openai.py, prod_server_openai.py, run_prod_openai.sh) that drives the REAL production _generate_a2ui via a slow local OpenAI-compatible endpoint, with a tool_dispatch_fired>=1 anti-false-green guard. RED (sync-on-loop) -> GREEN (to_thread) verified for all three sites. |
||
|
Sam Julien
|
a010f33994 |
docs(shell-docs): add Threads overview (#5947)
## Summary
- turn `/threads` into a product-oriented overview that explains why
developers use CopilotKit Threads and routes them by job to Drawer,
Headless, import, architecture, and deployment docs
- label the overview as `Overview` in the Threads navigation while
retaining `Threads` as the page title
- move the existing custom UI implementation guide to
`/headless-threads` across root, generated, authored, and Built-in
framework surfaces
- present the architecture as a product-to-system story: what users
experience, the UI/runtime/agent pieces in the app, and Enterprise
Intelligence as the cloud-hosted or self-hosted Threads platform
- provide responsive desktop and mobile diagram assets in light and dark
modes, showing durable history, replay to live, realtime sync,
lifecycle, and locking
- move `Threads & Persistence Architecture` into the Threads navigation
group across all framework modes
- replace the standalone migration CTA with contextual prose that leads
naturally to `Import Thread History`
- replace ambiguous linked-card layouts with a comparison table,
explicit action links, and a conventional next-steps list
- migrate implementation-intent links to `/headless-threads` while
keeping product-level links on `/threads`
- correct the ADK Vertex importer project-variable reference
- add regression coverage for route availability, nav labels/order,
page-title separation, shared architecture placement, and
framework-aware link rewriting
## Authoring surfaces
- **Shared/root:** `src/content/docs/{threads,headless-threads}.mdx`,
shared overview and headless snippets, root `meta.json`, and responsive
light/dark diagram assets
- **Authored frameworks:** integration wrappers and navigation metadata;
shared navigation logic inserts the architecture page into each Threads
group
- **Generated frameworks:** shared root routes, snippets, and root
navigation; generated data files are not hand-edited
- **Built-in Agent:** authored wrapper plus the same shared navigation
injection
- **Cross-links/reference:** Drawer, import, CLI, architecture,
tutorials, and `useThreads` reference pages
## Routing and redirects
No redirect is added for the old `/threads` implementation URL because
`/threads` is intentionally reused by the new overview. Existing
external links to `/threads` now land on the product overview, and
internal links that specifically mean the custom `useThreads`
implementation guide have moved to `/headless-threads`. Framework-aware
link rewriting scopes both routes normally.
## Base
This PR targets `main` after #5915 merged. Its diff contains only the
Threads overview follow-up commits.
## Validation
- `npm run lint` (passes with existing repository warnings only)
- `npm run test` (32 files, 170 tests)
- `npm run typecheck`
- `npm run build` (214 static pages generated; existing Turbopack
tracing warning only)
- `git diff --check`
- SVG XML validation for both architecture assets
- live browser checks on root, Mastra, LangGraph Python, and Built-in
Agent routes
- light/dark diagram rendering and narrow/desktop layout passes
|
||
|
Jordan Ritter
|
8a0b829732 | fix(showcase): harden async-wedge repro generator lane against false-green | ||
|
github-actions[bot]
|
518cb42ef3 | style: auto-fix formatting | ||
|
Jordan Ritter
|
c5695baf2d |
fix(showcase): offload sync anthropic LLM calls off the claude-sdk-python event loop
The claude-sdk-python agent :8000 wedges under D6/LLM load: two synchronous anthropic.Anthropic().messages.create() calls run directly on the uvicorn asyncio event loop, freezing it for the full LLM round-trip so /health stops responding. The watchdog counts 3 consecutive failures (~90s) and kill-restarts the container, dropping active sessions. Root cause (sync-in-async), all in integrations/claude-sdk-python/: - src/agents/agent.py: _execute_tool's generate_a2ui branch builds a sync anthropic.Anthropic() and calls messages.create() synchronously; invoked on the loop from run_agent's agentic loop AND from the Claude-Agent-SDK MCP tool handler in claude_agent_sdk_adapter.py. - src/agents/a2ui_dynamic.py: _generate_a2ui, same sync pattern, invoked on the loop from the run_a2ui_dynamic_agent generator. Fix: wrap every async call site in `await asyncio.to_thread(...)` (lowest blast radius — the sync functions and the shared ExecuteTool callback type are unchanged, and the whole tool-dispatch path is fixed uniformly, not just generate_a2ui): - agent.py run_agent call site - claude_agent_sdk_adapter.py MCP tool handler - a2ui_dynamic.py secondary call site Blast radius: claude-sdk-python only. a2ui_dynamic.py is per-integration (each framework has its own copy); every other claude-sdk-python agent already uses AsyncAnthropic. The `tools` symlink to shared/python was not touched. entrypoint.sh: drop the Slack alert from the :8000 agent watchdog branch (keep the kill-restart — it self-heals silently now that the root cause is fixed); keep the LOUD #oss-alerts page on the public $PORT /api/health branch. Adds showcase/tests/repro/async-wedge/ — a faithful RED/GREEN harness driving the real anthropic sync client against a controllable slow endpoint, plus a mutation guard on the real _generate_a2ui. |
||
|
Sam Julien
|
e4db18b718 | docs(shell-docs): refine Threads overview screenshot | ||
|
Jordan Ritter
|
7abcd216dc |
fix(showcase): stop the claude-sdk-python stdout-backpressure event-loop wedge (#5987)
## What happened The `claude-sdk-python` showcase column went fully red on **staging** (37 cells, `BE ✗` cascading) while prod and the TypeScript sibling stayed green on the same image. It wasn't 37 bugs — it was one wedged replica. **Root cause:** a D6 fan-out pushed the container's combined log volume past Railway's ~500 logs/sec drain cap. `entrypoint.sh` pipes both processes' stdout through an `awk` process-substitution, so Next.js's `fd1` is a **synchronous pipe**; when Railway stopped draining, the pipe filled and Next.js's next `console.log` blocked in `write(2)`, **freezing the event loop**. Even the static `/api/health` went 502, CPU→0, memory flat, process alive — so `restartPolicyType: ON_FAILURE` never fired and `numReplicas: 1` meant one wedge reds the whole column. Load-triggered, not a code/env diff. Full analysis (root cause + mitigation trade-offs): Notion → *Showcase stdout-backpressure wedge* under Plans / Proposals. ## The fix (two coordinated MUSTs) Showcase's promise is preserved throughout — real D6 traffic, live page, and full CVDIAG diagnostics all intact. Nothing is sampled or dropped. - **MUST-1 — take the flood off stdout, losslessly.** Route CVDIAG's per-LLM-call breadcrumb off stdout behind a new `CVDIAG_LOG_STDOUT` gate (**default ON**, so every other integration is byte-for-byte unchanged); the non-blocking PocketBase sink still receives every envelope at full fidelity — which is the path `cvdiag classify` and the dashboard already read from. `emit_cvdiag` now enqueues to PB **before** the stdout write so a wedged fd1 can't cost the durable breadcrumb. `entrypoint.sh` self-activates `CVDIAG_LOG_STDOUT=0` only when `CVDIAG_PB_URL` is wired (safe: never silences stdout when PB isn't receiving). Plus uvicorn `--no-access-log` to drop the access-log noise. - **MUST-2 — detect and recover the hang, loudly.** Extend the watchdog to poll the public `$PORT /api/health` and, on sustained failure, POST a `#oss-alerts` Slack alert **before** kill-restarting — and add the same alert to the agent-`:8000` branch. No silent recovery: every wedge pages. ## Red → green proof A docker `node:22-slim` repro (`showcase/tests/repro/stdout-wedge/`) reproduces the real topology (same `awk` pipe, Railway-capped drain reader, uvicorn+CVDIAG-shaped flood, static no-log `/api/health` victim): - **RED** (unmitigated): `/api/health` 200 → 502/timeout the instant the flood crosses the cap; heartbeat frozen; CPU parked at 0. `200=6 / WEDGE=11`. - **GREEN** (flood cut below cap): health stays fast-200 across the whole window; heartbeat advances. `200=16 / WEDGE=0`. - `run.sh` asserts the outcome and **exits non-zero on a false result** (a deliberately-forced false-GREEN exits 5, was exit 0 pre-fix). - MUST-2: the actual `entrypoint.sh` watchdog loop, run verbatim against a genuinely wedged port, detects → POSTs the captured alert → `kill -9`s the real Next.js PID. `watchdog.sh` needle-anchors the public probe/kill/alert against `entrypoint.sh` (mutating the probe fails the test). - Unit: `test_cvdiag_log_stdout_gate.py` — 5/5 incl. a hostile-stdout durability test (RED: enqueue starved; GREEN: enqueue preserved). Full `_shared` suite 19 passed / 2 skipped. ## Review Tier-3 cr-loop (shared source + deploy config + kill path): 7-agent review → adversarial per-finding verification → 5 mandatory fixes (all red-green'd, isolated worktrees) → 7-agent confirmation round converged to **zero mandatory findings** → bucket-(c) promotion audit `PROMOTE_TO_A: 0`. ## ⚠️ Not merge-ready yet — draft on purpose - [ ] **Staging branch-deploy validation** — local can't exercise the one runtime unknown: that the container actually reaches `showcase-pocketbase.railway.internal:8090` and lands a `cvdiag_events` row. Must confirm on a staging deploy of this branch before merge. - [ ] **Railway env wiring (out-of-band, human-gated):** set on `showcase-claude-sdk-python` (staging + prod) — `CVDIAG_BACKEND_EMITTER=1`, `CVDIAG_PB_URL=http://showcase-pocketbase.railway.internal:8090`, `CVDIAG_WRITER_KEY` (op:// in DevOps `showcase`), `SLACK_WEBHOOK_OSS_ALERTS`. Without these MUST-1/MUST-2 stay inert (safe: default is current behavior). - [ ] Green CI. ## Follow-up (non-blocking, fail-safe) Repro-harness polish (none false-GREEN-capable): GREEN heartbeat assertion is timing-fragile under a raised start-delay (false-RED only); `run.sh` local lane doesn't forward all tunables; `watchdog.sh` webhook-assert race + helper-death flake; reader has no close handler on the local lane. Pre-existing (bucket c): `OPENAI_API_KEY` warning is mislabeled; Next.js has no readiness gate; `_SETUP_DONE` degrade-latch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) |
||
|
Benjamin Taylor
|
7edb6dbf19 |
docs: address adversarial review of threads-lifecycle guide
- History section: "Platform replay (the default)" → "Server-side replay", state the precondition (needs a server-side store — platform or a persisting AgentRunner; a bare runtime replays nothing), and use the correct method name connectAgent() (there is no agent.connect()). - First-message thread creation (headless): fix a race — the example set the thread via setActiveThreadId() (a deferred React state update) then sent immediately, which lands on the previous thread; and truly-headless has nothing syncing agent.threadId. Now set agent.threadId directly and add a caveat explaining the state-setter timing. - v1 notes: correct the setThreadId throw attribution — the useThreads setter silently shadows under a prop; the throwing setThreadId is the one on the main <CopilotKit> hooks. - MCP Apps: drop the unverified "not persisted server-side" assertion; reframe as client-side re-derivation that restores via normal history replay. - LangGraph: don't imply the linked persistence page proves the Platform UUID rule; loosen the checkpointer shorthand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|
Ran Shem Tov
|
0440c58106 |
docs(showcase/mastra): document OM-as-background-activity (OSS-391)
Short how-to section in background-tasks.mdx: enable Observational Memory on the agent's Memory + opt in on the adapter (observationalMemory: true on getLocalAgents), render via renderActivityMessages with activityType mastra-observational-memory. Mirrors the working /demos/observational-memory wiring. (--no-verify: worktree commitlint binary still broken post-crash.) |