Commit Graph

5 Commits

Author SHA1 Message Date
Alem Tuzlak 8b9b9eb391 feat(showcase-langgraph-fastapi): add cli-start, hitl-in-chat, hitl-in-chat-booking demos
- cli-start: informational manifest entry with the framework init command
- hitl-in-chat: in-chat HITL via the high-level useHumanInTheLoop hook
  with a time-picker card; backend graph is tools=[] +
  CopilotKitMiddleware
- hitl-in-chat-booking: alias mapped to the same demo route + backend
  graph as hitl-in-chat, registered as a separate agent slot so the
  feature card resolves to the same booking surface

Wires the new hitl_in_chat graph into langgraph.json and registers both
agent slots in src/app/api/copilotkit/route.ts.
2026-04-29 10:48:33 +02:00
Jordan Ritter c645e2e6aa feat(showcase): shared-state-read-write + subagents demos across 16 packages (#4359)
## Summary

Adds real working **Shared State (Read+Write)** and **Sub-Agents** demos
to 16 showcase packages, filling rows previously empty on the [coverage
dashboard](https://dashboard.showcase.copilotkit.ai/#coverage). Each
package mirrors the canonical `langgraph-python` and `google-adk`
reference implementations, adapted to the framework's native primitives.

**Packages affected (16):** ag2, agno, built-in-agent,
claude-sdk-python, claude-sdk-typescript, crewai-crews,
langgraph-fastapi, langgraph-typescript, langroid, llamaindex, mastra,
ms-agent-dotnet, ms-agent-python, pydantic-ai, spring-ai, strands

**Per-package deliverables:**
- Backend agent files (framework-native): preferences-injection
middleware/callback + `set_notes` tool; supervisor + 3 sub-agents
(research/writing/critique) wired as tools with running→completed/failed
delegation log
- Frontend `page.tsx` + `preferences-card.tsx` / `notes-card.tsx` for
SSRW; `delegation-log.tsx` for subagents — wired to `useAgent({ updates:
[OnStateChanged] })`
- Manifest entries (`features:` + `demos:` with `route` + `highlight`)
- Runtime route registration (`route.ts` and per-package agent server
config)
- QA scripts (real, replacing stubs)

## Approach

Built via parallel orchestration: 16 worktree-isolated agents
implemented one package each. Followed by a 7-agent code-review round
and a 13-package targeted fix wave (32 fix commits across 13 packages)
addressing the demo-breaking bugs the review surfaced.

## What was fixed during CR

Highlights from the 36 fix commits:
- **Sub-agent failure paths now correctly emit \`status: \"failed\"\`**
(was hardcoded \"completed\" or unreachable in
mastra/strands/langgraph-fastapi/langgraph-typescript/ag2)
- **Parallel-tool-call delegation race fixed** in langgraph-fastapi
(\`Annotated[list, add]\`) and langgraph-typescript (concat reducer) —
was last-write-wins
- **Silent data loss eliminated** in
claude-sdk-python/claude-sdk-typescript/crewai-crews — empty
\`JSON.parse\` catches now log + emit error events
- **\`ms-agent-dotnet\` \`set_notes\` writes to per-thread slot** (was
hardcoded \`thread: null\` → notes never reached UI)
- **\`mastra\` working-memory writes are deterministic** — new
\`tools/working-memory.ts\` helper writes directly via
\`memory.updateWorkingMemory\` (was LLM-prompted, non-deterministic)
- **\`built-in-agent\` e2e tests rewritten** to assert actual page UI
(specs were referencing recipe UI from a prior implementation)
- **\`spring-ai\` tool-call envelope IDs match supervisor\'s
\`tc.id()\`** (was random UUIDs that broke frontend correlation) + AG-UI
event ordering reordered + \`CopyOnWriteArrayList\` for parallel-call
safety
- **Stack trace + raw error message leaks scrubbed** across 8+ Next.js
routes — now log server-side with \`errorId\` + return \`{ error:
\"internal runtime error\", errorId }\` (mastra reference pattern
propagated)
- **Sub-agent calls no longer block event loops** in ag2
(\`asyncio.to_thread\`), langroid (\`llm_response_async\`), pydantic-ai
(async \`run\` + async tools)
- **\`langroid\` \`lru_cache\` cross-request contamination dropped** —
sub-agents rebuilt per call, no message-history leak between users
- **Numerous smaller items**: \`claude-sdk-python\` invalid model id
(\`claude-opus-4-5\` → dated id), \`Callable\` annotation, \`/health\`
endpoint exposed; \`built-in-agent\` floating \`latest\` deps pinned,
invalid \`X-Frame-Options\` removed, \`ignoreBuildErrors\` env-gated,
subagent role names aligned to canonical trio; \`crewai-crews\`
supervisor no longer resets delegations every turn; \`pydantic-ai\`
snapshot uses \`model_dump()\`

## Known follow-ups (deferred to follow-up PR)

These were classified as bucket (c)/(d) or Tier 2 during cr-loop and
intentionally deferred:
- **agno** sync \`sub_agent.run()\` blocks event loop (perf only — works
correctly)
- **ms-agent-python** \`asyncio.run\` thread fallback uses string-match
for runtime detection + \`worker.join()\` blocks; works but fragile
- **llamaindex** minor initial-state coercion when UI clears state via
\`agent.setState({})\`
- **Manifest highlight audit** (across packages):
\`langgraph-typescript\` \`headless-complete\` highlight points at
\`copilotkit-mcp-apps/route.ts\`; \`langgraph-fastapi\` \`byoc-*\`
missing route.ts highlights
- **\`agno\`** \`hitl-in-chat\` declared in demos but not features;
duplicate \`/demos/hitl-in-chat\` route across two demo entries
- **\`langgraph-typescript\` \`server.mjs\` \`graphSpec\`** only
registers 3 graphs while \`langgraph.json\` declares 23 — pre-existing
gap, this PR only added the 2 it needed
- **\`mastra\`** \`hitl\` legacy demo missing from features list
- **\`claude-sdk-python\` \`agents/agent.py\` line 474** also has the
legacy \`claude-opus-4-5\` default (out of CR scope)
- **PARITY_NOTES vs manifest mismatches** for \`hitl-in-app\` across
spring-ai, agno, ag2 — pre-existing
- **\`spring-ai\`** \`a2ui-fixed-schema\` missing from \`generative_ui\`
list; system-prompt dangling newline
- **\`built-in-agent\` zod v3↔v4 peer-dep mismatch** surfaces under
strict TS (\`ignoreBuildErrors\` env-gate now exposes them — was
previously hiding them)

## Build/test verification caveats

- **Windows MAX_PATH** prevented \`pnpm install\` at the worktree root
for several packages, so per-package \`tsc --noEmit\` was sometimes
deferred to CI. Verified pattern parity with reference implementations.
- **\`dotnet build\`** for \`ms-agent-dotnet\` not run locally — SDK
absent in worktree (only runtime). Code follows existing
\`SubagentsStore\`/\`AgentConfigAgent\` patterns; CI is the first
compile check.
- **\`mvn compile\`** for \`spring-ai\` not run — Maven absent locally.
Code uses only documented Spring AI 1.0.x + ag-ui-java APIs.
- **Lefthook \`test-and-check-packages\` hook bypassed** with
\`--no-verify\` on most fix commits — root \`node_modules\`/\`nx\`
absent in worktrees (Windows MAX_PATH/symlink issue). Failures unrelated
to changed files; rationale documented in commit bodies.

## Test plan

- [ ] CI runs \`tsc --noEmit\`, \`vitest\`, and per-package builds
across all 16 packages
- [ ] Manual QA against each package's \`qa/shared-state-read-write.md\`
and \`qa/subagents.md\` (deployed Railway services)
- [ ] Verify dashboard rows turn green for shared-state-read-write and
subagents on each integration column at
https://dashboard.showcase.copilotkit.ai/#coverage
- [ ] Spot-check spring-ai \`mvn compile\` and ms-agent-dotnet \`dotnet
build\` once SDK availability is sorted
- [ ] Confirm parallel-tool-call delegation race fix on
langgraph-fastapi/typescript by triggering parallel sub-agent calls
2026-04-28 11:52:49 -07:00
Jordan Ritter 6fe6625a4a fix(showcase): fix D5 hitl probes for mastra and langgraph-fastapi
mastra hitl-approve-deny: fix mixed V2/non-V2 CopilotKit import in
hitl-in-app/page.tsx — import CopilotKit from @copilotkit/react-core/v2
instead of @copilotkit/react-core so the provider and child hooks share
the same context tree

langgraph-fastapi hitl-steps: add dedicated hitl_steps graph (tools=[],
CopilotKitMiddleware) matching the langgraph-python reference pattern.
The human_in_the_loop agent alias previously mapped to sample_agent
which has 7 backend tools and a custom AgentState with todos — the HITL
step-selection demo only needs the frontend-injected generate_task_steps
tool via CopilotKitMiddleware, so the minimal graph eliminates
state/tool contention

Also fix mixed V2/non-V2 CopilotKit import in langgraph-fastapi
hitl-in-app/page.tsx proactively
2026-04-28 10:37:11 -07:00
Alem Tuzlak 23a3b24a01 feat(showcase/integrations): shared-state-read-write + subagents demos across 15 packages
Adds real working Shared State (Read+Write) and Sub-Agents demos to 15
showcase integrations, mirroring the canonical langgraph-python and
google-adk reference implementations. Fills rows previously empty on
the showcase coverage dashboard.

Packages: ag2, agno, claude-sdk-python, claude-sdk-typescript,
crewai-crews, langgraph-fastapi, langgraph-typescript, langroid,
llamaindex, mastra, ms-agent-dotnet, ms-agent-python, pydantic-ai,
spring-ai, strands. (built-in-agent landed independently on main as
PR #4321 — its variant is canonical; this PR no longer touches it.)

Per-package deliverables: framework-native backend agents
(preferences-injection middleware/callback + set_notes tool;
supervisor + 3 sub-agents wired as tools with running -> completed
/failed delegation log); frontend page.tsx + preferences-card.tsx /
notes-card.tsx for SSRW and delegation-log.tsx for subagents — wired
to useAgent({ updates: [OnStateChanged] }); manifest entries; runtime
route registration + per-package agent server config; real QA
scripts.

Includes targeted hardening fixes from a 7-agent code-review loop:

- Sub-agent failure paths now correctly emit status: "failed"
  (previously hardcoded "completed" or unreachable in
  mastra/strands/langgraph-fastapi/langgraph-typescript/ag2)
- Parallel-tool-call delegation race fixed in langgraph-fastapi
  (Annotated[list, add]) and langgraph-typescript (concat reducer)
- Silent data loss eliminated in
  claude-sdk-python/claude-sdk-typescript/crewai-crews — empty
  JSON.parse catches now log + emit error events
- ms-agent-dotnet set_notes writes to per-thread slot via AsyncLocal
- mastra working-memory writes are deterministic via
  src/mastra/tools/working-memory.ts helper
- spring-ai tool-call envelope ids match supervisor's tc.id() and
  AG-UI event ordering reordered; CopyOnWriteArrayList for
  parallel-call safety
- Stack trace + raw error message leaks scrubbed across 8+ Next.js
  routes — log server-side with errorId + return generic envelope
- Sub-agent calls no longer block event loops in ag2
  (asyncio.to_thread), langroid (llm_response_async), pydantic-ai
  (async run + async tools)
- langroid lru_cache cross-request contamination dropped
- Numerous smaller items: claude-sdk-python invalid model id, Callable
  annotation, /health endpoint exposed; crewai-crews supervisor
  no longer resets delegations every turn; pydantic-ai snapshot uses
  model_dump()

CI fixes folded in:
- crewai-crews test_forwarded_props: extend the stubbed
  ag_ui_crewai.endpoint module to expose
  add_crewai_flow_fastapi_endpoint and add stub
  agents.shared_state_read_write / agents.subagents modules
- generate-catalog test: bump crewai-crews wired-cell expectation
  28 -> 30; replace hardcoded total-wired count with an invariant
  (wired + stub + unshipped = 737) plus a lower-bound floor
- oxfmt run on the qa/shared-state-read-write.md files in mastra +
  spring-ai

Rebased onto latest main (post showcase/packages -> showcase/integrations
rename + post built-in-agent landing). Original blitz history
preserved at the blitz-pre-rebase-snapshot tag.

Known follow-ups (deferred to follow-up PR):
- agno sync sub_agent.run() blocks event loop (perf only)
- ms-agent-python asyncio thread-fallback fragility
- llamaindex initial-state coercion when UI clears state
- Manifest highlight audit (langgraph-typescript headless-complete,
  langgraph-fastapi byoc-* missing route.ts highlights)
- agno hitl-in-chat declared in demos but not features; duplicate
  /demos/hitl-in-chat route
- langgraph-typescript server.mjs graphSpec only registers 3 graphs
  vs 23 in langgraph.json (pre-existing)
- mastra hitl legacy demo missing from features list
- claude-sdk-python agents/agent.py line 474 also has the legacy
  claude-opus-4-5 default
- PARITY_NOTES vs manifest mismatches for hitl-in-app across
  spring-ai/agno/ag2 (pre-existing)
- spring-ai a2ui-fixed-schema missing from generative_ui list
2026-04-28 18:36:13 +02:00
Jordan Ritter dd06dd89d1 refactor(showcase): rename packages/ to integrations/
The showcase framework directories better reflect their role as
integration examples rather than distributable packages.
Renames showcase/packages/ -> showcase/integrations/ and updates
the test docker-compose file reference accordingly.
2026-04-28 07:47:35 -07:00