Commit Graph

5 Commits

Author SHA1 Message Date
Jordan Ritter 34f615a0fb fix(showcase): restore single-source python tool symlinks + iron-rule guard
Restore the 12 Python integration tools/ dirs to symlinks into
shared/python/tools. They had eroded to real, drifting copies via an
accidental stage_shared() leak (commit 534cd1efa7) — the structural root
cause of showcase divergence bugs. Symlinking re-establishes the single
source of truth; content is identical to shared (only render_a2ui naming
and the shared roll_dice/sanitize additions are adopted).

Add showcase/AGENTS.md documenting the 4 iron rules and the single-source
symlink mechanism, plus a validate-shared-symlinks CI guard (shrink-only
baseline) that fails on any NEW erosion.
2026-07-14 22:17:54 -07:00
Jordan Ritter 2482317ccc style: apply ruff format to Python codebase
320 files reformatted. One-time alignment to match the ruff format
check added to CI in #4812.
2026-05-13 23:10:35 -07:00
Alem Tuzlak 4670d25a78 fix(showcase/google-adk): break Gemini tool loop, align agent IDs, A2UI v0.9 shape
Brings the Google ADK showcase back to parity with the langgraph-python
north-star across the 14 issues catalogued in PR #4792's TL;DR. Four
independent classes of bug fixed; all 36 demos now route, terminate, and
render correctly against real Gemini.

1. Universal Gemini infinite tool loop
   ADK's LlmAgent does not naturally terminate after a tool result with
   Gemini 2.5-flash — every backend or frontend tool fired forever. Lifted
   the (orphaned) `simple_after_model_modifier` from agents/main.py into
   shared_chat.stop_on_terminal_text without the SalesPipelineAgent
   name-gate; wired it as `after_model_callback=` into every registered
   LlmAgent (22 dedicated agents plus the build_simple_chat_agent /
   build_thinking_chat_agent factories). simple_after_model_modifier is
   kept as a thin alias so the existing test file keeps resolving.

2. Stale @ag-ui/client trapped on deprecated event names
   ag_ui_adk v0.6.1 emits the canonical REASONING_* events but the
   integration's package.json pinned `@ag-ui/client: ^0.0.43` which under
   npm's pre-1.0 caret rule resolves to strictly 0.0.43 — a version that
   only knows the deprecated THINKING_* names. Every Gemini response
   tripped the runtime's Zod discriminator. Bumped to ^0.0.53 and
   regenerated the lockfile.

3. Frontend agent IDs out of sync with backend mounts
   page.tsx for hitl-in-chat / frontend-tools-async / prebuilt-popup
   declared underscored agent IDs that didn't appear in the runtime's
   agent map, so useAgent threw "Agent not found after runtime sync"
   and the React tree crashed. Renamed to the dashed form that matches
   the registry. MCP Apps had the same class of bug at the route level —
   copilotkit-mcp-apps/route.ts pointed HttpAgent at /mcp_apps but the
   FastAPI mount is /mcp-apps; fixed to dash.

4. A2UI ops in deprecated v0.8 flat shape
   tools/generate_a2ui.py:build_a2ui_operations_from_tool_call,
   tools/search_flights.py, and agents/a2ui_fixed_agent.py emitted
   `{type: "create_surface", surfaceId, ...}` (flat). The
   @ag-ui/a2ui-middleware matcher only walks the v0.9 nested keys
   (`{createSurface: {surfaceId, ...}}`), so every op was grouped under
   the fallback "default" surface and the renderer threw
   `Catalog not found: default` or
   `Component 'undefined' is missing an 'id'`. Rewrote to v0.9 nested
   shape with `version: "v0.9"` and `updateDataModel` using `path` +
   `value` (matching copilotkit.a2ui Python helper).

   Three follow-on fixes in agents/main.py and beautiful_chat_agent.py
   that surfaced once the structural fix landed:
   - _AGENT_NAME_TO_CATALOG_ID table + _resolve_pinned_catalog_id helper:
     Gemini hallucinated catalog IDs because the schema for catalogId
     was unconstrained; the north-star hardcodes CUSTOM_CATALOG_ID per
     agent file, mirrored here with a name to id table so one shared
     generate_a2ui dispatches per demo.
   - Tightened parametersJsonSchema for components.items to require
     id + component AND explicitly declare the optional text / label /
     value / children / child / data props. Gemini's structured-output
     path drops fields not in the schema even with default
     additionalProperties: true, which produced [{}, {}, {}].
   - Hard-requirements prompt prefix with a concrete PieChart example
     ported from langgraph-python's _GENERATE_A2UI_PROMPT_HEADER, plus
     _sanitize_a2ui_components / _has_root_component validators and
     _unstringify_json_fields to round-trip Gemini's quirk of emitting
     "data": "[{...}]" as a JSON string instead of an actual array.

Windows note: the integration's tools/ symlink does not materialize on
Windows worktrees (git stores it as mode 100644). The local copies under
showcase/integrations/google-adk/tools/ are kept byte-identical to the
canonical sources under showcase/shared/python/tools/. On Linux/macOS
where the symlink works, only the shared/ copy is authoritative.
2026-05-13 17:11:16 +02:00
Jordan Ritter 534cd1efa7 fix(showcase): D5 integration fixes across 12 frameworks
Per-framework fixes to pass D5 e2e-deep probes:
- agno: deduplicate agent_server routes
- claude-sdk-python: handle ParsedContentBlockStopEvent (SDK v0.97+)
- claude-sdk-typescript: remove orphan tool-rendering page
- crewai-crews: add backend tool_rendering agent + shared_state fix
- google-adk: add AGUIToolset to all ADK agents for frontend tools
- langgraph-typescript: remove stale import
- langroid: emit ToolCallResultEvent for backend tools + fix adapter
- llamaindex: v2 provider import, book_call stub, PYTHONPATH fix
- ms-agent-python: disable Responses API store for aimock compat
- pydantic-ai: simplify gen-ui page component
- spring-ai: raise tool iteration cap (1→5) + fix connection pooling
- strands: shared tools symlink + requirements update
2026-04-29 19:40:10 -07:00
Jordan Ritter e9a2e143de fix(showcase): add shared-tools symlinks and refactor imports
Replace sys.path.insert hacks in Python agent files with direct
imports via symlinks to shared/{python,typescript}/tools.
Update Dockerfiles, entrypoints, and configs to support the new
symlink-based tool resolution. Add PARITY_NOTES for frameworks
that have known gaps.
2026-04-28 07:50:03 -07:00