Multiple CopilotChat components with the same agentId but different
threadIds were sharing a single agent instance, causing message state
to bleed between them. The useAgent hook now creates per-thread clones
keyed by agentId:threadId, keeping messages and state isolated.
Closes#2957
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
## Summary
`<CopilotSidebar defaultOpen={false} />` was opening anyway because the
prop was not being forwarded through the provider chain. This PR fixes
that - and also addresses the architectural trade-off flagged in review.
### Who is affected
**User A** just uses `<CopilotSidebar />` with no outer provider
Before the fix, their sidebar opened by default. After the fix, it still
opens by default. Nothing changed for them.
**User B** uses `<CopilotSidebar defaultOpen={false} />`
Before: broken (opened anyway). After: works.
**User C** wraps their app in a bare `CopilotChatConfigurationProvider`
and reads `isModalOpen` from it.
Before our fix `isModalOpen` was stuck at true forever. After: it
reflects the sidebar's state.
### What changed
- The `defaultOpen` prop is forwarded correctly through the provider
chain to both `CopilotSidebar` and `CopilotPopup`.
- Outer `useCopilotChatConfiguration()` hooks now reflect sidebar state.
Fixed via bidirectional state sync between nested providers.
### Files changed
- `packages/v2/react/src/components/chat/CopilotChat.tsx` - accept and
forward `isModalDefaultOpen`
- `packages/v2/react/src/components/chat/CopilotSidebar.tsx` - pass
`isModalDefaultOpen={defaultOpen}`
- `packages/v2/react/src/components/chat/CopilotPopup.tsx` - same
- `packages/v2/react/src/providers/CopilotChatConfigurationProvider.tsx`
- fix resolution logic + bidirectional sync
-
`packages/v2/react/src/providers/__tests__/CopilotChatConfigurationProvider.test.tsx`
- add tests
### Test plan
- [x] 843 tests pass (including 4 new bidirectional sync tests)
- [x] New tests cover all three reproduction scenarios from
[tkt-modal-default-open](https://github.com/CopilotKit/deep-agent-cpk-experiments/tree/main/app/client/src/tickets/tkt-modal-default-open)
**Linear:**
[CPK-7152](https://linear.app/copilotkit/issue/CPK-7152/fix-defaultopenfalse-prop-ignored-in-copilotsidebar)
**GitHub Issue:** #3475
**Related PRs:** #3477, #3496 (stalled community PRs addressing the same
issue)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
PR #3513 fixed Behavior A (defaultOpen={false} now respected) but broke
Behavior B: users who read isModalOpen from an outer
CopilotChatConfigurationProvider no longer see state changes originating
in the inner provider (e.g. CopilotSidebarView's provider).
Root cause: with hasExplicitDefault=true, the inner provider used its own
setter exclusively, so open/close events never reached ancestor providers.
Fix: when a provider owns its state (hasExplicitDefault=true), wrap
setModalOpen to also call parentConfig.setModalOpen — propagating changes
upward through the provider chain. Add a useEffect to sync parent→child
when an ancestor's state is changed externally (e.g. via an outer hook).
The mount-skip guard (isMounted ref) ensures the child's own
isModalDefaultOpen is honoured on first render and not overwritten.
Three new tests mirror the reproduction scenarios from:
https://github.com/CopilotKit/deep-agent-cpk-experiments/tree/main/app/client/src/tickets/tkt-modal-default-open
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ag-ui/client 0.0.47 had a bug where connectAgent() hung forever
for agents that don't implement connect(), causing detachActiveRun()
and runAgent() to deadlock. Fixed in 0.0.48.
## Summary
Fixes a race condition where `detachActiveRun()` was called without
`await`, allowing a new run to overwrite pipeline state before cleanup
finished — silently dropping the previous run.
- **`run-handler.ts`**: `void agent.detachActiveRun()` → `await
agent.detachActiveRun()`. The original deadlock that motivated
fire-and-forget (ConnectNotImplementedError cleanup) has been resolved
in the current `@ag-ui/client`. Confirmed via git history: added as
fire-and-forget in `5b3037a` on Mar 13 by Max Korp.
- **`use-copilot-chat_internal.ts`**: Added AbortController cleanup in
the `connectAgent` useEffect, mirroring the V2 `CopilotChat.tsx`
pattern. Guards state updates against aborted signals.
- Updated test mocks to include `detachActiveRun`
**Linear:**
[CPK-7151](https://linear.app/copilotkit/issue/CPK-7151/fix-race-condition-in-runhandlerrunagent-causes-dropped-runs)
**GitHub Issue:** #3482
## Files changed
- `packages/v2/core/src/core/run-handler.ts`
- `packages/v1/react-core/src/hooks/use-copilot-chat_internal.ts`
-
`packages/v1/react-core/src/hooks/__tests__/use-copilot-chat-internal-connect.test.tsx`
-
`packages/v1/react-core/src/hooks/__tests__/use-coagent-state-render.e2e.test.tsx`
## Test plan
- [x] All tests pass (pre-commit hook ran full suite)
- [x] Manual: rapid sequential message sends don't drop runs
- [x] Manual: verify no deadlock on initial connectAgent → immediate
runAgent
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Remove -mt-16 from input container so the scrollbar is not clipped.
Drop FEATHER_HEIGHT and inputContainerHeight from content padding
since the input is now a flex sibling, not an absolute overlay.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The input container was absolutely positioned on top of the scroll area,
causing the custom scrollbar to get clipped at the bottom. Changed to
flex column layout with negative margin to preserve the visual overlap
where messages fade behind the input.
Still needs tuning — bottom spacing varies by viewport. Pushing for
review to get input on the layout approach.
Resolves CPK-7153
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace overflow-y-scroll with overflow-y-auto so the scrollbar only
appears when content overflows. Add minimal custom scrollbar CSS scoped
to [data-copilotkit] for a thin, rounded thumb with no gutter.
Resolves CPK-7153
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When a user clicks Stop (or calls agent.abortRun()) while a frontend tool
handler is executing, processAgentResult would unconditionally start a new
runAgent() call — restarting the run the user just stopped.
Changes:
- Add AbortController to RunHandler, created per top-level runAgent() call
- stopAgent() now aborts the controller before calling agent.abortRun()
- agent.abortRun() is intercepted during a run to also abort the controller
- processAgentResult checks the abort signal before starting follow-up runs
- Tool handlers now receive an optional AbortSignal in their context for
cooperative cancellation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Await detachActiveRun() in run-handler.ts instead of fire-and-forget.
The original deadlock that motivated void has been resolved in the
current @ag-ui/client — ConnectNotImplementedError cleanup now
completes reliably.
Add AbortController cleanup in use-copilot-chat_internal.ts to match
the V2 CopilotChat.tsx pattern, preventing stale state updates and
ensuring proper teardown on unmount/re-render.
Resolves CPK-7151
Closes#3482
Co-Authored-By: Claude <noreply@anthropic.com>
Forward isModalDefaultOpen through CopilotChat into the configuration
provider. Fix nested provider resolution so explicit isModalDefaultOpen
overrides the parent's value instead of being ignored.
Resolves CPK-7152
Closes#3475
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When using the children render prop pattern, containerRef was never
passed to the render function. This caused CopilotChatView's
ResizeObserver to never measure the input height, resulting in
insufficient paddingBottom and input overlapping chat messages.
Closes#3500
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add MCPClientProvider interface and mcpClients config field to
BuiltInAgent, allowing users to provide pre-created MCP clients
whose tools are merged into the agent's tool set without per-request
lifecycle management. Users control persistence, auth, and caching.
React StrictMode double-mounts components in development, causing
CopilotChat's connectAgent() useEffect to abort its in-flight fetch
on the first cleanup. This produced noisy "Agent execution failed:
AbortError: signal is aborted without reason" errors in browser
devtools.
Two fixes:
1. withAbortErrorHandling() in agent.ts now catches AbortError
(alongside the existing ZodError handling) and returns EMPTY,
preventing the error from reaching onError() which would log
"Agent execution failed:" to the console.
2. CopilotChat.tsx attaches .catch() to the fire-and-forget
detachActiveRun() call in the cleanup function. The promise
does not actually reject, but without an attached handler V8
flags the promise chain as unhandled when the abort signal
propagates through connected promises internally.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
<!--
Thank you for sending the PR! We appreciate you spending the time to
work on these changes.
Help us understand your motivation by explaining why you decided to make
this change.
**Please PLEASE reach out to us first before starting any significant
work on new or existing features.**
By the time you've gotten here, you're looking at creating a pull
request so hopefully we're not too late.
We love community contributions! That said, we want to make sure we're
all on the same page before you start.
Investing a lot of time and effort just to find out it doesn't align
with the upstream project feels awful, and we don't want that to happen.
It also helps to make sure the work you're planning isn't already in
progress.
As described in our contributing guide, please file an issue first:
https://github.com/ag-ui-protocol/ag-ui/issues
Or, reach out to us on Discord: https://discord.com/invite/6dffbvGU3D
You can learn more about contributing to copilotkit here:
https://github.com/copilotkit/copilotkit/blob/master/CONTRIBUTING.md
Happy contributing!
-->
## What does this PR do?
(Describe the changes introduced in this PR)
## Related PRs and Issues
- (Direct link to related PR or issue, if relevant)
## Checklist
- [ ] I have read the [Contribution
Guide](https://github.com/copilotkit/copilotkit/blob/master/CONTRIBUTING.md)
- [ ] If the PR changes or adds functionality, I have updated the
relevant documentation
## Problem
When a HITL (Human-in-the-Loop) tool has no parameters, some providers
(e.g., Google ADK) send `arguments` as an empty string `""`.
`JSON.parse("")` throws `"Unexpected end of JSON input"`, crashing the
tool execution pipeline with an opaque error instead of executing the
tool with empty args.
Fixes#3263
## Root Cause
In `run-handler.ts`, both the specific-tool and wildcard-tool execution
paths call `JSON.parse(toolCall.function.arguments)` without checking
for empty/falsy values:
```ts
// Line 309 — specific tool path
parsedArgs = JSON.parse(toolCall.function.arguments); // crashes on ""
// Line 448 — wildcard tool path
parsedArgs = JSON.parse(toolCall.function.arguments); // crashes on ""
```
## Fix
Treat empty/falsy argument strings as `{}` (empty object) before
parsing:
```ts
const rawArgs = toolCall.function.arguments;
parsedArgs = rawArgs ? JSON.parse(rawArgs) : {};
```
This matches the existing defensive patterns:
- **v1 `agui-to-gql.ts`**: already catches parse errors and falls back
to `{}`
- **v2 `web-inspector`**: already checks `args === "" ` before parsing
(line 818)
## Changes
| File | Change |
|------|--------|
| `packages/v2/core/src/core/run-handler.ts` | Safe empty-args fallback
at both parse sites |
| `packages/v2/core/src/__tests__/core-edge-cases.test.ts` | Updated
test: empty args → handler called with `{}` |
| `packages/v2/core/src/__tests__/core-full.test.ts` | Updated test:
empty args → handler called with `{}` |
## Testing
- All 230 passing tests still pass (61 pre-existing failures in
unrelated packages unchanged)
- Updated 2 tests that previously expected a crash on empty args to
verify the handler is called with `{}`
Address review feedback:
- Extract parseToolArguments() to deduplicate empty/null/undefined handling
- Add debug-level warning when arguments fallback to {} (no longer silent)
- Type toolCall parameter as ToolCall instead of any in executeSpecificTool
and executeWildcardTool
- Both specific-tool and wildcard paths share the same parsing logic
Treat empty, null, or undefined tool arguments as {} instead of throwing
a JSON parse error. Uses explicit checks (=== '' || === null || === undefined)
rather than a broad falsy check, as recommended in review.
Addresses all review feedback from jpr5:
- Added tests for wildcard tool path with empty args
- Added tests for null and undefined arguments
- Used explicit empty/null/undefined check instead of broad falsy
- Added inline comments explaining the fallback rationale
- Removed duplicate tests (TEST 7/8) from core-full.test.ts
- Removed console.log debugging statements from tests
Run prettier on ~1,865 files across examples/ to match the monorepo's
formatting standards. These files were imported as-is from standalone
repos that used different prettier configs.
- base-command: wrap checkCLIVersion() fetch in try-catch so CLI
doesn't crash when offline (version check is non-critical)
- init: forward argv to Create instead of dropping all flags, remove
misleading flag definitions (init is just a deprecated redirect)
- detect-endpoint-type: fix Promise.all destructuring (5 promises but
only 4 variables caused isCopilot to receive the LangGraph FastAPI
result), add missing isMCP branch, use isLangGraphFastAPI result
- auth.service: validate OAuth state parameter before tracking analytics
with user data, add reject()+server.close() on state mismatch so the
Promise settles instead of hanging the CLI forever
- create.test: fix quote-style assertion to match prettier output
- Remove copy-paste triplication in scaffoldAgent (LangSmith block
duplicated twice, causing duplicate .env entries and redundant writes)
- Update AgentTemplates URLs to point to monorepo paths instead of
archived standalone repos
- Fix flags.projectName → args.projectName in banner logic (projectName
is an Args field, not Flags)
- Remove stale trpc-cli path mapping and project reference from
tsconfig.json (package doesn't exist in this monorepo)
Migrate the copilotkit CLI (npx copilotkit create/init/dev) from
CopilotCloud into packages/v1/cli. TEMPLATE_REPOS updated to use
monorepo subdirectory sparse checkout for all CopilotKit-owned
templates, with tarball fallback for external repos (ag2).
Martha Kelly Schumann