mirror of
https://github.com/conorluddy/ios-simulator-skill.git
synced 2026-09-14 20:07:12 +08:00
Conor
28ef1a4818
`get_booted_device_udid()` silently returned the first booted simulator. When more than one is booted (or a stale idb companion lingers), gesture and tap commands resolve to a device other than the one being watched — idb reports success on the wrong device, so swipes/scrolls silently no-op with no error. Keep the first-match default but print a stderr warning on ambiguity naming the selected device and advising an explicit --udid. Add `get_booted_device_udids()` so callers can detect the multi-device case, plus regression tests covering single/multiple/none/failure listings.
84 lines
2.8 KiB
Python
84 lines
2.8 KiB
Python
"""Regression tests for ambiguous booted-device auto-selection.
|
|
|
|
When more than one simulator is booted, `get_booted_device_udid()` used to
|
|
silently return the first match. Gesture/tap commands resolve their target via
|
|
this helper, so they could land on a simulator other than the one being watched
|
|
(idb reports success on the wrong device, so nothing appears to happen). The fix
|
|
keeps the first-match behaviour but emits a stderr warning on ambiguity, and
|
|
exposes `get_booted_device_udids()` so callers can detect the multi-device case.
|
|
"""
|
|
|
|
import subprocess
|
|
|
|
import pytest
|
|
from common.device_utils import get_booted_device_udid, get_booted_device_udids
|
|
|
|
UDID_A = "AAAAAAAA-1111-2222-3333-444444444444"
|
|
UDID_B = "BBBBBBBB-5555-6666-7777-888888888888"
|
|
|
|
|
|
def _fake_simctl(stdout: str):
|
|
"""Return a subprocess.run stub that yields the given booted-device listing."""
|
|
|
|
def _run(*_args, **_kwargs):
|
|
return subprocess.CompletedProcess(args=[], returncode=0, stdout=stdout, stderr="")
|
|
|
|
return _run
|
|
|
|
|
|
# === get_booted_device_udids ===
|
|
|
|
|
|
def test_lists_all_booted_udids(monkeypatch):
|
|
listing = (
|
|
f"-- iOS 26.2 --\n"
|
|
f" iPhone 17 Pro ({UDID_A}) (Booted)\n"
|
|
f" iPad Pro ({UDID_B}) (Booted)\n"
|
|
)
|
|
monkeypatch.setattr(subprocess, "run", _fake_simctl(listing))
|
|
assert get_booted_device_udids() == [UDID_A, UDID_B]
|
|
|
|
|
|
def test_returns_empty_when_none_booted(monkeypatch):
|
|
monkeypatch.setattr(subprocess, "run", _fake_simctl("== Devices ==\n-- iOS 26.2 --\n"))
|
|
assert get_booted_device_udids() == []
|
|
|
|
|
|
def test_returns_empty_when_simctl_fails(monkeypatch):
|
|
def _boom(*_args, **_kwargs):
|
|
raise subprocess.CalledProcessError(1, "simctl")
|
|
|
|
monkeypatch.setattr(subprocess, "run", _boom)
|
|
assert get_booted_device_udids() == []
|
|
|
|
|
|
# === get_booted_device_udid ===
|
|
|
|
|
|
def test_single_device_returns_udid_without_warning(monkeypatch, capsys):
|
|
listing = f"-- iOS 26.2 --\n iPhone 17 Pro ({UDID_A}) (Booted)\n"
|
|
monkeypatch.setattr(subprocess, "run", _fake_simctl(listing))
|
|
|
|
assert get_booted_device_udid() == UDID_A
|
|
assert capsys.readouterr().err == ""
|
|
|
|
|
|
def test_multiple_devices_warns_and_picks_first(monkeypatch, capsys):
|
|
listing = f" iPhone 17 Pro ({UDID_A}) (Booted)\n iPad Pro ({UDID_B}) (Booted)\n"
|
|
monkeypatch.setattr(subprocess, "run", _fake_simctl(listing))
|
|
|
|
assert get_booted_device_udid() == UDID_A
|
|
stderr = capsys.readouterr().err
|
|
assert "2 booted simulators" in stderr
|
|
assert UDID_A in stderr and UDID_B in stderr
|
|
assert "--udid" in stderr
|
|
|
|
|
|
def test_no_device_returns_none(monkeypatch):
|
|
monkeypatch.setattr(subprocess, "run", _fake_simctl("-- iOS 26.2 --\n"))
|
|
assert get_booted_device_udid() is None
|
|
|
|
|
|
if __name__ == "__main__":
|
|
raise SystemExit(pytest.main([__file__, "-v"]))
|