mirror of https://github.com/ComposioHQ/composio.git synced 2026-09-22 11:46:35 +08:00

Files

T

Alberto Schiabel 11de45889a fix(core): contain async Pusher subscription errors (#4448 )

## Summary
`PusherService.subscribe` binds `pusher:subscription_error` after the
Pusher subscription call returns. `pusher-js` dispatches this event
asynchronously without catching listener exceptions, so authentication,
permission, server, or network subscription failures could escape as
uncaught exceptions in Node applications.

Fixes #4445

## Changes
- Log asynchronous Pusher subscription errors at the SDK error boundary
instead of throwing from the event callback.
- Add regression coverage that emits `pusher:subscription_error` after
`subscribe()` resolves and verifies that it does not throw.
- Add a patch changeset for the fixed `@composio/core`/`@composio/slim`
package group.

## Type of change
- [x] Bug fix
- [ ] New feature
- [ ] Refactor/Chore
- [ ] Documentation
- [ ] Breaking change

## How Has This Been Tested?
- Node `v24.17.0` / pnpm `11.8.0`
- `pnpm --filter @composio/core exec vitest run
test/services/pusher.test.ts test/utils/pusher.test.ts` — 2 files, 5
tests passed
- `pnpm --filter @composio/core test` — 55 test files passed; 1,289
tests passed and 2 existing tests reported expected failures; command
exited successfully
- `pnpm --filter @composio/core typecheck`
- `pnpm lint` — passed with existing repository warnings
- `pnpm validate:changesets`
- `pusher-js` `v8.6.0` runtime probe confirmed that an exception thrown
from a `pusher:subscription_error` listener reaches Node's
`uncaughtException` handler; the regression test verifies the SDK
callback no longer throws.

## Screenshots (if applicable)

Not applicable.

## Checklist
- [x] I have read the Code of Conduct and this PR adheres to it
- [x] I ran linters/tests locally and they passed
- [x] I updated documentation as needed
- [x] I added tests or explain why not applicable
- [x] I added a changeset if this change affects published packages

## Additional context
This patch is intentionally limited to the live `PusherService` path.
XHR timeout handling is a separate concern and is not included here. The
older unreferenced `PusherUtils` helper is unchanged to keep this fix
scoped to the path used by `Triggers`.

2026-09-16 14:56:45 +02:00

config.json

chore(release): migrate to Changesets v3

2026-08-25 01:01:10 +02:00

heavy-toes-repeat.md

chore(deps): upgrade CI actions and every outdated dependency (#4381 )

2026-09-08 16:15:34 +02:00

json-schema-to-zod-pattern-guard.md

fix(json-schema-to-zod): guard schema pattern compilation (#4405 )

2026-09-09 19:53:07 +02:00

lucky-pugs-attend.md

fix(experimental): stamp eve durable callback descriptors (#4385 )

2026-09-08 20:51:33 +02:00

quiet-pumas-recover.md

feat(core): add optional onSubscriptionError callback for trigger subscriptions

2026-09-15 16:33:00 +02:00

read-response-body-export.md

fix(cli): cap remote file downloads in tool uploads (SEC-908) (#4417 )

2026-09-10 15:57:13 +02:00

README.md

Add changesets

2025-05-19 19:30:29 +05:30

ssrf-redirect-semantics.md

fix(sdk): honor Fetch redirect semantics in both SSRF guards (#4387 )

2026-09-08 20:51:12 +02:00

ssrf-transition-ranges.md

fix(sdk): honor Fetch redirect semantics in both SSRF guards (#4387 )

2026-09-08 20:51:12 +02:00

strip-credentials-cross-origin-redirect.md

fix(sdk): harden pusher auth and cross-origin redirect headers (#4406 )

2026-09-09 21:29:18 +02:00

tool-not-found-only-on-404.md

fix(core): raise tool not found only on 404/400

2026-09-11 22:54:53 +02:00

toolkit-auth-field-is-secret.md

fix(core): normalize a missing toolkit auth field group instead of throwing

2026-09-15 15:11:27 +02:00

tools-jsdoc-examples.md

docs(core): fix tools getInput, proxyExecute, and execute examples

2026-09-14 13:56:26 +02:00

witty-shrimps-check.md

ci(ts): verify packed provider compatibility (#4355 )

2026-09-07 12:33:53 +02:00

README.md

Changesets

Hello and welcome! This folder has been automatically generated by @changesets/cli, a build tool that works with multi-package repos, or single-package repos to help you version and publish your code. You can find the full documentation for it in our repository

We have a quick list of common questions to get you started engaging with this project in our documentation