mirror of
https://github.com/ComposioHQ/composio.git
synced 2026-09-22 11:46:35 +08:00
jkomyno
8bb1d29950
getRawComposioToolBySlug relabelled every client error, including an invalid API key (401), as ComposioToolNotFoundError. Map only 404/400 to not-found and wrap the rest in a new ComposioToolFetchError that keeps the client error as cause. Toolkits.getToolkitBySlug compared against the OpenAI APIError class, so its not-found branch never fired; import the Composio client class instead. Python mirrors the mapping: an unknown slug raises ToolNotFoundError (now a NotFoundError), anything else propagates the composio_client error unchanged. PRDE-1613 Claude-Session: https://claude.ai/code/session_017HtbhwMAKcfebo8HyXWa5s
74 lines
2.5 KiB
Python
74 lines
2.5 KiB
Python
"""Error mapping for ``Tools.get_raw_composio_tool_by_slug``.
|
|
|
|
Only an unknown slug becomes ``ToolNotFoundError``. Other client failures,
|
|
such as an invalid API key, must surface unchanged so callers can tell a
|
|
missing tool from a rejected request (parity with the TypeScript SDK).
|
|
"""
|
|
|
|
from unittest.mock import Mock
|
|
|
|
import httpx
|
|
import pytest
|
|
from composio_client import AuthenticationError, BadRequestError, NotFoundError
|
|
|
|
from composio import exceptions
|
|
from composio.core.models.tools import Tools
|
|
from tests.conftest import mock_http_client
|
|
|
|
|
|
def _status_error(cls, status: int):
|
|
request = httpx.Request("GET", "https://backend.composio.dev/api/v3/tools/X")
|
|
response = httpx.Response(status, request=request)
|
|
return cls("error", response=response, body=None)
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_client() -> Mock:
|
|
return mock_http_client()
|
|
|
|
|
|
@pytest.fixture
|
|
def tools(mock_client: Mock) -> Tools:
|
|
return Tools(client=mock_client, provider=Mock())
|
|
|
|
|
|
def test_unknown_slug_raises_tool_not_found(tools: Tools, mock_client: Mock) -> None:
|
|
not_found = _status_error(NotFoundError, 404)
|
|
mock_client.tools.retrieve.side_effect = not_found
|
|
|
|
with pytest.raises(exceptions.ToolNotFoundError) as exc_info:
|
|
tools.get_raw_composio_tool_by_slug("NONEXISTENT_TOOL")
|
|
|
|
assert exc_info.value.__cause__ is not_found
|
|
assert isinstance(exc_info.value, exceptions.NotFoundError)
|
|
assert "NONEXISTENT_TOOL" in str(exc_info.value)
|
|
|
|
|
|
def test_malformed_slug_raises_tool_not_found(tools: Tools, mock_client: Mock) -> None:
|
|
mock_client.tools.retrieve.side_effect = _status_error(BadRequestError, 400)
|
|
|
|
with pytest.raises(exceptions.ToolNotFoundError):
|
|
tools.get_raw_composio_tool_by_slug("malformed slug")
|
|
|
|
|
|
def test_invalid_api_key_is_not_tool_not_found(tools: Tools, mock_client: Mock) -> None:
|
|
unauthorized = _status_error(AuthenticationError, 401)
|
|
mock_client.tools.retrieve.side_effect = unauthorized
|
|
|
|
with pytest.raises(AuthenticationError) as exc_info:
|
|
tools.get_raw_composio_tool_by_slug("SLACK_FETCH_CONVERSATION_HISTORY")
|
|
|
|
assert exc_info.value is unauthorized
|
|
assert exc_info.value.status_code == 401
|
|
|
|
|
|
def test_execute_surfaces_auth_error_from_schema_fetch(
|
|
tools: Tools, mock_client: Mock
|
|
) -> None:
|
|
mock_client.tools.retrieve.side_effect = _status_error(AuthenticationError, 401)
|
|
|
|
with pytest.raises(AuthenticationError):
|
|
tools.execute("SLACK_FETCH_CONVERSATION_HISTORY", {}, user_id="user")
|
|
|
|
mock_client.tools.execute.assert_not_called()
|