mirror of
https://github.com/ComposioHQ/composio.git
synced 2026-09-22 11:46:35 +08:00
CoralGarden52
85d4923507
## Summary The Python Vertex AI Google provider rebuilt tool parameter schemas from `properties` and `required` without resolving internal `$ref`/`$defs` references first. As a result, referenced properties were sent as dangling references and could not be interpreted by Vertex AI. This change dereferences internal schema references before the existing Google-specific translation. It follows the provider behavior fixed in [TypeScript PR #4288](https://github.com/ComposioHQ/composio/pull/4288). ## Changes - Dereference Google provider input schemas with the existing `dereference_json_schema` helper. - Use the resolved schema when extracting properties and required fields. - Add a regression test covering a property defined through `$ref`/`$defs`. ## Type of change - [x] Bug fix - [ ] New feature - [ ] Refactor/Chore - [ ] Documentation - [ ] Breaking change ## How Has This Been Tested? - `pytest tests/test_google_provider.py tests/test_json_schema.py tests/test_provider.py -q -k 'not TestLangchainReservedKeywords and not TestLangchainFreeFormObjectArguments'` — 59 passed, 4 skipped, 5 deselected. - `ruff check --config config/ruff.toml providers/google/composio_google/provider.py tests/test_google_provider.py` — passed. - `ruff format --check providers/google/composio_google/provider.py tests/test_google_provider.py` — passed. - `mypy --config-file config/mypy.ini providers/google/composio_google/provider.py tests/test_google_provider.py` — passed. ## Screenshots (if applicable) Not applicable. ## Checklist - [x] I have read the Code of Conduct and this PR adheres to it - [x] I ran linters/tests locally and they passed - [x] I updated documentation as needed - [x] I added tests or explain why not applicable - [x] I added a changeset if this change affects published TypeScript packages ## Additional context This is a Python-only provider fix; no TypeScript changeset is required. No existing issue was found for the Python provider, so this PR includes the minimal reproduction and regression test directly. --------- Co-authored-by: jkomyno <alberto@composio.dev>
34 lines
1.0 KiB
Python
34 lines
1.0 KiB
Python
"""Tests for the Vertex AI Google provider."""
|
|
|
|
import pytest
|
|
|
|
from composio.client.types import Tool
|
|
|
|
GoogleProvider = pytest.importorskip("composio_google").GoogleProvider
|
|
|
|
|
|
def test_wrap_tool_dereferences_internal_refs() -> None:
|
|
"""Referenced input properties must be expanded before Vertex translation."""
|
|
tool = Tool.model_construct(
|
|
slug="TEST_REF",
|
|
description="test",
|
|
input_parameters={
|
|
"type": "object",
|
|
"properties": {"message": {"$ref": "#/$defs/Message"}},
|
|
"required": ["message"],
|
|
"$defs": {
|
|
"Message": {
|
|
"type": "object",
|
|
"properties": {"subject": {"type": "string"}},
|
|
"required": ["subject"],
|
|
}
|
|
},
|
|
},
|
|
)
|
|
|
|
wrapped = GoogleProvider().wrap_tool(tool)
|
|
message_schema = wrapped.to_dict()["parameters"]["properties"]["message"]
|
|
|
|
assert "ref" not in message_schema
|
|
assert message_schema["properties"]["subject"]["type"] == "STRING"
|