cloudflare__vinext/tests/slot.test.ts

import React from "react";
import { renderToReadableStream } from "react-dom/server.edge";
import { describe, expect, it, vi } from "vite-plus/test";
import { UNMATCHED_SLOT } from "../packages/vinext/src/server/app-elements.js";

vi.mock("next/navigation", () => ({
  usePathname: () => "/",
}));

function createContextProvider<TValue>(
  context: React.Context<TValue>,
  value: TValue,
  child: React.ReactNode,
): React.ReactElement {
  return React.createElement(context.Provider, { value }, child);
}

async function readStream(stream: ReadableStream<Uint8Array>): Promise<string> {
  const reader = stream.getReader();
  const decoder = new TextDecoder();
  let text = "";

  for (;;) {
    const { done, value } = await reader.read();
    if (done) {
      break;
    }
    text += decoder.decode(value, { stream: true });
  }

  return text + decoder.decode();
}

async function renderHtml(element: React.ReactElement): Promise<string> {
  const stream = await renderToReadableStream(element);
  await stream.allReady;
  return readStream(stream);
}

describe("slot primitives", () => {
  it("exports the client primitives", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");

    expect(typeof mod.Slot).toBe("function");
    expect(typeof mod.Children).toBe("function");
    expect(typeof mod.ParallelSlot).toBe("function");
    expect(typeof mod.mergeElements).toBe("function");
    expect(mod.ElementsContext).toBeDefined();
    expect(mod.ChildrenContext).toBeDefined();
    expect(mod.ParallelSlotsContext).toBeDefined();
    expect(mod.UNMATCHED_SLOT).toBe(Symbol.for("vinext.unmatchedSlot"));
  });

  it("Children renders null outside a Slot provider", async () => {
    const { Children } = await import("../packages/vinext/src/shims/slot.js");

    const html = await renderHtml(React.createElement(Children));
    expect(html).toBe("");
  });

  it("ParallelSlot renders null outside a Slot provider", async () => {
    const { ParallelSlot } = await import("../packages/vinext/src/shims/slot.js");

    const html = await renderHtml(React.createElement(ParallelSlot, { name: "modal" }));
    expect(html).toBe("");
  });

  it("Slot renders the matched element and provides children and parallel slots", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");

    function LayoutShell(): React.ReactElement {
      return React.createElement(
        "div",
        null,
        React.createElement("main", null, React.createElement(mod.Children)),
        React.createElement(
          "aside",
          null,
          React.createElement(mod.ParallelSlot, { name: "modal" }),
        ),
      );
    }

    const slotElement = createContextProvider(
      mod.ElementsContext,
      { "layout:/": React.createElement(LayoutShell) },
      React.createElement(
        mod.Slot,
        {
          id: "layout:/",
          parallelSlots: {
            modal: React.createElement("em", null, "modal content"),
          },
        },
        React.createElement("span", null, "child content"),
      ),
    );

    const html = await renderHtml(slotElement);
    expect(html).toContain("child content");
    expect(html).toContain("modal content");
  });

  it("Slot returns null when the entry is absent", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");

    const html = await renderHtml(
      createContextProvider(
        mod.ElementsContext,
        {},
        React.createElement(mod.Slot, { id: "slot:modal:/" }),
      ),
    );

    expect(html).toBe("");
  });

  it("Slot does not treat empty objects as transport metadata", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const consoleError = vi.spyOn(console, "error").mockImplementation(() => {});

    try {
      await expect(
        renderHtml(
          createContextProvider(
            mod.ElementsContext,
            { "slot:modal:/": {} },
            React.createElement(mod.Slot, { id: "slot:modal:/" }),
          ),
        ),
      ).rejects.toThrow(/Objects are not valid|object/i);
    } finally {
      consoleError.mockRestore();
    }
  });

  it("warns in development when transport metadata appears under a render entry", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const warn = vi.spyOn(console, "warn").mockImplementation(() => {});

    try {
      const html = await renderHtml(
        createContextProvider(
          mod.ElementsContext,
          { "slot:metadata-warning:/": { "layout:/": "s" } },
          React.createElement(mod.Slot, { id: "slot:metadata-warning:/" }),
        ),
      );

      expect(html).toBe("");
      expect(warn).toHaveBeenCalledWith(
        "[vinext] Transport metadata value found under App Router render entry: slot:metadata-warning:/",
      );
    } finally {
      warn.mockRestore();
    }
  });

  it("warns in development when a non-slot entry is absent", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const warn = vi.spyOn(console, "warn").mockImplementation(() => {});

    try {
      const html = await renderHtml(
        createContextProvider(
          mod.ElementsContext,
          {},
          React.createElement(mod.Slot, { id: "route:/missing" }),
        ),
      );

      expect(html).toBe("");
      expect(warn).toHaveBeenCalledWith(
        "[vinext] Missing App Router element entry during render: route:/missing",
      );
    } finally {
      warn.mockRestore();
    }
  });

  it("does not warn when an absent parallel slot key is omitted on soft navigation", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const warn = vi.spyOn(console, "warn").mockImplementation(() => {});

    try {
      const html = await renderHtml(
        createContextProvider(
          mod.ElementsContext,
          {},
          React.createElement(mod.Slot, { id: "slot:modal:/" }),
        ),
      );

      expect(html).toBe("");
      expect(warn).not.toHaveBeenCalled();
    } finally {
      warn.mockRestore();
    }
  });

  it("Slot throws the notFound signal for an unmatched slot sentinel", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const renderPromise = renderHtml(
      createContextProvider(
        mod.ElementsContext,
        { "slot:modal:/": mod.UNMATCHED_SLOT },
        React.createElement(mod.Slot, { id: "slot:modal:/" }),
      ),
    );
    const consoleError = vi.spyOn(console, "error").mockImplementation(() => {});

    try {
      await expect(renderPromise).rejects.toMatchObject({ digest: "NEXT_HTTP_ERROR_FALLBACK;404" });
    } finally {
      consoleError.mockRestore();
    }
  });

  it("Slot renders a present null entry without triggering notFound", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");
    const errors: Error[] = [];

    const stream = await renderToReadableStream(
      createContextProvider(
        mod.ElementsContext,
        { "slot:modal:/": null },
        React.createElement(mod.Slot, { id: "slot:modal:/" }),
      ),
      {
        onError(error: unknown) {
          if (error instanceof Error) {
            errors.push(error);
          }
        },
      },
    );

    await stream.allReady;
    const html = await readStream(stream);

    expect(html).toBe("");
    expect(errors).toEqual([]);
  });

  it("normalizes the server unmatched-slot marker to the client sentinel", async () => {
    const { normalizeAppElements, APP_UNMATCHED_SLOT_WIRE_VALUE } =
      await import("../packages/vinext/src/server/app-elements.js");
    const mod = await import("../packages/vinext/src/shims/slot.js");

    const normalized = normalizeAppElements({
      __rootLayout: "/",
      __route: "route:/dashboard",
      "slot:modal:/": APP_UNMATCHED_SLOT_WIRE_VALUE,
    });

    expect(normalized["slot:modal:/"]).toBe(mod.UNMATCHED_SLOT);
  });

  it("mergeElements preserves approved non-slot elements", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "slot:modal:/": React.createElement("div", null, "previous slot"),
      },
      {
        "page:/blog/hello": React.createElement("div", null, "page"),
        "slot:modal:/": React.createElement("div", null, "next slot"),
      },
      { preserveElementIds: ["layout:/"] },
    );

    expect(Object.keys(merged).sort()).toEqual(["layout:/", "page:/blog/hello", "slot:modal:/"]);
    expect(merged["layout:/"]).toBeDefined();
    expect(merged["page:/blog/hello"]).toBeDefined();
    expect(merged["slot:modal:/"]).not.toBeNull();
  });

  it("mergeElements drops absent non-slot elements without approved persistence", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/dashboard": React.createElement("div", null, "dashboard"),
      },
      {
        "page:/settings": React.createElement("div", null, "settings"),
      },
    );

    expect(Object.hasOwn(merged, "layout:/")).toBe(false);
    expect(Object.hasOwn(merged, "page:/dashboard")).toBe(false);
    expect(Object.hasOwn(merged, "page:/settings")).toBe(true);
  });

  it("mergeElements does not infer unmatched slot preservation from the wire marker", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const previousSlotContent = React.createElement("div", null, "previous modal");
    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "slot:modal:/": previousSlotContent,
        "page:/dashboard": React.createElement("div", null, "dashboard"),
      },
      {
        "page:/blog": React.createElement("div", null, "blog page"),
        "slot:modal:/": UNMATCHED_SLOT,
      },
      { preserveElementIds: ["layout:/"] },
    );

    expect(merged["slot:modal:/"]).toBe(UNMATCHED_SLOT);
    expect(merged["page:/blog"]).toBeDefined();
    expect(merged["layout:/"]).toBeDefined();
  });

  it("mergeElements preserves previous slot content for planner-approved default/unmatched slots", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const previousSlotContent = React.createElement("div", null, "previous modal");
    const defaultSlotContent = React.createElement("div", null, "default modal");
    const mergedFromUnmatched = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "slot:modal:/": previousSlotContent,
      },
      {
        "page:/blog": React.createElement("div", null, "blog page"),
        "slot:modal:/": UNMATCHED_SLOT,
      },
      { preserveElementIds: ["layout:/"], preservePreviousSlotIds: ["slot:modal:/"] },
    );
    const mergedFromDefault = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "slot:modal:/": previousSlotContent,
      },
      {
        "page:/blog": React.createElement("div", null, "blog page"),
        "slot:modal:/": defaultSlotContent,
      },
      { preserveElementIds: ["layout:/"], preservePreviousSlotIds: ["slot:modal:/"] },
    );

    expect(mergedFromUnmatched["slot:modal:/"]).toBe(previousSlotContent);
    expect(mergedFromDefault["slot:modal:/"]).toBe(previousSlotContent);
  });

  it("mergeElements preserves a present null default slot when the planner approves it", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "slot:modal:/": null,
      },
      {
        "page:/blog": React.createElement("div", null, "blog page"),
        "slot:modal:/": UNMATCHED_SLOT,
      },
      { preserveElementIds: ["layout:/"], preservePreviousSlotIds: ["slot:modal:/"] },
    );

    expect(Object.hasOwn(merged, "slot:modal:/")).toBe(true);
    expect(merged["slot:modal:/"]).toBeNull();
  });

  it("mergeElements allows UNMATCHED_SLOT for slots absent from previous state", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/": React.createElement("div", null, "home"),
      },
      {
        "page:/blog": React.createElement("div", null, "blog"),
        "slot:modal:/": UNMATCHED_SLOT,
      },
      { preserveElementIds: ["layout:/"] },
    );

    // No previous value to preserve — the sentinel passes through.
    expect(merged["slot:modal:/"]).toBe(UNMATCHED_SLOT);
  });

  it("mergeElements clears stale slots absent from next when clearAbsentSlots is set", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/feed": React.createElement("div", null, "feed"),
        "slot:modal:/feed": React.createElement("div", null, "intercepted modal"),
      },
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/feed": React.createElement("div", null, "feed"),
      },
      true,
    );

    expect(Object.hasOwn(merged, "slot:modal:/feed")).toBe(false);
  });

  it("mergeElements keeps unmatched slot markers on traversal without planner approval", async () => {
    const { mergeElements, UNMATCHED_SLOT } = await import("../packages/vinext/src/shims/slot.js");

    const realContent = React.createElement("div", null, "modal content");
    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/feed": React.createElement("div", null, "feed"),
        "slot:modal:/feed": realContent,
      },
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/feed": React.createElement("div", null, "feed"),
        // @ts-expect-error - typescript is not correctly inferring the type of the symbol
        "slot:modal:/feed": UNMATCHED_SLOT,
      },
      { clearAbsentSlots: true, preserveElementIds: ["layout:/"] },
    );

    expect(Object.hasOwn(merged, "slot:modal:/feed")).toBe(true);
    expect(merged["slot:modal:/feed"]).toBe(UNMATCHED_SLOT);
  });

  it("mergeElements preserves absent slots when clearAbsentSlots is not set", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/dashboard": React.createElement("div", null, "dashboard"),
        "slot:team:/dashboard": React.createElement("div", null, "team panel"),
      },
      {
        "page:/dashboard/settings": React.createElement("div", null, "settings"),
      },
    );

    // Without clearAbsentSlots, absent slots survive (soft nav to child route)
    expect(Object.hasOwn(merged, "slot:team:/dashboard")).toBe(true);
  });

  it("mergeElements drops absent slots when legacy absent-slot preservation is fenced", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "page:/dashboard": React.createElement("div", null, "dashboard"),
        "slot:team:/dashboard": React.createElement("div", null, "team panel"),
      },
      {
        "page:/dashboard/settings": React.createElement("div", null, "settings"),
      },
      { preserveAbsentSlots: false },
    );

    expect(Object.hasOwn(merged, "slot:team:/dashboard")).toBe(false);
  });

  it("mergeElements preserves explicitly approved mounted slots without wire absence semantics", async () => {
    const { mergeElements } = await import("../packages/vinext/src/shims/slot.js");

    const mountedSlot = React.createElement("div", null, "team panel");
    const merged = mergeElements(
      {
        "layout:/": React.createElement("div", null, "layout"),
        "layout:/dashboard": React.createElement("div", null, "dashboard layout"),
        "page:/dashboard": React.createElement("div", null, "dashboard"),
        "slot:team:/dashboard": mountedSlot,
      },
      {
        "page:/dashboard/settings": React.createElement("div", null, "settings"),
      },
      {
        preserveAbsentSlots: false,
        preserveElementIds: ["layout:/", "layout:/dashboard", "slot:team:/dashboard"],
      },
    );

    expect(merged["slot:team:/dashboard"]).toBe(mountedSlot);
  });

  it("Slot renders element from resolved context", async () => {
    const mod = await import("../packages/vinext/src/shims/slot.js");

    const stream = await renderToReadableStream(
      createContextProvider(
        mod.ElementsContext,
        { "layout:/": React.createElement("div", null, "resolved slot") },
        React.createElement(mod.Slot, { id: "layout:/" }),
      ),
    );

    const reader = stream.getReader();
    const decoder = new TextDecoder();
    let html = "";
    for (;;) {
      const { done, value } = await reader.read();
      if (done) break;
      html += decoder.decode(value, { stream: true });
    }
    html += decoder.decode();

    expect(html).toContain("resolved slot");
  });
});