1 Commits

Author	SHA1	Message	Date
James Anderson	373e8264a1	feat(use-cache): support callable cached functions with rsc plugin api (#2156) ... * fix(use-cache): support nested cache functions passed as props * fix(use-cache): use inline registerServerReference instead of broken forward-reference module-level code The previous approach used `noExport: true` and appended module-level `const ${name}_$$vcf` declarations at the end of the transformed file, then referenced them via forward reference at the call-site. This caused a temporal dead zone (TDZ) error because `const` bindings are not hoisted — the call-site assignment evaluated before the TLA const was initialized, crashing all RSC files that contain function-level "use cache" (HTTP 500 for use-cache pages, route handlers, etc.). Fix: keep the existing hoisting/export behaviour (`noExport` stays false) and instead wrap `registerCachedFunction(...)` with `registerServerReference(...)` inline at call-site in the RSC environment. This adds the RSC serialisation metadata ($$typeof, $$id) so cached functions can be passed as props to client components (useActionState / formAction), while not disturbing the existing exported binding that loadServerAction relies on. * fix(use-cache): use correct normalised id and register in manifest for nested function props The previous approach passed the raw absolute file path as the $$id to registerServerReference. @vitejs/plugin-rsc resolves server references by a normalised key (sha256(toRelativeId) in build; URL-path in dev), so production would throw "server reference not found" for any cached function passed as a client-component prop. Also, the module was never added to the virtual:vite-rsc/server-references manifest because only the plugin's own "use server" transform writes to manager.serverReferenceMetaMap. Without a manifest entry, the production serverReferences lookup has no entry for the module at all. Fix: - Capture the plugin-rsc manager via the rsc:minimal plugin API in configResolved so we can write to serverReferenceMetaMap directly. - Compute normalizedRefKey to match vitePluginUseServer's getNormalizedId(): build → sha256(toRelativeId(id)).hex.slice(0,12) dev → id.slice(root.length) (Vite URL path) - After transformHoistInlineDirective succeeds, register the hoisted export names in manager.serverReferenceMetaMap[id] so the manifest is populated. - Pass normalizedRefKey (not raw id) to registerServerReference. Add unit tests verifying the hash formula matches plugin-rsc's own logic. * fix(use-cache): wrap hoisted exports as cached server references and register manifest after rsc:use-server - Derive the build-mode reference key via plugin-rsc's own manager.toRelativeId() instead of a string slice, so the hash input is byte-for-byte identical to the plugin's hashString(toRelativeId(id)). - Reassign each hoisted inline 'use cache' export at module level to registerServerReference(registerCachedFunction(fn)) so the module export itself is the cached wrapper (Next.js parity: direct action invocation goes through the cache) and call sites/manifest imports all observe the same wrapped function. - Register serverReferenceMetaMap entries from a new vinext:use-cache-server-references plugin placed after the plugin-rsc plugins: rsc:use-server deletes metaMap entries for modules without 'use server', which wiped the entries written during the use-cache transform (prod actions 404'd with 'server reference not found'). - Deduplicate the RSC/non-RSC transform branches into a single transformHoistInlineDirective call and hoist the @vitejs/plugin-rsc/react/rsc resolution out of the per-module path. - Replace the self-referential key-formula unit test with the ported Next.js fixture (use-cache-with-server-function-props/nested-cache), a dev-mode Playwright round-trip test, and a production-server integration test that resolves the serialized references via action POSTs and asserts cached-invoke semantics. * docs(use-cache): document dev-key normalisation scope for inline cache server references * fix(use-cache): throw instead of emitting unresolvable inline cache server references when the plugin-rsc manager is missing When the @vitejs/plugin-rsc manager is unavailable in the rsc environment, the inline 'use cache' transform previously fell back to a locally computed reference key and still wrapped the hoisted exports — but the manifest registration plugin bails without the manager, so the emitted reference would serialize into the RSC payload yet never resolve (silent 404 on action POST in production). Fail loudly at transform time instead; the manager is a structural invariant whenever the rsc environment exists. Adds transform-level unit tests for the fail-loud path (build + dev), the non-rsc no-manager control, and build reference-key parity with plugin-rsc. * test(use-cache): pin unencrypted closure-captured bound args and document the divergence Extends the nested-fn-props fixture with a cached function that closes over a value from the cached component's scope, exercising the .bind(null, ...) bound-arg path end to end: the production round-trip test asserts the captured value appears in plaintext in the flight payload (pinning the documented divergence from Next.js, which encrypts bound args by default) and that invoking the bound reference observes the captured value; the Playwright test covers the real flight-client encodeReply round-trip in dev. A transform-level test pins that captures are emitted as plain bind args. The divergence is now also documented in the README's Known limitations section. * refactor(use-cache): route registerServerReference through a vinext shim to decouple from plugin-rsc module-id normalisation The inline 'use cache' prepend imported registerServerReference from a file:// URL of @vitejs/plugin-rsc/react/rsc while the cache runtime imports the same package via the bare specifier, relying on Vite normalising both to a single module id. Re-export it instead from a new vinext-owned cache-server-reference shim whose only react/rsc specifier is the same bare one cache-runtime uses, resolved from the same importer location — one module instance by construction. The transform unit test now pins that the emitted import targets the shim and never a plugin-rsc file URL. * test(use-cache): pin cached-invoke semantics for the closure-bound getMessage path Mirror the getDate cache assertion on the closure-bound path: the fixture's getMessage now appends a Math.random() suffix so cache hits are observable, and the production-server round-trip asserts that two identical bound-arg invocations return the same cached value while a different bound arg misses instead of reusing the entry. The Playwright assertion matches the suffixed message via regex. * fix(use-cache): encrypt closure-bound arguments * refactor(use-cache): use plugin-rsc directive transforms * test(use-cache): cover directive transforms across environments * fix(cache): update RSC directive prerelease * fix(cache): stabilize directive reference tests * style(cache): format HMR test * refactor(use-cache): move server function directives to user land * refactor(use-cache): clarify generic directive plugin naming * refactor(use-cache): own directive plugin types * refactor(use-cache): use plugin-rsc metadata map directly * refactor(use-cache): own server reference metadata lifecycle * chore(use-cache): keep directive type internal * refactor(use-cache): adopt server reference claims * fix(init): install required plugin-rsc prerelease * feat(rsc): harden use cache server functions * feat(cache): adopt plugin-rsc transform primitives * refactor(cache): rename callable plugin * test(init): update plugin-rsc install expectations * test(cache): avoid reloading during HMR retries * test(cache): align callable references with plugin-rsc * fix(cache): align mixed directives with plugin-rsc 0.5.34 * fix(cache): harden callable use cache transforms * fix(cache): support manually configured RSC * fix(cache): harden manual RSC ordering	2026-08-10 00:52:19 +01:00