mirror of
https://github.com/ChromeDevTools/chrome-devtools-mcp.git
synced 2026-09-14 19:45:30 +08:00
dad58bc749
Reverts ChromeDevTools/chrome-devtools-mcp#2635 Does not help https://github.com/ChromeDevTools/chrome-devtools-mcp/actions/runs/33643689394/job/100292870232?pr=2631#step:9:1611
158 lines
5.7 KiB
TypeScript
158 lines
5.7 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2026 Google LLC
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import assert from 'node:assert';
|
|
import {describe, it} from 'node:test';
|
|
|
|
import {serverHooks} from '../server.js';
|
|
import {html, withMcpContext} from '../utils.js';
|
|
|
|
describe('WaitForHelper', () => {
|
|
const server = serverHooks();
|
|
|
|
it('does not stall when an action opens a dialog without handleDialog', async () => {
|
|
await withMcpContext(async (response, context) => {
|
|
const mcpPage = context.getSelectedMcpPage();
|
|
await mcpPage.pptrPage.setContent(html`<button id="b">go</button>`);
|
|
|
|
// The action opens a dialog asynchronously and passes no handleDialog.
|
|
// The dialog leaves the renderer paused; without the fix,
|
|
// waitForStableDom's setup evaluation would hang until protocolTimeout
|
|
// (~180s) while the tool mutex is held, freezing the session.
|
|
try {
|
|
const result = await Promise.race([
|
|
mcpPage.waitForEventsAfterAction(async () => {
|
|
await mcpPage.pptrPage.evaluate(() => {
|
|
setTimeout(() => confirm('blocked?'), 0);
|
|
});
|
|
}),
|
|
// Comfortably above WaitForHelper.#stableDomTimeout (3s): the call
|
|
// should return well within this once the dialog is detected.
|
|
new Promise<'stalled'>(resolve =>
|
|
setTimeout(() => resolve('stalled'), 5_000),
|
|
),
|
|
]);
|
|
|
|
assert(
|
|
result !== 'stalled',
|
|
'stalled because a dialog was shown; would time out with ProtocolError',
|
|
);
|
|
// The dialog was detected but not handled (no handleDialog was passed).
|
|
assert.strictEqual(result.dialogHandled, false);
|
|
// The dialog is still open and recorded, so the next blockedByDialog tool
|
|
// correctly refuses to run.
|
|
assert.throws(() => mcpPage.throwIfDialogOpen());
|
|
} finally {
|
|
await mcpPage.getDialog()?.dismiss();
|
|
}
|
|
});
|
|
});
|
|
|
|
it('awaits navigation when action takes longer than expectNavigationIn', async () => {
|
|
await withMcpContext(async (response, context) => {
|
|
server.addHtmlRoute('/nav-target', html`<main>navigated</main>`);
|
|
const url = server.getRoute('/nav-target');
|
|
const mcpPage = context.getSelectedMcpPage();
|
|
|
|
const result = await mcpPage.waitForEventsAfterAction(
|
|
async () => {
|
|
// Simulate an action that takes longer than expectNavigationIn (300ms)
|
|
// before triggering the navigation.
|
|
await new Promise(resolve => setTimeout(resolve, 600));
|
|
await mcpPage.pptrPage.evaluate(targetUrl => {
|
|
location.href = targetUrl;
|
|
}, url);
|
|
},
|
|
{waitForStableDom: false, expectNavigationIn: 300},
|
|
);
|
|
|
|
assert.strictEqual(result.navigatedToUrl, url);
|
|
});
|
|
});
|
|
|
|
it('does not hang when an iframe navigates', async () => {
|
|
await withMcpContext(async (response, context) => {
|
|
server.addHtmlRoute('/iframe-src', html`<p>iframe</p>`);
|
|
server.addHtmlRoute('/iframe-target', html`<p>iframe navigated</p>`);
|
|
const iframeSrc = server.getRoute('/iframe-src');
|
|
const iframeTarget = server.getRoute('/iframe-target');
|
|
const mcpPage = context.getSelectedMcpPage();
|
|
await mcpPage.pptrPage.setContent(
|
|
html`<iframe
|
|
id="subframe"
|
|
src="${iframeSrc}"
|
|
></iframe>`,
|
|
);
|
|
|
|
const startTime = Date.now();
|
|
const result = await mcpPage.waitForEventsAfterAction(
|
|
async () => {
|
|
await mcpPage.pptrPage.evaluate(targetUrl => {
|
|
const frame = document.querySelector('iframe');
|
|
if (!frame) {
|
|
throw new Error('iframe not found');
|
|
}
|
|
frame.src = targetUrl;
|
|
}, iframeTarget);
|
|
},
|
|
{waitForStableDom: false, expectNavigationIn: 50, timeout: 2000},
|
|
);
|
|
|
|
const elapsed = Date.now() - startTime;
|
|
assert(
|
|
elapsed < 1500,
|
|
`Took ${elapsed}ms; should not hang waiting for iframe`,
|
|
);
|
|
assert.strictEqual(result.navigatedToUrl, undefined);
|
|
});
|
|
});
|
|
|
|
it('awaits navigation when preceded by same-document navigation', async () => {
|
|
await withMcpContext(async (response, context) => {
|
|
server.addHtmlRoute('/nav-start', html`<main>start</main>`);
|
|
server.addHtmlRoute('/nav-target-2', html`<main>navigated 2</main>`);
|
|
const startUrl = server.getRoute('/nav-start');
|
|
const targetUrl = server.getRoute('/nav-target-2');
|
|
const mcpPage = context.getSelectedMcpPage();
|
|
await mcpPage.pptrPage.goto(startUrl);
|
|
|
|
const result = await mcpPage.waitForEventsAfterAction(
|
|
async () => {
|
|
await mcpPage.pptrPage.evaluate(url => {
|
|
history.pushState({}, '', '/intermediate-state');
|
|
location.href = url;
|
|
}, targetUrl);
|
|
},
|
|
{waitForStableDom: false, expectNavigationIn: 1000},
|
|
);
|
|
|
|
assert.strictEqual(result.navigatedToUrl, targetUrl);
|
|
});
|
|
});
|
|
|
|
it('captures navigatedToUrl for same-document navigation alone', async () => {
|
|
await withMcpContext(async (response, context) => {
|
|
server.addHtmlRoute('/nav-start-push', html`<main>start push</main>`);
|
|
server.addHtmlRoute('/same-doc-target', html`<main>target</main>`);
|
|
const startUrl = server.getRoute('/nav-start-push');
|
|
const targetUrl = server.getRoute('/same-doc-target');
|
|
const mcpPage = context.getSelectedMcpPage();
|
|
await mcpPage.pptrPage.goto(startUrl);
|
|
|
|
const result = await mcpPage.waitForEventsAfterAction(
|
|
async () => {
|
|
await mcpPage.pptrPage.evaluate(url => {
|
|
history.pushState({}, '', url);
|
|
}, targetUrl);
|
|
},
|
|
{waitForStableDom: false},
|
|
);
|
|
|
|
assert.strictEqual(result.navigatedToUrl, targetUrl);
|
|
});
|
|
});
|
|
});
|