mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
Nick Dima
43aae1d30a
* fix(ios): use XCTest runner for screenshots on physical devices `xcrun devicectl device screenshot` was removed in Xcode 26.x, causing `agent-device screenshot` to fail on physical iOS devices with exit code 64. This fix routes physical device screenshots through the AgentDeviceRunner XCTest runner (already used for snapshot/interaction commands) instead: - Add `screenshot` command to the Swift runner's `CommandType` enum - Implement the handler using `XCUIScreen.main.screenshot()`, writing a timestamped PNG to the app's temp directory (returned as `tmp/<file>`) - If `appBundleId` is provided, activate the target app before capturing so the screenshot shows the app under test rather than the runner itself - In `screenshotIos()`, pass `appBundleId` to the runner command then pull the file back to the host via `xcrun devicectl device copy from` (same mechanism used by the recording feature) - Thread `appBundleId` through `Interactor.screenshot()` → `dispatch.ts` → `screenshotIos()` so the active session's app is always captured - Extract `IOS_RUNNER_CONTAINER_BUNDLE_IDS` to `runner-client.ts` so it can be shared between `apps.ts` and `record-trace.ts` Fixes: screenshots failing with "Failed to capture iOS screenshot" on devices using Xcode 26.x / devicectl 506.6+ * fix: clean up iOS screenshot fallback follow-ups --------- Co-authored-by: Michał Pierzchała <thymikee@gmail.com>