mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
278 lines
11 KiB
TypeScript
278 lines
11 KiB
TypeScript
// Daemon leak oracle (#1781 B1, feeds #1431): observes daemon liveness and an
|
|
// isolated state dir, then applies the lifecycle/residue rules in
|
|
// `daemon-leak-model.ts` (which documents them and is where they are tested).
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import {
|
|
isProcessAlive,
|
|
readHostProcessIdentityObservations,
|
|
readProcessCommand,
|
|
readOwnedProcessRecordFile,
|
|
} from '@agent-device/host-kit/process';
|
|
|
|
import { AppError } from '@agent-device/kernel/errors';
|
|
import type { OwnedProcessRecord } from '@agent-device/contracts/platform-runtime-host';
|
|
import {
|
|
evaluateDaemonLeaks,
|
|
formatDaemonLeakReport,
|
|
hasDaemonLeaks,
|
|
type DaemonLeakPhaseSelection,
|
|
type OwnedProcessRecordObservation,
|
|
type DaemonLeakSnapshot,
|
|
type StateEntry,
|
|
} from './daemon-leak-model.ts';
|
|
|
|
const DEFAULT_SETTLE_MS = 5_000;
|
|
const SETTLE_POLL_MS = 250;
|
|
|
|
/**
|
|
* `phase` carries the identity that phase needs: `after-close` cannot be
|
|
* requested without naming at least one closed session (see
|
|
* DaemonLeakPhaseSelection), so the vacuous checkpoint that accepts every open
|
|
* capture handle is not expressible. `after-shutdown` takes nothing extra.
|
|
*
|
|
* Closed sessions are directory names, not paths — the basename of
|
|
* `sessionStore.resolveSessionDir(name)`, or of the `sessionStateDir` an
|
|
* `open`/`close` response reports.
|
|
*/
|
|
export type DaemonLeakOracleOptions = DaemonLeakPhaseSelection & {
|
|
stateDir: string;
|
|
/** Every daemon pid the lane observed for this state dir (from daemon.json). */
|
|
daemonPids: readonly number[];
|
|
/**
|
|
* Where sessions live, when that is not `<stateDir>/sessions` — an in-process
|
|
* scenario harness roots its SessionStore directly at its own temp dir.
|
|
* Entries below it are normalized to the canonical `sessions/<name>/…` shape
|
|
* so the rules stay layout-independent.
|
|
*/
|
|
sessionsDir?: string;
|
|
/** How long stragglers may take to exit before they count as leaked. */
|
|
settleMs?: number;
|
|
};
|
|
|
|
async function captureDaemonLeakSnapshot(
|
|
options: DaemonLeakOracleOptions,
|
|
): Promise<DaemonLeakSnapshot> {
|
|
const stateDir = path.resolve(options.stateDir);
|
|
const stateEntries = readStateEntries(stateDir, options.sessionsDir);
|
|
return evaluateDaemonLeaks({
|
|
...phaseSelectionOf(options),
|
|
stateDir,
|
|
daemonPids: options.daemonPids,
|
|
livePids: options.daemonPids.filter((pid) => isProcessAlive(pid)),
|
|
stateEntries,
|
|
ownedProcessRecords: readOwnedProcessObservations(
|
|
stateDir,
|
|
path.resolve(options.sessionsDir ?? path.join(stateDir, 'sessions')),
|
|
stateEntries,
|
|
),
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Re-snapshots until clean or `settleMs` elapses. Stragglers that exit on their
|
|
* own inside the window are not leaks.
|
|
*/
|
|
async function settleDaemonLeakSnapshot(
|
|
options: DaemonLeakOracleOptions,
|
|
): Promise<DaemonLeakSnapshot> {
|
|
const deadline = Date.now() + (options.settleMs ?? DEFAULT_SETTLE_MS);
|
|
let snapshot = await captureDaemonLeakSnapshot(options);
|
|
while (hasDaemonLeaks(snapshot) && Date.now() < deadline) {
|
|
await new Promise((resolve) => setTimeout(resolve, SETTLE_POLL_MS));
|
|
snapshot = await captureDaemonLeakSnapshot(options);
|
|
}
|
|
return snapshot;
|
|
}
|
|
|
|
/** Throws with the full report if anything daemon-owned survives the settle window. */
|
|
export async function assertNoDaemonLeaks(options: DaemonLeakOracleOptions): Promise<void> {
|
|
const snapshot = await settleDaemonLeakSnapshot(options);
|
|
if (hasDaemonLeaks(snapshot)) throw new Error(formatDaemonLeakReport(snapshot));
|
|
}
|
|
|
|
function phaseSelectionOf(options: DaemonLeakOracleOptions): DaemonLeakPhaseSelection {
|
|
return options.phase === 'after-close'
|
|
? { phase: 'after-close', closedSessions: options.closedSessions }
|
|
: { phase: 'after-shutdown' };
|
|
}
|
|
|
|
// Files, plus empty directories as their own entries (an unswept session
|
|
// scaffold leaves no file behind), plus the `lifecycle` of durable capture
|
|
// descriptors so the rules stay free of filesystem access.
|
|
function readStateEntries(stateDir: string, sessionsDir?: string): StateEntry[] {
|
|
if (!fs.existsSync(stateDir)) return [];
|
|
const sessionsRoot = path.resolve(sessionsDir ?? path.join(stateDir, 'sessions'));
|
|
const entries: StateEntry[] = [];
|
|
for (const dirent of fs.readdirSync(stateDir, { recursive: true, withFileTypes: true })) {
|
|
const absolute = path.join(dirent.parentPath, dirent.name);
|
|
const relative = toCanonicalEntryPath(absolute, stateDir, sessionsRoot);
|
|
if (!dirent.isDirectory()) {
|
|
entries.push({
|
|
path: relative,
|
|
kind: 'file',
|
|
...(relative.endsWith('.resource.json')
|
|
? { descriptorLifecycle: readDescriptorLifecycle(absolute) }
|
|
: {}),
|
|
...(isOwnedProcessRecordEntry(relative)
|
|
? { ownedProcessRecordStatus: readOwnedProcessRecordStatus(absolute) }
|
|
: {}),
|
|
});
|
|
} else if (isEmptyDirectory(absolute)) {
|
|
entries.push({ path: `${relative}/`, kind: 'empty-directory' });
|
|
}
|
|
}
|
|
return entries;
|
|
}
|
|
|
|
function readOwnedProcessObservations(
|
|
stateDir: string,
|
|
sessionsRoot: string,
|
|
stateEntries: readonly StateEntry[],
|
|
): OwnedProcessRecordObservation[] {
|
|
return stateEntries.flatMap((entry) =>
|
|
readOwnedProcessObservation(entry, stateDir, sessionsRoot),
|
|
);
|
|
}
|
|
|
|
function readOwnedProcessObservation(
|
|
entry: StateEntry,
|
|
stateDir: string,
|
|
sessionsRoot: string,
|
|
): OwnedProcessRecordObservation[] {
|
|
if (entry.kind !== 'file' || !isOwnedProcessRecordEntry(entry.path)) return [];
|
|
const sessionId = /^sessions\/([^/]+)\/owned-processes\.json$/.exec(entry.path)?.[1];
|
|
const scope =
|
|
sessionId === undefined ? { kind: 'daemon' as const } : { kind: 'session' as const, sessionId };
|
|
const absolute =
|
|
sessionId === undefined
|
|
? path.join(stateDir, 'owned-processes.json')
|
|
: path.join(sessionsRoot, sessionId, 'owned-processes.json');
|
|
const read = readOwnedProcessRecordFile(absolute, scope);
|
|
const identities = readHostProcessIdentityObservations(read.records.map((record) => record.pid));
|
|
const { liveRecords, ownershipLostRecords } = classifyOwnedProcessRecords(
|
|
read.records,
|
|
identities,
|
|
);
|
|
return [
|
|
{
|
|
scope: scope.kind,
|
|
...(sessionId === undefined ? {} : { sessionId }),
|
|
recordPath: entry.path,
|
|
records: read.records,
|
|
liveRecords,
|
|
ownershipLostRecords,
|
|
status: read.status,
|
|
},
|
|
];
|
|
}
|
|
|
|
function classifyOwnedProcessRecords(
|
|
records: readonly OwnedProcessRecord[],
|
|
identities: ReadonlyMap<number, { state: string; startTime: string }>,
|
|
): { liveRecords: OwnedProcessRecord[]; ownershipLostRecords: OwnedProcessRecord[] } {
|
|
const liveRecords: OwnedProcessRecord[] = [];
|
|
const ownershipLostRecords: OwnedProcessRecord[] = [];
|
|
for (const record of records) {
|
|
const classification = classifyOwnedProcessRecord(record, identities);
|
|
if (classification === 'live') liveRecords.push(record);
|
|
if (classification === 'ownership-lost') ownershipLostRecords.push(record);
|
|
}
|
|
return { liveRecords, ownershipLostRecords };
|
|
}
|
|
|
|
function classifyOwnedProcessRecord(
|
|
record: OwnedProcessRecord,
|
|
identities: ReadonlyMap<number, { state: string; startTime: string }>,
|
|
): 'live' | 'missing' | 'ownership-lost' {
|
|
if (!isProcessAlive(record.pid)) return 'missing';
|
|
const observation = identities.get(record.pid);
|
|
if (observation === undefined) return isProcessAlive(record.pid) ? 'ownership-lost' : 'missing';
|
|
if (observation.state.startsWith('Z')) return 'missing';
|
|
return observation.startTime === record.startTime &&
|
|
readProcessCommand(record.pid) === record.command
|
|
? 'live'
|
|
: 'ownership-lost';
|
|
}
|
|
|
|
function isOwnedProcessRecordEntry(entryPath: string): boolean {
|
|
return /^(?:owned-processes\.json|sessions\/[^/]+\/owned-processes\.json)$/.test(entryPath);
|
|
}
|
|
|
|
function readOwnedProcessRecordStatus(filePath: string): 'decoded' | 'invalid' {
|
|
return readOwnedProcessRecordFile(filePath, { kind: 'daemon' }).status;
|
|
}
|
|
|
|
// `sessions/<name>/…` regardless of where the SessionStore is rooted.
|
|
function toCanonicalEntryPath(absolute: string, stateDir: string, sessionsRoot: string): string {
|
|
const withinSessions = path.relative(sessionsRoot, absolute);
|
|
const relative =
|
|
withinSessions.startsWith('..') || path.isAbsolute(withinSessions)
|
|
? path.relative(stateDir, absolute)
|
|
: path.join('sessions', withinSessions);
|
|
return relative.split(path.sep).join('/');
|
|
}
|
|
|
|
function isEmptyDirectory(directoryPath: string): boolean {
|
|
try {
|
|
return fs.readdirSync(directoryPath).length === 0;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function readDescriptorLifecycle(filePath: string): string | undefined {
|
|
try {
|
|
const parsed = JSON.parse(fs.readFileSync(filePath, 'utf8')) as { lifecycle?: unknown };
|
|
return typeof parsed.lifecycle === 'string' ? parsed.lifecycle : undefined;
|
|
} catch {
|
|
return undefined;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Parses the standalone CLI's argv into oracle options, refusing the invocation
|
|
* the type system already refuses in code: `--phase after-close` without a
|
|
* `--closed-session` would accept every open capture handle and report clean.
|
|
*/
|
|
function parseDaemonLeakOracleArgs(argv: readonly string[]): DaemonLeakOracleOptions {
|
|
const readFlag = (name: string): string[] =>
|
|
argv.flatMap((arg, index) => (arg === name && argv[index + 1] ? [argv[index + 1]!] : []));
|
|
const stateDir = readFlag('--state-dir')[0];
|
|
if (!stateDir) {
|
|
throw new AppError('INVALID_ARGS', 'daemon leak oracle: --state-dir is required');
|
|
}
|
|
const common = {
|
|
stateDir,
|
|
daemonPids: readFlag('--daemon-pid').map(Number),
|
|
...(readFlag('--sessions-dir')[0] ? { sessionsDir: readFlag('--sessions-dir')[0] } : {}),
|
|
settleMs: Number(readFlag('--settle-ms')[0] ?? DEFAULT_SETTLE_MS),
|
|
};
|
|
const phase = readFlag('--phase')[0] ?? 'after-shutdown';
|
|
if (phase !== 'after-close') return { ...common, phase: 'after-shutdown' };
|
|
const [first, ...rest] = readFlag('--closed-session');
|
|
if (!first) {
|
|
throw new AppError(
|
|
'INVALID_ARGS',
|
|
'daemon leak oracle: --phase after-close requires at least one --closed-session',
|
|
{
|
|
hint: 'Pass the closed session directory name (the basename of the session state dir). Without it the checkpoint would accept every unfinalized capture handle and report clean.',
|
|
},
|
|
);
|
|
}
|
|
return { ...common, phase: 'after-close', closedSessions: [first, ...rest] };
|
|
}
|
|
|
|
// Standalone use (red-proofs, manual triage):
|
|
// node --experimental-strip-types test/integration/support/daemon-leak-oracle.ts \
|
|
// --state-dir <dir> --daemon-pid <pid> [--daemon-pid <pid>…] \
|
|
// [--phase after-shutdown | --phase after-close --closed-session <dir-name>…]
|
|
// [--sessions-dir <dir>] [--settle-ms <n>]
|
|
// Prints the report and exits 1 on a leak.
|
|
if (process.argv[1] && path.resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
|
|
const snapshot = await settleDaemonLeakSnapshot(parseDaemonLeakOracleArgs(process.argv.slice(2)));
|
|
process.stdout.write(`${formatDaemonLeakReport(snapshot)}\n`);
|
|
process.exitCode = hasDaemonLeaks(snapshot) ? 1 : 0;
|
|
}
|