Files
Prateek Ranka eb0d791957 fix(orientation): disclose an unconfirmed rotation instead of asserting it (#2483)
* fix(orientation): disclose an unconfirmed rotation instead of asserting it

executeSetOrientation fell back to the requested rotation when the owner reported no resulting orientation, then reported 'Rotated to <request>' as a success claim. Keep the requested rotation for compatibility, but mark the claim unconfirmed and warn.

* fix(orientation): carry the unconfirmed rotation through the journal and public surface

Review follow-up on #2483. The daemon disclosed `confirmed: false` plus a warning,
but the surfaces that consume the result still asserted a rotation:

- `buildOrientationActionSummary` rebuilt "Rotated to <orientation>" from the
  orientation field alone, so a session journal recorded an unconfirmed rotation as
  fact. It now records "Requested <orientation> (unconfirmed)" when the owner
  reported nothing; the journal regression fails on the previous commit.
- `OrientationCommandResult` declares the optional `confirmed` and `warning`
  fields, and the MCP output schema advertises them so clients can consume the
  distinction (the navigation schema parity test covers the lockstep).

The disclosed-warning shape stays: no hard failure.

Gate: pnpm check:affected --run - 332 files / 2158 tests, all runnable checks passed.
2026-09-11 14:14:17 +02:00
..