mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
64 lines
2.6 KiB
TypeScript
64 lines
2.6 KiB
TypeScript
// `pnpm gate <check-id> [args…]` — the only way CI may run a gate.
|
|
//
|
|
// The run-gate action calls this with a structural id. The manifest reads that YAML field,
|
|
// never this command's surrounding shell. Raw workflow shell may still invoke this CLI, but
|
|
// doing so declares no ownership.
|
|
//
|
|
// Extra arguments are forwarded verbatim, so lane-specific flags (`--base`,
|
|
// `--udid`, `--report-junit`) stay in the workflow where they belong.
|
|
|
|
import { pathToFileURL } from 'node:url';
|
|
import fs from 'node:fs';
|
|
import path from 'node:path';
|
|
import { runCmdStreaming, runCmdSync } from '@agent-device/host-kit/command';
|
|
import { runEntrypoint } from '../lib/cli-entrypoint.ts';
|
|
import { CHECK_CATALOG, resolveCommand } from '../check-affected/checks.ts';
|
|
|
|
const USAGE = 'Usage: pnpm gate <check-id> [args…]\n';
|
|
|
|
export function resolveGate(
|
|
id: string,
|
|
scripts: Readonly<Record<string, string>>,
|
|
args: readonly string[],
|
|
): string[] {
|
|
// `pnpm gate x -- --flag` and `pnpm gate x --flag` both forward `--flag`.
|
|
const extra = args[0] === '--' ? args.slice(1) : args;
|
|
const spec = CHECK_CATALOG.find((entry) => entry.id === id);
|
|
if (!spec) {
|
|
const known = CHECK_CATALOG.map((entry) => entry.id).join(', ');
|
|
throw new Error(`Unknown gate "${id}".\nRegistered gates: ${known}`);
|
|
}
|
|
const command = resolveCommand(spec, scripts, 'origin/main');
|
|
// `fallow` carries a default --base; a lane that supplies its own replaces it
|
|
// rather than passing the flag twice.
|
|
const injected = extra.includes('--base') ? command.indexOf('--base') : -1;
|
|
const resolved =
|
|
injected === -1 ? command : [...command.slice(0, injected), ...command.slice(injected + 2)];
|
|
return [...resolved, ...extra];
|
|
}
|
|
|
|
async function main(argv: readonly string[]): Promise<number> {
|
|
const [id, ...rest] = argv;
|
|
if (!id || id === '--help') {
|
|
process.stdout.write(USAGE);
|
|
return id ? 0 : 1;
|
|
}
|
|
const repoRoot = runCmdSync('git', ['rev-parse', '--show-toplevel']).stdout.trim();
|
|
const pkg = JSON.parse(fs.readFileSync(path.join(repoRoot, 'package.json'), 'utf8')) as {
|
|
scripts: Record<string, string>;
|
|
};
|
|
const command = resolveGate(id, pkg.scripts, rest);
|
|
process.stdout.write(`[gate] ${id}: ${command.join(' ')}\n`);
|
|
const result = await runCmdStreaming(command[0] as string, command.slice(1), {
|
|
cwd: repoRoot,
|
|
allowFailure: true,
|
|
onStdoutChunk: (chunk) => void process.stdout.write(chunk),
|
|
onStderrChunk: (chunk) => void process.stderr.write(chunk),
|
|
});
|
|
return result.exitCode;
|
|
}
|
|
|
|
if (import.meta.url === pathToFileURL(process.argv[1] ?? '').href) {
|
|
runEntrypoint('gate', () => main(process.argv.slice(2)));
|
|
}
|