mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
91 lines
3.2 KiB
TypeScript
91 lines
3.2 KiB
TypeScript
// Selection is what the PR lane spends money on, so both halves of the rule are
|
|
// asserted end to end through the real CLI: a kernel diff selects nothing (the
|
|
// weekly sweep is the kernel report), and a lane-tooling diff selects real
|
|
// mutants rather than an empty matrix that proves nothing.
|
|
|
|
import assert from 'node:assert/strict';
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
import { after, test } from 'node:test';
|
|
import { runCmdSync } from '@agent-device/host-kit/command';
|
|
import { LANE_CANARY, shardMatrix, type ShardSpec } from './modules.ts';
|
|
import { affectedMatrixFor } from './run.ts';
|
|
|
|
const repoRoot = path.resolve(import.meta.dirname, '../..');
|
|
const worktrees: string[] = [];
|
|
|
|
after(() => {
|
|
for (const dir of worktrees) {
|
|
runCmdSync('git', ['worktree', 'remove', '--force', dir], { cwd: repoRoot });
|
|
}
|
|
});
|
|
|
|
/**
|
|
* A throwaway worktree holding one commit that touches only the given files, so
|
|
* `--list-affected` runs against a real `git diff` rather than a stubbed list.
|
|
*/
|
|
function worktreeWithCommit(name: string, files: readonly string[]): string {
|
|
const dir = fs.mkdtempSync(path.join(os.tmpdir(), `mutation-${name}-`));
|
|
fs.rmSync(dir, { recursive: true });
|
|
runCmdSync('git', ['worktree', 'add', '--detach', '--quiet', dir, 'HEAD'], { cwd: repoRoot });
|
|
worktrees.push(dir);
|
|
for (const file of files) {
|
|
fs.appendFileSync(path.join(dir, file), '\n');
|
|
}
|
|
runCmdSync('git', ['add', ...files], { cwd: dir });
|
|
// CI runners have no committer identity configured, and this commit is a
|
|
// fixture, so it carries its own rather than depending on the environment.
|
|
runCmdSync(
|
|
'git',
|
|
[
|
|
'-c',
|
|
'user.name=mutation-selection-test',
|
|
'-c',
|
|
'user.email=mutation-selection-test@invalid',
|
|
'commit',
|
|
'--quiet',
|
|
'--no-verify',
|
|
'-m',
|
|
`touch ${name}`,
|
|
],
|
|
{ cwd: dir },
|
|
);
|
|
return dir;
|
|
}
|
|
|
|
function listAffected(cwd: string): ShardSpec[] {
|
|
const result = runCmdSync(
|
|
'node',
|
|
[
|
|
'--experimental-strip-types',
|
|
path.join(repoRoot, 'scripts/mutation/run.ts'),
|
|
'--list-affected',
|
|
'--base',
|
|
'HEAD~1',
|
|
],
|
|
{ cwd },
|
|
);
|
|
assert.equal(result.exitCode, 0, result.stderr);
|
|
return JSON.parse(result.stdout.trim().split('\n').at(-1)!) as ShardSpec[];
|
|
}
|
|
|
|
test('a lane-tooling diff selects real mutants', () => {
|
|
const dir = worktreeWithCommit('tooling', ['scripts/mutation/run.ts']);
|
|
// The lane's own sources own no kernel, so derivation alone yields nothing:
|
|
// without the canary a harness change would run zero mutants.
|
|
assert.deepEqual(listAffected(dir), shardMatrix([LANE_CANARY]));
|
|
});
|
|
|
|
// The weekly sweep is the kernel report; selecting on derived ownership would
|
|
// run the full ten-shard sweep on most PRs for a report nobody gates on.
|
|
test('a kernel diff selects nothing — only a harness diff spends mutants', () => {
|
|
const dir = worktreeWithCommit('kernel', ['src/utils/scroll-edge-state.ts']);
|
|
assert.deepEqual(listAffected(dir), []);
|
|
assert.deepEqual(affectedMatrixFor(['src/utils/scroll-edge-state.ts']), []);
|
|
});
|
|
|
|
test('a docs-only diff selects nothing', () => {
|
|
assert.deepEqual(affectedMatrixFor(['docs/agents/testing.md']), []);
|
|
});
|