mirror of
https://github.com/callstack/agent-device.git
synced 2026-09-14 20:06:34 +08:00
e832325e87
* refactor: split generic host mechanics into @agent-device/host-kit (#2082 W1) The shared src/utils closure that blocked the platform-family moves lands on declared owners: generic host mechanics form a new private @agent-device/host-kit package between kernel and capture-kit, and capture-kit keeps capture, snapshot, and recording behavior, depending on host-kit for the mechanics it needs. tar-stream and yauzl move with the archive code. Every seam's exported subpaths are pinned in package-boundaries.test.ts, the layering model ranks the new zone, R13's allow-list names it, and each seam carries an exact eager-closure row. ADR-0019's substrate amendment describes the layout. Tests that mocked two of the moved modules separately became duplicate same-seam vi.mock factories, where the second silently replaced the first; those are merged, and the mocks that production code reaches past are pinned at their injection points instead. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * refactor(host-kit): one narrow capability port per export The four technical barrels (exec/fs/values/request) grouped by category rather than by capability, so a consumer needing one mechanic evaluated unrelated ones. Each export is now a single capability over the host machine: command, process, diagnostics, retry, archive, file, request, version. A port re-exports only what a consumer of that capability uses, and every port carries its own eager-closure row. Most of the old values barrel was never host mechanics. Pure record readers, config-source values, result text, memoization, async scoping, coordinate validation, and device-scope parsing touch no process, file, or environment, so they join kernel's other primitives instead. Closures fall accordingly: capture-kit's png-worker-client from 20 to 10, png-resize from 28 to 18, session-teardown from 79 to 68, and the CLI from 386 to 380. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * chore: drop the migration inventories and trim the touched comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: trim the touched host-kit and mutation-lane comments Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only in the touched files Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * docs: keep tool directives only across the touched tree Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: point the Swift parity comment at the real TS twin and test The W1 move rewrote this citation to packages/contracts/src/mobile-snapshot-semantics.ts, which does not exist: the module went to capture-kit while isTapPointInsideViewport itself went to packages/contracts/src/snapshot-visibility.ts. The TS test line was left pointing at the pre-move path. Both now resolve. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH * fix: repoint comment citations at the homes this refactor moved them to The W1 move left ~20 comment citations pointing at src/utils/*.ts and src/request/*.ts paths that no longer exist. Each now names the capability port that owns the symbol, which survives further file moves: exec -> host-kit/command host-process, owner-identity -> host-kit/process diagnostics -> host-kit/diagnostics atomic-file, process-lock -> host-kit/file retry -> host-kit/retry request progress/cancel -> host-kit/request version -> host-kit/version ttl-memo, source-value, parsing, device-isolation, keyed-lock, success-text -> kernel subpaths Comment-only; no closure, budget, or behavior change. ADR citations are left as written, being dated records of the decision rather than live references. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018VngeKZH6zBuJzNBk5YzUH --------- Co-authored-by: Claude <noreply@anthropic.com>
101 lines
3.4 KiB
TypeScript
101 lines
3.4 KiB
TypeScript
// Xcode 26.2's SwiftPM leaves TemporaryDirectory.* marker directories behind
|
|
// even after successful `swift` and `xcodebuild` commands. Keep build-lane
|
|
// scratch state under one owned directory so it can be removed deterministically.
|
|
// Production runner launches intentionally do not use this wrapper.
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
import { runCmdBackground } from '@agent-device/host-kit/command';
|
|
|
|
const [command, ...args] = process.argv.slice(2);
|
|
if (!command) {
|
|
throw new Error('Usage: node scripts/swift-toolchain-tmpdir.ts <command> [args...]');
|
|
}
|
|
|
|
const commandTmpDir = fs.mkdtempSync(
|
|
path.join(os.tmpdir(), `agent-device-swift-toolchain-${process.pid}-`),
|
|
);
|
|
|
|
let cleanedUp = false;
|
|
function cleanup(): void {
|
|
if (cleanedUp) return;
|
|
cleanedUp = true;
|
|
fs.rmSync(commandTmpDir, { recursive: true, force: true });
|
|
}
|
|
process.on('exit', cleanup);
|
|
|
|
const { child, wait } = runCmdBackground(command, args, {
|
|
env: { ...process.env, TMPDIR: commandTmpDir },
|
|
stdio: 'inherit',
|
|
captureOutput: false,
|
|
allowFailure: true,
|
|
detached: process.platform !== 'win32',
|
|
});
|
|
|
|
const FORCE_KILL_DELAY_MS = 5_000;
|
|
const FORCE_KILL_WAIT_MS = 1_000;
|
|
const PROCESS_GROUP_POLL_MS = 25;
|
|
const processGroupId = process.platform !== 'win32' ? child.pid : undefined;
|
|
let forwardedSignal: 'SIGINT' | 'SIGTERM' | undefined;
|
|
let forceKillTimer: ReturnType<typeof setTimeout> | undefined;
|
|
let forceKillDeadline: number | undefined;
|
|
for (const signal of ['SIGINT', 'SIGTERM'] as const) {
|
|
process.on(signal, () => {
|
|
if (forwardedSignal) return;
|
|
forwardedSignal = signal;
|
|
signalToolchain(signal);
|
|
// Keep the owned TMPDIR alive while Swift/Xcode handles the signal and
|
|
// flushes its descendants. A stuck process group is force-killed after a
|
|
// bounded grace period, after which normal exit cleanup can run.
|
|
forceKillDeadline = Date.now() + FORCE_KILL_DELAY_MS;
|
|
forceKillTimer = setTimeout(() => signalToolchain('SIGKILL'), FORCE_KILL_DELAY_MS);
|
|
forceKillTimer.unref();
|
|
});
|
|
}
|
|
|
|
const result = await wait;
|
|
if (processGroupId) {
|
|
const gracefulDeadline = forceKillDeadline ?? Date.now() + FORCE_KILL_DELAY_MS;
|
|
const exitedGracefully = await waitForProcessGroupExit(
|
|
processGroupId,
|
|
Math.max(0, gracefulDeadline - Date.now()),
|
|
);
|
|
if (!exitedGracefully) {
|
|
signalToolchain('SIGKILL');
|
|
await waitForProcessGroupExit(processGroupId, FORCE_KILL_WAIT_MS);
|
|
}
|
|
}
|
|
if (forceKillTimer) clearTimeout(forceKillTimer);
|
|
process.exitCode =
|
|
forwardedSignal === 'SIGINT' ? 130 : forwardedSignal === 'SIGTERM' ? 143 : result.exitCode;
|
|
|
|
function signalToolchain(signal: NodeJS.Signals): void {
|
|
if (processGroupId) {
|
|
try {
|
|
process.kill(-processGroupId, signal);
|
|
return;
|
|
} catch (error) {
|
|
if ((error as NodeJS.ErrnoException).code === 'ESRCH') return;
|
|
}
|
|
}
|
|
child.kill(signal);
|
|
}
|
|
|
|
async function waitForProcessGroupExit(processGroup: number, timeoutMs: number): Promise<boolean> {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (isProcessGroupAlive(processGroup)) {
|
|
if (Date.now() >= deadline) return false;
|
|
await new Promise((resolve) => setTimeout(resolve, PROCESS_GROUP_POLL_MS));
|
|
}
|
|
return true;
|
|
}
|
|
|
|
function isProcessGroupAlive(processGroup: number): boolean {
|
|
try {
|
|
process.kill(-processGroup, 0);
|
|
return true;
|
|
} catch (error) {
|
|
return (error as NodeJS.ErrnoException).code === 'EPERM';
|
|
}
|
|
}
|